[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386104#comment-16386104 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/804 > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386085#comment-16386085 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/804 VOTE +1 > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385465#comment-16385465 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/804 VOTE: +1 > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384708#comment-16384708 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/804 This looks good to me. Thanks for fixing the Spark and Giraph versions as well, @spmallette. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383801#comment-16383801 ] ASF GitHub Bot commented on TINKERPOP-1862: --- GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/804 TINKERPOP-1862 Messenger proper handling of Direction.BOTH https://issues.apache.org/jira/browse/TINKERPOP-1862 This pulls in all changes from #801 and adds fixes to allow integration tests in spark and giraph to pass. This isn't completely ready for VOTE yet, but wanted to get it in place for review by @PBGraff to make sure I didn't leave anything out by mistake. Also, needed time to for docker tests to run. I will update this PR with a VOTE when it's ready for general review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1862 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/804.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #804 commit f02ea338a8d039c50896f7c65ca57a695975fc43 Author: Graff, Philip B Date: 2018-01-04T18:27:44Z TinkerMessenger proper handling of Direction.BOTH commit 80c0b8465fe9bb6ddbe4522a36304c7ba054e909 Author: Graff, Philip B Date: 2018-01-14T02:32:29Z Adding simple graph computer test of proper message passing in all 3 directions commit 750677cf55d7445c3746870d86c6592f6cd3664d Author: Graff, Philip B Date: 2018-01-14T04:49:27Z Test cleanup - hopefully can run now commit 153238b2a8a3fc5e051251662ef6ab80f72c659f Author: Graff, Philip B Date: 2018-01-14T06:01:17Z Additional check. Tests still fail - but I think this is a problem with the implementations, not the test. commit 5467a33f2e17ad22b736effebede124556f049ed Author: Graff, Philip B Date: 2018-01-14T18:44:33Z Test bug fix and refactoring repeated code commit febe0ac8ecdf1828233017864b629a644c7260a8 Author: Graff, Philip B Date: 2018-02-25T17:22:39Z Updating kitchen sink graph commit f03c4df45473bafcf95d47f34467479f89af73a1 Author: Graff, Philip B Date: 2018-02-25T17:35:43Z Updating message passing tests to use kitchen sink commit b0b124b84c597079b271adb0dec2044f0c2ec9b3 Author: Graff, Philip B Date: 2018-02-25T21:15:40Z Revert "Updating kitchen sink graph" This reverts commit febe0ac8ecdf1828233017864b629a644c7260a8. commit 0490a082d9b533cb7ef4a1a25bd25500844821a6 Author: Graff, Philip B Date: 2018-02-25T21:27:28Z Proper update of kitchen sink through TinkerFactory commit 027ae2771d3c67bb613c525a689fe10123686b45 Author: Graff, Philip B Date: 2018-02-28T16:38:33Z Using "name" instead of "propertyin" commit 26a5770efb288d60150cf9db60a5dd67568179f2 Author: Stephen Mallette Date: 2018-03-02T16:29:57Z TINKERPOP-1862 Fix Messenger implementations for Spark/Giraph handling BOTH These now behave like TinkerMessenger and in the case of BOTH pass the message to the opposite vertex in the StarGraph commit 7956b481b459a9998401abc8b02322f256a73ae7 Author: Stephen Mallette Date: 2018-03-02T16:33:21Z TINKERPOP-1862 Updated changelog > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383795#comment-16383795 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/801 > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382445#comment-16382445 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/801 I just pushed the fix for the `ToyGraphInputRdd`: https://github.com/apache/tinkerpop/commit/a61dd58eea353637d74086426e4258de5927a8d9 If your rebase you'll get that little fix. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[
https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382108#comment-16382108
]
ASF GitHub Bot commented on TINKERPOP-1862:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/801
I'm sorry to say that spark integration tests are failing for your added
tests. Not sure what's wrong. I made an initial fix that solved the first body
of errors. I updated `ToyGraphInputRDD` to include:
```java
else if
(configuration.getString(Constants.GREMLIN_HADOOP_INPUT_LOCATION).contains("sink"))
vertices =
IteratorUtils.list(IteratorUtils.map(TinkerFactory.createKitchenSink().vertices(),
VertexWritable::new));
```
But the tests still fail with:
```text
[ERROR]
testMessagePassingOut(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest)
Time elapsed: 5.693 s <<< ERROR!
java.util.concurrent.ExecutionException: java.lang.IllegalStateException:
Name is null
at
org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.runMPTest(GraphComputerTest.java:2741)
at
org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingOut(GraphComputerTest.java:2710)
Caused by: java.lang.IllegalStateException: Name is null
Caused by: java.lang.NullPointerException: Name is null
[ERROR]
testMessagePassingBoth(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest)
Time elapsed: 5.397 s <<< ERROR!
java.util.concurrent.ExecutionException: java.lang.IllegalStateException:
Name is null
at
org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.runMPTest(GraphComputerTest.java:2741)
at
org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingBoth(GraphComputerTest.java:2726)
Caused by: java.lang.IllegalStateException: Name is null
Caused by: java.lang.NullPointerException: Name is null
[ERROR]
testMessagePassingIn(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest)
Time elapsed: 5.198 s <<< ERROR!
java.util.concurrent.ExecutionException: java.lang.IllegalStateException:
Name is null
at
org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.runMPTest(GraphComputerTest.java:2741)
at
org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingIn(GraphComputerTest.java:2694)
Caused by: java.lang.IllegalStateException: Name is null
Caused by: java.lang.NullPointerException: Name is null
```
Not sure I know what is causing thatI don't what "Name" is referring to
here. I was guessing the property you just added to "sink" but it's not the
same case, so..
> TinkerGraph VertexProgram message passing doesn't work properly when using
> Direction.BOTH
> -
>
> Key: TINKERPOP-1862
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1862
> Project: TinkerPop
> Issue Type: Bug
> Components: process, tinkergraph
>Affects Versions: 3.2.7
>Reporter: Philip Graff
>Priority: Major
>
> I think the messages are being sent properly in TinkerMessenger, but when I
> call messenger.receiveMessages(), the vertex is getting messages from the
> outVertex of their edges regardless of the edge direction. This is due to
> line 71 of TinkerMessenger (linked below) which calls
> Edge.vertices(direction).next(), thus getting the first result out of the
> Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following
> line 124 of TinkerEdge (linked below), the outVertex is always returned
> first. TinkerMessenger needs to be modified to return the correct vertex (I
> think it's the one that != this.vertex).
> https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71
> https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380678#comment-16380678 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/801 OK, I've made that update and now this build passes. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[
https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380270#comment-16380270
]
ASF GitHub Bot commented on TINKERPOP-1862:
---
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/801#discussion_r171238657
--- Diff:
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerFactory.java
---
@@ -149,6 +149,13 @@ public static void generateKitchenSink(final
TinkerGraph graph) {
g.addV("loops").property(T.id, 1000).property("name",
"loop").as("me").
addE("self").to("me").
iterate();
+final String LABEL = "message_passing_test";
+final String EDGE_LABEL = "msg_pass_test_edge";
+final String PROPERTY_IN = "propertyin";
+Vertex a = graph.addVertex(T.id, 2000, T.label, LABEL,
PROPERTY_IN, "a");
--- End diff --
all of these sample graphs need a "name" property of some sort. that's why
the build is currently failing for me. please "final" the two `Vertex`
variables.
> TinkerGraph VertexProgram message passing doesn't work properly when using
> Direction.BOTH
> -
>
> Key: TINKERPOP-1862
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1862
> Project: TinkerPop
> Issue Type: Bug
> Components: process, tinkergraph
>Affects Versions: 3.2.7
>Reporter: Philip Graff
>Priority: Major
>
> I think the messages are being sent properly in TinkerMessenger, but when I
> call messenger.receiveMessages(), the vertex is getting messages from the
> outVertex of their edges regardless of the edge direction. This is due to
> line 71 of TinkerMessenger (linked below) which calls
> Edge.vertices(direction).next(), thus getting the first result out of the
> Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following
> line 124 of TinkerEdge (linked below), the outVertex is always returned
> first. TinkerMessenger needs to be modified to return the correct vertex (I
> think it's the one that != this.vertex).
> https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71
> https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377512#comment-16377512 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/801 I'm not sure why this is failing, it's due to something with the javascript. I don't know how my changes potentially affected that. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376252#comment-16376252 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/801 Done > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376242#comment-16376242 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/801 I'll modify and let you know when I'm done so that I make sure it's setup as I need. For my test I need not just a self-edge but also an edge to another vertex. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376240#comment-16376240 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/801 sorry - the process for adding new data to the sink is different. i didn't realize that the self-edge graph i'd already added wasn't sufficient for what you needed or i would have provided instructions. you actually needed to do this: 1. modify this to include your data: https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerFactory.java#L147 2. then do `cd tinkergraph-gremlin` and `mvn clean install -Dio` which will generate and update all the relevant files. If you want I can go through that process for you when I merge it so that you don't need to fuss with this PR anymore. Not a big deal - I'm more concerned about the general content of the PR. Please let me know if you just want me to handle it that way. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376193#comment-16376193 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/801 @spmallette : I believe this is ready now if you can run the Docker test: `docker/build.sh -t -n -i` > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376162#comment-16376162 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/801 Never mind, I think I got it. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[
https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376154#comment-16376154
]
ASF GitHub Bot commented on TINKERPOP-1862:
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/801
Hi @spmallette, I'm trying to add to the kitchen sink graph for my message
passing test and I want to make sure I'm doing it right. I'm doing this in Java
and calling a custom `main()`:
```
Graph g1 = TinkerGraph.open();
Graph g2 = TinkerGraph.open();
Graph g3 = TinkerGraph.open();
try {
// GraphSON v1.0
g1.io(GraphSONIo.build(GraphSONVersion.V1_0)).readGraph("../tinkerpop/data/tinkerpop-sink.json");
addData(g1);
g1.io(GraphSONIo.build(GraphSONVersion.V1_0)).writeGraph("tinkerpop-sink.json");
// GraphSON v2.0
g2.io(GraphSONIo.build(GraphSONVersion.V2_0)).readGraph("../tinkerpop/data/tinkerpop-sink-v2d0.json");
addData(g2);
g2.io(GraphSONIo.build(GraphSONVersion.V2_0)).writeGraph("tinkerpop-sink-v2d0.json");
// Gryo
g3.io(GryoIo.build()).readGraph("../tinkerpop/data/tinkerpop-sink.kryo");
addData(g3);
g3.io(GryoIo.build()).writeGraph("tinkerpop-sink.kryo");
} catch (IOException e) {
e.printStackTrace();
}
```
where
```
private static void addData(Graph g) {
Vertex a = g.addVertex(T.id, 1L, T.label, LABEL, PROPERTYIN, VTX_A);
Vertex b = g.addVertex(T.id, 2L, T.label, LABEL, PROPERTYIN, VTX_B);
a.addEdge(EDGE_LABEL, b);
a.addEdge(EDGE_LABEL, a);
}
```
`V1_0` appears to be coming out right, but `V2_0` looks to be typed when
the original isn't. Plus, I can't see how to read/write typed versions as
opposed to un-typed. Gryo appears to be straightforward. Should I add a GraphML
version?
> TinkerGraph VertexProgram message passing doesn't work properly when using
> Direction.BOTH
> -
>
> Key: TINKERPOP-1862
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1862
> Project: TinkerPop
> Issue Type: Bug
> Components: process, tinkergraph
>Affects Versions: 3.2.7
>Reporter: Philip Graff
>Priority: Major
>
> I think the messages are being sent properly in TinkerMessenger, but when I
> call messenger.receiveMessages(), the vertex is getting messages from the
> outVertex of their edges regardless of the edge direction. This is due to
> line 71 of TinkerMessenger (linked below) which calls
> Edge.vertices(direction).next(), thus getting the first result out of the
> Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following
> line 124 of TinkerEdge (linked below), the outVertex is always returned
> first. TinkerMessenger needs to be modified to return the correct vertex (I
> think it's the one that != this.vertex).
> https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71
> https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376134#comment-16376134 ] ASF GitHub Bot commented on TINKERPOP-1862: --- GitHub user PBGraff opened a pull request: https://github.com/apache/tinkerpop/pull/801 TINKERPOP-1862 TinkerMessenger proper handling of Direction.BOTH New PR based off of #777 re-based on new head of tp32 branch. Need to update toy graph merged in #794 with scenario for this test and then update relevant tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PBGraff/tinkerpop TINKERPOP-1862 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/801.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #801 commit f02ea338a8d039c50896f7c65ca57a695975fc43 Author: Graff, Philip B Date: 2018-01-04T18:27:44Z TinkerMessenger proper handling of Direction.BOTH commit 80c0b8465fe9bb6ddbe4522a36304c7ba054e909 Author: Graff, Philip B Date: 2018-01-14T02:32:29Z Adding simple graph computer test of proper message passing in all 3 directions commit 750677cf55d7445c3746870d86c6592f6cd3664d Author: Graff, Philip B Date: 2018-01-14T04:49:27Z Test cleanup - hopefully can run now commit 153238b2a8a3fc5e051251662ef6ab80f72c659f Author: Graff, Philip B Date: 2018-01-14T06:01:17Z Additional check. Tests still fail - but I think this is a problem with the implementations, not the test. commit 5467a33f2e17ad22b736effebede124556f049ed Author: Graff, Philip B Date: 2018-01-14T18:44:33Z Test bug fix and refactoring repeated code > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376131#comment-16376131 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff closed the pull request at: https://github.com/apache/tinkerpop/pull/777 > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357143#comment-16357143 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/777 Great, thanks. I haven't been able to work on this recently but having that merged will help. I'll check it out and update my test as well as fix the git history of the branch for this and #772. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357120#comment-16357120 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/777 #794 and #795 have both merged now. @PBGraff you now have a test graph with a single simple self-loop subgraph that you can use (and obviously add other test subgraphs as needed). hope that helps move this PR forward. please let me know if you have any questions > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347574#comment-16347574 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/777 I just added the new toy graph infrastructure on #794 - as soon as that merges then we can finish this one up. @PBGraff something still sorta looks fishy here with the commit history. my expectation would be that this PR would have no commits except your own, but i still see some of mine (and others) in there. I don't know the full state of your fork, so it's hard to give advice, but perhaps you need to: 1. update your fork's tp32 branch with the latest from tinkerpop 2. `git checkout tp32` 3. `git checkout -b TINKERPOP-1862-revised` 4. cherry pick just your commits from TINKERPOP-1862 over to TINKERPOP-1862-revised 5. kill the old TINKERPOP-1862 (local and remote) and rename it TINKERPOP-1862-revised appropriately by dropping the "-revised" then push that Then going forward all you should have to do is keep your fork's tp32 branch updated and periodically: `git rebase origin/tp32` on the TINKERPOP-1862 branch which will continually take all your changes and replay them on the head of your fork's tp32. If you have some other more elegant git solution, that's cool toojust providing the hammer solution to the problem in case you can't figure out anything better. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334827#comment-16334827 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/777 Thanks, @spmallette. Regarding the re-basing, I think I just managed that... > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334767#comment-16334767 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/777 I guess I'll create a new issue for this in JIRA. crazy > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334766#comment-16334766 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/777 Absolutely, I like the idea. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334740#comment-16334740 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/777 dar - a new graph - serious yak shaving going on with pull requests lately. perhaps we create a "TEST" graph that can contain many disconnected subgraphs that we can add to and adjust as needed. When we used it in our tests we would just always take care to blind any test traversals to the parts of the graph that didn't matter. That way, we could have just abstract stuff in there like, a self-loop, a tree, etc. Nothing would have to have meaning like "The Crew" or "Modern". does that make sense? > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334717#comment-16334717 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/777 Unfortunately, we don't have any self-loops in our sample graphs. @spmallette That's really something we should consider to add. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334681#comment-16334681 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/777 I'll look, but I was also particularly interested in having a self-loop edge to make sure that those are handled correctly as well. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334668#comment-16334668 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/777 > we could use the Grateful Dead graph; this pattern occurs 1476 times in it. perfect - i was wondering if Grateful Dead would work earlier. @PBGraff can you perhaps find a pattern in that graph that will allow you to just use that existing data set? > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334664#comment-16334664 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/777 I agree this test should run for all GraphComputers, but the test may not try to mutate the graph, as the test suite will run the test against a whole bunch of immutable graphs. Assuming that all we need is a pair 2 vertices connected via 2 edges in opposite directions, we could use the Grateful Dead graph; this pattern occurs 1476 times in it. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334229#comment-16334229 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/777 I think it's best to include this test for all `GraphComputer` implementations to ensure that they are doing message passing correctly. The problem was found with `TinkerMessenger`, but the test should be there for code coverage. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334203#comment-16334203 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/777 I looked into this one some more. This was a change to the `TinkerMessenger` so technically I would think that this is a change specific to TinkerGraph, in which case the test could be aligned solely to TinkerGraph. Butit makes me wonder if other `GraphComputer` (like Spark's) work correctly. I'm hesitant to just bind this test to TinkerGraph if it's good to test to have elsewhere. @dkuppitz any thoughts on this? > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331444#comment-16331444 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/777 I'm posting this to all open PRs of current relevance - this PR needs to be rebased against the branch it is targeted against given a broken python dependency that was published to pypi a day or so ago. I've pushed a fix on tp32 and master at this point and David Brown is working on getting an issue raised with the project that initiated the problem. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328128#comment-16328128 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/777 I don't have an environment for testing with Spark right now, so I was unable to run those tests. They're failing because for the test I added I want to create my own graph and add two vertices and two edges to it (see `runTest(Direction)` at line 2665 of `GraphComputerTest.java`). Is there a better way to do this that will be acceptable for Spark where it seems the graph is immutable? I was trying to not have to create another GraphML/GraphSON/Gryo graph to be stored. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327733#comment-16327733 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/777 When I run the integration tests with `docker/build.sh -t -i` I get some failures in spark - do they fail for you too @PBGraff ? ```text [ERROR] Tests run: 619, Failures: 0, Errors: 3, Skipped: 149, Time elapsed: 237.084 s <<< FAILURE! - in org.apache.tinkerpop.gremlin.spark.process.computer.SparkGraphComputerProcessIntegrateTest [ERROR] testMessagePassingOut(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) Time elapsed: 0.001 s <<< ERROR! java.lang.UnsupportedOperationException: Graph does not support adding vertices at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.runTest(GraphComputerTest.java:2666) at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingOut(GraphComputerTest.java:2637) [ERROR] testMessagePassingBoth(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) Time elapsed: 0 s <<< ERROR! java.lang.UnsupportedOperationException: Graph does not support adding vertices at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.runTest(GraphComputerTest.java:2666) at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingBoth(GraphComputerTest.java:2652) [ERROR] testMessagePassingIn(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) Time elapsed: 0.001 s <<< ERROR! java.lang.UnsupportedOperationException: Graph does not support adding vertices at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.runTest(GraphComputerTest.java:2666) at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingIn(GraphComputerTest.java:2622) [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingBoth(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) [ERROR] Run 1: GraphComputerTest.testMessagePassingBoth:2652->runTest:2666 ? UnsupportedOperation [ERROR] Run 2: GraphComputerTest.testMessagePassingBoth:2652->runTest:2666 ? UnsupportedOperation [INFO] [ERROR] org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingIn(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) [ERROR] Run 1: GraphComputerTest.testMessagePassingIn:2622->runTest:2666 ? UnsupportedOperation [ERROR] Run 2: GraphComputerTest.testMessagePassingIn:2622->runTest:2666 ? UnsupportedOperation [INFO] [ERROR] org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingOut(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) [ERROR] Run 1: GraphComputerTest.testMessagePassingOut:2637->runTest:2666 ? UnsupportedOperation [ERROR] Run 2: GraphComputerTest.testMessagePassingOut:2637->runTest:2666 ? UnsupportedOperation [INFO] [INFO] [ERROR] Tests run: 1625, Failures: 0, Errors: 3, Skipped: 267 ``` > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325728#comment-16325728 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/777 Tests pass now, good to go from me. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325430#comment-16325430 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/777 @spmallette Updated PR from https://github.com/apache/tinkerpop/pull/770 > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325429#comment-16325429 ] ASF GitHub Bot commented on TINKERPOP-1862: --- GitHub user PBGraff opened a pull request: https://github.com/apache/tinkerpop/pull/777 TINKERPOP-1862 TinkerMessenger proper handling of Direction.BOTH New PR targeted to `tp32` branch. Fixes `TinkerMessenger` handling of direction to get the correct messages. Also now adds a set of tests to `GraphComputerTest` to test this message passing in a simple graph with a simple vertex program in all directions (`IN`, `OUT`, and `BOTH`). You can merge this pull request into a Git repository by running: $ git pull https://github.com/PBGraff/tinkerpop TINKERPOP-1862 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/777.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #777 commit 5e157faebfe971c3ef06ac5365993052021a95fb Author: Graff, Philip B Date: 2018-01-04T18:27:44Z TinkerMessenger proper handling of Direction.BOTH commit 01a9ee5ae80fd429726d0722edae3195d9a625c5 Author: Graff, Philip B Date: 2018-01-14T02:32:29Z Adding simple graph computer test of proper message passing in all 3 directions > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325424#comment-16325424 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff closed the pull request at: https://github.com/apache/tinkerpop/pull/770 > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321514#comment-16321514 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/770 I assume this problem also exists in the tp32 branch (3.2.x) - if so, could you please re-target this PR to that branch? also, can you please include tests to validate that self-loops are being handled properly? > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311831#comment-16311831 ] ASF GitHub Bot commented on TINKERPOP-1862: --- GitHub user PBGraff opened a pull request: https://github.com/apache/tinkerpop/pull/770 TINKERPOP-1862 TinkerMessenger proper handling of Direction.BOTH This PR presents a fix for `TinkerMessenger` that handled `Direction.BOTH` by identifying the `Vertex` that is not the one receiving the message. In the case of self-loops, the same `Vertex` is still returned so these are handled properly. Note that self-loops cause messages to be sent/received twice since the `Edge` is both `IN` and `OUT`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PBGraff/tinkerpop TINKERPOP-1862 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/770.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #770 commit 70b74de41a288ea27f0cc6b89cba57d07c3bc3d0 Author: Graff, Philip B Date: 2018-01-04T18:27:44Z TinkerMessenger proper handling of Direction.BOTH > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
