svn commit: r960812 - /tomcat/taglibs/standard/trunk/impl/pom.xml

2010-07-06 Thread bayard
Author: bayard Date: Tue Jul 6 06:32:09 2010 New Revision: 960812 URL: http://svn.apache.org/viewvc?rev=960812view=rev Log: Adding pom changes from #49548. Hook the new TestSetSupport file up directly, and ensure the jar includes the .properties file. Patch from Jeremy Boynes Modified:

DO NOT REPLY [Bug 49548] Refactoring SetSupport

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49548 Henri Yandell bay...@apache.org changed: What|Removed |Added OS/Version||All --- Comment

svn commit: r960814 - in /tomcat/taglibs/standard/trunk/impl/src: main/java/org/apache/taglibs/standard/functions/Functions.java test/java/org/apache/taglibs/standard/functions/TestFunctions.java

2010-07-06 Thread bayard
Author: bayard Date: Tue Jul 6 06:46:55 2010 New Revision: 960814 URL: http://svn.apache.org/viewvc?rev=960814view=rev Log: Patch from Jeremy Boynes (#49554): The implementation of Functions has checks for null parameters that are redundant given coercion required by the Engine. As discussed

svn commit: r960817 - in /tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard: resources/Resources.properties tag/common/core/SetSupport.java

2010-07-06 Thread bayard
Author: bayard Date: Tue Jul 6 06:52:21 2010 New Revision: 960817 URL: http://svn.apache.org/viewvc?rev=960817view=rev Log: Applying Jeremy Boynes' refactoring of SetSupport per #49548 Patch primarily refactors the large if clause that sets the result into smaller methods. It also clears up IDE

DO NOT REPLY [Bug 49548] Refactoring SetSupport

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49548 Henri Yandell bay...@apache.org changed: What|Removed |Added Status|NEW |NEEDINFO ---

DO NOT REPLY [Bug 49554] Clean up Functions

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49554 Henri Yandell bay...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: [taglibs] Null handling in Functions

2010-07-06 Thread Henri Yandell
With Tomcat 7 now out, it's tempting to focus on Taglibs in that space rather than worrying about JavaEE5. Does it do much for the user to add the annotations? Does it do much for us on the development side? On Mon, Jul 5, 2010 at 12:17 AM, Jeremy Boynes jboy...@apache.org wrote: I work on a

svn commit: r960823 - /tomcat/taglibs/standard/trunk/impl/pom.xml

2010-07-06 Thread bayard
Author: bayard Date: Tue Jul 6 07:09:35 2010 New Revision: 960823 URL: http://svn.apache.org/viewvc?rev=960823view=rev Log: Adding some basic reports Modified: tomcat/taglibs/standard/trunk/impl/pom.xml Modified: tomcat/taglibs/standard/trunk/impl/pom.xml URL:

svn commit: r960825 - /tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/core/RemoveTag.java

2010-07-06 Thread bayard
Author: bayard Date: Tue Jul 6 07:11:41 2010 New Revision: 960825 URL: http://svn.apache.org/viewvc?rev=960825view=rev Log: Removing unused constants Modified: tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/core/RemoveTag.java Modified:

svn commit: r960826 - /tomcat/taglibs/standard/trunk/impl/pom.xml

2010-07-06 Thread bayard
Author: bayard Date: Tue Jul 6 07:13:29 2010 New Revision: 960826 URL: http://svn.apache.org/viewvc?rev=960826view=rev Log: Setting build properties; most importantly that the jdk version is 1.5 Modified: tomcat/taglibs/standard/trunk/impl/pom.xml Modified:

svn commit: r960828 - /tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/core/ForEachSupport.java

2010-07-06 Thread bayard
Author: bayard Date: Tue Jul 6 07:13:47 2010 New Revision: 960828 URL: http://svn.apache.org/viewvc?rev=960828view=rev Log: Optimizing to use Boolean.TRUE/FALSE and not new Boolean Modified:

svn commit: r960829 - in /tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard: lang/jstl/BeanInfoIndexedProperty.java lang/jstl/ImplicitObjects.java tag/common/core/ForTokensS

2010-07-06 Thread bayard
Author: bayard Date: Tue Jul 6 07:15:08 2010 New Revision: 960829 URL: http://svn.apache.org/viewvc?rev=960829view=rev Log: Removing unused imports Modified: tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/lang/jstl/BeanInfoIndexedProperty.java

svn commit: r960830 - /tomcat/taglibs/standard/trunk/impl/pom.xml

2010-07-06 Thread bayard
Author: bayard Date: Tue Jul 6 07:18:05 2010 New Revision: 960830 URL: http://svn.apache.org/viewvc?rev=960830view=rev Log: Adding findbugs Modified: tomcat/taglibs/standard/trunk/impl/pom.xml Modified: tomcat/taglibs/standard/trunk/impl/pom.xml URL:

[g...@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2010-07-06 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This

Re: [g...@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2010-07-06 Thread Konstantin Kolinko
2010/7/6 Bill Barker billbar...@apache.org: BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:941: Some tests completed with an Error. See /srv/gump/public/workspace/tomcat-trunk/output/build/logs for details. It is testBug47413 in org.apache.el.TestELInJsp

Re: [VOTE] Release Tomcat 5.5.30 Build

2010-07-06 Thread Konstantin Kolinko
2010/7/1 Jim Jagielski j...@jagunet.com: The builds for Tomcat 5.5.30 are ready for testing and approval. The candidates binaries are available here:   http://people.apache.org/~jim/tomcat-5.5/ According to the release process, the 5.5.30 build corresponding to the tag TOMCAT_5_5_30 [1] is:

DO NOT REPLY [Bug 49217] Accepting java keyword in EL

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 --- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com 2010-07-06 06:34:01 EDT --- Reading jsp-2_1-fr-spec-el.pdf (Expression Language Specification Version 2.1, Final Release), 1) page 21: (35/122) An identifier is constrained to

DO NOT REPLY [Bug 40114] Session inadvertently hijacked by different after server restart

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=40114 Denis A. alt...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED

svn commit: r960864 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-06 Thread kkolinko
Author: kkolinko Date: Tue Jul 6 10:40:16 2010 New Revision: 960864 URL: http://svn.apache.org/viewvc?rev=960864view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

DO NOT REPLY [Bug 40114] Session inadvertently hijacked by different after server restart

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=40114 --- Comment #3 from Denis A. alt...@gmail.com 2010-07-06 06:48:37 EDT --- (In reply to comment #2) I mean: This seems to happen *randomly* only after a server restart. For instance an user login and has some session scoped beans from its

DO NOT REPLY [Bug 40114] Session inadvertently hijacked by different after server restart

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=40114 Denis A. alt...@gmail.com changed: What|Removed |Added CC||alt...@gmail.com

Re: [VOTE] Release Tomcat 5.5.30 Build

2010-07-06 Thread jean-frederic clere
On 07/01/2010 06:11 PM, Jim Jagielski wrote: The builds for Tomcat 5.5.30 are ready for testing and approval. The candidates binaries are available here: http://people.apache.org/~jim/tomcat-5.5/ According to the release process, the 5.5.30 build corresponding to the tag TOMCAT_5_5_30

Re: [VOTE] Release build 6.0.28

2010-07-06 Thread Konstantin Kolinko
2010/6/29 jean-frederic clere jfcl...@gmail.com: Due to bugs (49445 and 49424) and as I was not able to finish the release process quickly (because of working remotely) and as releases are cheap we would like to abandon 6.0.27 and propose the vote for 6.0.28 The candidates binaries are

DO NOT REPLY [Bug 49217] Accepting java keyword in EL

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 --- Comment #4 from Mark Thomas ma...@apache.org 2010-07-06 08:08:57 EDT --- Java identifier is defined by the Java Language Specification and explicitly states keywords are not permitted. The definition is actually even stricter than

Re: svn commit: r960864 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-06 Thread Mark Thomas
On 06/07/2010 12:40, kkoli...@apache.org wrote: Author: kkolinko Date: Tue Jul 6 10:40:16 2010 New Revision: 960864 URL: http://svn.apache.org/viewvc?rev=960864view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

DO NOT REPLY [Bug 40114] Session inadvertently hijacked by different after server restart

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=40114 --- Comment #4 from Chuck Caldarale chuck.caldar...@unisys.com 2010-07-06 09:05:59 EDT --- (In reply to comment #2) This happen with: * Tomcat 5.5.26 There is a discrepancy between the version the bug was filed under (5.0.26), and what

DO NOT REPLY [Bug 49548] Refactoring SetSupport

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49548 --- Comment #4 from Jeremy Boynes jboy...@apache.org 2010-07-06 09:20:16 EDT --- (In reply to comment #3) On the tests - what are Syntax1 and Syntax3? They are references to the Syntax section in the spec. Syntax one is where a variable

DO NOT REPLY [Bug 49505] ApplicationHttpRequest.setAttribute doesn't call the wrapper's setAttribute in case of special attributes

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49505 ran...@hotmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: [taglibs] Null handling in Functions

2010-07-06 Thread Jeremy Boynes
IMO they would not help either users or developers much as this is not an contract used by anyone other than the container. They would supplement the documentation but we would still want that to explain why a null would not be passed. What environment to support deserves its own thread :) On

[g...@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2010-07-06 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-taglibs-standard has an issue affecting its community

DO NOT REPLY [Bug 49505] ApplicationHttpRequest.setAttribute doesn't call the wrapper's setAttribute in case of special attributes

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49505 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED

svn commit: r960940 - in /tomcat/trunk: test/webapp-3.0/bug47413.jsp webapps/examples/WEB-INF/classes/jsp2/examples/ValuesBean.java webapps/examples/jsp/jsp2/el/composite.jsp

2010-07-06 Thread markt
Author: markt Date: Tue Jul 6 16:45:23 2010 New Revision: 960940 URL: http://svn.apache.org/viewvc?rev=960940view=rev Log: Side effect of fixing https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 Make the examples and the unit tests spec compliant Modified:

svn commit: r960942 - in /tomcat/trunk: java/org/apache/el/parser/AstDotSuffix.java java/org/apache/el/parser/AstIdentifier.java java/org/apache/el/util/Validation.java webapps/docs/changelog.xml

2010-07-06 Thread markt
Author: markt Date: Tue Jul 6 16:47:39 2010 New Revision: 960942 URL: http://svn.apache.org/viewvc?rev=960942view=rev Log: Improve fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 Make sure identifiers meet the requirements of the JLS Modified:

DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 chamith buddhika chamibuddh...@gmail.com changed: What|Removed |Added Attachment #25638|0 |1

DO NOT REPLY [Bug 49561] Remove proprietary URLEncoder

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49561 --- Comment #1 from Jeremy Boynes jboy...@apache.org 2010-07-06 13:02:50 EDT --- Created an attachment (id=25718) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=25718) Patch to switch to using URLEncoder -- Configure bugmail:

DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 chamith buddhika chamibuddh...@gmail.com changed: What|Removed |Added Attachment #25639|0 |1

DO NOT REPLY [Bug 49561] New: Remove proprietary URLEncoder

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49561 Summary: Remove proprietary URLEncoder Product: Taglibs Version: 1.2.0 Platform: PC Status: NEW Severity: enhancement Priority: P2 Component: Standard

DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 chamith buddhika chamibuddh...@gmail.com changed: What|Removed |Added Attachment #25641|0 |1

DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 chamith buddhika chamibuddh...@gmail.com changed: What|Removed |Added Attachment #25640|0 |1

svn commit: r961057 - in /tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/core: ParamSupport.java Util.java

2010-07-06 Thread bayard
Author: bayard Date: Wed Jul 7 02:14:53 2010 New Revision: 961057 URL: http://svn.apache.org/viewvc?rev=961057view=rev Log: Upgraded to the JVM included version of URLEncoder from the Util.URLEncode method. Removing said method. Supplid by Jeremy Boynes to #49561 Modified:

DO NOT REPLY [Bug 49561] Remove proprietary URLEncoder

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49561 Henri Yandell bay...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r961058 - /tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/tag/common/core/TestSetSupport.java

2010-07-06 Thread bayard
Author: bayard Date: Wed Jul 7 02:23:26 2010 New Revision: 961058 URL: http://svn.apache.org/viewvc?rev=961058view=rev Log: Adding more tests for SetSupport from Jeremy Boynes' patch to #49548. The Syntax1/Syntax3 notations refers to the specification. Modified:

svn commit: r961059 - /tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/xml/XPathUtil.java

2010-07-06 Thread bayard
Author: bayard Date: Wed Jul 7 02:24:26 2010 New Revision: 961059 URL: http://svn.apache.org/viewvc?rev=961059view=rev Log: FIXME-TODO Modified: tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/xml/XPathUtil.java Modified:

DO NOT REPLY [Bug 49548] Refactoring SetSupport

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49548 Henri Yandell bay...@apache.org changed: What|Removed |Added Status|NEEDINFO|RESOLVED

DO NOT REPLY [Bug 49565] New: Findbugs: Util.specialCharactersRepresentation should be both final and package protected

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49565 Summary: Findbugs: Util.specialCharactersRepresentation should be both final and package protected Product: Taglibs Version: 1.2.0 Platform: PC Status: NEW

DO NOT REPLY [Bug 49565] Findbugs: Util.specialCharactersRepresentation should be both final and package protected

2010-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49565 --- Comment #1 from Jeremy Boynes jboy...@apache.org 2010-07-07 01:55:45 EDT --- Created an attachment (id=25724) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=25724) Fix findbugs error and refactor output implementation Patch