svn commit: r1173020 - /tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread markt
Author: markt Date: Tue Sep 20 08:33:44 2011 New Revision: 1173020 URL: http://svn.apache.org/viewvc?rev=1173020view=rev Log: Better detection of thread termination at end of test Better failure messages so it is easier to see the cause of any failure immediately Modified:

svn commit: r1173021 - /tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread markt
Author: markt Date: Tue Sep 20 08:36:18 2011 New Revision: 1173021 URL: http://svn.apache.org/viewvc?rev=1173021view=rev Log: Remove debug use of System.out Add missing volatile Modified: tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java Modified:

svn commit: r1173022 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread markt
Author: markt Date: Tue Sep 20 08:37:15 2011 New Revision: 1173022 URL: http://svn.apache.org/viewvc?rev=1173022view=rev Log: Better detection of thread termination at end of test Better failure messages so it is easier to see the cause of any failure immediately Modified:

Re: svn commit: r1172234 - in /tomcat/trunk/java/org/apache/catalina/ha/session: ClusterManagerBase.java DeltaSession.java

2011-09-20 Thread Keiichi Fujino
I think that it is necessary to add sessionAttributeFilter to the cloneFromTemplate method of both BackupManager and DeltaManager. Otherwise, it will not be set to BackupManager or DeltaManager, even if it sets sessionAttributeFilter to server.xml. For example, the following codes are added to

[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2011-09-20 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-09-20 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This

svn commit: r1173082 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProtocol.java test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread markt
Author: markt Date: Tue Sep 20 11:02:41 2011 New Revision: 1173082 URL: http://svn.apache.org/viewvc?rev=1173082view=rev Log: Remove empty comment Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java

Re: svn commit: r1173082 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProtocol.java test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread Konstantin Kolinko
2011/9/20 ma...@apache.org: Author: markt Date: Tue Sep 20 11:02:41 2011 New Revision: 1173082 URL: http://svn.apache.org/viewvc?rev=1173082view=rev Log: Remove empty comment You did more than removed a comment (you've committed two files instead of one)... Modified:    

svn commit: r1173088 - in /tomcat/trunk/java/org/apache/catalina/ha/session: BackupManager.java ClusterManagerBase.java DeltaManager.java

2011-09-20 Thread rjung
Author: rjung Date: Tue Sep 20 11:32:49 2011 New Revision: 1173088 URL: http://svn.apache.org/viewvc?rev=1173088view=rev Log: Pull up members cluster and notifyListenersOnReplication to common base class. Modified: tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java

Re: svn commit: r1172689 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2011-09-20 Thread Konstantin Kolinko
2011/9/20 sebb seb...@gmail.com: On 19 September 2011 17:30,  ma...@apache.org wrote: Author: markt Date: Mon Sep 19 16:30:36 2011 New Revision: 1172689 URL: http://svn.apache.org/viewvc?rev=1172689view=rev Log: Fix threading issue with changing visibility of methods and fields Modified:

svn commit: r1173090 - in /tomcat/trunk/java/org/apache/catalina/ha/session: BackupManager.java ClusterManagerBase.java DeltaManager.java

2011-09-20 Thread rjung
Author: rjung Date: Tue Sep 20 11:36:29 2011 New Revision: 1173090 URL: http://svn.apache.org/viewvc?rev=1173090view=rev Log: - Pull up common clode code to base class. - Add sessionAttributeFilter to clone method - Reduce visibility of notifyListenersOnReplication Modified:

Re: svn commit: r1172234 - in /tomcat/trunk/java/org/apache/catalina/ha/session: ClusterManagerBase.java DeltaSession.java

2011-09-20 Thread Rainer Jung
On 20.09.2011 11:05, Keiichi Fujino wrote: I think that it is necessary to add sessionAttributeFilter to the cloneFromTemplate method of both BackupManager and DeltaManager. Otherwise, it will not be set to BackupManager or DeltaManager, even if it sets sessionAttributeFilter to server.xml.

Re: svn commit: r1173082 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProtocol.java test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread Mark Thomas
On 20/09/2011 12:09, Konstantin Kolinko wrote: 2011/9/20 ma...@apache.org: Author: markt Date: Tue Sep 20 11:02:41 2011 New Revision: 1173082 URL: http://svn.apache.org/viewvc?rev=1173082view=rev Log: Remove empty comment You did more than removed a comment (you've committed two files

svn commit: r1173096 - /tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread markt
Author: markt Date: Tue Sep 20 11:54:44 2011 New Revision: 1173096 URL: http://svn.apache.org/viewvc?rev=1173096view=rev Log: Revert accidental commit Modified: tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java Modified:

svn commit: r1173097 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11NioProtocol.java

2011-09-20 Thread markt
Author: markt Date: Tue Sep 20 11:56:17 2011 New Revision: 1173097 URL: http://svn.apache.org/viewvc?rev=1173097view=rev Log: Remove ununsed comment Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java Propchange:

Re: [VOTE] Release Tomcat 5.5.34 Build

2011-09-20 Thread Konstantin Kolinko
2011/9/18 Jim Jagielski j...@jagunet.com: The builds for Tomcat 5.5.34 are ready for testing and approval. The candidates binaries are available here: [x] Stable Best regards, Konstantin Kolinko - To unsubscribe, e-mail:

Re: svn commit: r1173082 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProtocol.java test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread Konstantin Kolinko
2011/9/20 Mark Thomas ma...@apache.org: On 20/09/2011 12:09, Konstantin Kolinko wrote: 2011/9/20  ma...@apache.org: Author: markt Date: Tue Sep 20 11:02:41 2011 New Revision: 1173082 URL: http://svn.apache.org/viewvc?rev=1173082view=rev Log: Remove empty comment You did more than

Re: svn commit: r1173082 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProtocol.java test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread Mark Thomas
On 20/09/2011 13:41, Konstantin Kolinko wrote: 2011/9/20 Mark Thomas ma...@apache.org: On 20/09/2011 12:09, Konstantin Kolinko wrote: 2011/9/20 ma...@apache.org: Author: markt Date: Tue Sep 20 11:02:41 2011 New Revision: 1173082 URL: http://svn.apache.org/viewvc?rev=1173082view=rev Log:

svn commit: r1173135 - /tomcat/tc7.0.x/trunk/

2011-09-20 Thread kkolinko
Author: kkolinko Date: Tue Sep 20 13:20:20 2011 New Revision: 1173135 URL: http://svn.apache.org/viewvc?rev=1173135view=rev Log: Mark r1170647 as merged. (It was merged in r1170656) Modified: tomcat/tc7.0.x/trunk/ (props changed) Propchange: tomcat/tc7.0.x/trunk/

svn commit: r1173172 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-09-20 Thread kkolinko
Author: kkolinko Date: Tue Sep 20 14:43:26 2011 New Revision: 1173172 URL: http://svn.apache.org/viewvc?rev=1173172view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

DO NOT REPLY [Bug 51813] Tomcat randomly crashes with [libtcnative-1.so.1+0x152ca] Java_org_apache_tomcat_jni_Socket_sendbb+0x5a

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51813 --- Comment #3 from Mike Jakubik mike.jaku...@intertainservices.com 2011-09-20 16:08:58 UTC --- Hi Christopher, Thanks for the info, but it appears that simply switching to render a png instead of a jpeg has fixed our problem.

svn commit: r1173241 - /tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread markt
Author: markt Date: Tue Sep 20 16:46:17 2011 New Revision: 1173241 URL: http://svn.apache.org/viewvc?rev=1173241view=rev Log: 5s is plenty when things are working and 10s is too long when they aren't. Modified: tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java Modified:

svn commit: r1173251 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11AprProtocol.java

2011-09-20 Thread markt
Author: markt Date: Tue Sep 20 17:05:08 2011 New Revision: 1173251 URL: http://svn.apache.org/viewvc?rev=1173251view=rev Log: Don't add to Poller when socket is closing to prevent NPEs. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1173253 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread markt
Author: markt Date: Tue Sep 20 17:06:38 2011 New Revision: 1173253 URL: http://svn.apache.org/viewvc?rev=1173253view=rev Log: Reduce waiting time to a single 5s wait rather than 2*10s Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1173256 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2011-09-20 Thread markt
Author: markt Date: Tue Sep 20 17:08:41 2011 New Revision: 1173256 URL: http://svn.apache.org/viewvc?rev=1173256view=rev Log: Ensure that when the connector is stopped that a Comet END event is processed to signal to the app and to close the socket Modified:

svn commit: r1173260 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml

2011-09-20 Thread markt
Author: markt Date: Tue Sep 20 17:10:52 2011 New Revision: 1173260 URL: http://svn.apache.org/viewvc?rev=1173260view=rev Log: Fix a timing issue in NIO connector that meant that stopping a connector did not trigger a Comet END event if the associated processor was processing a READ event when

svn commit: r1173288 - /tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread markt
Author: markt Date: Tue Sep 20 18:17:06 2011 New Revision: 1173288 URL: http://svn.apache.org/viewvc?rev=1173288view=rev Log: Modify test to account for behaviours of different platforms and different connectors. Modified: tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java

DO NOT REPLY [Bug 44679] Cookies are treated differently between 6.0.16 and 6.0.14

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44679 --- Comment #44 from krystian krystian.no...@gmail.com 2011-09-20 18:32:13 UTC --- Observing the comments here I would have to support it as being an interoperability issue between other, non Java platforms/languages. As an example we can

svn commit: r1173309 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread markt
Author: markt Date: Tue Sep 20 19:03:48 2011 New Revision: 1173309 URL: http://svn.apache.org/viewvc?rev=1173309view=rev Log: Modify test to account for behaviours of different platforms and different connectors. Modified: tomcat/tc7.0.x/trunk/ (props changed)

Re: svn commit: r1173082 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProtocol.java test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread Mark Thomas
On 20/09/2011 13:41, Konstantin Kolinko wrote: 2011/9/20 Mark Thomas ma...@apache.org: On 20/09/2011 12:09, Konstantin Kolinko wrote: 2011/9/20 ma...@apache.org: Author: markt Date: Tue Sep 20 11:02:41 2011 New Revision: 1173082 URL: http://svn.apache.org/viewvc?rev=1173082view=rev Log:

DO NOT REPLY [Bug 51852] New: BeanELResolver varargs handling is broken in multiple ways

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51852 Bug #: 51852 Summary: BeanELResolver varargs handling is broken in multiple ways Product: Tomcat 7 Version: trunk Platform: PC Status: NEW

DO NOT REPLY [Bug 51852] BeanELResolver varargs handling is broken in multiple ways

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51852 --- Comment #1 from Matt Benson mben...@apache.org 2011-09-20 19:17:16 UTC --- Created attachment 27543 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27543 Proposed patch I grant the ASF license to incorporate the contents of

DO NOT REPLY [Bug 51852] BeanELResolver varargs handling is broken in multiple ways

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51852 Matt Benson mben...@apache.org changed: What|Removed |Added CC||mben...@apache.org

svn commit: r1173330 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/config/listeners.xml

2011-09-20 Thread schultz
Author: schultz Date: Tue Sep 20 20:16:08 2011 New Revision: 1173330 URL: http://svn.apache.org/viewvc?rev=1173330view=rev Log: Fixed bug #51687: Improve JreMemoryLeakPreventionListener against leak caused by sun.java2d.Disposer - Added (optional) protection against sun.java2d.Disposer thread

svn commit: r1173331 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2011-09-20 Thread schultz
Author: schultz Date: Tue Sep 20 20:16:59 2011 New Revision: 1173331 URL: http://svn.apache.org/viewvc?rev=1173331view=rev Log: Fixed bug #51687: Improve JreMemoryLeakPreventionListener against leak caused by sun.java2d.Disposer - Added (optional) protection against sun.java2d.Disposer thread

svn commit: r1173333 - in /tomcat/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/config/listeners.xml

2011-09-20 Thread schultz
Author: schultz Date: Tue Sep 20 20:17:23 2011 New Revision: 117 URL: http://svn.apache.org/viewvc?rev=117view=rev Log: Fixed bug #51687: Improve JreMemoryLeakPreventionListener against leak caused by sun.java2d.Disposer - Added (optional) protection against sun.java2d.Disposer thread

DO NOT REPLY [Bug 51687] Improve JreMemoryLeakPreventionListener against leak caused by sun.java2d.Disposer

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51687 Christopher Schultz ch...@christopherschultz.net changed: What|Removed |Added Status|NEW

svn commit: r1173342 - in /tomcat/trunk/java/org/apache/catalina/startup: ExpandWar.java LocalStrings.properties

2011-09-20 Thread schultz
Author: schultz Date: Tue Sep 20 20:30:10 2011 New Revision: 1173342 URL: http://svn.apache.org/viewvc?rev=1173342view=rev Log: Fixed bug #51580: Severe error deploying WAR application (ExpandWar error) - Added error mesage when JarEntry InputStream cannot be found due to a broken WAR file

svn commit: r1173343 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/startup/ExpandWar.java java/org/apache/catalina/startup/LocalStrings.properties webapps/docs/changelog.xml

2011-09-20 Thread schultz
Author: schultz Date: Tue Sep 20 20:33:05 2011 New Revision: 1173343 URL: http://svn.apache.org/viewvc?rev=1173343view=rev Log: Fixed bug #51580: Severe error deploying WAR application (ExpandWar error) - Added nicer error message when WAR file filenames are improperly encoded. Modified:

DO NOT REPLY [Bug 51580] Severe error deploying WAR application (ExpandWar error)

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51580 Christopher Schultz ch...@christopherschultz.net changed: What|Removed |Added Status|REOPENED

DO NOT REPLY [Bug 18500] Host aliases to match by regular expression

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=18500 --- Comment #5 from Christopher Schultz ch...@christopherschultz.net 2011-09-20 21:33:24 UTC --- Unfortunately for this enhancement, the Mapper is written to use a relatively high-performance binary search algorithm to find a matching Host

DO NOT REPLY [Bug 50504] Allow setting query string character set trough request attribute

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50504 --- Comment #2 from Christopher Schultz ch...@christopherschultz.net 2011-09-20 21:50:03 UTC --- Couldn't this just be written as a Valve? The only utility I can see for checking for a request attribute like

DO NOT REPLY [Bug 50923] Difficult to pick out valid values from config descriptions

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50923 --- Comment #1 from Christopher Schultz ch...@christopherschultz.net 2011-09-20 21:55:50 UTC --- I don't happen to like the tag entry but that's a matter of taste, I suppose. I think that instead of defining entry to emit

DO NOT REPLY [Bug 50923] Difficult to pick out valid values from config descriptions

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50923 --- Comment #2 from Sebb s...@apache.org 2011-09-20 22:36:21 UTC --- Created attachment 27546 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27546 Screenshot -- Configure bugmail:

DO NOT REPLY [Bug 50923] Difficult to pick out valid values from config descriptions

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50923 --- Comment #3 from Sebb s...@apache.org 2011-09-20 22:36:39 UTC --- Created attachment 27547 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27547 Screenshot -- Configure bugmail:

DO NOT REPLY [Bug 50923] Difficult to pick out valid values from config descriptions

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50923 --- Comment #4 from Sebb s...@apache.org 2011-09-20 22:36:59 UTC --- Created attachment 27548 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27548 Screenshot -- Configure bugmail:

DO NOT REPLY [Bug 50923] Difficult to pick out valid values from config descriptions

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50923 --- Comment #5 from Sebb s...@apache.org 2011-09-20 22:37:29 UTC --- Created attachment 27549 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27549 Screenshot Fx zoomed -- Configure bugmail:

DO NOT REPLY [Bug 50923] Difficult to pick out valid values from config descriptions

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50923 --- Comment #6 from Sebb s...@apache.org 2011-09-20 22:43:24 UTC --- Only when I zoom the Firefox display do I start to see a difference with the code sections. I use a 17 screen, 1440x900 pixels, WinXP, in case that's relevant. I don't

DO NOT REPLY [Bug 18500] Host aliases to match by regular expression

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=18500 --- Comment #6 from Konstantin Kolinko knst.koli...@gmail.com 2011-09-21 00:04:47 UTC --- Since last time when I participated in discussion of such a feature [1] my thought is - start processing in the Mapper with the currently

Re: svn commit: r1173082 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProtocol.java test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread Konstantin Kolinko
2011/9/20 Mark Thomas ma...@apache.org: On 20/09/2011 13:41, Konstantin Kolinko wrote: BTW: I am unable to reproduce Gump failure for TestCometProcessor with NIO (running with JDK 6u26/WinXP), but this test fails for me when running it with APR connector. I *think* I have all these issues

svn commit: r1173461 - in /tomcat/trunk/java/org/apache/catalina/ha/session: BackupManager.java ClusterManagerBase.java

2011-09-20 Thread kfujino
Author: kfujino Date: Wed Sep 21 02:07:24 2011 New Revision: 1173461 URL: http://svn.apache.org/viewvc?rev=1173461view=rev Log: followup r1173088 and r1173090. Modified: tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java

[Tomcat Wiki] Trivial Update of GettingStarted by DavidHieber

2011-09-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on Tomcat Wiki for change notification. The GettingStarted page has been changed by DavidHieber: http://wiki.apache.org/tomcat/GettingStarted?action=diffrev1=13rev2=14 Comment: re-wording for clarity. == Getting your first

DO NOT REPLY [Bug 47678] Unable to allocate shared memory when using isapi_redirect.dll as an extension and filter

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47678 Ben benthecomputer...@gmail.com changed: What|Removed |Added CC|

DO NOT REPLY [Bug 50504] Allow setting query string character set trough request attribute

2011-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50504 --- Comment #3 from Attila Király kiralyattila...@gmail.com 2011-09-21 05:17:51 UTC --- A Valve could be a solution too if it comes with Tomcat. It would mean that encoding can be configured per webapp which is what this ticket is about.