Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Martin Grigorov
Hi, Broken - do not release. It seems WebSocket support is broken for Google Chrome 32+. I tested Apache Wicket integration and it failed with: WebSocket connection to 'ws://localhost:8080/ws/wicket/websocket?pageId=0wicket-ajax-baseurl=behavior?0' failed: Invalid UTF-8 sequence in header value

Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Rémy Maucherat
2014-01-28 Mark Thomas ma...@apache.org The proposed Apache Tomcat 8.0.0 release is now available for voting. This is the first non-RC release so I am leaving all the stability options open to get an idea of where folks think we currently stand. The main changes since RC10 are: - Fix

svn commit: r1562411 - in /tomcat/trunk: build.properties.default java/org/apache/tomcat/websocket/server/UpgradeUtil.java webapps/docs/changelog.xml

2014-01-29 Thread markt
Author: markt Date: Wed Jan 29 11:23:42 2014 New Revision: 1562411 URL: http://svn.apache.org/r1562411 Log: Fix bug handling the Sec-WebSocket-Protocol header returned to the client Modified: tomcat/trunk/build.properties.default

svn commit: r1562413 - /tomcat/trunk/webapps/docs/changelog.xml

2014-01-29 Thread markt
Author: markt Date: Wed Jan 29 11:26:48 2014 New Revision: 1562413 URL: http://svn.apache.org/r1562413 Log: Correct tag nesting Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

svn commit: r1562414 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/server/UpgradeUtil.java webapps/docs/changelog.xml

2014-01-29 Thread markt
Author: markt Date: Wed Jan 29 11:28:35 2014 New Revision: 1562414 URL: http://svn.apache.org/r1562414 Log: Fix bug handling the Sec-WebSocket-Protocol header returned to the client Modified: tomcat/tc7.0.x/trunk/ (props changed)

buildbot exception in ASF Buildbot on tomcat-trunk

2014-01-29 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5451 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Re: buildbot exception in ASF Buildbot on tomcat-trunk

2014-01-29 Thread Mark Thomas
On 29/01/2014 11:32, build...@apache.org wrote: The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5451 Buildbot URL: http://ci.apache.org/ Buildslave for this

Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Mark Thomas
On 29/01/2014 10:11, Martin Grigorov wrote: Hi, Broken - do not release. It seems WebSocket support is broken for Google Chrome 32+. I tested Apache Wicket integration and it failed with: WebSocket connection to

Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Martin Grigorov
On Wed, Jan 29, 2014 at 12:37 PM, Mark Thomas ma...@apache.org wrote: On 29/01/2014 10:11, Martin Grigorov wrote: Hi, Broken - do not release. It seems WebSocket support is broken for Google Chrome 32+. I tested Apache Wicket integration and it failed with: WebSocket connection

svn commit: r1562420 - /tomcat/trunk/build.properties.default

2014-01-29 Thread markt
Author: markt Date: Wed Jan 29 11:43:20 2014 New Revision: 1562420 URL: http://svn.apache.org/r1562420 Log: Update snapshot version Modified: tomcat/trunk/build.properties.default Modified: tomcat/trunk/build.properties.default URL:

Request parameters in HandshakeRequest

2014-01-29 Thread Martin Grigorov
Hi, Apologies in advance if this is for users@. Should javax.websocket.server.HandshakeRequest#getParameterMap() contain the parameters from the query string ? There is javax.websocket.server.HandshakeRequest#getQueryString() but I don't see how WebSocket request can be done with POST method so

buildbot failure in ASF Buildbot on tomcat-trunk

2014-01-29 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5452 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1562421 - /tomcat/trunk/build.properties.default

2014-01-29 Thread markt
Author: markt Date: Wed Jan 29 11:51:45 2014 New Revision: 1562421 URL: http://svn.apache.org/r1562421 Log: Revert accidental commit Modified: tomcat/trunk/build.properties.default Modified: tomcat/trunk/build.properties.default URL:

Re: Request parameters in HandshakeRequest

2014-01-29 Thread Mark Thomas
On 29/01/2014 11:44, Martin Grigorov wrote: Hi, Apologies in advance if this is for users@. Should javax.websocket.server.HandshakeRequest#getParameterMap() contain the parameters from the query string ? It should. There is javax.websocket.server.HandshakeRequest#getQueryString() but I

Re: Request parameters in HandshakeRequest

2014-01-29 Thread Martin Grigorov
On Wed, Jan 29, 2014 at 1:06 PM, Mark Thomas ma...@apache.org wrote: On 29/01/2014 11:44, Martin Grigorov wrote: Hi, Apologies in advance if this is for users@. Should javax.websocket.server.HandshakeRequest#getParameterMap() contain the parameters from the query string ? It

Re: [VOTE] Release Apache Tomcat 6.0.39

2014-01-29 Thread Ognjen Blagojevic
On 28.1.2014 0:08, Mark Thomas wrote: The proposed Apache Tomcat 6.0.39 release candidate is now available for voting. ... The proposed 6.0.39 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 6.0.39 Stable Tested .zip distribution on Windows 7 64-bit: - Tested

[Bug 56087] New: antiResourceLocking=false still locks ttf

2014-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56087 Bug ID: 56087 Summary: antiResourceLocking=false still locks ttf Product: Tomcat 7 Version: 7.0.28 Hardware: PC Status: NEW Severity: normal Priority: P2

Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Rainer Jung
I'm seeing consistent unit test failures in TestAsyncContextImpl when using APR: Testcase: testDispatchErrorWithThreadSingleThenComplete took 5.171 sec Testcase: testDispatchErrorSingleThenComplete took 2.226 sec Testcase: testTimeoutListenerCompleteNonAsyncDispatch took 2.257 sec FAILED

[Bug 56088] New: AbstractQueryReport$StatementProxy throws exception on Object methods if statement is closed

2014-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56088 Bug ID: 56088 Summary: AbstractQueryReport$StatementProxy throws exception on Object methods if statement is closed Product: Tomcat Modules Version: unspecified

svn commit: r1562458 - /tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java

2014-01-29 Thread rjung
Author: rjung Date: Wed Jan 29 14:36:48 2014 New Revision: 1562458 URL: http://svn.apache.org/r1562458 Log: More info if test fails in access log valve check. Modified: tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java Modified:

Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Rossen Stoyanchev
I can confirm that the issue with the empty Sec-WebSocket-Protocol header also affects Chrome 31.0.1650.63. The actual issue appears as an Invalid UTF-8 sequence in header value message in the Chrome dev tool. Although I had read what Martin reported for Chrome 32, I couldn't confirm it's the

Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Yoav Shapira
On Wed, Jan 29, 2014 at 9:55 AM, Rossen Stoyanchev rstoyanc...@gopivotal.com wrote: I can confirm that the issue with the empty Sec-WebSocket-Protocol header also affects Chrome 31.0.1650.63. I haven't tested 8.0.0 myself yet, but if it's broken on Chrome 31, that's a far bigger problem than

[Bug 56087] antiResourceLocking=false still locks ttf

2014-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56087 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Brian Clozel
I've reproduced this issue with Chrome 32.0.1700.102 and Chrome canary 34.0.1811.0. Chrome 32 is already mainstream anyway (thanks evergreen browsers): http://clicky.com/marketshare/global/web-browsers/google-chrome/ -- Brian Clozel On Wed, Jan 29, 2014 at 4:38 PM, Yoav Shapira

buildbot success in ASF Buildbot on tomcat-trunk

2014-01-29 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5454 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

svn commit: r1562581 - in /tomcat/trunk: java/org/apache/tomcat/util/net/SocketWrapper.java webapps/docs/changelog.xml

2014-01-29 Thread markt
Author: markt Date: Wed Jan 29 20:37:31 2014 New Revision: 1562581 URL: http://svn.apache.org/r1562581 Log: Fix regression in fix for BZ55996 Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java tomcat/trunk/webapps/docs/changelog.xml Modified:

Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Mark Thomas
On 29/01/2014 14:32, Rainer Jung wrote: I'm seeing consistent unit test failures in TestAsyncContextImpl when using APR: I can reproduce these and have hopefully found a fix. This is a serious enough regression (async timeouts are broken in some cases) to justify dropping 8.0.0 and tagging

[VOTE][CANCELLED] Release Apache Tomcat 8.0.0

2014-01-29 Thread Mark Thomas
Testing has discovered a regression in the asynchronous timeouts. A 8.0.1 tag will follow once I've finished running the unit tests locally to check for further regressions. Mark - To unsubscribe, e-mail:

svn commit: r1562584 - /tomcat/trunk/webapps/docs/changelog.xml

2014-01-29 Thread markt
Author: markt Date: Wed Jan 29 20:40:52 2014 New Revision: 1562584 URL: http://svn.apache.org/r1562584 Log: 8.0.0 will not be released Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

svn commit: r1562585 - in /tomcat/trunk: build.properties.default res/maven/mvn.properties.default

2014-01-29 Thread markt
Author: markt Date: Wed Jan 29 20:41:54 2014 New Revision: 1562585 URL: http://svn.apache.org/r1562585 Log: Prep for next release Modified: tomcat/trunk/build.properties.default tomcat/trunk/res/maven/mvn.properties.default Modified: tomcat/trunk/build.properties.default URL:

Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Konstantin Kolinko
2014-01-29 Mark Thomas ma...@apache.org: The proposed Apache Tomcat 8.0.0 release is now available for voting. (...) It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0/ The Maven staging repo is:

Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Mark Thomas
On 29/01/2014 21:03, Konstantin Kolinko wrote: 2014-01-29 Mark Thomas ma...@apache.org: The proposed Apache Tomcat 8.0.0 release is now available for voting. (...) It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0/ The Maven staging repo is:

svn commit: r1562596 - /tomcat/trunk/test/org/apache/catalina/authenticator/TestSSOnonLoginAndBasicAuthenticator.java

2014-01-29 Thread markt
Author: markt Date: Wed Jan 29 21:17:35 2014 New Revision: 1562596 URL: http://svn.apache.org/r1562596 Log: Saw a failure on Windows. Switch to our standard pattern for waiting that allows the possibility of a long wait but will finish sooner if it can rather than using a fixed wait. Modified:

svn commit: r1562597 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/jasper/ java/org/apache/jasper/compiler/ java/org/apache/jasper/servlet/ webapps/docs/ webapps/docs/config/

2014-01-29 Thread kkolinko
Author: kkolinko Date: Wed Jan 29 21:19:57 2014 New Revision: 1562597 URL: http://svn.apache.org/r1562597 Log: Make the xmlBlockExternal option in Catalina and Jasper to be true by default. Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

svn commit: r1562627 - in /tomcat/tc8.0.x: ./ tags/

2014-01-29 Thread markt
Author: markt Date: Wed Jan 29 23:06:33 2014 New Revision: 1562627 URL: http://svn.apache.org/r1562627 Log: Prep location for 8.0.x tags Added: tomcat/tc8.0.x/ tomcat/tc8.0.x/tags/ - To unsubscribe, e-mail:

svn commit: r1562629 - in /tomcat: tags/TOMCAT_8_0_0/ tags/TOMCAT_8_0_0_RC1/ tags/TOMCAT_8_0_0_RC10/ tags/TOMCAT_8_0_0_RC2/ tags/TOMCAT_8_0_0_RC3/ tags/TOMCAT_8_0_0_RC4/ tags/TOMCAT_8_0_0_RC5/ tags/TO

2014-01-29 Thread markt
Author: markt Date: Wed Jan 29 23:10:09 2014 New Revision: 1562629 URL: http://svn.apache.org/r1562629 Log: Move 8.0.x tags to long term location Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_0/ - copied from r1562627, tomcat/tags/TOMCAT_8_0_0/ tomcat/tc8.0.x/tags/TOMCAT_8_0_0_RC1/ -

svn commit: r1562630 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_1: ./ build.properties.default

2014-01-29 Thread markt
Author: markt Date: Wed Jan 29 23:11:21 2014 New Revision: 1562630 URL: http://svn.apache.org/r1562630 Log: Tag 8.0.1 Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_1/ - copied from r1562626, tomcat/trunk/ Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_1/build.properties.default Modified:

svn commit: r1562633 - in /tomcat/trunk: build.properties.default res/maven/mvn.properties.default

2014-01-29 Thread markt
Author: markt Date: Wed Jan 29 23:20:49 2014 New Revision: 1562633 URL: http://svn.apache.org/r1562633 Log: Prep for next release Modified: tomcat/trunk/build.properties.default tomcat/trunk/res/maven/mvn.properties.default Modified: tomcat/trunk/build.properties.default URL:

[VOTE] Release Apache Tomcat 8.0.1

2014-01-29 Thread Mark Thomas
The proposed Apache Tomcat 8.0.1 release is now available for voting. This should be the first non-RC release so I am leaving all the stability options open to get an idea of where folks think we currently stand. The main changes since RC10 are: - Fix broken sendfile support in NIO - Add a