jndi schema is still used in Tomcat 8

2014-12-02 Thread Violeta Georgieva
Hi, During an investigation of an issue I found that org.apache.jasper.compiler.JspRuntimeContext (rows 513, 517) and org.apache.tomcat.util.scan.StandardJarScanner (row 309) still use jndi schema. Shouldn't it be war schema instead of jndi? Thanks, Violeta

Re: jndi schema is still used in Tomcat 8

2014-12-02 Thread Mark Thomas
On 02/12/2014 08:22, Violeta Georgieva wrote: Hi, During an investigation of an issue I found that org.apache.jasper.compiler.JspRuntimeContext (rows 513, 517) and org.apache.tomcat.util.scan.StandardJarScanner (row 309) still use jndi schema. Shouldn't it be war schema instead of

Re: svn commit: r1642721 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-12-02 Thread Mark Thomas
On 01/12/2014 21:52, Rémy Maucherat wrote: 2014-12-01 22:00 GMT+01:00 Mark Thomas ma...@apache.org: This is an improvement since it is not just the scheme, host and port but it still reflects the connection being made to WebSocket rather than the Origin of the request. I don't see how the

Re: svn commit: r1642721 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-12-02 Thread Rémy Maucherat
2014-12-02 9:46 GMT+01:00 Mark Thomas ma...@apache.org: Assuming that this is coming from testing with the TCK, I'd like to see the results of challenging the affected tests (ideally with the discussion on the EG as a result of that challenge) before making any final decision on what the

Re: svn commit: r1642360 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java LocalStrings.properties TransformationFactory.java WsWebSocketContainer.java server/UpgradeUtil.java server

2014-12-02 Thread Mark Thomas
On 01/12/2014 12:34, Rémy Maucherat wrote: 2014-12-01 11:19 GMT+01:00 Mark Thomas ma...@apache.org: On 28/11/2014 20:33, r...@apache.org wrote: Author: remm Date: Fri Nov 28 20:33:20 2014 New Revision: 1642360 URL: http://svn.apache.org/r1642360 Log: - Use the extensions specified by

[Bug 57287] Sort files listed by DefaultServlet

2014-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57287 --- Comment #6 from Oleg Trokhov otro...@minsk.ximxim.com --- Created attachment 32249 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32249action=edit sorting list I refactor import, so checkstyle task passed. So we leave my

Re: svn commit: r1642721 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-12-02 Thread Mark Thomas
On 02/12/2014 09:01, Rémy Maucherat wrote: 2014-12-02 9:46 GMT+01:00 Mark Thomas ma...@apache.org: Assuming that this is coming from testing with the TCK, I'd like to see the results of challenging the affected tests (ideally with the discussion on the EG as a result of that challenge)

Re: svn commit: r1642721 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-12-02 Thread Rémy Maucherat
2014-12-02 10:12 GMT+01:00 Mark Thomas ma...@apache.org:My opinion is that the default value currently being provided is just plain wrong. The origin is meant to be the script origin generating the WebSocket connection request not the scheme, host and port of the WebSocket connection currently

Re: svn commit: r1642360 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java LocalStrings.properties TransformationFactory.java WsWebSocketContainer.java server/UpgradeUtil.java server

2014-12-02 Thread Rémy Maucherat
2014-12-02 10:04 GMT+01:00 Mark Thomas ma...@apache.org: Possible options: a) Require servers to support a NO-OP extension. Kind of pointless since it would just be there to pass the tests. b) Drop the test. Not ideal. If the API is there it should be tested. c) Add a ignore unknown

[Bug 57215] Regression in Tomcat 7.0.54 after Bug 56501 with urls starting with //

2014-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57215 --- Comment #8 from Konstantin Kolinko knst.koli...@gmail.com --- (In reply to Konstantin Kolinko from comment #5) 5. In CoyoteAdapter.postParseRequest() when decodedURI.getType() is not bytes (e.g. when requestURI is changed by

Re: jndi schema is still used in Tomcat 8

2014-12-02 Thread Violeta Georgieva
2014-12-02 10:44 GMT+02:00 Mark Thomas ma...@apache.org: On 02/12/2014 08:22, Violeta Georgieva wrote: Hi, During an investigation of an issue I found that org.apache.jasper.compiler.JspRuntimeContext (rows 513, 517) and org.apache.tomcat.util.scan.StandardJarScanner (row 309)

Re: svn commit: r1642721 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-12-02 Thread Konstantin Kolinko
2014-12-02 12:12 GMT+03:00 Mark Thomas ma...@apache.org: On 02/12/2014 09:01, Rémy Maucherat wrote: 2014-12-02 9:46 GMT+01:00 Mark Thomas ma...@apache.org: Assuming that this is coming from testing with the TCK, I'd like to see the results of challenging the affected tests (ideally with the

svn commit: r1642845 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-12-02 Thread remm
Author: remm Date: Tue Dec 2 11:56:59 2014 New Revision: 1642845 URL: http://svn.apache.org/r1642845 Log: Remove origin header due to bad feedback. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Modified:

[Bug 56966] AccessLogValve's elapsed time has 15ms precision on Windows

2014-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56966 --- Comment #4 from Tom Fitzhenry t...@tom-fitzhenry.me.uk --- The machine is a virtual machine running on the Windows Azure hypervisor (similar to Hyper-V, supposedly). The guest OS runs Windows Server 2012 R2, and reports its hardware

Re: svn commit: r1642721 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-12-02 Thread Mark Thomas
On 02/12/2014 09:24, Rémy Maucherat wrote: 2014-12-02 10:12 GMT+01:00 Mark Thomas ma...@apache.org:My opinion is that the default value currently being provided is just plain wrong. The origin is meant to be the script origin generating the WebSocket connection request not the scheme, host

Re: svn commit: r1642721 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-12-02 Thread Rémy Maucherat
2014-12-02 15:47 GMT+01:00 Mark Thomas ma...@apache.org: I think there might a solution that works for everybody (thanks Konstantin). What about setting an origin header value of null in the client if none is set by the user? That is consistent with all the specifications and is arguably

[Bug 57252] Custom error page is not used for an error that occurs asynchronously

2014-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57252 Mark Thomas ma...@apache.org changed: What|Removed |Added OS||All --- Comment #1

[Bug 54143] Add display of PermGen memory pool usage to the Status page of the Manager webapp

2014-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54143 --- Comment #2 from Konstantin Kolinko knst.koli...@gmail.com --- Created attachment 32252 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32252action=edit 2014-12-02_tc6_54143_v1.patch Patch for Tomcat 6 Add display of memory

svn commit: r1642898 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-12-02 Thread kkolinko
Author: kkolinko Date: Tue Dec 2 15:18:32 2014 New Revision: 1642898 URL: http://svn.apache.org/r1642898 Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1642962 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2014-12-02 Thread remm
Author: remm Date: Tue Dec 2 17:35:04 2014 New Revision: 1642962 URL: http://svn.apache.org/r1642962 Log: Add failing websockets test. Modified: tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java Modified:

svn commit: r1642974 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2014-12-02 Thread remm
Author: remm Date: Tue Dec 2 18:09:44 2014 New Revision: 1642974 URL: http://svn.apache.org/r1642974 Log: Add another websockets failing test on batch mode. Modified: tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java Modified:

Catching up

2014-12-02 Thread Nick Williams
Guys, For a myriad of personal, professional, and health reasons, I've been out of pocket for many months. I'm finally starting to catch up today on 9200 Tomcat developer and user list messages. It will take me many days. I just wanted to let y'all know that I'm still alive, and head off any

Re: [PROPOSAL] Drop comet support in Tomcat 9 onwards

2014-12-02 Thread Nick Williams
On Jun 19, 2014, at 10:45 AM, Rémy Maucherat wrote: 2014-06-18 23:40 GMT+02:00 Mark Thomas ma...@apache.org: I have been thinking about connector refactoring for Tomcat 9. Currently BIO is planned to be dropped due to the number of features in the servlet spec that rely on non-blocking IO.

svn commit: r1643002 - /tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java

2014-12-02 Thread markt
Author: markt Date: Tue Dec 2 20:16:01 2014 New Revision: 1643002 URL: http://svn.apache.org/r1643002 Log: Fix concurrency issue identified while investigating BZ 57252. Ensure that non-container threads can't change the async state until the container thread has completed post-processing.

svn commit: r1643007 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java

2014-12-02 Thread remm
Author: remm Date: Tue Dec 2 21:15:44 2014 New Revision: 1643007 URL: http://svn.apache.org/r1643007 Log: As an additional cleanup, don't write any empty message when flushing and there's no data to flush. Modified:

svn commit: r1643008 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Util.java pojo/PojoMethodMapping.java

2014-12-02 Thread remm
Author: remm Date: Tue Dec 2 21:16:51 2014 New Revision: 1643008 URL: http://svn.apache.org/r1643008 Log: Websockets annotations can be located on superclasses, and also improve duplicates detection. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/Util.java

[Bug 57274] Annotation scanning can cause classes to skip class transformation

2014-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57274 --- Comment #3 from Nick Williams nicho...@nicholaswilliams.net --- I will think about this some. Off the top of my head, I don't know what the answer is, but it sure would be nice if there were a solution. -- You are receiving this mail

Re: Catching up

2014-12-02 Thread Nick Williams
Huh. Amazing how fast that went. I'm caught up on everything since May 7 (last time I checked my email in this folder). Good job, everyone involved, on releasing 8.0.x stable, beginning 9.0.x, and addressing many bugs. Kudos! Nick On Dec 2, 2014, at 1:20 PM, Nick Williams wrote: Guys, For

[Bug 57274] Annotation scanning can cause classes to skip class transformation

2014-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57274 --- Comment #4 from Phillip pverhey...@broadleafcommerce.com --- The solution that I had was to completely disable the scanning by adding an empty absolute-ordering / tag into my web.xml. This obviously means that there is no way to have

[Bug 57274] Annotation scanning can cause classes to skip class transformation

2014-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57274 --- Comment #5 from Mark Thomas ma...@apache.org --- (In reply to Phillip from comment #4) Mark, what do you mean by delay the transformation until the the class is declared? Does this mean moving the transformation code from

Re: svn commit: r1643008 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Util.java pojo/PojoMethodMapping.java

2014-12-02 Thread Mark Thomas
On 02/12/2014 21:16, r...@apache.org wrote: Author: remm Date: Tue Dec 2 21:16:51 2014 New Revision: 1643008 URL: http://svn.apache.org/r1643008 Log: Websockets annotations can be located on superclasses, and also improve duplicates detection. No they can't. See section 4.8 of the Java

Re: [PROPOSAL] Drop comet support in Tomcat 9 onwards

2014-12-02 Thread Christopher Schultz
Mark, On 6/18/14 5:40 PM, Mark Thomas wrote: I have been thinking about connector refactoring for Tomcat 9. Currently BIO is planned to be dropped due to the number of features in the servlet spec that rely on non-blocking IO. I would like to propose dropping support for Comet in Tomcat 9

Re: [PROPOSAL] Drop comet support in Tomcat 9 onwards

2014-12-02 Thread Mark Thomas
On 02/12/2014 22:17, Christopher Schultz wrote: Mark, On 6/18/14 5:40 PM, Mark Thomas wrote: I have been thinking about connector refactoring for Tomcat 9. Currently BIO is planned to be dropped due to the number of features in the servlet spec that rely on non-blocking IO. I would like

Re: svn commit: r1643008 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Util.java pojo/PojoMethodMapping.java

2014-12-02 Thread Rémy Maucherat
2014-12-02 23:12 GMT+01:00 Mark Thomas ma...@apache.org: On 02/12/2014 21:16, r...@apache.org wrote: Author: remm Date: Tue Dec 2 21:16:51 2014 New Revision: 1643008 URL: http://svn.apache.org/r1643008 Log: Websockets annotations can be located on superclasses, and also improve

[Bug 55837] ServletContext.getRealPath() returns null

2014-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55837 --- Comment #10 from Jo Desmet jo_des...@yahoo.com --- Just tested this in 8.0.3 log.info(Path3: +request.getRealPath(/)); // Works log.info(Path4: +request.getRealPath(\\)); // returns null!! log.info(Path2:

[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2014-12-02 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

2014-12-02 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-validate has an issue affecting its community

[Bug 57238] Updated SSL/TLS information for Tomcat 8/9

2014-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57238 --- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com --- (In reply to Christopher Schultz from comment #1) 0. Author tags have been discouraged, while the older contributors names have been left in for ... nostalgia? One should