Re: svn commit: r1646359 - /tomcat/trunk/java/org/apache/coyote/Response.java

2014-12-18 Thread Mark Thomas
On 18/12/2014 07:31, Konstantin Kolinko wrote: 2014-12-18 1:48 GMT+03:00 ma...@apache.org: Author: markt Date: Wed Dec 17 22:48:48 2014 New Revision: 1646359 URL: http://svn.apache.org/r1646359 Log: Remove code highlighted as unused by UCDetector Modified:

svn commit: r1646420 - /tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java

2014-12-18 Thread violetagg
Author: violetagg Date: Thu Dec 18 09:51:32 2014 New Revision: 1646420 URL: http://svn.apache.org/r1646420 Log: Provide the correct array size when invoking toArray() Modified: tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java Modified:

svn commit: r1646423 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/webresources/StandardRoot.java

2014-12-18 Thread violetagg
Author: violetagg Date: Thu Dec 18 09:56:21 2014 New Revision: 1646423 URL: http://svn.apache.org/r1646423 Log: Merged revision 1646420 from tomcat/trunk: Provide the correct array size when invoking toArray() Modified: tomcat/tc8.0.x/trunk/ (props changed)

[Bug 56021] SSL connector using windows-my keystore

2014-12-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56021 --- Comment #3 from Asanka sam...@gmail.com --- 1. Make sure you have the correct keyAlias, following openssl command should show alias as the common name (CN) - openssl pkcs12 -info -in filename.pfx 2. Certificate needs to be installed to

svn commit: r1646445 - in /tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net: SSLSupport.java jsse/JSSESupport.java

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 12:54:17 2014 New Revision: 1646445 URL: http://svn.apache.org/r1646445 Log: Remove unused method Modified: tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/SSLSupport.java tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/jsse/JSSESupport.java

svn commit: r1646446 - in /tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net: SSLSupport.java jsse/JSSESupport.java

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 12:56:16 2014 New Revision: 1646446 URL: http://svn.apache.org/r1646446 Log: Servlet API requires java.security.cert.X509Certificate[] so be explicit about this in the support class. Modified:

svn commit: r1646448 - in /tomcat/trunk/java/org/apache/tomcat/util/net: SSLSupport.java jsse/JSSESupport.java

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 13:00:04 2014 New Revision: 1646448 URL: http://svn.apache.org/r1646448 Log: Remove unused method Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SSLSupport.java tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESupport.java Modified:

svn commit: r1646449 - in /tomcat/trunk/java/org/apache/tomcat/util/net: SSLSupport.java jsse/JSSESupport.java

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 13:01:41 2014 New Revision: 1646449 URL: http://svn.apache.org/r1646449 Log: Servlet API requires java.security.cert.X509Certificate[] so be explicit about this in the support class. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SSLSupport.java

[Bug 57340] NioConnector caches get corrupted on concurrent comet close

2014-12-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57340 --- Comment #6 from Nikita Zyulyaev zyuly...@devexperts.com --- (In reply to Mark Thomas from comment #5) I have committed a fix for this to trunk (Tomcat 9.0.x). Are you able to check out trunk from svn, build it and comfirm whether or

[Bug 57340] NioConnector caches get corrupted on concurrent comet close

2014-12-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57340 --- Comment #7 from Mark Thomas ma...@apache.org --- Are you able to build 7.0.x from svn and test against that? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 57340] NioConnector caches get corrupted on concurrent comet close

2014-12-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57340 --- Comment #8 from Nikita Zyulyaev zyuly...@devexperts.com --- (In reply to Mark Thomas from comment #7) Are you able to build 7.0.x from svn and test against that? Of course. -- You are receiving this mail because: You are the

[Bug 57340] NioConnector caches get corrupted on concurrent comet close

2014-12-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57340 --- Comment #9 from Mark Thomas ma...@apache.org --- Great - not all users are able/willing to do that. I'll get the back-ports done now. -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1646456 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/coyote/http11/upgrade/ java/org/apache/tomcat/util/net/

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 13:31:16 2014 New Revision: 1646456 URL: http://svn.apache.org/r1646456 Log: Simplify. NioChannel.getAttachment(boolean) was only ever called with a parameter of false. Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1646458 - /tomcat/tc8.0.x/trunk/test/org/apache/catalina/comet/TestCometProcessor.java

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 13:56:19 2014 New Revision: 1646458 URL: http://svn.apache.org/r1646458 Log: Small improvement to the test Modified: tomcat/tc8.0.x/trunk/test/org/apache/catalina/comet/TestCometProcessor.java Modified:

svn commit: r1646460 - /tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 14:05:05 2014 New Revision: 1646460 URL: http://svn.apache.org/r1646460 Log: Use the provided atomic method to replace the attachment and return a reference to the old value. Modified: tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

svn commit: r1646461 - /tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 14:14:50 2014 New Revision: 1646461 URL: http://svn.apache.org/r1646461 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57340 Ensure that Socket and SocketWrapper are only returned to the cache once on socket close (it is possible for multiple threads

svn commit: r1646462 - in /tomcat/tc8.0.x/trunk: ./ webapps/docs/changelog.xml

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 14:16:47 2014 New Revision: 1646462 URL: http://svn.apache.org/r1646462 Log: Update changelog Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc8.0.x/trunk/

svn commit: r1646464 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/comet/TestCometProcessor.java

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 14:21:07 2014 New Revision: 1646464 URL: http://svn.apache.org/r1646464 Log: Small improvement to the test Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/comet/TestCometProcessor.java Propchange:

svn commit: r1646465 - in /tomcat/tc7.0.x/trunk/java/org/apache: coyote/ajp/ coyote/http11/ coyote/http11/upgrade/ tomcat/util/net/

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 14:24:09 2014 New Revision: 1646465 URL: http://svn.apache.org/r1646465 Log: Simplify. NioChannel.getAttachment(boolean) was only ever called with a parameter of false. Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java

svn commit: r1646466 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 14:26:01 2014 New Revision: 1646466 URL: http://svn.apache.org/r1646466 Log: Use the provided atomic method to replace the attachment and return a reference to the old value. Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Re: svn commit: r1643766 - /tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java

2014-12-18 Thread Violeta Georgieva
Hi, 2014-12-10 17:43 GMT+02:00 Christopher Schultz ch...@christopherschultz.net : Violetta, On 12/8/14 4:04 AM, violet...@apache.org wrote: Author: violetagg Date: Mon Dec 8 09:04:56 2014 New Revision: 1643766 URL: http://svn.apache.org/r1643766 Log: Extract several protected

svn commit: r1646468 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 14:31:41 2014 New Revision: 1646468 URL: http://svn.apache.org/r1646468 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57340 Ensure that Socket and SocketWrapper are only returned to the cache once on socket close (it is possible for multiple threads

[Bug 57340] NioConnector caches get corrupted on concurrent comet close

2014-12-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57340 --- Comment #10 from Mark Thomas ma...@apache.org --- Fix applied to 8.0.x for 8.0.16 onwards and to 7.0.x for 7.0.58 onwards. You should be good to build 7.0.x from svn trunk and test now. -- You are receiving this mail because: You are

svn commit: r1646470 - /tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 14:44:28 2014 New Revision: 1646470 URL: http://svn.apache.org/r1646470 Log: Remove unused method spotted by kfujino Modified: tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java Modified:

svn commit: r1646471 - in /tomcat/trunk/java/org/apache/catalina: authenticator/SingleSignOn.java ha/authenticator/ClusterSingleSignOn.java

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 14:59:48 2014 New Revision: 1646471 URL: http://svn.apache.org/r1646471 Log: kfujino review of BZ 57338 fix. Need to replicate updates to SSOEntry Modified: tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java

svn commit: r1646476 - in /tomcat/trunk: java/org/apache/catalina/ha/authenticator/ClusterSingleSignOn.java webapps/docs/config/cluster-valve.xml

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 15:23:45 2014 New Revision: 1646476 URL: http://svn.apache.org/r1646476 Log: kfujino review of BZ 57338 fix. Add configuration options for mapSendOptions and terminateOnStartFailure. Document the configuration options. Modified:

[Bug 57340] NioConnector caches get corrupted on concurrent comet close

2014-12-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57340 --- Comment #11 from Nikita Zyulyaev zyuly...@devexperts.com --- (In reply to Mark Thomas from comment #10) Fix applied to 8.0.x for 8.0.16 onwards and to 7.0.x for 7.0.58 onwards. You should be good to build 7.0.x from svn trunk and

[Bug 57340] NioConnector caches get corrupted on concurrent comet close

2014-12-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57340 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 57367] New: If JAR scan experiences a stack overflow, give the URL from which each class in the loop was loaded in the complaint

2014-12-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57367 Bug ID: 57367 Summary: If JAR scan experiences a stack overflow, give the URL from which each class in the loop was loaded in the complaint Product: Tomcat 7

[Bug 57367] If JAR scan experiences a stack overflow, give the URL from which each class in the loop was loaded in the complaint

2014-12-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57367 Edward Kuns eddie.k...@gmail.com changed: What|Removed |Added OS||All --- Comment

[Bug 57340] NioConnector caches get corrupted on concurrent comet close

2014-12-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57340 --- Comment #13 from Konstantin Kolinko knst.koli...@gmail.com --- (In reply to Nikita Zyulyaev from comment #11) (In reply to Mark Thomas from comment #10) Fix applied to 8.0.x for 8.0.16 onwards and to 7.0.x for 7.0.58 onwards.

[Bug 56438] If jar scan does not find context config or TLD config, log a message

2014-12-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56438 Edward Kuns eddie.k...@gmail.com changed: What|Removed |Added CC|

[Bug 56884] Support for HTTP Method PATCH under the AJP protocol

2014-12-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56884 Jason jasonreic...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: Back-porting BZ57338 SSO + Cluster improvements

2014-12-18 Thread Christopher Schultz
Mark, On 12/16/14 5:52 PM, Mark Thomas wrote: The fix for BZ 57338 (SSO + cluster) ended up making some fairly invasive changes so that the implementation was sensible. I'd like to discuss which - if any - of these changes we'd be happy to back-port to Tomcat 8 and Tomcat 7. I think you

svn commit: r1646559 - /tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java

2014-12-18 Thread markt
Author: markt Date: Thu Dec 18 22:28:26 2014 New Revision: 1646559 URL: http://svn.apache.org/r1646559 Log: Avoid unnecessary object creation Modified: tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java Modified:

[GUMP@vmgump]: Project tomcat-native-make (in module tomcat-native) failed

2014-12-18 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-native-make has an issue affecting its community integration. This

[GUMP@vmgump]: Project tomcat-native-make (in module tomcat-native) failed

2014-12-18 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-native-make has an issue affecting its community integration. This