svn commit: r1701023 - in /tomcat/trunk/java/org/apache/catalina/connector: InputBuffer.java OutputBuffer.java

Author: markt Date: Thu Sep 3 13:45:39 2015 New Revision: 1701023 URL: http://svn.apache.org/r1701023 Log: Refactor. Remove duplicate constants Modified: tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java

svn commit: r1701021 - /tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java

Author: markt Date: Thu Sep 3 13:41:13 2015 New Revision: 1701021 URL: http://svn.apache.org/r1701021 Log: Refactor: reduce visibility Modified: tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java Modified: tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java

svn commit: r1701027 - in /tomcat/trunk/java/org/apache: catalina/connector/CoyoteAdapter.java catalina/connector/OutputBuffer.java catalina/connector/Response.java tomcat/util/buf/C2BConverter.java

Author: markt Date: Thu Sep 3 14:00:09 2015 New Revision: 1701027 URL: http://svn.apache.org/r1701027 Log: Experiment with a static cache of C2BConverter objects rather than a per request cache that gets cleared every time the request switches to async mode. Modified:

buildbot success in ASF Buildbot on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/201 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[Bug 58321] Using non-thread-safe javax.net.ssl.SSLEngine inside org.apache.tomcat.util.net.SecureNio2Channel without synchronization

https://bz.apache.org/bugzilla/show_bug.cgi?id=58321 --- Comment #4 from Mark Thomas --- Given bug 57799 which suggests that there might be a concurrency issue with NIO2 and TLS it might be worth taking a closer look at the stack traces in this report to see if they offer any

svn commit: r1701020 - /tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java

Author: markt Date: Thu Sep 3 13:40:48 2015 New Revision: 1701020 URL: http://svn.apache.org/r1701020 Log: Refactor. Move C2BConverter creation into a dedicated method. Modified: tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java Modified:

[Bug 58321] Using non-thread-safe javax.net.ssl.SSLEngine inside org.apache.tomcat.util.net.SecureNio2Channel without synchronization

https://bz.apache.org/bugzilla/show_bug.cgi?id=58321 --- Comment #3 from Remy Maucherat --- No idea, it sounds too specific to the NIO2 behavior. Sure the completion handler is going to be called directly by the main thread pool, but only once per IO operation, and since a read

Re: svn commit: r1701027 - in /tomcat/trunk/java/org/apache: catalina/connector/CoyoteAdapter.java catalina/connector/OutputBuffer.java catalina/connector/Response.java tomcat/util/buf/C2BConverter.ja

On 03/09/2015 15:00, ma...@apache.org wrote: > Author: markt > Date: Thu Sep 3 14:00:09 2015 > New Revision: 1701027 > > URL: http://svn.apache.org/r1701027 > Log: > Experiment with a static cache of C2BConverter objects rather than a per > request cache that gets cleared every time the request

[Bug 58323] Client passing away causes Log.ERROR messages

https://bz.apache.org/bugzilla/show_bug.cgi?id=58323 benjamin.gehrels_exter...@immobilienscout24.de changed: What|Removed |Added Status|RESOLVED

[Bug 58321] Using non-thread-safe javax.net.ssl.SSLEngine inside org.apache.tomcat.util.net.SecureNio2Channel without synchronization

https://bz.apache.org/bugzilla/show_bug.cgi?id=58321 --- Comment #5 from Remy Maucherat --- Yes, but I don't see how a concurrent read is possible, and this is a "non blocking" read, that other bug is supposed to be using blocking IO. -- You are receiving this mail because:

[Bug 58321] Using non-thread-safe javax.net.ssl.SSLEngine inside org.apache.tomcat.util.net.SecureNio2Channel without synchronization

https://bz.apache.org/bugzilla/show_bug.cgi?id=58321 --- Comment #7 from Yilong Li --- (In reply to Remy Maucherat from comment #3) > No idea, it sounds too specific to the NIO2 behavior. Sure the completion > handler is going to be called directly by the main

[Bug 58323] Client passing away causes Log.ERROR messages

https://bz.apache.org/bugzilla/show_bug.cgi?id=58323 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED

svn commit: r1701095 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/InputBuffer.java

Author: markt Date: Thu Sep 3 18:30:10 2015 New Revision: 1701095 URL: http://svn.apache.org/r1701095 Log: Follow-up to https://bz.apache.org/bugzilla/show_bug.cgi?id=58313 Fix concurrent access of encoders map when clearing encoders prior to switch to async. Modified:

svn commit: r1701113 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

Author: markt Date: Thu Sep 3 19:35:19 2015 New Revision: 1701113 URL: http://svn.apache.org/r1701113 Log: Small simplification Use 'conv == null' to indicate that conv has not been set rather than a separate flag. Modified: tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

svn commit: r1701116 - in /tomcat/trunk: java/org/apache/catalina/connector/CoyoteAdapter.java java/org/apache/catalina/connector/InputBuffer.java java/org/apache/tomcat/util/buf/B2CConverter.java tes

Author: markt Date: Thu Sep 3 19:44:27 2015 New Revision: 1701116 URL: http://svn.apache.org/r1701116 Log: Use Charset rather than encoding name to create B2CConvertor Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

svn commit: r1701094 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/connector/InputBuffer.java

Author: markt Date: Thu Sep 3 18:28:58 2015 New Revision: 1701094 URL: http://svn.apache.org/r1701094 Log: Follow-up to https://bz.apache.org/bugzilla/show_bug.cgi?id=58313 Fix concurrent access of encoders map when clearing encoders prior to switch to async. Modified:

svn commit: r1701093 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

Author: markt Date: Thu Sep 3 18:27:27 2015 New Revision: 1701093 URL: http://svn.apache.org/r1701093 Log: Follow-up to https://bz.apache.org/bugzilla/show_bug.cgi?id=58313 Fix concurrent access of encoders map when clearing encoders prior to switch to async. Modified:

buildbot exception in ASF Buildbot on tomcat-8-trunk

The Buildbot has detected a build exception on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/84 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1701096 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: markt Date: Thu Sep 3 18:31:30 2015 New Revision: 1701096 URL: http://svn.apache.org/r1701096 Log: Add the InputBuffer side of the proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1701114 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

Author: markt Date: Thu Sep 3 19:40:01 2015 New Revision: 1701114 URL: http://svn.apache.org/r1701114 Log: Key encoder cache on Charset rather than encoding name Modified: tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java Modified:

svn commit: r1701117 - /tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java

Author: markt Date: Thu Sep 3 19:48:07 2015 New Revision: 1701117 URL: http://svn.apache.org/r1701117 Log: Better name Modified: tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java Modified: tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java URL:

[Bug 58321] Using non-thread-safe javax.net.ssl.SSLEngine inside org.apache.tomcat.util.net.SecureNio2Channel without synchronization

https://bz.apache.org/bugzilla/show_bug.cgi?id=58321 --- Comment #6 from Yilong Li --- (In reply to Remy Maucherat from comment #3) > No idea, it sounds too specific to the NIO2 behavior. Sure the completion > handler is going to be called directly by the main

svn commit: r1701123 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java

Author: markt Date: Thu Sep 3 20:07:58 2015 New Revision: 1701123 URL: http://svn.apache.org/r1701123 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58320 In async requests multiple threads can access the request attribute map at the same time. Modified:

svn commit: r1701118 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

Author: markt Date: Thu Sep 3 19:48:51 2015 New Revision: 1701118 URL: http://svn.apache.org/r1701118 Log: Refactor. Move B2CConverter creation into a dedicated method. Modified: tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java Modified:

svn commit: r1701119 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

Author: markt Date: Thu Sep 3 19:49:17 2015 New Revision: 1701119 URL: http://svn.apache.org/r1701119 Log: Refactor: reduce visibility Modified: tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java Modified: tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java URL:

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/206 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

buildbot success in ASF Buildbot on tomcat-7-trunk

The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/61 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1701127 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/connector/InputBuffer.java test/org/apache/catalina/valves/TesterAccessLogValve.java

Author: markt Date: Thu Sep 3 20:16:12 2015 New Revision: 1701127 URL: http://svn.apache.org/r1701127 Log: No <> in Java 6 Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/InputBuffer.java tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java

[Bug 58320] Data race inside the non-thread-safe HashMap org.apache.catalina.connector.Request.attributes

https://bz.apache.org/bugzilla/show_bug.cgi?id=58320 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

buildbot success in ASF Buildbot on tomcat-8-trunk

The Buildbot has detected a restored build on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/85 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1701120 - in /tomcat/trunk/java/org/apache: catalina/connector/CoyoteAdapter.java catalina/connector/InputBuffer.java catalina/connector/Request.java tomcat/util/buf/B2CConverter.java

Author: markt Date: Thu Sep 3 19:58:03 2015 New Revision: 1701120 URL: http://svn.apache.org/r1701120 Log: Use a static cache of B2CConverter objects rather than a per request cache that gets cleared every time the request switches to async mode. Modified:

[Bug 57136] EL Parser escaping dollar sign not ${ or ${...}

https://bz.apache.org/bugzilla/show_bug.cgi?id=57136 Mark Thomas changed: What|Removed |Added Status|REOPENED|NEEDINFO --- Comment

[Bug 57136] EL Parser escaping dollar sign not ${ or ${...}

https://bz.apache.org/bugzilla/show_bug.cgi?id=57136 --- Comment #13 from Mark Thomas --- https://java.net/jira/browse/UEL-42 -- You are receiving this mail because: You are the assignee for the bug. - To

Re: svn commit: r1700900 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/util/RequestUtil.java

On 03/09/2015 00:27, Rainer Jung wrote: > Am 02.09.2015 um 23:08 schrieb Konstantin Kolinko: >> 2015-09-03 0:00 GMT+03:00 Mark Thomas : >>> On 02/09/2015 21:46, ma...@apache.org wrote: Author: markt Date: Wed Sep 2 20:46:17 2015 New Revision: 1700900

svn commit: r1700938 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: markt Date: Thu Sep 3 07:08:08 2015 New Revision: 1700938 URL: http://svn.apache.org/r1700938 Log: This was accidentally applied when adding the proposal. kkolinko and rjung voted +1 for this on the dev list Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified:

Re: svn commit: r1700964 - /tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java

On 09/03/2015 11:16 AM, jfcl...@apache.org wrote: Author: jfclere Date: Thu Sep 3 09:16:48 2015 New Revision: 1700964 URL: http://svn.apache.org/r1700964 Log: Remove useless code. Well it reset the pos after the put... I will rollback that might be used somewhere no? Cheers Jean-Frederic

svn commit: r1700964 - /tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java

Author: jfclere Date: Thu Sep 3 09:16:48 2015 New Revision: 1700964 URL: http://svn.apache.org/r1700964 Log: Remove useless code. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java Modified:

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/196 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1700967 - /tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java

Author: jfclere Date: Thu Sep 3 09:35:09 2015 New Revision: 1700967 URL: http://svn.apache.org/r1700967 Log: Rollback http://svn.apache.org/r1700964 (sorry). Modified: tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java Modified:

buildbot success in ASF Buildbot on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/197 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1700977 - /tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java

Author: markt Date: Thu Sep 3 10:21:17 2015 New Revision: 1700977 URL: http://svn.apache.org/r1700977 Log: Testing access log entries may be accessed concurrently so ensure that access is thread safe. Modified: tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java

[Bug 58319] New: Data race inside the non-thread-safe ArrayList org.apache.catalina.valves.TesterAccessLogValve.entries

https://bz.apache.org/bugzilla/show_bug.cgi?id=58319 Bug ID: 58319 Summary: Data race inside the non-thread-safe ArrayList org.apache.catalina.valves.TesterAccessLogValve.entrie s Product: Tomcat 8 Version: trunk

[Bug 58320] New: Data race inside the non-thread-safe HashMap org.apache.catalina.connector.Request.attributes

https://bz.apache.org/bugzilla/show_bug.cgi?id=58320 Bug ID: 58320 Summary: Data race inside the non-thread-safe HashMap org.apache.catalina.connector.Request.attributes Product: Tomcat 8 Version: 8.0.24 Hardware: PC

svn commit: r1700979 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/valves/TesterAccessLogValve.java

Author: markt Date: Thu Sep 3 10:24:14 2015 New Revision: 1700979 URL: http://svn.apache.org/r1700979 Log: Testing access log entries may be accessed concurrently so ensure that access is thread safe. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1700978 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/catalina/valves/TesterAccessLogValve.java

Author: markt Date: Thu Sep 3 10:22:27 2015 New Revision: 1700978 URL: http://svn.apache.org/r1700978 Log: Testing access log entries may be accessed concurrently so ensure that access is thread safe. Modified: tomcat/tc8.0.x/trunk/ (props changed)

[Bug 58319] Data race inside the non-thread-safe ArrayList org.apache.catalina.valves.TesterAccessLogValve.entries

https://bz.apache.org/bugzilla/show_bug.cgi?id=58319 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 58321] New: Using non-thread-safe javax.net.ssl.SSLEngine inside org.apache.tomcat.util.net.SecureNio2Channel without synchronization

https://bz.apache.org/bugzilla/show_bug.cgi?id=58321 Bug ID: 58321 Summary: Using non-thread-safe javax.net.ssl.SSLEngine inside org.apache.tomcat.util.net.SecureNio2Channel without synchronization Product: Tomcat 8

[Bug 58321] Using non-thread-safe javax.net.ssl.SSLEngine inside org.apache.tomcat.util.net.SecureNio2Channel without synchronization

https://bz.apache.org/bugzilla/show_bug.cgi?id=58321 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED

buildbot failure in ASF Buildbot on tomcat-7-trunk

The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/59 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[Bug 58321] Using non-thread-safe javax.net.ssl.SSLEngine inside org.apache.tomcat.util.net.SecureNio2Channel without synchronization

https://bz.apache.org/bugzilla/show_bug.cgi?id=58321 --- Comment #2 from Yilong Li --- (In reply to Remy Maucherat from comment #1) > This looks invalid as the IO operations are protected by pending flags > and/or semaphores. I get it your tool seems to use

svn commit: r1701124 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml

Author: markt Date: Thu Sep 3 20:10:10 2015 New Revision: 1701124 URL: http://svn.apache.org/r1701124 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58320 In async requests multiple threads can access the request attribute map at the same time. Modified: tomcat/tc8.0.x/trunk/

svn commit: r1701125 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml

Author: markt Date: Thu Sep 3 20:15:16 2015 New Revision: 1701125 URL: http://svn.apache.org/r1701125 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58320 In async requests multiple threads can access the request attribute map at the same time. Modified: tomcat/tc7.0.x/trunk/

svn commit: r1701011 - /tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java

Author: remm Date: Thu Sep 3 13:12:31 2015 New Revision: 1701011 URL: http://svn.apache.org/r1701011 Log: Reading the code, don't treat 0 as a problem at this point. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java Modified:

svn commit: r1701016 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

Author: remm Date: Thu Sep 3 13:22:02 2015 New Revision: 1701016 URL: http://svn.apache.org/r1701016 Log: Blocking mode doesn't work for me with APR in some cases if the nonblock option isn't set as well. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified:

buildbot exception in ASF Buildbot on tomcat-trunk

The Buildbot has detected a build exception on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/200 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/199 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[Bug 58323] New: Client passing away causes Log.ERROR messages

https://bz.apache.org/bugzilla/show_bug.cgi?id=58323 Bug ID: 58323 Summary: Client passing away causes Log.ERROR messages Product: Tomcat 8 Version: 8.0.23 Hardware: PC OS: Linux Status: NEW Severity:

[Bug 58323] Client passing away causes Log.ERROR messages

https://bz.apache.org/bugzilla/show_bug.cgi?id=58323 benjamin.gehrels_exter...@immobilienscout24.de changed: What|Removed |Added CC|

[Bug 58323] Client passing away causes Log.ERROR messages

https://bz.apache.org/bugzilla/show_bug.cgi?id=58323 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED