Re: Message files encoding

2018-08-01 Thread Emmanuel Bourg
Le 01/08/2018 à 16:34, Mark Thomas a écrit : > I think there is a little more work to be done. Currently the files are > corrupted when I look at them in an IDE. I've tried playing with > svn:mimetype without much luck. With IntelliJ the encoding is automatically detected as UTF-8, but I had to

buildbot failure in on tomcat-trunk

2018-08-01 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3484 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: Message files encoding

2018-08-01 Thread Mark Thomas
On 01/08/18 15:10, Emmanuel Bourg wrote: > Le 01/08/2018 à 14:12, Mark Thomas a écrit : > >> That solves the complexity problem. It looks like all that would be >> required is a change from copying the file to using native2ascii with >> appropriate src and destinations. >> >> No objections here.

svn commit: r1837237 - /tomcat/trunk/build.xml

2018-08-01 Thread ebourg
Author: ebourg Date: Wed Aug 1 13:38:12 2018 New Revision: 1837237 URL: http://svn.apache.org/viewvc?rev=1837237=rev Log: Convert the message files from UTF-8 to ASCII at build time Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL:

svn commit: r1837238 - /tomcat/trunk/build.xml

2018-08-01 Thread ebourg
Author: ebourg Date: Wed Aug 1 14:01:37 2018 New Revision: 1837238 URL: http://svn.apache.org/viewvc?rev=1837238=rev Log: Also convert the Messages*.properties file to ASCII Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL:

Re: Message files encoding

2018-08-01 Thread Mark Thomas
On 01/08/18 16:03, Emmanuel Bourg wrote: > Le 01/08/2018 à 16:34, Mark Thomas a écrit : > >> I think there is a little more work to be done. Currently the files are >> corrupted when I look at them in an IDE. I've tried playing with >> svn:mimetype without much luck. > > With IntelliJ the

svn commit: r1837246 - /tomcat/trunk/build.xml

2018-08-01 Thread markt
Author: markt Date: Wed Aug 1 15:41:07 2018 New Revision: 1837246 URL: http://svn.apache.org/viewvc?rev=1837246=rev Log: ws police Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1837246=1837245=1837246=diff

buildbot success in on tomcat-trunk

2018-08-01 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3485 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: Message files encoding

2018-08-01 Thread Emmanuel Bourg
Le 01/08/2018 à 14:12, Mark Thomas a écrit : > That solves the complexity problem. It looks like all that would be > required is a change from copying the file to using native2ascii with > appropriate src and destinations. > > No objections here. Ok it's committed (r1837237 and r1837238 for the

svn commit: r1837239 [2/8] - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/connector/ org/apache/catalina/core/ org/apache/

2018-08-01 Thread ebourg
Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings_ja.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/LocalStrings_ja.properties?rev=1837239=1837238=1837239=diff ==

svn commit: r1837239 [1/8] - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/connector/ org/apache/catalina/core/ org/apache/

2018-08-01 Thread ebourg
Author: ebourg Date: Wed Aug 1 14:04:20 2018 New Revision: 1837239 URL: http://svn.apache.org/viewvc?rev=1837239=rev Log: Converted the message files to UTF-8 Modified: tomcat/trunk/java/javax/el/LocalStrings_es.properties tomcat/trunk/java/javax/servlet/LocalStrings_es.properties

svn commit: r1837239 [5/8] - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/connector/ org/apache/catalina/core/ org/apache/

2018-08-01 Thread ebourg
Modified: tomcat/trunk/java/org/apache/catalina/session/LocalStrings_ja.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/LocalStrings_ja.properties?rev=1837239=1837238=1837239=diff

svn commit: r1837239 [3/8] - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/connector/ org/apache/catalina/core/ org/apache/

2018-08-01 Thread ebourg
Modified: tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_ja.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/LocalStrings_ja.properties?rev=1837239=1837238=1837239=diff

svn commit: r1837239 [6/8] - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/connector/ org/apache/catalina/core/ org/apache/

2018-08-01 Thread ebourg
Modified: tomcat/trunk/java/org/apache/el/Messages_es.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/Messages_es.properties?rev=1837239=1837238=1837239=diff == ---

svn commit: r1837239 [7/8] - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/connector/ org/apache/catalina/core/ org/apache/

2018-08-01 Thread ebourg
Modified: tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_ja.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_ja.properties?rev=1837239=1837238=1837239=diff

svn commit: r1837239 [8/8] - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/connector/ org/apache/catalina/core/ org/apache/

2018-08-01 Thread ebourg
Modified: tomcat/trunk/java/org/apache/naming/LocalStrings_es.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/LocalStrings_es.properties?rev=1837239=1837238=1837239=diff == ---

svn commit: r1837239 [4/8] - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/connector/ org/apache/catalina/core/ org/apache/

2018-08-01 Thread ebourg
Modified: tomcat/trunk/java/org/apache/catalina/manager/host/LocalStrings_ru.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/host/LocalStrings_ru.properties?rev=1837239=1837238=1837239=diff

svn commit: r1837214 - in /tomcat/trunk/java/org/apache/catalina/tribes/membership: LocalStrings.properties StaticMembershipProvider.java

2018-08-01 Thread kfujino
Author: kfujino Date: Wed Aug 1 07:16:05 2018 New Revision: 1837214 URL: http://svn.apache.org/viewvc?rev=1837214=rev Log: -Implement MemberMessage.toString. -Add log messagess. Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties

Re: svn commit: r1837219 - /tomcat/trunk/java/org/apache/naming/LocalStrings.properties

2018-08-01 Thread Mark Thomas
On 01/08/2018 10:40, ebo...@apache.org wrote: Author: ebourg Date: Wed Aug 1 09:40:15 2018 New Revision: 1837219 URL: http://svn.apache.org/viewvc?rev=1837219=rev Log: Fixed an improperly doubled quote in the English messages For the benefit of the archives this change is correct but we do

svn commit: r1837218 - /tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_fr.properties

2018-08-01 Thread ebourg
Author: ebourg Date: Wed Aug 1 09:26:04 2018 New Revision: 1837218 URL: http://svn.apache.org/viewvc?rev=1837218=rev Log: Fixed an error in the French translation of the jasper messages: 'library' stands for 'bibliothèque' and not 'librairie' Modified:

Re: JDK 11 Early Access build 22 & JDK 12 Early Access b02 are available.

2018-08-01 Thread Mark Thomas
Rory, I can confirm that there is a JDK bug here. The short version is that server initiated renegotiation of a TLSv1.2 connection fails if the Java client is configured to allow TLSv1.3 Details available under internal review ID : 9056398 As always, I'm happy to provide further details if

svn commit: r1837224 - /tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties

2018-08-01 Thread markt
Author: markt Date: Wed Aug 1 10:39:29 2018 New Revision: 1837224 URL: http://svn.apache.org/viewvc?rev=1837224=rev Log: Follow-up to r1837221 { -> ] Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties Modified:

buildbot failure in on tomcat-trunk

2018-08-01 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3479 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Message files encoding

2018-08-01 Thread Emmanuel Bourg
Hi all, The LocalString*.properties files are ASCII encoded which renders the modification of the non-english messages rather inconvenient. Contributors either need a specialized resource editor or go through a native2ascii roundtrip. How do feel about converting the message files to UTF-8 to

Re: Message files encoding

2018-08-01 Thread Mark Thomas
On 01/08/18 12:03, Emmanuel Bourg wrote: > Hi all, > > The LocalString*.properties files are ASCII encoded which renders the > modification of the non-english messages rather inconvenient. > Contributors either need a specialized resource editor or go through a > native2ascii roundtrip. > > How

svn commit: r1837219 - /tomcat/trunk/java/org/apache/naming/LocalStrings.properties

2018-08-01 Thread ebourg
Author: ebourg Date: Wed Aug 1 09:40:15 2018 New Revision: 1837219 URL: http://svn.apache.org/viewvc?rev=1837219=rev Log: Fixed an improperly doubled quote in the English messages Modified: tomcat/trunk/java/org/apache/naming/LocalStrings.properties Modified:

Re: JDK 11 Early Access build 22 & JDK 12 Early Access b02 are available.

2018-08-01 Thread Rory O'Donnell
Thanks Mark, I'll follow up and advise when it's moved into JBS Rgds,Rory On 01/08/2018 10:41, Mark Thomas wrote: Rory, I can confirm that there is a JDK bug here. The short version is that server initiated renegotiation of a TLSv1.2 connection fails if the Java client is configured to

svn commit: r1837221 - /tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties

2018-08-01 Thread ebourg
Author: ebourg Date: Wed Aug 1 10:19:53 2018 New Revision: 1837221 URL: http://svn.apache.org/viewvc?rev=1837221=rev Log: Fixed a broken parameter in the Spanish messages Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties Modified:

svn commit: r1837222 - in /tomcat/trunk: java/javax/servlet/http/ java/org/apache/catalina/authenticator/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/ma

2018-08-01 Thread ebourg
Author: ebourg Date: Wed Aug 1 10:24:31 2018 New Revision: 1837222 URL: http://svn.apache.org/viewvc?rev=1837222=rev Log: Fixed the improperly doubled quotes in the French messages (single quotes should only be doubled when the messages have parameters) Modified:

svn commit: r1837223 - /tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_ja.properties

2018-08-01 Thread ebourg
Author: ebourg Date: Wed Aug 1 10:39:05 2018 New Revision: 1837223 URL: http://svn.apache.org/viewvc?rev=1837223=rev Log: Fixed the missing double quotes in the Japanese messages Modified: tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_ja.properties Modified:

Re: svn commit: r1837219 - /tomcat/trunk/java/org/apache/naming/LocalStrings.properties

2018-08-01 Thread Emmanuel Bourg
Le 01/08/2018 à 12:36, Mark Thomas a écrit : > For the benefit of the archives this change is correct but we do need to > be careful. > > Any string that includes substitutions (i.e. {0}, {1}, etc.) requires > that any ' characters are escaped as '' due to how MessageFormat.format > behaves.

Re: svn commit: r1837219 - /tomcat/trunk/java/org/apache/naming/LocalStrings.properties

2018-08-01 Thread Konstantin Kolinko
2018-08-01 12:40 GMT+03:00 : > Author: ebourg > Date: Wed Aug 1 09:40:15 2018 > New Revision: 1837219 > > URL: http://svn.apache.org/viewvc?rev=1837219=rev > Log: > Fixed an improperly doubled quote in the English messages > > Modified: >

buildbot success in on tomcat-trunk

2018-08-01 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3480 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: Message files encoding

2018-08-01 Thread Emmanuel Bourg
Le 01/08/2018 à 13:08, Mark Thomas a écrit : > I like the idea but that will make building with later versions of Java > problematic - or at least more complex - since native2ascii has been > removed in Java 9 onwards. Good point, I wasn't aware of native2ascii removal. I checked the Ant code

svn commit: r1837227 - in /tomcat/trunk/java/org/apache: catalina/ha/deploy/ catalina/ha/session/ catalina/tribes/group/ catalina/tribes/io/ jasper/resources/ naming/

2018-08-01 Thread ebourg
Author: ebourg Date: Wed Aug 1 12:13:38 2018 New Revision: 1837227 URL: http://svn.apache.org/viewvc?rev=1837227=rev Log: Replaced "Can't" with "Cannot" in the English message files Modified: tomcat/trunk/java/org/apache/catalina/ha/deploy/LocalStrings.properties

Re: Message files encoding

2018-08-01 Thread Emmanuel Bourg
Le 01/08/2018 à 14:08, Martin Grigorov a écrit : > I hope the following changes your mind: > > 1) Bulgarian translations in XML format: > https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Application_bg.properties.xml > 2) Czech translation in ascii format:

Re: Message files encoding

2018-08-01 Thread Martin Grigorov
Hi, On Wed, Aug 1, 2018 at 2:08 PM Mark Thomas wrote: > On 01/08/18 12:03, Emmanuel Bourg wrote: > > Hi all, > > > > The LocalString*.properties files are ASCII encoded which renders the > > modification of the non-english messages rather inconvenient. > > Contributors either need a specialized

Re: Message files encoding

2018-08-01 Thread Emmanuel Bourg
Le 01/08/2018 à 13:16, Martin Grigorov a écrit : > What about using the XML version of Java Properties ? > https://docs.oracle.com/javase/7/docs/api/java/util/Properties.html#loadFromXML(java.io.InputStream) > This way the encoding could be specified in the XML file itself and there > is no need

Re: Message files encoding

2018-08-01 Thread Martin Grigorov
On Wed, Aug 1, 2018 at 2:56 PM Emmanuel Bourg wrote: > Le 01/08/2018 à 13:16, Martin Grigorov a écrit : > > > What about using the XML version of Java Properties ? > > > https://docs.oracle.com/javase/7/docs/api/java/util/Properties.html#loadFromXML(java.io.InputStream) > > This way the encoding

Re: Message files encoding

2018-08-01 Thread Mark Thomas
On 01/08/18 12:47, Emmanuel Bourg wrote: > Le 01/08/2018 à 13:08, Mark Thomas a écrit : > >> I like the idea but that will make building with later versions of Java >> problematic - or at least more complex - since native2ascii has been >> removed in Java 9 onwards. > > Good point, I wasn't

Re: svn commit: r1837219 - /tomcat/trunk/java/org/apache/naming/LocalStrings.properties

2018-08-01 Thread Emmanuel Bourg
Le 01/08/2018 à 13:17, Konstantin Kolinko a écrit : > Proper written spelling is "Cannot". ("Can't" is for spoken > language.) So that you can remove the apostrophe altogether. Thank you for the suggestion, I replaced a handful of occurrences. Emmanuel Bourg

svn commit: r1837243 - in /tomcat/trunk/java/org/apache: catalina/authenticator/ catalina/core/ catalina/loader/ catalina/manager/ catalina/mbeans/ catalina/realm/ catalina/users/ catalina/util/ catal

2018-08-01 Thread ebourg
Author: ebourg Date: Wed Aug 1 14:52:10 2018 New Revision: 1837243 URL: http://svn.apache.org/viewvc?rev=1837243=rev Log: Fixed several mistakes and inconsistencies in the French messages Modified: tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings_fr.properties

svn commit: r1837244 - /tomcat/trunk/java/org/apache/catalina/manager/host/LocalStrings_ru.properties

2018-08-01 Thread markt
Author: markt Date: Wed Aug 1 15:01:21 2018 New Revision: 1837244 URL: http://svn.apache.org/viewvc?rev=1837244=rev Log: Fix trailing whitespace Modified: tomcat/trunk/java/org/apache/catalina/manager/host/LocalStrings_ru.properties Modified:

svn commit: r1837245 - in /tomcat/trunk: java/javax/el/ java/javax/servlet/ java/javax/servlet/http/ java/org/apache/catalina/authenticator/ java/org/apache/catalina/authenticator/jaspic/ java/org/apa

2018-08-01 Thread markt
Author: markt Date: Wed Aug 1 15:19:21 2018 New Revision: 1837245 URL: http://svn.apache.org/viewvc?rev=1837245=rev Log: Set svn:mime-type for UTF-8 propert files so they display correctly in web UI Modified: tomcat/trunk/java/javax/el/LocalStrings.properties (props changed)

[GUMP@vmgump-vm3]: Project tomcat-trunk-validate-eoln (in module tomcat-trunk) failed

2018-08-01 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate-eoln has an issue affecting its community

svn commit: r1837259 - in /tomcat/tc8.5.x/trunk: java/org/apache/coyote/http2/Http2Protocol.java java/org/apache/coyote/http2/Http2UpgradeHandler.java test/org/apache/coyote/http2/TestAbstractStream.j

2018-08-01 Thread markt
Author: markt Date: Wed Aug 1 20:27:24 2018 New Revision: 1837259 URL: http://svn.apache.org/viewvc?rev=1837259=rev Log: Fix error in back-port of HTTP/2 compression Modified: tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/Http2Protocol.java

Re: Message files encoding

2018-08-01 Thread Christopher Schultz
Mark, On 8/1/18 11:21 AM, Mark Thomas wrote: > On 01/08/18 16:03, Emmanuel Bourg wrote: >> Le 01/08/2018 à 16:34, Mark Thomas a écrit : >> >>> I think there is a little more work to be done. Currently the files are >>> corrupted when I look at them in an IDE. I've tried playing with >>>

[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

2018-08-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60594 --- Comment #33 from Mark Thomas --- The point regarding log files is a valid one but if the parsing of the request target fails, the access log will contain null rather than the request target. Generally, we do allow potentially security

[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

2018-08-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60594 --- Comment #34 from Mark Thomas --- Ah. No need. Enable debug logging for org.apache.coyote.http11.Http11InputBuffer and it will log the entire request headers. -- You are receiving this mail because: You are the assignee for the bug.