Re: [PROPOSAL] Copy DBCP 1.x (and POOL 1.x) source to 7.0.x

2019-02-13 Thread Mark Thomas
On 12/02/2019 23:10, Christopher Schultz wrote: > Mark, > > On 2/12/19 08:55, Mark Thomas wrote: >> Hi, > >> Tomcat 7 depends on DBCP 1.x and POOL 1.x. The last release of each >> of these was in 2013. There are a number of fixes I would like to >> be able to pull into Tomcat 7 - including the

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-02-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 --- Comment #26 from Mark Thomas --- Got it. With the single & the pid of the process that is put in the background is not the pid of the Tomcat process. If I specify $CATALINA_PID and then configure systemd to use the same file with PIDFILE

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-02-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 --- Comment #24 from Mark Thomas --- (In reply to Rainer Jung from comment #22) > Do we actually understand, what would be wrong with the line > > 2\>\&1 \& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command "&" > > (single

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-02-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 --- Comment #25 from Mark Thomas --- (In reply to Mark Thomas from comment #24) > bash: syntax error near unexpected token `}' I think this is just incorrect escaping of the command and could be a red herring. -- You are receiving this mail

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-02-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 --- Comment #27 from Rainer Jung --- Excellent analysis! I *think* the "&" at the end of the line is only useful, if a pipe command is actually being used. So one could put it into the construction of the string variable to which we pipe,

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-02-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 --- Comment #28 from Konstantin Kolinko --- (In reply to Rainer Jung from comment #27) > Excellent analysis! > > I *think* the "&" at the end of the line is only useful, if a pipe command > is actually being used. So one could put it into the

svn commit: r1853510 - in /tomcat/tc7.0.x/trunk: ./ bin/catalina.sh webapps/docs/changelog.xml

2019-02-13 Thread markt
Author: markt Date: Wed Feb 13 14:05:45 2019 New Revision: 1853510 URL: http://svn.apache.org/viewvc?rev=1853510=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 Revert the changes for BZ 53930 that added support for the CATALINA_OUT_CMD environment variable as they prevented

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-02-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

2019-02-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=53930 Mark Thomas changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-02-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 --- Comment #31 from Christopher Schultz --- (In reply to Mark Thomas from comment #26) (for the record) > Assuming the above is correct I think we have two options: > > 1. Revert the "&" -> "&&" change. systemd users (and possibly others)

Confirming that UTF-7 is not a typo in Tomcat docs

2019-02-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I just wanted to confirm that UTF-7 is not a typo on this page: http://tomcat.apache.org/tomcat-9.0-doc/security-howto.html#System_Prope rties Under the system property ENFORCE_ENCODING_IN_GET_WRITER. I'm almost certain that it's *not* a

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-02-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 --- Comment #29 from Mark Thomas --- (In reply to Konstantin Kolinko from comment #28) > My preference is to revert and to start planning a new patch from there. +1 We can re-open bug 53930 and discuss options there. Calling touch on a

svn commit: r1853509 - in /tomcat/tc8.5.x/trunk: ./ bin/catalina.sh webapps/docs/changelog.xml

2019-02-13 Thread markt
Author: markt Date: Wed Feb 13 14:04:15 2019 New Revision: 1853509 URL: http://svn.apache.org/viewvc?rev=1853509=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 Revert the changes for BZ 53930 that added support for the CATALINA_OUT_CMD environment variable as they prevented

Re: [Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-02-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 2/13/19 06:46, bugzi...@apache.org wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 > > --- Comment #26 from Mark Thomas --- Got it. > > With the single & the pid of the process that is put in the > background is not the

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

2019-02-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=53930 --- Comment #6 from Konstantin Kolinko --- Note that a regression from this patch is being discussed in bug 63041. -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1853508 - in /tomcat/trunk: bin/catalina.sh webapps/docs/changelog.xml

2019-02-13 Thread markt
Author: markt Date: Wed Feb 13 14:01:49 2019 New Revision: 1853508 URL: http://svn.apache.org/viewvc?rev=1853508=rev Log: (empty) Modified: tomcat/trunk/bin/catalina.sh tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/bin/catalina.sh URL:

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

2019-02-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=53930 --- Comment #8 from Mark Thomas --- The proposed patch causes problems for systemd users (and possibly others) that do not explicitly use CATALINA_PID to determine the PID of the started Tomcat process. Options: 1. Apply this patch as

svn commit: r1853553 - in /tomcat/tc8.5.x/trunk/java/org/apache/catalina/manager: LocalStrings_ru.properties host/LocalStrings_ru.properties

2019-02-13 Thread kkolinko
Author: kkolinko Date: Thu Feb 14 04:41:27 2019 New Revision: 1853553 URL: http://svn.apache.org/viewvc?rev=1853553=rev Log: Improve Russian translations provided for Manager and Host Manager web applications. Modified:

svn commit: r1853551 - in /tomcat/trunk: java/org/apache/catalina/manager/StatusTransformer.java webapps/docs/changelog.xml

2019-02-13 Thread kkolinko
Author: kkolinko Date: Thu Feb 14 04:14:37 2019 New Revision: 1853551 URL: http://svn.apache.org/viewvc?rev=1853551=rev Log: Improve display of summary values on the status page of Manager web application: separate terms and values with a whitespace. Modified:

svn commit: r1853550 - in /tomcat/trunk: java/org/apache/catalina/manager/LocalStrings_ru.properties java/org/apache/catalina/manager/host/LocalStrings_ru.properties webapps/docs/changelog.xml

2019-02-13 Thread kkolinko
Author: kkolinko Date: Thu Feb 14 04:13:12 2019 New Revision: 1853550 URL: http://svn.apache.org/viewvc?rev=1853550=rev Log: Improve Russian translations provided for Manager and Host Manager web applications. Modified:

svn commit: r1853557 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/manager/StatusTransformer.java webapps/docs/changelog.xml

2019-02-13 Thread kkolinko
Author: kkolinko Date: Thu Feb 14 05:08:58 2019 New Revision: 1853557 URL: http://svn.apache.org/viewvc?rev=1853557=rev Log: Improve display of summary values on the status page of Manager web application: separate terms and values with a whitespace. Modified:

svn propchange: r1853508 - svn:log

2019-02-13 Thread kkolinko
Author: kkolinko Revision: 1853508 Modified property: svn:log Modified: svn:log at Thu Feb 14 04:29:37 2019 -- --- svn:log (original) +++ svn:log Thu Feb 14 04:29:37 2019 @@ -0,0 +1,2 @@ +Fix

svn commit: r1853555 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/manager/StatusTransformer.java webapps/docs/changelog.xml

2019-02-13 Thread kkolinko
Author: kkolinko Date: Thu Feb 14 04:50:56 2019 New Revision: 1853555 URL: http://svn.apache.org/viewvc?rev=1853555=rev Log: Improve display of summary values on the status page of Manager web application: separate terms and values with a whitespace. Merged r1853551 from tomcat/trunk.

svn commit: r1853554 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/LocalStrings_ru.properties java/org/apache/catalina/manager/host/LocalStrings_ru.properties

2019-02-13 Thread kkolinko
Author: kkolinko Date: Thu Feb 14 04:44:31 2019 New Revision: 1853554 URL: http://svn.apache.org/viewvc?rev=1853554=rev Log: Improve Russian translations provided for Manager and Host Manager web applications. Merged r1853553 from tomcat/tc8.5.x/trunk. Modified: tomcat/tc7.0.x/trunk/

Tag 9.0.x / 8.5.x

2019-02-13 Thread Mark Thomas
All, Thoughts on new 9.0.x and 8.5.x releases due to the regression caused by BZ 63041? I'm happy to RM these if the community wants to see them. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

Re: Confirming that UTF-7 is not a typo in Tomcat docs

2019-02-13 Thread Konstantin Kolinko
ср, 13 февр. 2019 г. в 17:57, Christopher Schultz : > > I just wanted to confirm that UTF-7 is not a typo on this page: > > http://tomcat.apache.org/tomcat-9.0-doc/security-howto.html#System_Prope > rties > > Under the system property ENFORCE_ENCODING_IN_GET_WRITER. > > I'm almost certain that

Re: Confirming that UTF-7 is not a typo in Tomcat docs

2019-02-13 Thread Mark Thomas
On 13/02/2019 14:57, Christopher Schultz wrote: > All, > > I just wanted to confirm that UTF-7 is not a typo on this page: > > http://tomcat.apache.org/tomcat-9.0-doc/security-howto.html#System_Prope > rties > > Under the system property ENFORCE_ENCODING_IN_GET_WRITER. > > I'm almost certain