svn commit: r1854326 - in /tomcat/trunk: java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/net/openssl/ test/org/apache/tomcat/util/net/ webapps/docs/

2019-02-25 Thread markt
Author: markt Date: Mon Feb 25 17:38:35 2019 New Revision: 1854326 URL: http://svn.apache.org/viewvc?rev=1854326=rev Log: Refactor to a) reduce duplication and b) enable JSSE style config to be used with APR Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java

svn commit: r1854328 - in /tomcat/trunk/test/org/apache/tomcat/util/net: TesterSupport.java keystore-info.txt localhost-copy1.jks localhost-rsa-copy1.jks localhost-rsa.jks localhost.jks

2019-02-25 Thread markt
Author: markt Date: Mon Feb 25 17:59:13 2019 New Revision: 1854328 URL: http://svn.apache.org/viewvc?rev=1854328=rev Log: Rename keystore files in preparation for adding an EC keystore Added: tomcat/trunk/test/org/apache/tomcat/util/net/localhost-rsa-copy1.jks - copied unchanged from

[Bug 63206] Try to create parent directories before writing an uploaded file to disk

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63206 --- Comment #8 from Mark Thomas --- There may be circumstances (e.g. when running under a security manager or due to file system permissions) where it will not be possible to create the directory even if the container tries to do so. This

svn commit: r1854327 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/net/openssl/ test/org/apache/tomcat/util/net/ webapps/docs/

2019-02-25 Thread markt
Author: markt Date: Mon Feb 25 17:49:28 2019 New Revision: 1854327 URL: http://svn.apache.org/viewvc?rev=1854327=rev Log: Refactor to a) reduce duplication and b) enable JSSE style config to be used with APR Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1854339 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/util/net/

2019-02-25 Thread markt
Author: markt Date: Mon Feb 25 21:00:44 2019 New Revision: 1854339 URL: http://svn.apache.org/viewvc?rev=1854339=rev Log: Rename keystore files in preparation for adding an EC keystore Added: tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/localhost-rsa-copy1.jks - copied

Re: [VOTE] Migrate to git

2019-02-25 Thread David Blevins
Vote is closed I'm just a lurker, but non-binding +1 from me :) Great to see this! -David > On Feb 21, 2019, at 8:13 AM, Mark Thomas wrote: > > This is a VOTE to migrate the primary source code repository for Apache > Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git. > > The migration will be

[GUMP@vmgump-vm3]: Project taglibs-parent (in module tomcat-taglibs) failed

2019-02-25 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project taglibs-parent has an issue affecting its community integration. This

[Bug 63210] Tomcat failing to shutdown if EvictionTimer thread is running

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63210 --- Comment #1 from k...@gameldar.com --- Created attachment 36464 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36464=edit stacktrace showing servlet initialization in 9.0.16 -- You are receiving this mail because: You are the

[Bug 63210] Tomcat failing to shutdown if EvictionTimer thread is running

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63210 --- Comment #2 from k...@gameldar.com --- Created attachment 36465 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36465=edit Thread dump after Tomcat fails to stop -- You are receiving this mail because: You are the assignee for the

[Bug 63210] Tomcat failing to shutdown if EvictionTimer thread is running

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63210 --- Comment #4 from k...@gameldar.com --- Created attachment 36467 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36467=edit Example war for the replication case -- You are receiving this mail because: You are the assignee for the

[Bug 63210] Tomcat failing to shutdown if EvictionTimer thread is running

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63210 --- Comment #5 from k...@gameldar.com --- Created attachment 36468 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36468=edit context configuration file for replication case -- You are receiving this mail because: You are the assignee

[Bug 63210] Tomcat failing to shutdown if EvictionTimer thread is running

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63210 --- Comment #3 from k...@gameldar.com --- Created attachment 36466 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36466=edit Example servlet source to replicate the issue -- You are receiving this mail because: You are the assignee

[Bug 63210] Tomcat failing to shutdown if EvictionTimer thread is running

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63210 --- Comment #6 from k...@gameldar.com --- Created attachment 36469 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36469=edit Patch that fixes this specific case with the EvictionTimer thread -- You are receiving this mail because: You

[Bug 63210] New: Tomcat failing to shutdown if EvictionTimer thread is running

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63210 Bug ID: 63210 Summary: Tomcat failing to shutdown if EvictionTimer thread is running Product: Tomcat 9 Version: 9.0.x Hardware: PC OS: Mac OS X 10.1

[Bug 63206] New: Try to create parent directories before writing an uploaded file to disk

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63206 Bug ID: 63206 Summary: Try to create parent directories before writing an uploaded file to disk Product: Tomcat 8 Version: 8.5.38 Hardware: PC OS: All

[Bug 63205] Unable to load certificate store on openjdk

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63205 --- Comment #1 from Christopher Schultz --- While we generally don't work-around JVM bugs, this one was reported back in 2016 and doesn't look like there is much likleihood that it will be fixed. -- You are receiving this mail because: You

Re: Git migration: new branch/tag naming scheme

2019-02-25 Thread Konstantin Kolinko
пн, 18 февр. 2019 г. в 11:08, Emmanuel Bourg > > Le 16/02/2019 à 16:09, Michael Osipov a écrit : > > > The given approach, for whatsoever reason, performs an uppercase and > > replaces dots with underscores. This reduces readability, but also > > requires people (esp. package maintainers) to

DEBUG binaries for win32/win64

2019-02-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, At the risk of making the build for Windows even more onerous, would it be possible to distribute DEBUG builds along with the standard ones? The native stack trace in this bug report[1] for example is non-existent and useless because it just

[Bug 63206] Try to create parent directories before writing an uploaded file to disk

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63206 --- Comment #2 from Remy Maucherat --- (In reply to Christopher Schultz from comment #1) > I'm a -1 on this unless it is a configurable option and disabled by default. > Tomcat shouldn't be creating directories unless explicitly directed to do

Re: DEBUG binaries for win32/win64

2019-02-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 2/25/19 09:42, Mark Thomas wrote: > On 25/02/2019 14:17, Christopher Schultz wrote: >> All, >> >> At the risk of making the build for Windows even more onerous, >> would it be possible to distribute DEBUG builds along with the >> standard

[Bug 63206] Try to create parent directories before writing an uploaded file to disk

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63206 --- Comment #3 from Andy Wilkinson --- > Tomcat shouldn't be creating directories unless explicitly directed to do so. That seems a little arbitrary to apply that rule in this case. Tomcat already creates directories in several places. A few

Re: [VOTE] Migrate to git

2019-02-25 Thread Huxing Zhang
Hi, > > > > This is a VOTE to migrate the primary source code repository for Apache > > Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git. > > [X] +1 Go ahead with the migration Thanks for the work! -- Best Regards! Huxing - To

[Bug 63206] Try to create parent directories before writing an uploaded file to disk

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63206 --- Comment #1 from Christopher Schultz --- I'm a -1 on this unless it is a configurable option and disabled by default. Tomcat shouldn't be creating directories unless explicitly directed to do so. -- You are receiving this mail because:

Re: DEBUG binaries for win32/win64

2019-02-25 Thread Mark Thomas
On 25/02/2019 14:17, Christopher Schultz wrote: > All, > > At the risk of making the build for Windows even more onerous, would > it be possible to distribute DEBUG builds along with the standard ones? > > The native stack trace in this bug report[1] for example is > non-existent and useless

Re: [RESULT][VOTE] Migrate to git

2019-02-25 Thread Mark Thomas
The following votes were cast: Binding: +1: funkman, csutherl, fschumacher, mgrigorov, remm, ebourg, violetagg, mturk, kfugino, markt Non-Binding: +1: woonsan, michaelo, isapir The vote therefore passes. A big thank you to everyone who contributed to the discussions we have had on this

No commits to svn trunk, 8.5.x and 7.0.x after 2019-02-26 07.00 UTC

2019-02-25 Thread Mark Thomas
All, I have informed ASF Infrastructure that they can disable the svn -> git replication any time after 07.00 UTC tomorrow. Please, to keep the migration simple, DO NOT commit to trunk, 8.5.x or 7.0.x after this time. I will notify the list when the git repo is ready for general writing. Note:

[Bug 63206] Try to create parent directories before writing an uploaded file to disk

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63206 --- Comment #4 from Konstantin Kolinko --- I think the OP means the following: If ${catalina.base}/temp directory does not exist, file upload fails. Unlike ${catalina.base}/work, the "temp" directory is not created automatically at start

[Bug 63206] Try to create parent directories before writing an uploaded file to disk

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63206 --- Comment #5 from Christopher Schultz --- (In reply to Andy Wilkinson from comment #3) > > Tomcat shouldn't be creating directories unless explicitly directed to do > > so. > > That seems a little arbitrary to apply that rule in this case.

[Bug 63206] Try to create parent directories before writing an uploaded file to disk

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63206 --- Comment #6 from Christopher Schultz --- (In reply to Konstantin Kolinko from comment #4) > I think the OP means the following: > If ${catalina.base}/temp directory does not exist, file upload fails. > > Unlike ${catalina.base}/work, the

[Bug 63206] Try to create parent directories before writing an uploaded file to disk

2019-02-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63206 --- Comment #7 from Andy Wilkinson --- > Because it can be set by the application and is not configured and/or managed > by Tomcat. That was a distinction that you did not make when you stated the following: > Tomcat shouldn't be creating