[GitHub] [tomcat] markt-asf opened a new pull request #384: Fix BZ 60781 Escape access log output where httpd does

markt-asf opened a new pull request #384: URL: https://github.com/apache/tomcat/pull/384 https://bz.apache.org/bugzilla/show_bug.cgi?id=60781 It isn't quite as simple just escape where httpd does as httpd and Tomcat support slightly different things and validate at different points.

[Bug 60781] Access Log Valve does not escape the same as mod_log_config

https://bz.apache.org/bugzilla/show_bug.cgi?id=60781 --- Comment #3 from Mark Thomas --- Using Felix's patch as a starting point, I've put together this PR: https://github.com/apache/tomcat/pull/384 -- You are receiving this mail because: You are the assignee for the bug.

Re: [VOTE] Release Apache Tomcat 8.5.61

Mark, Thanks for RMing. On 12/3/20 09:49, Mark Thomas wrote: The proposed Apache Tomcat 8.5.61 release is now available for voting. The notable changes compared to the 8.5.60 release are: - Align the behaviour of ServletContext.getRealPath(String path) with the recent clarification from

[tomcat] branch 8.5.x updated: Fix checkstyle warnings

This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4a6cfbd Fix checkstyle warnings 4a6cfbd is

[tomcat] branch 8.5.x updated: Let the RemoteCIDRValve inherit from RequestFilterValve.

This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 7ff1be3 Let the RemoteCIDRValve inherit from

APRLifecycleListener documentation

All, Does anyone have any objections to me clarifying the documentation for the APRLifecycleListener to say that it's really configuring tcnative and, despite its name, it can (and sometimes should!) be used even if the APR connector isn't being used? -chris

Re: APRLifecycleListener documentation

On 04/12/2020 19:51, Christopher Schultz wrote: > All, > > Does anyone have any objections to me clarifying the documentation for > the APRLifecycleListener to say that it's really configuring tcnative > and, despite its name, it can (and sometimes should!) be used even if > the APR connector

[tomcat] branch master updated: Fix checkstyle warnings

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 3bc0f91 Fix checkstyle warnings 3bc0f91 is

Re: [tomcat] 02/05: Collapse identical catch blocks

On 04/12/2020 00:05, ebo...@apache.org wrote: > commit d03a176f94b42564ac5f6f28b587ad0e483716e2 > Author: Emmanuel Bourg > AuthorDate: Fri Dec 4 00:15:59 2020 +0100 > > Collapse identical catch blocks > java/org/apache/el/parser/AstValue.java| 6 ++ This is generated

[Bug 64110] Record TLS protocol in access log for connections with a failed TLS handshake

https://bz.apache.org/bugzilla/show_bug.cgi?id=64110 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

buildbot failure in on tomcat-85-trunk

The Buildbot has detected a new failure on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/2557 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

buildbot failure in on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5579 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch master updated: Fix Javadoc errors

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 0fbab05 Fix Javadoc errors 0fbab05 is described

[tomcat] branch 9.0.x updated: Fix BZ 64110 - request attr for requested ciphers and protocols

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 344d073 Fix BZ 64110 - request attr for requested

[tomcat] branch master updated: Fix BZ 64110 - request attr for requested ciphers and protocols

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new cf84fb6 Fix BZ 64110 - request attr for

[GitHub] [tomcat] markt-asf merged pull request #380: Fix BZ 64110 - request attr for requested ciphers and protocols

markt-asf merged pull request #380: URL: https://github.com/apache/tomcat/pull/380 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[tomcat] 01/02: Increment version for next development cycle

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit be54a6e76053478a731e26e8a27eadd1dd6f9b5c Author: Mark Thomas AuthorDate: Fri Dec 4 08:49:16 2020 + Increment

[tomcat] branch master updated (4189868 -> 10a059d)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 4189868 Merge pull request #380 from markt-asf/bz-64110 new be54a6e Increment version for next development

[tomcat] 02/02: Move entry to correct version

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 10a059d81d32e192b69277718ec03712a70495de Author: Mark Thomas AuthorDate: Fri Dec 4 08:50:04 2020 + Move entry

[tomcat] branch 9.0.x updated: Increment version for next development cycle

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new bdfda53 Increment version for next development

[tomcat] branch 8.5.x updated: Increment version for next development cycle

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new a44e737 Increment version for next development

[tomcat] branch 8.5.x updated: Fix BZ 64110 - request attr for requested ciphers and protocols

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 2448e04 Fix BZ 64110 - request attr for requested

buildbot failure in on tomcat-9-trunk

The Buildbot has detected a new failure on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/563 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

Re: [tomcat] 02/05: Collapse identical catch blocks

Le 04/12/2020 à 09:03, Mark Thomas a écrit : >> java/org/apache/el/parser/AstValue.java| 6 ++ > > This is generated code. The change will be undone the next time the > source is regenerated. My preference is to leave generated code as-is > but I don't think this needs to be

[tomcat] 04/12: Replace ThreadLocal inner classes with ThreadLocal.withInitial() + lambda expression

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 92ee90fbb0ade1513d755afac6d85cd682f8199a Author: Emmanuel Bourg AuthorDate: Wed Dec 2 01:07:51 2020 +0100 Replace

[tomcat] 06/12: Replace Collections.sort() with List.sort()

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 14f24d1c60bd61b3002120b2b6da1e67a9d4a688 Author: Emmanuel Bourg AuthorDate: Wed Dec 2 01:28:25 2020 +0100 Replace

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

Le 04/12/2020 à 12:13, Rémy Maucherat a écrit : > +1 to backport to 9.0, but not to Tomcat 8.5 since it would need to be Java > 7 compatible [some of the changes might be fine, but for others it's not > possible]. Did you mean Tomcat 7? Because Tomcat 8.5 already depends on Java 7. Emmanuel

[tomcat] branch master updated: Let the RemoteCIDRValve inherit from RequestFilterValve and support all of its features. Especially add support for connector specific configuration using "addConnector

This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 74f4740 Let the RemoteCIDRValve inherit from

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

On Fri, Dec 4, 2020 at 2:08 AM Igal Sapir wrote: > On Thu, Dec 3, 2020 at 2:48 PM Martin Grigorov > wrote: > > > Hi, > > > > Shall we backport these commits to 9.x and 8.5? > > It will make it easier to backport future changes in these classes. > > > > +1 > > No need to diverge the branches

Re: buildbot failure in on tomcat-trunk

On 04/12/2020 08:52, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building tomcat. Full details are available at: > https://ci.apache.org/builders/tomcat-trunk/builds/5579 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for

[tomcat] 11/12: Make the inner classes static when possible to save a reference to the enclosing class

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit fe36ceef496d1b59dd8d133a62ad213f48474969 Author: Emmanuel Bourg AuthorDate: Fri Dec 4 00:48:39 2020 +0100 Make the

[tomcat] 02/12: Use lambda expressions with AccessController.doPrivileged()

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit caba05c91f7151209651a2e03f1c70676c2730a6 Author: Emmanuel Bourg AuthorDate: Wed Dec 2 00:52:02 2020 +0100 Use

[tomcat] 09/12: Collapse identical catch blocks

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit fd478f52423753b1c7a3118fe147e253fb4bf17c Author: Emmanuel Bourg AuthorDate: Fri Dec 4 00:15:59 2020 +0100 Collapse

[tomcat] branch 9.0.x updated (073f9d0 -> 64a3ea5)

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 073f9d0 Fix parsing logic new b47fb6a Use the valueOf() method of the primitive wrapper classes instead of

[tomcat] 05/12: Replace Runnable inner classes with lambda expressions

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d3e9253e4d20f416f9f73b64c4169f9b15ca1e94 Author: Emmanuel Bourg AuthorDate: Wed Dec 2 01:16:12 2020 +0100 Replace

[tomcat] 03/12: Use method references instead of lambda expressions when possible

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 490f3fca007c06ccf28c8a1cc2aa2e0578958ba0 Author: Emmanuel Bourg AuthorDate: Wed Dec 2 00:55:34 2020 +0100 Use

[tomcat] 07/12: Replace loops with Collection.removeIf() when possible

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 389e1f3582c6d86389acb11f4fa00dff68d5ba69 Author: Emmanuel Bourg AuthorDate: Wed Dec 2 01:34:34 2020 +0100 Replace

[tomcat] 01/12: Use the valueOf() method of the primitive wrapper classes instead of the deprecated constructors (to be removed as part of JEP 390)

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b47fb6af157169e0278d1fbb8fe6d998ee0356b6 Author: Emmanuel Bourg AuthorDate: Tue Dec 1 22:35:49 2020 +0100 Use the

[tomcat] branch 9.0.x updated: Fix parsing logic

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 073f9d0 Fix parsing logic 073f9d0 is described

[tomcat] branch 8.5.x updated: Fix parsing logic

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new fa4f710 Fix parsing logic fa4f710 is described

[tomcat] branch master updated: Fix parsing logic

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 1e3bd8a Fix parsing logic 1e3bd8a is described

[tomcat] 12/12: No longer use Throwable.initCause() when possible

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 64a3ea59a016b32b4d6bd9beb5c42599c4d1b18a Author: Emmanuel Bourg AuthorDate: Fri Dec 4 01:03:07 2020 +0100 No longer

[tomcat] 08/12: Replace explicit types with <>

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cf0d33c11e6bf15598530c2a2e811b2be3104c89 Author: Emmanuel Bourg AuthorDate: Thu Dec 3 23:43:49 2020 +0100 Replace

[tomcat] 10/12: Make the serialVersionUID fields private

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit e343c61a73650879670c4cad6e3f0afa847e22d5 Author: Emmanuel Bourg AuthorDate: Fri Dec 4 00:22:09 2020 +0100 Make the

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

On Fri, Dec 4, 2020 at 1:04 PM Emmanuel Bourg wrote: > Le 04/12/2020 à 12:13, Rémy Maucherat a écrit : > > > +1 to backport to 9.0, but not to Tomcat 8.5 since it would need to be > Java > > 7 compatible [some of the changes might be fine, but for others it's not > > possible]. > > Did you mean

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

Le 04/12/2020 à 13:31, Rémy Maucherat a écrit : > I mean you can add lambda expressions in Tomcat 9, but not Tomcat 8.5, > right ? Since Tomcat 8.5 is supposed to be Java 7 friendly ( > http://tomcat.apache.org/whichversion.html ). Tomcat 7 would be Java 6 > (ouch). Oh ok, I thought you were

buildbot success in on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5582 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[tomcat] 01/05: Use the valueOf() method of the primitive wrapper classes instead of the deprecated constructors (to be removed as part of JEP 390)

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit bf3f7731649c30b37ca9089bd737c83b0b6ae638 Author: Emmanuel Bourg AuthorDate: Tue Dec 1 22:35:49 2020 +0100 Use the

[tomcat] 03/05: Make the serialVersionUID fields private

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 398cd3ae7c545a0b88cd6b305f858c57006f5536 Author: Emmanuel Bourg AuthorDate: Fri Dec 4 00:22:09 2020 +0100 Make the

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

Le 04/12/2020 à 02:07, Igal Sapir a écrit : >> Shall we backport these commits to 9.x and 8.5? >> It will make it easier to backport future changes in these classes. > > +1 > > No need to diverge the branches unnecessarily. I've backported the changes to Tomcat 9 and 8.5 (minus the incompatible

[tomcat] branch 9.0.x updated: Fix validation error: ModifierOrder.

This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 7773972 Fix validation error: ModifierOrder.

[tomcat] branch 9.0.x updated: Let the RemoteCIDRValve inherit from RequestFilterValve.

This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 5905f82 Let the RemoteCIDRValve inherit from

[tomcat] 05/05: No longer use Throwable.initCause() when possible

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 85eb58ebe5501742725dc470d339ffc402668280 Author: Emmanuel Bourg AuthorDate: Fri Dec 4 01:03:07 2020 +0100 No longer

[tomcat] 02/05: Collapse identical catch blocks

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 22e89f8cde17dd62e1a5cf4365027da0de245145 Author: Emmanuel Bourg AuthorDate: Fri Dec 4 00:15:59 2020 +0100 Collapse

[tomcat] 04/05: Make the inner classes static when possible to save a reference to the enclosing class

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit da81376ae66f1a5b3a38c5fc584b47d55ec5ca5c Author: Emmanuel Bourg AuthorDate: Fri Dec 4 00:48:39 2020 +0100 Make the

[tomcat] branch 8.5.x updated (fa4f710 -> 85eb58e)

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from fa4f710 Fix parsing logic new bf3f773 Use the valueOf() method of the primitive wrapper classes instead of

[tomcat] branch 9.0.x updated: Fix validation error: Unused import.

This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 39ce7a3 Fix validation error: Unused import.

buildbot success in on tomcat-85-trunk

The Buildbot has detected a restored build on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/2558 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

buildbot success in on tomcat-9-trunk

The Buildbot has detected a restored build on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/565 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The