[tomcat] branch 9.0.x updated: SpotBugs false positive. NPE isn't possible here.

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 9a2ce27 SpotBugs false positive. NPE isn't

Re: [tomcat] branch 10.0.x updated: Avoid synchronization on roles verification

2021-06-23 Thread Mark Thomas
On 04/06/2021 09:14, r...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new

[tomcat] branch main updated: SpotBugs false positive. NPE isn't possible here.

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new f721ad9 SpotBugs false positive. NPE isn't possible

[tomcat] branch 10.0.x updated: SpotBugs false positive. NPE isn't possible here.

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 7d587ca SpotBugs false positive. NPE isn't

[tomcat] branch 8.5.x updated: SpotBugs false positive. NPE isn't possible here.

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new c4b5c86 SpotBugs false positive. NPE isn't

Re: [tomcat] branch 10.0.x updated: Avoid synchronization on roles verification

2021-06-23 Thread Rémy Maucherat
On Wed, Jun 23, 2021 at 11:18 AM Mark Thomas wrote: > > On 04/06/2021 09:14, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch 10.0.x > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > >

[tomcat] branch 9.0.x updated: Align with 10.0.x.

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new db9618a Align with 10.0.x. db9618a is described

[tomcat] branch 9.0.x updated: Fix Javadoc (and CI build)

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 17c3c21 Fix Javadoc (and CI build) 17c3c21 is

[tomcat] branch 10.0.x updated: Fix Javadoc (and CI build)

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 9f2c041 Fix Javadoc (and CI build) 9f2c041 is

[tomcat] branch 8.5.x updated: Fix Javadoc (and CI build)

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 701fa02 Fix Javadoc (and CI build) 701fa02 is

[tomcat] branch main updated: Fix Javadoc (and CI build)

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 0ec9b4b Fix Javadoc (and CI build) 0ec9b4b is

[tomcat] branch 8.5.x updated: Refactor to use a shared SecureRandom instance

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 02822aa Refactor to use a shared SecureRandom

[tomcat] branch main updated: Additional false positives with latest SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new f0925ab Additional false positives with latest

[tomcat] branch 9.0.x updated: Additional false positives with latest SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 276bd7a Additional false positives with latest

[tomcat] branch main updated: Update Tomcat version numbers

2021-06-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 2a792b6 Update Tomcat version numbers 2a792b6 is

[tomcat] branch 8.5.x updated: Fix SpotBugs warning and threading issue

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new cd1ebb5 Fix SpotBugs warning and threading issue

[tomcat] branch 8.5.x updated: Fix some serialization warnings

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 8b85b67 Fix some serialization warnings 8b85b67

buildbot success in on tomcat-9.0.x

2021-06-23 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-9.0.x while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9.0.x/builds/45 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch main updated: Refactor to use a shared SecureRandom instance

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 8d3b310 Refactor to use a shared SecureRandom

[tomcat] branch 9.0.x updated: Refactor to use a shared SecureRandom instance

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 0e4bc93 Refactor to use a shared SecureRandom

[tomcat] branch 10.0.x updated: Refactor to use a shared SecureRandom instance

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 46f519e Refactor to use a shared SecureRandom

[tomcat] branch 10.0.x updated: Additional false positives with latest SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new cbd8c93 Additional false positives with latest

[tomcat] branch 8.5.x updated: Additional false positives with latest SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 6f7d47e Additional false positives with latest

[tomcat] branch main updated: Remove unnecessary null check identified by SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new be141fa Remove unnecessary null check identified by

Re: [tomcat] branch 10.0.x updated: Avoid synchronization on roles verification

2021-06-23 Thread Mark Thomas
On 23/06/2021 10:37, Rémy Maucherat wrote: On Wed, Jun 23, 2021 at 11:18 AM Mark Thomas wrote: I have a fix in mind for the toString()/toXml() methods. It may have a marginal performance impact but given that these methods are only used when debugging and/or persisting configuration to

[tomcat] branch 9.0.x updated: Remove unnecessary null check identified by SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new d4a127f Remove unnecessary null check identified

[tomcat] branch 10.0.x updated: Remove unnecessary null check identified by SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new dfc8671 Remove unnecessary null check

buildbot failure in on tomcat-9.0.x

2021-06-23 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-9.0.x while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9.0.x/builds/46 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch main updated: Fix SpotBugs warning and threading issue

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new feca996 Fix SpotBugs warning and threading issue

[tomcat] branch main updated: Fix some serialization warnings

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 0163f97 Fix some serialization warnings 0163f97 is

[tomcat] branch 10.0.x updated: Fix some serialization warnings

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 96d1859 Fix some serialization warnings 96d1859

[tomcat] branch 9.0.x updated: Fix some serialization warnings

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 0690dd9 Fix some serialization warnings 0690dd9

buildbot failure in on tomcat-10.0.x

2021-06-23 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-10.0.x while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-10.0.x/builds/64 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch 10.0.x updated: Fix SpotBugs warning and threading issue

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new ea274f2 Fix SpotBugs warning and threading

[tomcat] branch 9.0.x updated: Fix SpotBugs warning and threading issue

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 208a365 Fix SpotBugs warning and threading issue

[tomcat] branch 9.0.x updated: Fix concurrency issues reported by SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new c11142d Fix concurrency issues reported by

[tomcat] branch 10.0.x updated: Fix concurrency issues reported by SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new ef57a96 Fix concurrency issues reported by

[tomcat] branch main updated: Fix concurrency issues reported by SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 6d74989 Fix concurrency issues reported by SpotBugs

[tomcat] branch main updated: Remaining false positives with latest Eclipse / SpotBugs plugin

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 5c0b4fa Remaining false positives with latest

[tomcat] branch 9.0.x updated: Remaining false positives with latest Eclipse / SpotBugs plugin

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f7b8cf0 Remaining false positives with latest

[tomcat] branch 10.0.x updated: Simplify - identified by SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 08c419a Simplify - identified by SpotBugs

[tomcat] branch 9.0.x updated: Simplify - identified by SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new d52d085 Simplify - identified by SpotBugs d52d085

[tomcat] branch main updated: Simplify - identified by SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new b9bd126 Simplify - identified by SpotBugs b9bd126

buildbot success in on tomcat-10.0.x

2021-06-23 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-10.0.x while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-10.0.x/builds/66 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[tomcat] branch 8.5.x updated: Fix concurrency issues reported by SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 6a34a9e Fix concurrency issues reported by

buildbot success in on tomcat-9.0.x

2021-06-23 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-9.0.x while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9.0.x/builds/48 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch 10.0.x updated: Remaining false positives with latest Eclipse / SpotBugs plugin

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new e60b4a4 Remaining false positives with latest

[tomcat] branch 8.5.x updated: Remaining false positives with latest Eclipse / SpotBugs plugin

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new eeddd3b Remaining false positives with latest

[tomcat] branch 8.5.x updated: Simplify - identified by SpotBugs

2021-06-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 74b45fd Simplify - identified by SpotBugs 74b45fd

Re: mod_headers as a Filter

2021-06-23 Thread Mark Thomas
On 07/05/2021 09:33, Rémy Maucherat wrote: On Wed, Apr 28, 2021 at 10:45 AM Rémy Maucherat wrote: On Wed, Apr 28, 2021 at 9:07 AM Mark Thomas wrote: I'm wondering if there is merit in a Valve-like mechanism for Coyote. Name TBD but would look something like: - callbacks - after request

Re: [tomcat] branch main updated: Simplify - identified by SpotBugs

2021-06-23 Thread Christopher Schultz
Mark, On 6/23/21 13:19, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new