Re: [tomcat] branch main updated: Protect against a known OS bug

2021-11-22 Thread Mark Thomas
On 22/11/2021 18:28, Christopher Schultz wrote: It seems like very little overhead -- especially because it's done only once per connection and not, for example once per request or (much worse) once-per-IO-event. So it's probably not worth the extra code unless it's easy to swap-out the

Re: OpenSSL module build releases

2021-11-22 Thread Christopher Schultz
Rémy, On 11/22/21 02:00, Rémy Maucherat wrote: I am done with the initial version of the OpenSSL with Panama module. Fantastic. It could be time for more testing and build releases (obviously targeting only Java 17). It should also be easy to add new features as needed since the full

Re: OpenSSL module build releases

2021-11-22 Thread Rémy Maucherat
On Mon, Nov 22, 2021 at 10:55 PM Christopher Schultz wrote: > > Rémy, > > On 11/22/21 02:00, Rémy Maucherat wrote: > > I am done with the initial version of the OpenSSL with Panama module. > > Fantastic. > > > It could be time for more testing and build releases (obviously > > targeting only Java

[tomcat] branch 8.5.x updated: Force the use of a single acceptor thread

2021-11-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new ead24df Force the use of a single acceptor thread

[tomcat] branch servlet-6-cookies created (now c2d3ec7)

2021-11-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch servlet-6-cookies in repository https://gitbox.apache.org/repos/asf/tomcat.git. at c2d3ec7 Cookie updates for Servlet 6.0. Only support RFC 6265. Remove others. This branch includes the

[tomcat] branch 9.0.x updated: Avoid duplicate read registrations for blocking I/O with NIO

2021-11-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new b0675f3 Avoid duplicate read registrations for

[tomcat] branch main updated: Avoid duplicate read registrations for blocking I/O with NIO

2021-11-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 5a55179 Avoid duplicate read registrations for

[tomcat] branch 10.0.x updated: Avoid duplicate read registrations for blocking I/O with NIO

2021-11-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 2604b2b Avoid duplicate read registrations for

[GitHub] [tomcat] markt-asf closed pull request #459: 9.0.x

2021-11-22 Thread GitBox
markt-asf closed pull request #459: URL: https://github.com/apache/tomcat/pull/459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] markt-asf commented on pull request #459: 9.0.x

2021-11-22 Thread GitBox
markt-asf commented on pull request #459: URL: https://github.com/apache/tomcat/pull/459#issuecomment-975345803 Further PR submissions like this one will result in a ban. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tomcat] markt-asf opened a new pull request #460: Cookie updates for Servlet 6.0. Only support RFC 6265. Remove others.

2021-11-22 Thread GitBox
markt-asf opened a new pull request #460: URL: https://github.com/apache/tomcat/pull/460 This removes support for Netscape cookies and RFC 2109 cookies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] rmaucher commented on pull request #460: Cookie updates for Servlet 6.0. Only support RFC 6265. Remove others.

2021-11-22 Thread GitBox
rmaucher commented on pull request #460: URL: https://github.com/apache/tomcat/pull/460#issuecomment-975477925 I think there will be a lot of complaints ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tomcat] markt-asf commented on pull request #460: Cookie updates for Servlet 6.0. Only support RFC 6265. Remove others.

2021-11-22 Thread GitBox
markt-asf commented on pull request #460: URL: https://github.com/apache/tomcat/pull/460#issuecomment-975488132 I suspect you are right. I suspect this change will mean a longer than otherwise beta period for 10.1.x. It may be we end up adding a few more options to

Re: Checkstyle and CVE-2021-42574

2021-11-22 Thread Christopher Schultz
Mark, On 11/20/21 04:39, Mark Thomas wrote: On 19/11/2021 22:58, Christopher Schultz wrote: Mark, On 11/19/21 13:46, Mark Thomas wrote: On 19/11/2021 18:12, Christopher Schultz wrote: All, On 11/19/21 13:04, Christopher Schultz wrote: All, I've been (briefly) looking into using

[tomcat] branch 8.5.x updated: Protect against a known OS bug

2021-11-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 01158bc Protect against a known OS bug 01158bc is

Re: [tomcat] branch main updated: Protect against a known OS bug

2021-11-22 Thread Christopher Schultz
Mark, Apologies for top-posting but this might get lost in the code below. This patch appears to: 1. Get the address from the just-accepted socket 2. Compare the address to the most-recently-accepted socket address (see #3) 2a. Throw an error if the current and previous address are the same

[GitHub] [tomcat] ChristopherSchultz commented on pull request #460: Cookie updates for Servlet 6.0. Only support RFC 6265. Remove others.

2021-11-22 Thread GitBox
ChristopherSchultz commented on pull request #460: URL: https://github.com/apache/tomcat/pull/460#issuecomment-975651008 Just let MSIE die already. :) Oh, and all those custom clients whose devs never bothered to look at the HTTP or Cookie specs. -- This is an automated message from the

Re: [tomcat] branch main updated: Protect against a known OS bug

2021-11-22 Thread Christopher Schultz
Mark, On 11/22/21 11:57, Mark Thomas wrote: On 22/11/2021 15:36, Christopher Schultz wrote: Mark, Apologies for top-posting but this might get lost in the code below. No problem. This patch appears to: 1. Get the address from the just-accepted socket 2. Compare the address to the

[tomcat] branch main updated: Improve robustness for expired credentials

2021-11-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 808e0cb Improve robustness for expired credentials

[tomcat] branch 10.0.x updated: Improve robustness for expired credentials

2021-11-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new ec8390a Improve robustness for expired

[tomcat] branch 9.0.x updated: Improve robustness for expired credentials

2021-11-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new b543bd7 Improve robustness for expired

[tomcat] branch 8.5.x updated: Improve robustness for expired credentials

2021-11-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 292d2e2 Improve robustness for expired

Re: [tomcat] branch main updated: Protect against a known OS bug

2021-11-22 Thread Mark Thomas
On 22/11/2021 15:36, Christopher Schultz wrote: Mark, Apologies for top-posting but this might get lost in the code below. No problem. This patch appears to: 1. Get the address from the just-accepted socket 2. Compare the address to the most-recently-accepted socket address (see #3)  

[tomcat] branch main updated: Fix bad check for destroy

2021-11-22 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new d2036d1 Fix bad check for destroy d2036d1 is

[tomcat] branch main updated: Remove "next" item

2021-11-22 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 57acf6d Remove "next" item 57acf6d is described