[Bug 66207] StringManager#getManager(String, Enumeration) cannot return the correct value

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66207 --- Comment #3 from HanLi --- It's not a bug, so close it. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail:

[Bug 66207] StringManager#getManager(String, Enumeration) cannot return the correct value

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66207 HanLi changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

Re: tcnative crashes during shutdown (TC 10.x unit tests)

2022-08-15 Thread Mark Thomas
On 19/07/2022 23:16, Rainer Jung wrote: Roughly the same pattern I saw for TC 10.0 now also seen for TC 10.1. A failure rate of 1 in 50 is going to make any testing a relatively slow process. We are going to need at least 250 test runs to get a reasonable degree of certainty in the results.

[Bug 66210] Some unit tests are failing on a non-English PC

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 --- Comment #4 from Han Li --- (In reply to Mark Thomas from comment #3) > Option 2 is sufficient to test the functionality primarily being tested > whereas option 3 (sort of) tests some of the i18n as well. Agreed! I also think that option 3

[Bug 66194] When using http2 and maxHeaderSize is exceeded, nothing is logged

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66194 --- Comment #1 from Mark Thomas --- Logging every instance of this opens up the potential for a DoS. We can look at the possibility of mirroring the logging used for HTTP/1.1 which logs via a UserDataHelper instance. -- You are receiving

[Bug 66196] HTTP/1 connector doesn't blow-up when HTTP header contains non-ASCII characters

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66196 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Mark

[Bug 66210] Some unit tests are failing on a non-English PC

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 --- Comment #3 from Mark Thomas --- I think we have a number of options here: 1. (Similar to my previous 'fixes') reduce the text tested to that which doesn't change depending on locale. 2. Force the unit tests to run under en-US. 3. Use

[GitHub] [tomcat] markt-asf closed pull request #534: Issue 66195 observe mr jar system property

2022-08-15 Thread GitBox
markt-asf closed pull request #534: Issue 66195 observe mr jar system property URL: https://github.com/apache/tomcat/pull/534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tomcat] markt-asf commented on pull request #534: Issue 66195 observe mr jar system property

2022-08-15 Thread GitBox
markt-asf commented on PR #534: URL: https://github.com/apache/tomcat/pull/534#issuecomment-1214871231 The sync block won't be reached: https://github.com/openjdk/jdk/blob/jdk-11%2B28/src/java.base/share/classes/java/util/jar/JarFile.java#L382 The case hasn't been made that this

[Bug 66195] Observe multi-release JAR system property from JVM if available via system properties

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66195 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 66196] HTTP/1 connector doesn't blow-up when HTTP header contains non-ASCII characters

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66196 --- Comment #2 from Boris Petrov --- Well, in my case it was the `ETag` header but I believe it's illegal to send non-ASCII characters in any header. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 66194] When using http2 and maxHeaderSize is exceeded, nothing is logged

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66194 --- Comment #2 from damien.hol...@unimarket.com --- Logging at least the first instance would be much more helpful than the current situation. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 66209] CPU regression when classpath Bloom filters are active

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66209 --- Comment #1 from Mark Thomas --- This patch essentially trades memory for performance. We have some users that won't want to make that trade - even if the memory concerned is relatively small. Given the competing demands here, I think we

[Bug 66210] Some unit tests are failing on a non-English PC

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 --- Comment #5 from Mark Thomas --- Sounds great. Thanks. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail:

[Bug 66209] CPU regression when classpath Bloom filters are active

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66209 --- Comment #2 from John Engebretson --- I had a hand in the original implementation, and the intent was always to create the Bloom filters once and keep them around forever. In our internal implementation (Tomcat 8) we did exactly that.

[tomcat] branch 9.0.x updated: [Bug 66184] Ensure that all root loggers have a level or parent

2022-08-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 9c9dc83e5a [Bug 66184] Ensure that all root

[Bug 66184] Null root logger level on Java 8

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66184 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO

[GitHub] [tomcat] aooohan closed pull request #537: Bugfix for 66210 - Some unit tests are failing on a non-English PC

2022-08-15 Thread GitBox
aooohan closed pull request #537: Bugfix for 66210 - Some unit tests are failing on a non-English PC URL: https://github.com/apache/tomcat/pull/537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] aooohan commented on pull request #537: Bugfix for 66210 - Some unit tests are failing on a non-English PC

2022-08-15 Thread GitBox
aooohan commented on PR #537: URL: https://github.com/apache/tomcat/pull/537#issuecomment-1216053591 Will be refix according to option 3, so close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] markt-asf commented on pull request #540: Fix typo

2022-08-15 Thread GitBox
markt-asf commented on PR #540: URL: https://github.com/apache/tomcat/pull/540#issuecomment-1216130168 Thanks for the PR. Back-ported to all other supported branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tomcat] markt-asf merged pull request #538: Fix typo

2022-08-15 Thread GitBox
markt-asf merged PR #538: URL: https://github.com/apache/tomcat/pull/538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tomcat] branch 10.0.x updated: [Bug 66184] Ensure that all root loggers have a level or parent

2022-08-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new e5a5122d2b [Bug 66184] Ensure that all root

[Bug 66179] NPE when retrieving locale from request

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66179 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #5 from Mark

[GitHub] [tomcat] markt-asf merged pull request #540: Fix typo

2022-08-15 Thread GitBox
markt-asf merged PR #540: URL: https://github.com/apache/tomcat/pull/540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[Bug 66183] AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66183 --- Comment #2 from Mark Thomas --- I agree that this needs to be fixed. Your plan sounds reasonable to me. -- You are receiving this mail because: You are the assignee for the bug.

[GitHub] [tomcat] aooohan opened a new pull request, #541: Bugfix for 66183 - AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-15 Thread GitBox
aooohan opened a new pull request, #541: URL: https://github.com/apache/tomcat/pull/541 Fix [BZ66183](https://bz.apache.org/bugzilla/show_bug.cgi?id=66183) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[tomcat] branch main updated: [Bug 66184] Ensure that all root loggers have a level or parent

2022-08-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new d54295e2d8 [Bug 66184] Ensure that all root loggers

[GitHub] [tomcat] markt-asf commented on pull request #533: [Bug 66184] Ensure that all root loggers have a level or parent

2022-08-15 Thread GitBox
markt-asf commented on PR #533: URL: https://github.com/apache/tomcat/pull/533#issuecomment-1216008668 Thanks for the bug report and PR. I just want to clean up a few minor points (e.g. add a change log entry) and then I'll back-port this. -- This is an automated message from the Apache

[tomcat] branch main updated: Follow-up to #533

2022-08-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 46d7162237 Follow-up to #533 46d7162237 is described

[Bug 66183] AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66183 --- Comment #4 from Han Li --- There is also this problem in Extended Access Log Valve. -- You are receiving this mail because: You are the assignee for the bug. - To

[Bug 66196] HTTP/1 connector doesn't blow-up when HTTP header contains non-ASCII characters

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66196 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #3 from Mark Thomas

[GitHub] [tomcat] markt-asf merged pull request #533: [Bug 66184] Ensure that all root loggers have a level or parent

2022-08-15 Thread GitBox
markt-asf merged PR #533: URL: https://github.com/apache/tomcat/pull/533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tomcat] branch 8.5.x updated: [Bug 66184] Ensure that all root loggers have a level or parent

2022-08-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 55067d1ff1 [Bug 66184] Ensure that all root

[tomcat] branch 8.5.x updated: Align IDE configuration with current dependency versions

2022-08-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new ad54dc88e6 Align IDE configuration with current

[GitHub] [tomcat] markt-asf commented on pull request #538: Fix typo

2022-08-15 Thread GitBox
markt-asf commented on PR #538: URL: https://github.com/apache/tomcat/pull/538#issuecomment-1216134107 Thanks for the PR. Back-ported to 10.0.x. (9.0.x and earlier does not have the affected code.) -- This is an automated message from the Apache Git Service. To respond to the message,

[Bug 66183] AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66183 --- Comment #3 from Han Li --- (In reply to Mark Thomas from comment #2) > I agree that this needs to be fixed. Your plan sounds reasonable to me. Ok, I'll go ahead and fix this bug today. Thanks Mark! Han -- You are receiving this mail

[Bug 66183] AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66183 --- Comment #5 from Han Li --- PR: https://github.com/apache/tomcat/pull/541 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe,