[tomcat] branch 8.5.x updated: Fix BZ66210 https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 Use StringManager to retrieve the expected txt in the current locale and then compare the actual output

This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new dc6fffe27d Fix BZ66210

[tomcat] branch main updated: Switch to Executor for async logging

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new c0c50fb1e4 Switch to Executor for async logging

[tomcat] branch 10.0.x updated: Switch to Executor for async logging

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 0d46bfb5ea Switch to Executor for async logging

[tomcat] branch 9.0.x updated: Switch to Executor for async logging

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 9c801e41e8 Switch to Executor for async logging

[tomcat] branch 10.0.x updated: Fix Checkstyle import order warnings

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 34dccfd345 Fix Checkstyle import order warnings

[tomcat] branch main updated: Fix Checkstyle import order warnings

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new e475dad3ba Fix Checkstyle import order warnings

[tomcat] branch main updated: Fix BZ66210 https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 Use StringManager to retrieve the expected txt in the current locale and then compare the actual output t

This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new e0f6e0c641 Fix BZ66210

[tomcat] branch 9.0.x updated: Fix BZ66210 https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 Use StringManager to retrieve the expected txt in the current locale and then compare the actual output

This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 58550071fc Fix BZ66210

[GitHub] [tomcat] markt-asf commented on pull request #545: Replace `LoggerThread` with single-threaded executor

markt-asf commented on PR #545: URL: https://github.com/apache/tomcat/pull/545#issuecomment-1226902105 I think this is a better approach than the current code that uses a Thread. Therefore, I think we can close #544. I have been reviewing the PR and overall I like it. I have noticed

[GitHub] [tomcat] aooohan commented on pull request #542: Bugfix for 66210 - Some unit tests are failing on a non-English PC

aooohan commented on PR #542: URL: https://github.com/apache/tomcat/pull/542#issuecomment-1226960393 Merge manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] aooohan closed pull request #542: Bugfix for 66210 - Some unit tests are failing on a non-English PC

aooohan closed pull request #542: Bugfix for 66210 - Some unit tests are failing on a non-English PC URL: https://github.com/apache/tomcat/pull/542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[Bug 66210] Some unit tests are failing on a non-English PC

https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 Han Li changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat] branch 10.0.x updated: Fix BZ66210 https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 Use StringManager to retrieve the expected txt in the current locale and then compare the actual output

This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 62136a2e82 Fix BZ66210

Re: JDK 19 first Release Candidates!

Hi David, Apache Tomcat's build and tests pass successfully with JDK 19 b36 and 20 b11 on both Ubuntu x86_64 and openEuler OS ARM64. Regards, Martin On Mon, Aug 22, 2022 at 4:23 PM David Delabassee < david.delabas...@oracle.com> wrote: > Greetings! > > I hope you had a chance to take some time

[tomcat] branch 8.5.x updated: Fix Checkstyle import order warnings

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 21f4fa4c4a Fix Checkstyle import order warnings

[GitHub] [tomcat] markt-asf commented on pull request #545: Replace `LoggerThread` with single-threaded executor

markt-asf commented on PR #545: URL: https://github.com/apache/tomcat/pull/545#issuecomment-1227323763 Applied manually so I could address the lost messages on shutdown issue. Thanks for the PR. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] markt-asf closed pull request #545: Replace `LoggerThread` with single-threaded executor

markt-asf closed pull request #545: Replace `LoggerThread` with single-threaded executor URL: https://github.com/apache/tomcat/pull/545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: jakarta.el, useless getResource?

On 24/08/2022 14:40, Romain Manni-Bucau wrote: Hi Went ahead and created https://github.com/apache/tomcat/pull/547 (if it helps) Thanks. There weren't any objections so I'll merge that PR shortly. Mark Romain Manni-Bucau @rmannibucau | Blog

[Bug 66236] maxSavePostSize=-1 crashes ssl renegotiation

https://bz.apache.org/bugzilla/show_bug.cgi?id=66236 --- Comment #1 from Mark Thomas --- A code inspection suggests that this hasn't been working in previous versions. While the special values of 0 and -1 work for FORM auth and HTTP upgrade, they do not work for TLS renegotiation. The

[GitHub] [tomcat] markt-asf commented on pull request #544: Avoid errors from shutting down `LoggerThread`

markt-asf commented on PR #544: URL: https://github.com/apache/tomcat/pull/544#issuecomment-1227322736 Fixed via #545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] markt-asf closed pull request #544: Avoid errors from shutting down `LoggerThread`

markt-asf closed pull request #544: Avoid errors from shutting down `LoggerThread` URL: https://github.com/apache/tomcat/pull/544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[tomcat] branch main updated: Simplifying ImportHandler to not test class presence with getResource (no more perf boost from it on modern JRE)

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a908486e0c Simplifying ImportHandler to not test

[GitHub] [tomcat] markt-asf merged pull request #547: Simplifying ImportHandler to not test class presence with getResource

markt-asf merged PR #547: URL: https://github.com/apache/tomcat/pull/547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tomcat] branch 10.0.x updated: Simplifying ImportHandler to not test class presence with getResource (no more perf boost from it on modern JRE)

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 1321709431 Simplifying ImportHandler to not test

[tomcat] branch 9.0.x updated: Simplifying ImportHandler to not test class presence with getResource (no more perf boost from it on modern JRE)

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 861eda8d58 Simplifying ImportHandler to not test

[GitHub] [tomcat-jakartaee-migration] markt-asf commented on pull request #33: fixes #32 check if file name ends with manifest name

markt-asf commented on PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#issuecomment-1227529439 Some background might help here. The main Tomcat code base doesn't use static imports at all. That is mostly my fault. For the migration tool for Jakarta

[tomcat] branch 10.0.x updated: Fix Javadoc typo

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 23bc1d7041 Fix Javadoc typo 23bc1d7041 is

[tomcat] branch main updated: Fix Javadoc typo

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new d243251948 Fix Javadoc typo d243251948 is described

[tomcat] branch 8.5.x updated: Switch to Executor for async logging

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 702a7cde41 Switch to Executor for async logging

[tomcat] branch 8.5.x updated: Simplifying ImportHandler to not test class presence with getResource

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 2b88e84408 Simplifying ImportHandler to not test

[tomcat] branch 9.0.x updated: Fix Checkstyle import order warnings

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 7a80d75590 Fix Checkstyle import order warnings

[tomcat] branch main updated: Add changelog entry

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new f605e9f352 Add changelog entry f605e9f352 is

[tomcat] branch 9.0.x updated: Fix Javadoc typo

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 831a674f7c Fix Javadoc typo 831a674f7c is

[GitHub] [tomcat-jakartaee-migration] wmccusker commented on a diff in pull request #33: fixes #32 check if file name ends with manifest name

wmccusker commented on code in PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r955189029 ## src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java: ## @@ -0,0 +1,16 @@ +package org.apache.tomcat.jakartaee; + +import static

[tomcat] branch 8.5.x updated: Fix Javadoc typo

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 5f980ee821 Fix Javadoc typo 5f980ee821 is

Re: jakarta.el, useless getResource?

Mark, On 8/22/22 07:54, Mark Thomas wrote: On 22/08/2022 11:48, Mark Thomas wrote: On 22/08/2022 10:20, Romain Manni-Bucau wrote: So overall I wonder if this check can be dropped now we have concurrent classloaders and cache almost everywhere. If not, should the missed items be cached

[GitHub] [tomcat-jakartaee-migration] wmccusker commented on pull request #33: fixes #32 check if file name ends with manifest name

wmccusker commented on PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#issuecomment-1227772671 Thanks for the context Mark! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: svn commit: r1903658 - /tomcat/site/trunk/xdocs/whoweare.xml

 On 8/24/22 06:25, li...@apache.org wrote: Author: lihan Date: Wed Aug 24 10:25:26 2022 New Revision: 1903658 URL: http://svn.apache.org/viewvc?rev=1903658=rev Log: add new committer - Han Li Modified: tomcat/site/trunk/xdocs/whoweare.xml Modified: tomcat/site/trunk/xdocs/whoweare.xml

[Bug 66179] NPE when retrieving locale from request

https://bz.apache.org/bugzilla/show_bug.cgi?id=66179 Christopher Schultz changed: What|Removed |Added Resolution|INFORMATIONPROVIDED |INVALID -- You are receiving

[GitHub] [tomcat] ppkarwasz commented on pull request #545: Replace `LoggerThread` with single-threaded executor

ppkarwasz commented on PR #545: URL: https://github.com/apache/tomcat/pull/545#issuecomment-1227607499 @markt-asf, thanks for taking care of this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[Bug 66236] maxSavePostSize=-1 crashes ssl renegotiation

https://bz.apache.org/bugzilla/show_bug.cgi?id=66236 --- Comment #2 from Mark Thomas --- It looks like reverting to using ByteChunk to store the request body in BufferedInputFilter should fix this. Initial impressions are that this works but I want to run more tests before committing. -- You

[GitHub] [tomcat-jakartaee-migration] aooohan closed pull request #27: Clean up duplicate property key and the use of deprecated api.

aooohan closed pull request #27: Clean up duplicate property key and the use of deprecated api. URL: https://github.com/apache/tomcat-jakartaee-migration/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tomcat-jakartaee-migration] aooohan commented on pull request #30: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry

aooohan commented on PR #30: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/30#issuecomment-1227979940 If there are no objections to this sloution, I will merge it today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: jakarta.el, useless getResource?

Hi Chris, My x10 dropping it was on java 17. Romain Le ven. 26 août 2022 à 02:39, Christopher Schultz < ch...@christopherschultz.net> a écrit : > Mark, > > On 8/22/22 07:54, Mark Thomas wrote: > > On 22/08/2022 11:48, Mark Thomas wrote: > >> On 22/08/2022 10:20, Romain Manni-Bucau wrote: > > >