if you have two proxy servers, very common, the X-Forwarded-For becomes
a comma separated list of IP addresses
Shankar Unni wrote:
Tim Funk wrote:
2) X-Forwarded-For (IIRC) can be multi-valued (comma seperated via
multiple proxies)
Plus, other load balancers seem to stick in other
svn propset svn:externals '^/tomcat/trunk/modules/jdbc-pool@1207712 jdbc-pool'
modules
does that seem right?
- Original Message -
From: fha...@apache.org
To: dev@tomcat.apache.org
Sent: Tuesday, November 29, 2011 6:00:19 AM
Subject: svn commit: r1207856 - /tomcat/tc7.0.x/trunk/modules/
[X] Stable
Filip
- Original Message -
From: jean-frederic clere jfcl...@gmail.com
To: dev@tomcat.apache.org
Sent: Monday, November 28, 2011 4:30:37 AM
Subject: [VOTE] Release build 6.0.35
The candidates binaries are available here:
http://people.apache.org/~jfclere/tomcat-6/v6.0.35/
http://people.apache.org/~fhanik/reports/servers/
Attached is a patch that leverages the Tomcat WebSocket API with minimalistic
changes and uses that to implement WebSockets in Tomcat 6.0.x
http://people.apache.org/~fhanik/websockets-for-tomcat-6.patch
This implementation doesn't touch the
- Original Message -
From: Costin Manolache cos...@gmail.com
I haven't looked at the tomcat6/tomcat7 interfaces, but I think the
current
hook mechanism used by spdy could be ported with minimal risk and
could be
used by websockets.
Tomcat 7 may be a candidate. Tomcat 6, If I
-Original Message-
There is no need in the above clone() method.
It has the same access level (protected) as super one.
I see that PoolProperties is written as implements Cloneable. In
such case the clone method is usually redeclared as public one.
[Filip Hanik]
No, implements
I need to investigate this, and why my config file is not being picked up by
subversion
Best
Filip
-Original Message-
From: kkoli...@apache.org [mailto:kkoli...@apache.org]
Sent: Tuesday, March 20, 2012 12:39 PM
To: dev@tomcat.apache.org
Subject: svn commit: r1303082 -
Have we published a check style configuration file?
-Original Message-
From: kkoli...@apache.org [mailto:kkoli...@apache.org]
Sent: Tuesday, March 20, 2012 12:56 PM
To: dev@tomcat.apache.org
Subject: svn commit: r1303096 - in /tomcat/trunk/modules/jdbc-pool:
doc/jdbc-pool.xml
[X] Stable, go ahead and release
- Original Message -
From: Henri Gomez henri.go...@gmail.com
To: Tomcat Developers List dev@tomcat.apache.org
Sent: Wednesday, March 21, 2012 2:33:58 AM
Subject: Re: [VOTE] Release Apache Tomcat Connectors 1.2.34
The Apache Tomcat Connectors
- /tomcat/trunk/modules/jdbc-
pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.
java
2012/3/20 Filip Hanik (mailing lists) devli...@hanik.com:
I need to investigate this, and why my config file is not being picked
up by
subversion
Maybe you do not have this setting
[X] Stable, go ahead and release
-Original Message-
From: Mladen Turk [mailto:mt...@apache.org]
Sent: Thursday, March 22, 2012 10:50 AM
To: Tomcat Developers List
Subject: Re: [VOTE] Release Apache Tomcat Connectors 1.2.35
On 03/22/2012 02:46 PM, Mladen Turk wrote:
The VOTE
On windows, it wasn't picking up ~/.subversion/config but
~/AppData/Roaming/Subversion/config
Filip
-Original Message-
From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com]
Sent: Wednesday, March 21, 2012 6:17 PM
To: 'Tomcat Developers List'
Subject: RE: svn commit: r1303082
Tomcat 7 is a Servlet 3.0 implementation with requirements to support Java 6,
wouldn't this break that contract if we do it for NIO/BIO?
Could this be done as a extras package for the Java connectors?
Why not add this into trunk first, and work with it there, as opposed to an
external
If InterruptedException was thrown by JRE it alone means that
interrupted flag has been cleared. So Thread.interrupted() call is a
NOOP.
(Effectively the interruption state means to interrupt the next
wait() etc. call immediately when they are called. When the actual
interruption happens
[+1] Released
-Original Message-
From: Jeremy Boynes [mailto:jer...@boynes.com] On Behalf Of Jeremy
Boynes
Sent: Sunday, March 25, 2012 11:02 PM
To: Tomcat Developers List
Subject: [VOTE] Release Apache Taglibs Parent POM 3
The proposed 3 release of Apache Taglibs Parent POM is
-Original Message-
From: Jeremy Boynes [mailto:jer...@boynes.com] On Behalf Of Jeremy
Boynes
Sent: Wednesday, March 28, 2012 8:38 AM
To: Tomcat Developers List
Subject: Re: [VOTE] Release Apache Taglibs Parent POM 3
Request for more votes please, we only have one binding vote so
-Original Message-
From: kfuj...@apache.org [mailto:kfuj...@apache.org]
Sent: Tuesday, March 27, 2012 8:51 PM
To: dev@tomcat.apache.org
Subject: svn commit: r1306130 - in
/tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties
UserConfig.java
+for
Is it my email client, or are some of these emails empty?
-Original Message-
From: build...@apache.org [mailto:build...@apache.org]
Sent: Wednesday, March 28, 2012 10:00 AM
To: dev@tomcat.apache.org
Subject: buildbot failure in ASF Buildbot on tomcat-trunk
-Original Message-
From: kfuj...@apache.org [mailto:kfuj...@apache.org]
Sent: Tuesday, March 27, 2012 8:51 PM
To: dev@tomcat.apache.org
Subject: svn commit: r1306130 - in
/tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties
UserConfig.java
+ for
[X] Stable - go ahead and release as 7.0.27 Stable
- Original Message -
From: Mark Thomas ma...@apache.org
To: Tomcat Developers List dev@tomcat.apache.org
Sent: Saturday, March 31, 2012 11:07:30 AM
Subject: [VOTE] Release Apache Tomcat 7.0.27
The proposed Apache Tomcat 7.0.27
- Original Message -
From: ma...@apache.org
To: dev@tomcat.apache.org
Sent: Thursday, March 29, 2012 2:19:18 PM
Subject: svn commit: r1307093 -
/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
Author: markt
Date: Thu Mar
/DisposableConnectionFacade.java
On 04/04/2012 17:12, Filip Hanik Mailing Lists wrote:
- Original Message -
From: ma...@apache.org To: dev@tomcat.apache.org Sent: Thursday,
March 29, 2012 2:19:18 PM Subject: svn commit: r1307093 -
/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc
/DisposableConnectionFacade.java
2012/4/4 Filip Hanik Mailing Lists devli...@hanik.com:
- Original Message -
From: Mark Thomas ma...@apache.org
To: Tomcat Developers List dev@tomcat.apache.org
Sent: Wednesday, April 4, 2012 11:18:42 AM
Subject: Re: svn commit: r1307093 -
/tomcat/trunk
e.java
2012/4/4 Filip Hanik Mailing Lists devli...@hanik.com:
I know of two places where long lines cause problems:
1. Commit e-mails.
Long lines are wrapped and it impacts readability.
2. Side-by-side comparison in viewvc when you do colored comparison
here I see a challenge
- Original Message -
From: Rüdiger Plüm, Vodafone Group ruediger.pl...@vodafone.com
Ok. As far as I can see the new method
execute(Runnable command, long timeout, TimeUnit unit);
of the Executor interface is implemented but not used.
Would it still be an acceptable backport if
Math.min is the intention here. On a 64 core box, it should still only have 2
pollers, not 64
The comment should read ('from' instead of 'of')
Very hard for applications to see a performance benefit *from* more than 2
pollers
-Original Message-
From: Christopher Schultz
The Apache Tomcat Connectors 1.2.36 is
[X] Stable, go ahead and release
[ ] Broken because of ...
Filip
-Original Message-
From: Mladen Turk [mailto:mt...@apache.org]
Sent: Friday, May 11, 2012 3:27 AM
To: dev@tomcat.apache.org
Subject: Re: [VOTE] Release Apache Tomcat
Yes we should. I can do it today, unless you beat me to it
-Original Message-
From: Konstantin Kolinko [mailto:knst.koli...@gmail.com]
Sent: Monday, May 14, 2012 5:55 AM
To: Tomcat Developers List
Subject: Re: svn commit: r1335546 - /tomcat/trunk/modules/jdbc-
- Mensaje original -
De: Rainer Jung rainer.j...@kippdata.de
}
Was that intentional? I'd say the timestamp should be provided by the
log framework and not by java.sql.Date. But maybe the whole message
is
just a leftover from debugging the issue.
The same for the TC
[X] Stable, go ahead and release
-Original Message-
From: Mladen Turk [mailto:mt...@apache.org]
Sent: Tuesday, May 29, 2012 3:24 AM
To: Tomcat Developers List
Subject: [VOTE] Release Apache Tomcat Connectors 1.2.37
Hi,
Apache Tomcat Connectors 1.2.37 release candidate is ready
Changing a public API method is something I would do for trunk. I'm not sure
about a .28 release that is considered stable.
Filip
-Original Message-
From: kkoli...@apache.org [mailto:kkoli...@apache.org]
Sent: Thursday, May 24, 2012 5:02 PM
To: dev@tomcat.apache.org
Subject: svn
/5/30 Filip Hanik (mailing lists) devli...@hanik.com:
Changing a public API method is something I would do for trunk. I'm
not sure about a .28 release that is considered stable.
API Stability section of RELEASE-NOTES.txt says those are our
internals and may change without notice between point
Ok, this is back to code discipline. At some point, we'd have to expect that
more users will adopt v7 in production (I'm still seeing 80%+ being on v6), at
that point, commits like this do nothing except pollute the diffs.
Servlet 3.1 has released a draft, where I'd expect that trunk is
/AbstractEndpoint.java
On 04/06/2012 17:05, Filip Hanik (mailing lists) wrote:
Ok, this is back to code discipline. At some point, we'd have to
expect that more users will adopt v7 in production (I'm still seeing
80%+ being on v6), at that point, commits like this do nothing except
pollute
-Original Message-
From: Konstantin Kolinko [mailto:knst.koli...@gmail.com]
Sent: Monday, June 04, 2012 3:50 PM
To: Tomcat Developers List
Subject: Re: Tomcat 7 code policy (was: Re: svn commit: r1345848)
2012/6/5 Konstantin Kolinko knst.koli...@gmail.com:
For that reason,
Over 2 months since last release
Got some critical fixes that I would like to see released
- max connections broken
- send file in nio broken
- jdbc pool can hang during DB failure
Filip
-
To unsubscribe, e-mail:
[X] Stable, go ahead and release
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
This is one example of counting down twice. There are a lot of places
calling destroySocket, the best would have been to pass a SocketWrapper
instead of long and keep a AtomicBoolean to track if destroy has been called
on it.
if (running !paused) {
// Hand this socket off to an
} else {
-countDownConnection();
// Close socket and pool right away
destroySocket(socket);
}
[Filip Hanik]
'running' variable could be false here, at which point, socket
My suggestion for a 7.0.28 is to have -1 for the default value of
maxConnections for APR. This disables maxConnections until we have a better
grip on it.
Changing it to track closures is quite a surgery, something I would do for
trunk, but leave out of 7.0.x. This leaves existing code flow
-Original Message-
From: Konstantin Kolinko [mailto:knst.koli...@gmail.com]
Sent: Tuesday, June 26, 2012 11:38 AM
To: Tomcat Developers List
Subject: Re: svn commit: r1354112 - in /tomcat/trunk/java/javax/servlet:
./ http/
2012/6/26 fha...@apache.org:
Author: fhanik
Date:
+1
-Original Message-
From: Mark Thomas [mailto:ma...@apache.org]
Sent: Tuesday, June 26, 2012 2:12 PM
To: Tomcat Developers List
Subject: Timing for 7.0.29
I'm sure circumstances will conspire against me but I am currently
planning to start the 7.0.29 release process early next
As some of you noticed, I added in the stubs for Servlet 3.1 yesterday.
I'm planning on starting on 3.1 features, mainly the non blocking
read/writes.
In Tomcat, we already have an implementation of this in the sandbox
http://svn.apache.org/viewvc/tomcat/sandbox/gdev6x/
That works fully, and
3.1 seems to be a fairly minor update so far, so we should be able to
start
pushing Tomcat 8 right around the time as the spec is finalized.
Just a word of caution. The EG is far from agreed on the best way to do
the non-blocking API at the moment. As with happened with the 3.0 async
3.1 seems to be a fairly minor update so far, so we should be able to
start
pushing Tomcat 8 right around the time as the spec is finalized.
Just a word of caution. The EG is far from agreed on the best way to do
the non-blocking API at the moment. As with happened with the 3.0 async
I posted some feedback to the expert group:
http://java.net/projects/servlet-spec/lists/users/archive/2012-06/message/15
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail:
Haven't had time to confirm this yet myself.
I helped a user troubleshoot an issue, something that looked like a bug that
was already fixed
https://issues.apache.org/bugzilla/show_bug.cgi?id=53367
The conversation is at
http://tomcat.markmail.org/thread/betq2iim6todqlde
and when I gave the user
Thanks for the review and fix
-Original Message-
From: Konstantin Kolinko [mailto:knst.koli...@gmail.com]
Sent: Sunday, July 01, 2012 6:06 AM
To: Tomcat Developers List
Subject: Re: svn commit: r1355615 - in /tomcat/trunk:
java/org/apache/catalina/realm/JNDIRealm.java
-Original Message-
From: Mark Thomas [mailto:ma...@apache.org]
Sent: Tuesday, July 03, 2012 12:37 PM
To: Tomcat Developers List
Subject: Re: svn commit: r1356849 -
/tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java
On 03/07/2012 18:54, fha...@apache.org wrote:
Author:
Will fix!
-Original Message-
From: Konstantin Kolinko [mailto:knst.koli...@gmail.com]
Sent: Tuesday, July 03, 2012 12:51 PM
To: Tomcat Developers List
Subject: Re: buildbot failure in ASF Buildbot on tomcat-trunk
2012/7/3 build...@apache.org:
The Buildbot has detected a new
I'm on Windows 7 and see TestOutputBuffer fail inconsistently with Java 7
Most runs are failures.
I'll be looking into this this week
-Original Message-
From: Mark Thomas [mailto:ma...@apache.org]
Sent: Monday, July 09, 2012 4:33 AM
To: Tomcat Developers List
Subject: Unit tests
This failure happens when the write blocks, and we enter the Selector for a
write operation.
filip
-Original Message-
From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com]
Sent: Monday, July 09, 2012 2:23 PM
To: 'Tomcat Developers List'
Subject: RE: Unit tests and trunk
(mailing lists) [mailto:devli...@hanik.com]
Sent: Monday, July 09, 2012 2:31 PM
To: 'Tomcat Developers List'
Subject: RE: Unit tests and trunk
This failure happens when the write blocks, and we enter the Selector
for a
write operation.
filip
-Original Message-
From: Filip Hanik
Message-
From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com]
Sent: Tuesday, July 10, 2012 10:43 AM
To: 'Tomcat Developers List'
Subject: RE: Unit tests and trunk
Ok, definitely a bug in Java 7/Windows 7.
If I turn on ProcMon from sysinternals to try to figure out what is
going
-Original Message-
From: Mark Thomas [mailto:ma...@apache.org]
Sent: Wednesday, July 11, 2012 2:45 AM
To: Tomcat Developers List
Subject: Re: Unit tests and trunk
On 11/07/2012 02:27, Filip Hanik (mailing lists) wrote:
Here's what I've found out so far
The patch below does
-Original Message-
From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com]
Sent: Wednesday, July 11, 2012 10:13 AM
To: 'Tomcat Developers List'
Subject: RE: Unit tests and trunk
-Original Message-
From: Mark Thomas [mailto:ma...@apache.org]
Sent: Wednesday
, July 11, 2012 1:32 PM
To: Tomcat Developers List
Subject: Re: Unit tests and trunk
On 11/07/2012 20:13, Filip Hanik (mailing lists) wrote:
-Original Message-
From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com]
Sent: Wednesday, July 11, 2012 10:13 AM
To: 'Tomcat
://blog.bielu.com/2011/11/hotspot-64bit-server-hangs-on-socket.html
-Original Message-
From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com]
Sent: Wednesday, July 11, 2012 2:54 PM
To: 'Tomcat Developers List'
Subject: RE: Unit tests and trunk
The idea of creating a VM
Will fix
-Original Message-
From: Mark Thomas [mailto:ma...@apache.org]
Sent: Wednesday, July 11, 2012 4:03 PM
To: Tomcat Developers List
Subject: Re: svn commit: r1360372 - /tomcat/trunk/webapps/docs/aio.xml
On 11/07/2012 20:51, fha...@apache.org wrote:
Author: fhanik
Date:
-Original Message-
From: Mark Thomas [mailto:ma...@apache.org]
Sent: Wednesday, July 11, 2012 4:28 PM
To: Tomcat Developers List
Subject: Re: Unit tests and trunk
On 11/07/2012 22:39, Filip Hanik (mailing lists) wrote:
Ok, I have a resolution to this, it's a IPv6 problem
I opened a new issue pointing back to the old issue
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7183450.
It may take a day or two before your bug shows up in this external database.
-Original Message-
From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com]
Sent
How do I get access to the build environment?
So we can change the build to default to Java 7
Filip
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
, Mark Thomas ma...@apache.org wrote:
On 11/07/2012 23:40, Filip Hanik (mailing lists) wrote:
How do I get access to the build environment?
Which build environment? Gump, buildbot, something else?
Mark
So we can change the build to default to Java 7
Filip
You are correct, I was chasing down the following:
Testsuite: org.apache.catalina.websocket.TestWebSocket
Tests run: 6, Failures: 1, Errors: 0, Time elapsed: 2.048 sec
INFO: Starting ProtocolHandler [http-nio-127.0.0.1-auto-2-9027]
Jul 12, 2012 11:56:27 AM
Fixed in
http://svn.apache.org/viewvc?view=revisionrevision=1360917
DBCP should compile as well as JDBC-POOL with 1.7 now too
-Original Message-
From: Rainer Jung [mailto:rainer.j...@kippdata.de]
Sent: Thursday, July 12, 2012 6:33 AM
To: Tomcat Developers List
Subject: Current unit
and properly fixed in
http://svn.apache.org/viewvc?view=revisionrevision=1360929
- Original Message -
From: Filip Hanik (mailing lists) devli...@hanik.com
To: Tomcat Developers List dev@tomcat.apache.org
Sent: Thursday, July 12, 2012 2:43:55 PM
Subject: RE: Current unit test
I know, it's the same patch for DBCP as for DBCP2.
we can fix it, not urgent though
- Original Message -
From: Rainer Jung rainer.j...@kippdata.de
To: dev@tomcat.apache.org
Sent: Friday, July 13, 2012 3:47:27 AM
Subject: Re: svn commit: r1360729 - in /tomcat/trunk: ./
/org/apache/tomcat/jdbc/test/driver/ res/dbcp/
Do these patches need to be fed back to Commons DBCP?
Or do they only apply to the version embedded by Tomcat?
On 14 July 2012 21:47, Rainer Jung rainer.j...@kippdata.de wrote:
On 14.07.2012 22:25, Filip Hanik Mailing Lists wrote:
I know
there will be more bug reports as more people turn to java 7
on windows/hardware
Yep.
Mark
Sent from my iPhone
On Jul 11, 2012, at 16:42, Mark Thomas ma...@apache.org wrote:
On 11/07/2012 23:30, Filip Hanik (mailing lists) wrote:
I wasn't able to reproduce on a Win 7 VM because the VM
nope, I will fix that
Filip
- Original Message -
From: Romain Manni-Bucau rmannibu...@gmail.com
To: Tomcat Developers List dev@tomcat.apache.org
Sent: Tuesday, July 24, 2012 5:18:32 PM
Subject: tomat-jdbc hashCode
Hi,
just noticed tomcat jdbc doesn't manage hashCode if the
Fixed in
r1370074 and r1370075
http://svn.apache.org/viewvc?rev=1370075view=rev
http://svn.apache.org/viewvc?rev=1370074view=rev
-Original Message-
From: Filip Hanik Mailing Lists [mailto:devli...@hanik.com]
Sent: Monday, July 30, 2012 5:58 AM
To: Tomcat Developers List
Subject
I've thought about this, you see if it is using TCCL it will cause a memory
leak on app reload as the app wont be unloaded due to the pool holding it.
But I think we should make it an option
Best
Filip
-Original Message-
From: Romain Manni-Bucau [mailto:rmannibu...@gmail.com]
Sent:
-Original Message-
From: Konstantin Kolinko [mailto:knst.koli...@gmail.com]
Sent: Monday, August 27, 2012 2:09 PM
To: Tomcat Developers List
Subject: Re: svn commit: r1377689 -
/tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListe
ner.java
2012/8/27 Mark
Hanik (mailing lists) devli...@hanik.com:
There are documentation glitches yet to be fixed:
a. systemprops.xml change in trunk was not reverted by this commit.
It was reverted in 7.0.x only.
[Filip Hanik]
I don't see the property in trunk, do you?
I took care of that an hour ago.
http
-Original Message-
From: Mark Thomas [mailto:ma...@apache.org]
Sent: Monday, August 27, 2012 3:44 PM
To: Tomcat Developers List
Subject: Re: svn commit: r1377689 -
/tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListe
ner.java
On 27/08/2012 22:37, Filip Hanik
On 27/08/2012 22:37, Filip Hanik (mailing lists) wrote:
-Original Message-
From: Konstantin Kolinko [mailto:knst.koli...@gmail.com]
Sent: Monday, August 27, 2012 2:09 PM
To: Tomcat Developers List
Subject: Re: svn commit: r1377689 -
/tomcat/trunk/java/org/apache/catalina/core
Romain, what you could do for a work around right now, is to set an executor
yourself.
This way, Tomcat won't attempt to stop it, and there wont be a delay.
http://tomcat.apache.org/tomcat-7.0-doc/config/executor.html
the only time tomcat attempts to stop the executor, is if it created it, but
Ladies and Gentlemen,
I'm back, it will take a little while to get up to speed on all changes but
I intend to get involved again, so go easy on me while I learn the new tools
of the trade ;)
Filip
-
To unsubscribe, e-mail:
http-bio-1234-exec-19 daemon prio=10 tid=0x7fc30c014000 nid=0x5bb2
runnable [0x7fc31250f000]
java.lang.Thread.State: RUNNABLE
at java.net.SocketInputStream.socketRead0(Native Method)
at java.net.SocketInputStream.read(SocketInputStream.java:152)
at
+1
-Original Message-
From: Olivier Lamy [mailto:ol...@apache.org]
Sent: Wednesday, November 06, 2013 6:05 PM
To: Tomcat Developers List
Subject: [VOTE] Apache Tomcat Maven plugin 2.2
Hi,
I'd like to release Apache Tomcat Maven plugin 2.2.
We fixed 22 issues. See
80 matches
Mail list logo
