Java 8 support
Hi, As I was looking at 55988, the testsuite seems to have two issues with Java 8 at the moment: - test.name=org/apache/tomcat/util/buf/TestUtf8.java UTF-8 experts wanted ! - test.name=org/apache/jasper/tagplugins/jstl/core/TestForEach.java This would look like a JDT configuration issue or bug, it doesn't care about the default keyword in the newly added Iterator interface method Rémy
Re: Java 8 support
On 26/03/2014 15:59, Rémy Maucherat wrote: Hi, As I was looking at 55988, the testsuite seems to have two issues with Java 8 at the moment: - test.name=org/apache/tomcat/util/buf/TestUtf8.java UTF-8 experts wanted ! That will be me. I went over this in great deal when I was looking at UTF-8 failures in the Autobahn WebSocket testing. Hopefully, this means a number of the UTF-8 parsing decoding bugs have been fixed. I'll take a look. Mark - test.name=org/apache/jasper/tagplugins/jstl/core/TestForEach.java This would look like a JDT configuration issue or bug, it doesn't care about the default keyword in the newly added Iterator interface method Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Java 8 support
2014-03-26 19:59 GMT+04:00 Rémy Maucherat r...@apache.org: Hi, As I was looking at 55988, the testsuite seems to have two issues with Java 8 at the moment: - test.name=org/apache/tomcat/util/buf/TestUtf8.java UTF-8 experts wanted ! - test.name=org/apache/jasper/tagplugins/jstl/core/TestForEach.java This would look like a JDT configuration issue or bug, it doesn't care about the default keyword in the newly added Iterator interface method 1. Can you cite what the errors are? 2. There is a number of known issues in JDK 1.8.0 itself http://www.oracle.com/technetwork/java/javase/8-known-issues-2157115.html 3. BTW, I usually use test.entry property to run a single test class (as documented in BUILDING.txt), though test.name is more capable. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Java 8 support
2014-03-26 17:10 GMT+01:00 Konstantin Kolinko knst.koli...@gmail.com:
1. Can you cite what the errors are?
An error occurred at line: [22] in the generated java file:
[C:\Work\apache-tomcat-8.0.5-src\output\test-tmp\work\Tomcat\localhost\test\org\apache\jsp\bug5\bug54242_jsp.java]
The type new Iterator(){} must implement the inherited abstract method
Iterator.forEachRemaining(Consumer)
As tested on Windows for the for foreach tag plugin and the Iterator
interface. Not a showstopper since the plugin can be disabled.
And the other:
Testcase: testJvmDecoder took 0 sec
FAILED
Valid sequence padded from one byte to two expected:2 but was:1
junit.framework.AssertionFailedError: Valid sequence padded from one byte
to two expected:2 but was:1
at org.apache.tomcat.util.buf.TestUtf8.doTest(TestUtf8.java:401)
at
org.apache.tomcat.util.buf.TestUtf8.testJvmDecoder(TestUtf8.java:367)
2. There is a number of known issues in JDK 1.8.0 itself
http://www.oracle.com/technetwork/java/javase/8-known-issues-2157115.html
Ok.
3. BTW, I usually use test.entry property to run a single test class
(as documented in BUILDING.txt), though test.name is more capable.
Well, it worked for me.
Rémy
Re: Java 8 support
On 26/03/2014 16:01, Mark Thomas wrote: On 26/03/2014 15:59, Rémy Maucherat wrote: Hi, As I was looking at 55988, the testsuite seems to have two issues with Java 8 at the moment: - test.name=org/apache/tomcat/util/buf/TestUtf8.java UTF-8 experts wanted ! That will be me. I went over this in great deal when I was looking at UTF-8 failures in the Autobahn WebSocket testing. Hopefully, this means a number of the UTF-8 parsing decoding bugs have been fixed. I'll take a look. Not bad. Java 7 fails 33 out of the 53 tests. Java 8 has improved to only 6 out of 53 tests failing. I also discovered a broken test that was hiding a bug in our UTF-8 decoder. I've fixed the test and our decoder. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
