Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-11-13 Thread Mark Thomas
On 13/11/17 12:26, Konstantin Kolinko wrote: > 2017-11-13 13:42 GMT+03:00 Mark Thomas : >> On 13/11/17 09:49, Mark Thomas wrote: >> >> >> >>> Hmm. >>> >>> As I started to look at this I realised that a large number of the >>> classes with errors are only using the static import

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-11-13 Thread Konstantin Kolinko
2017-11-13 13:42 GMT+03:00 Mark Thomas : > On 13/11/17 09:49, Mark Thomas wrote: > > > >> Hmm. >> >> As I started to look at this I realised that a large number of the >> classes with errors are only using the static import a few times. Some >> of them are using a mix of static

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-11-13 Thread Mark Thomas
On 13/11/17 09:49, Mark Thomas wrote: > Hmm. > > As I started to look at this I realised that a large number of the > classes with errors are only using the static import a few times. Some > of them are using a mix of static and non-static imports. > > Given that switching to the non-static

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-11-13 Thread Mark Thomas
On 13/11/17 08:59, Mark Thomas wrote: > On 11/11/17 21:47, Konstantin Kolinko wrote: >> 2017-11-11 23:48 GMT+03:00 Mark Thomas : >>> On 27/10/17 14:13, Mark Thomas wrote: Now Checkstyle 8.3 has been released, I think we need to do something about these. There are quite

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-11-13 Thread Mark Thomas
On 11/11/17 21:47, Konstantin Kolinko wrote: > 2017-11-11 23:48 GMT+03:00 Mark Thomas : >> On 27/10/17 14:13, Mark Thomas wrote: >>> Now Checkstyle 8.3 has been released, I think we need to do something >>> about these. There are quite a few options. >>> >>> Do we want the

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-11-11 Thread Konstantin Kolinko
2017-11-11 23:48 GMT+03:00 Mark Thomas : > On 27/10/17 14:13, Mark Thomas wrote: >> Now Checkstyle 8.3 has been released, I think we need to do something >> about these. There are quite a few options. >> >> Do we want the minimalist approach (run Rainer's script, tweak the >>

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-11-11 Thread Mark Thomas
On 27/10/17 14:13, Mark Thomas wrote: > Now Checkstyle 8.3 has been released, I think we need to do something > about these. There are quite a few options. > > Do we want the minimalist approach (run Rainer's script, tweak the > Eclipse recommendations to get as close as we can to what Checkstyle

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-10-27 Thread Mark Thomas
Now Checkstyle 8.3 has been released, I think we need to do something about these. There are quite a few options. Do we want the minimalist approach (run Rainer's script, tweak the Eclipse recommendations to get as close as we can to what Checkstyle wants) or do we take a broader 'What was Mark

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-09-27 Thread Rainer Jung
Am 25.09.2017 um 21:43 schrieb Mark Thomas: On 24/09/17 12:12, Konstantin Kolinko wrote: 2017-09-24 12:45 GMT+03:00 Rainer Jung : The current Gump failures during validate might be due to the following change in checkstyle:

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-09-25 Thread Mark Thomas
On 24/09/17 12:12, Konstantin Kolinko wrote: > 2017-09-24 12:45 GMT+03:00 Rainer Jung : >> The current Gump failures during validate might be due to the following >> change in checkstyle: >> >> https://github.com/checkstyle/checkstyle/issues/5065 >> >> Gump uses a snapshot

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-09-24 Thread Konstantin Kolinko
2017-09-24 12:45 GMT+03:00 Rainer Jung : > The current Gump failures during validate might be due to the following > change in checkstyle: > > https://github.com/checkstyle/checkstyle/issues/5065 > > Gump uses a snapshot of checkstyle. > > The complains should be mostly

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-09-24 Thread Rainer Jung
The current Gump failures during validate might be due to the following change in checkstyle: https://github.com/checkstyle/checkstyle/issues/5065 Gump uses a snapshot of checkstyle. The complains should be mostly about additional separator lines e.g. between static and non-static imports

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-07-26 Thread Rémy Maucherat
On Thu, Jul 27, 2017 at 3:41 AM, Bill Barker wrote: > validate: > [mkdir] Created dir: /srv/gump/public/workspace/ > tomcat-trunk/output/res/checkstyle > [checkstyle] Running Checkstyle 8.2-SNAPSHOT on 3152 files > [checkstyle] Running Checkstyle 8.2-SNAPSHOT on 245