Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]
On Tue, Oct 10, 2023 at 12:02 AM Christopher Schultz wrote: > > All, > > On 10/9/23 17:55, Christopher Schultz wrote: > > The proposed Apache Tomcat 8.5.94 release is now available for voting. > > > > The notable changes compared to 8.5.93 are: > > > > - Update Tomcat Native to 1.2.39 to pick up Windows binaries built with > >OpenSSL 3.0.11. > > > > - Provide a lifecycle listener that will automatically reload TLS > >configurations a set time before the certificate is due to expire. > >This is intended to be used with third-party tools that regularly > >renew TLS certificates. > > > > - Improve performance of EL expressions in JSPs that use implicit > >objects. > > > > - Several improvements to thread safety and recycling cleanup. > > > > Along with lots of other bug fixes and improvements. > > > > For full details, see the changelog: > > https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html > > > > It can be obtained from: > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.94/ > > > > The Maven staging repo is: > > https://repository.apache.org/content/repositories/orgapachetomcat-1436 > > I had the Maven staging URL incorrect. Please use this one instead: > https://repository.apache.org/content/repositories/orgapachetomcat-1457 > > > The tag is: > > https://github.com/apache/tomcat/tree/8.5.94/ > > 36d4f7d698f71cd322204a3b242a97c54860fb8c > > > > The proposed 8.5.94 release is: > > [ ] Broken - do not release > > [X] Stable - go ahead and release as 8.5.94 (stable) Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]
On 09/10/2023 19:01, Christopher Schultz wrote: The proposed 8.5.94 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.94 (stable) Build is reproducible. Unit tests pass on M1 MacOS, Linux and Windows. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]
Christopher Schultz 于2023年10月10日周二 06:02写道： > All, > > On 10/9/23 17:55, Christopher Schultz wrote: > > The proposed Apache Tomcat 8.5.94 release is now available for voting. > > > > The notable changes compared to 8.5.93 are: > > > > - Update Tomcat Native to 1.2.39 to pick up Windows binaries built with > >OpenSSL 3.0.11. > > > > - Provide a lifecycle listener that will automatically reload TLS > >configurations a set time before the certificate is due to expire. > >This is intended to be used with third-party tools that regularly > >renew TLS certificates. > > > > - Improve performance of EL expressions in JSPs that use implicit > >objects. > > > > - Several improvements to thread safety and recycling cleanup. > > > > Along with lots of other bug fixes and improvements. > > > > For full details, see the changelog: > > https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html > > > > It can be obtained from: > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.94/ > > > > The Maven staging repo is: > > https://repository.apache.org/content/repositories/orgapachetomcat-1436 > > I had the Maven staging URL incorrect. Please use this one instead: > https://repository.apache.org/content/repositories/orgapachetomcat-1457 > > > The tag is: > > https://github.com/apache/tomcat/tree/8.5.94/ > > 36d4f7d698f71cd322204a3b242a97c54860fb8c > > > > The proposed 8.5.94 release is: > > [ ] Broken - do not release > > [ X] Stable - go ahead and release as 8.5.94 (stable) > Han > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]
On Mon, Oct 9, 2023 at 3:02 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > All, > > On 10/9/23 17:55, Christopher Schultz wrote: > > The proposed Apache Tomcat 8.5.94 release is now available for voting. > > > > The notable changes compared to 8.5.93 are: > > > > - Update Tomcat Native to 1.2.39 to pick up Windows binaries built with > >OpenSSL 3.0.11. > > > > - Provide a lifecycle listener that will automatically reload TLS > >configurations a set time before the certificate is due to expire. > >This is intended to be used with third-party tools that regularly > >renew TLS certificates. > > > > - Improve performance of EL expressions in JSPs that use implicit > >objects. > > > > - Several improvements to thread safety and recycling cleanup. > > > > Along with lots of other bug fixes and improvements. > > > > For full details, see the changelog: > > https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html > > > > It can be obtained from: > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.94/ > > > > The Maven staging repo is: > > https://repository.apache.org/content/repositories/orgapachetomcat-1436 > > I had the Maven staging URL incorrect. Please use this one instead: > https://repository.apache.org/content/repositories/orgapachetomcat-1457 > > > The tag is: > > https://github.com/apache/tomcat/tree/8.5.94/ > > 36d4f7d698f71cd322204a3b242a97c54860fb8c > > > > The proposed 8.5.94 release is: > > [ ] Broken - do not release > > [X] Stable - go ahead and release as 8.5.94 (stable) > +1 Build is reproducible and unit tests passed on Ubuntu 22.04 with Java 1.8u382 Igal > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]
Chris, On Mon, Oct 9, 2023 at 7:29 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > Igal, > > On 10/9/23 18:53, Igal Sapir wrote: > > Chris, > > > > On Mon, Oct 9, 2023 at 3:22 PM Christopher Schultz < > > ch...@christopherschultz.net> wrote: > > > >> Igal, > >> > >> On 10/9/23 18:13, Igal Sapir wrote: > >>> Chris, > >>> > >>> I'm getting some errors when I run `ant clean test` with Java > 1.8.0_322 - > >>> any ideas? > >> > >> Yes, you will need to set some build properties. Have a look at this > >> script and look ad what I do with the "opens": > >> > >> > >> > https://github.com/ChristopherSchultz/apache-tomcat-stuff/blob/master/bin/test-tomcat-release.sh#L269 > > > > > > OK, now I got two failures (details below): > > > >[concat] Testsuites with failed tests: > >[concat] TEST-org.apache.tomcat.util.net.jsse.TestPEMFile.NIO2.txt > > Hmm, I thought this was fixed for Java 8.something-earlier-than-yours. > I'm using 1.8.0_372 on Linux and it passes all unit tests with this > build.properties: > > base.path=/path/to/downloads > execute.validate=true > java.7.home=/usr/local/java-7 > opens.javalang=-Dnop > opens.javaio=-Dnop > opens.sunrmi=-Dnop > opens.javautil=-Dnop > opens.javautilconcurrent=-Dnop > test.openssl.unimplemented=IDEA > test.openssl.loc=/path/to/openssl > > Maybe it behaves differently on Windows? > To clarify, I'm running Ubuntu 22.04 > > > > /workspace/build/tomcat/8.5.x/build/logs/TEST-org.apache.tomcat.websocket.TestWsWebSocketContainerSSL.NIO2.txt > > > > Testsuite: org.apache.tomcat.websocket.TestWsWebSocketContainerSSL > > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.864 sec > > - Standard Error - > > 09-Oct-2023 15:49:12.260 INFO [main] > > org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case > > [testConnectToServerEndpointSSL] > > 09-Oct-2023 15:49:13.038 INFO [main] > > org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler > > ["https-jsse-nio2-127.0.0.1-auto-1"] > > 09-Oct-2023 15:49:13.327 INFO [main] > > org.apache.tomcat.util.net.AbstractEndpoint.logCertificate Connector > > [https-jsse-nio2-127.0.0.1-auto-1], TLS virtual host [ > > _default_], certificate type [UNDEFINED] configured from keystore > > > [/workspace/src/tomcat/8.5.x/test/org/apache/tomcat/util/net/localhost-rsa.jks] > > using alias [t > > omcat] with trust store > > [/workspace/src/tomcat/8.5.x/test/org/apache/tomcat/util/net/ca.jks] > > 09-Oct-2023 15:49:13.341 INFO [main] > > org.apache.catalina.core.StandardService.startInternal Starting service > > [Tomcat] > > 09-Oct-2023 15:49:13.342 INFO [main] > > org.apache.catalina.core.StandardEngine.startInternal Starting Servlet > > engine: [Apache Tomcat/8.5.94] > > 09-Oct-2023 15:49:13.633 INFO [main] > > org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler > > ["https-jsse-nio2-127.0.0.1-auto-1-44075"] > > 09-Oct-2023 15:49:13.677 INFO [main] > > org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler > > ["https-jsse-nio2-127.0.0.1-auto-1-44075"] > > 09-Oct-2023 15:49:13.679 INFO [main] > > org.apache.catalina.core.StandardService.stopInternal Stopping service > > [Tomcat] > > 09-Oct-2023 15:49:13.696 INFO [main] > > org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler > > ["https-jsse-nio2-127.0.0.1-auto-1-44075"] > > 09-Oct-2023 15:49:13.702 INFO [main] > > org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler > > ["https-jsse-nio2-127.0.0.1-auto-1-44075"] > > - --- > > > > Testcase: testConnectToServerEndpointSSL took 1.793 sec > > Caused an ERROR > > The HTTP request to initiate the WebSocket connection to > > [wss://localhost:44075/echoAsync] failed > > javax.websocket.DeploymentException: The HTTP request to initiate the > > WebSocket connection to [wss://localhost:44075/echoAsync] failed > > at > > > org.apache.tomcat.websocket.WsWebSocketContainer.connectToServerRecursive(WsWebSocketContainer.java:428) > > > > at > > > org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer(WsWebSocketContainer.java:170) > > > > at > > > org.apache.tomcat.websocket.TestWsWebSocketContainerSSL.testConnectToServerEndpointSSL(TestWsWebSocketContainerSSL.java:64) > > > > Caused by: java.util.concurrent.ExecutionException: > > javax.net.ssl.SSLHandshakeException: No appropriate protocol (protocol is > > disabled or cipher suites are inap > > propriate) > > at > > > org.apache.tomcat.websocket.AsyncChannelWrapperSecure$WrapperFuture.get(AsyncChannelWrapperSecure.java:489) > > > > at > > > org.apache.tomcat.websocket.WsWebSocketContainer.connectToServerRecursive(WsWebSocketContainer.java:320) > > > > Caused by: javax.net.ssl.SSLHandshakeException: No appropriate protocol > > (protocol is disabled or cipher suites are inappropriate) > > at > > sun.security.ssl.HandshakeContext.(HandshakeContext.java:171) > >
Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]
Igal, On 10/9/23 18:53, Igal Sapir wrote: Chris, On Mon, Oct 9, 2023 at 3:22 PM Christopher Schultz < ch...@christopherschultz.net> wrote: Igal, On 10/9/23 18:13, Igal Sapir wrote: Chris, I'm getting some errors when I run `ant clean test` with Java 1.8.0_322 - any ideas? Yes, you will need to set some build properties. Have a look at this script and look ad what I do with the "opens": https://github.com/ChristopherSchultz/apache-tomcat-stuff/blob/master/bin/test-tomcat-release.sh#L269 OK, now I got two failures (details below): [concat] Testsuites with failed tests: [concat] TEST-org.apache.tomcat.util.net.jsse.TestPEMFile.NIO2.txt Hmm, I thought this was fixed for Java 8.something-earlier-than-yours. I'm using 1.8.0_372 on Linux and it passes all unit tests with this build.properties: base.path=/path/to/downloads execute.validate=true java.7.home=/usr/local/java-7 opens.javalang=-Dnop opens.javaio=-Dnop opens.sunrmi=-Dnop opens.javautil=-Dnop opens.javautilconcurrent=-Dnop test.openssl.unimplemented=IDEA test.openssl.loc=/path/to/openssl Maybe it behaves differently on Windows? /workspace/build/tomcat/8.5.x/build/logs/TEST-org.apache.tomcat.websocket.TestWsWebSocketContainerSSL.NIO2.txt Testsuite: org.apache.tomcat.websocket.TestWsWebSocketContainerSSL Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.864 sec - Standard Error - 09-Oct-2023 15:49:12.260 INFO [main] org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case [testConnectToServerEndpointSSL] 09-Oct-2023 15:49:13.038 INFO [main] org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler ["https-jsse-nio2-127.0.0.1-auto-1"] 09-Oct-2023 15:49:13.327 INFO [main] org.apache.tomcat.util.net.AbstractEndpoint.logCertificate Connector [https-jsse-nio2-127.0.0.1-auto-1], TLS virtual host [ _default_], certificate type [UNDEFINED] configured from keystore [/workspace/src/tomcat/8.5.x/test/org/apache/tomcat/util/net/localhost-rsa.jks] using alias [t omcat] with trust store [/workspace/src/tomcat/8.5.x/test/org/apache/tomcat/util/net/ca.jks] 09-Oct-2023 15:49:13.341 INFO [main] org.apache.catalina.core.StandardService.startInternal Starting service [Tomcat] 09-Oct-2023 15:49:13.342 INFO [main] org.apache.catalina.core.StandardEngine.startInternal Starting Servlet engine: [Apache Tomcat/8.5.94] 09-Oct-2023 15:49:13.633 INFO [main] org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler ["https-jsse-nio2-127.0.0.1-auto-1-44075"] 09-Oct-2023 15:49:13.677 INFO [main] org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler ["https-jsse-nio2-127.0.0.1-auto-1-44075"] 09-Oct-2023 15:49:13.679 INFO [main] org.apache.catalina.core.StandardService.stopInternal Stopping service [Tomcat] 09-Oct-2023 15:49:13.696 INFO [main] org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler ["https-jsse-nio2-127.0.0.1-auto-1-44075"] 09-Oct-2023 15:49:13.702 INFO [main] org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler ["https-jsse-nio2-127.0.0.1-auto-1-44075"] - --- Testcase: testConnectToServerEndpointSSL took 1.793 sec Caused an ERROR The HTTP request to initiate the WebSocket connection to [wss://localhost:44075/echoAsync] failed javax.websocket.DeploymentException: The HTTP request to initiate the WebSocket connection to [wss://localhost:44075/echoAsync] failed at org.apache.tomcat.websocket.WsWebSocketContainer.connectToServerRecursive(WsWebSocketContainer.java:428) at org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer(WsWebSocketContainer.java:170) at org.apache.tomcat.websocket.TestWsWebSocketContainerSSL.testConnectToServerEndpointSSL(TestWsWebSocketContainerSSL.java:64) Caused by: java.util.concurrent.ExecutionException: javax.net.ssl.SSLHandshakeException: No appropriate protocol (protocol is disabled or cipher suites are inap propriate) at org.apache.tomcat.websocket.AsyncChannelWrapperSecure$WrapperFuture.get(AsyncChannelWrapperSecure.java:489) at org.apache.tomcat.websocket.WsWebSocketContainer.connectToServerRecursive(WsWebSocketContainer.java:320) Caused by: javax.net.ssl.SSLHandshakeException: No appropriate protocol (protocol is disabled or cipher suites are inappropriate) at sun.security.ssl.HandshakeContext.(HandshakeContext.java:171) at sun.security.ssl.ClientHandshakeContext.(ClientHandshakeContext.java:103) at sun.security.ssl.TransportContext.kickstart(TransportContext.java:220) at sun.security.ssl.SSLEngineImpl.beginHandshake(SSLEngineImpl.java:97) at org.apache.tomcat.websocket.AsyncChannelWrapperSecure$WebSocketSslHandshakeThread.run(AsyncChannelWrapperSecure.java:347) This one I cannot explain at all. Which connector failed this test? APR, NIO, or NIO2. They should all behave the same way, so if one of them fails I'd expect the others to fail. So if one of
Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]
All, On 10/9/23 18:01, Christopher Schultz wrote: All, On 10/9/23 17:55, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.94 release is now available for voting. The notable changes compared to 8.5.93 are: - Update Tomcat Native to 1.2.39 to pick up Windows binaries built with OpenSSL 3.0.11. - Provide a lifecycle listener that will automatically reload TLS configurations a set time before the certificate is due to expire. This is intended to be used with third-party tools that regularly renew TLS certificates. - Improve performance of EL expressions in JSPs that use implicit objects. - Several improvements to thread safety and recycling cleanup. Along with lots of other bug fixes and improvements. For full details, see the changelog: https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.94/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1436 I had the Maven staging URL incorrect. Please use this one instead: https://repository.apache.org/content/repositories/orgapachetomcat-1457 The tag is: https://github.com/apache/tomcat/tree/8.5.94/ 36d4f7d698f71cd322204a3b242a97c54860fb8c The proposed 8.5.94 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.94 (stable) +1 for release stable. Works on a vanilla servlet-based application in a development environment. Some notes: checkstyle is unhappy about Java 8 again. I think we need to keep the checkstyle version low enough to allow a Java 8-based build. Though we always release using Java 11, the build should work for Java 8 so I think we need to downgrade checkstyle. There is no reason to stop the release for this. Details: * Environment * Java (build): openjdk version "1.8.0_372" OpenJDK Runtime Environment (Temurin)(build 1.8.0_372-b07) OpenJDK 64-Bit Server VM (Temurin)(build 25.372-b07, mixed mode) * Java (test): openjdk version "1.8.0_372" OpenJDK Runtime Environment (Temurin)(build 1.8.0_372-b07) OpenJDK 64-Bit Server VM (Temurin)(build 25.372-b07, mixed mode) * OS: Linux 6.1.0-12-amd64 x86_64 * cc: cc (Debian 12.2.0-14) 12.2.0 * make: GNU Make 4.3 * OpenSSL: OpenSSL 1.1.1 11 Sep 2018 * APR: 1.7.2 * * Valid SHA-512 signature for apache-tomcat-8.5.94.zip * Valid GPG signature for apache-tomcat-8.5.94.zip * Valid SHA-512 signature for apache-tomcat-8.5.94.tar.gz * Valid GPG signature for apache-tomcat-8.5.94.tar.gz * Valid SHA-512 signature for apache-tomcat-8.5.94.exe * Valid GPG signature for apache-tomcat-8.5.94.exe * Valid Windows Digital Signature for apache-tomcat-8.5.94.exe * Valid SHA512 signature for apache-tomcat-8.5.94-src.zip * Valid GPG signature for apache-tomcat-8.5.94-src.zip * Valid SHA512 signature for apache-tomcat-8.5.94-src.tar.gz * Valid GPG signature for apache-tomcat-8.5.94-src.tar.gz * * Binary Zip and tarball: Same * Source Zip and tarball: Same * * Building dependencies returned: 0 * tcnative builds cleanly * Tomcat builds cleanly * Junit Tests: PASSED - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]
Chris, On Mon, Oct 9, 2023 at 3:22 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > Igal, > > On 10/9/23 18:13, Igal Sapir wrote: > > Chris, > > > > I'm getting some errors when I run `ant clean test` with Java 1.8.0_322 - > > any ideas? > > Yes, you will need to set some build properties. Have a look at this > script and look ad what I do with the "opens": > > > https://github.com/ChristopherSchultz/apache-tomcat-stuff/blob/master/bin/test-tomcat-release.sh#L269 OK, now I got two failures (details below): [concat] Testsuites with failed tests: [concat] TEST-org.apache.tomcat.util.net.jsse.TestPEMFile.NIO2.txt [concat] TEST-org.apache.tomcat.websocket.TestWsWebSocketContainerSSL.NIO2.txt ❯ cat /workspace/build/tomcat/8.5.x/build/logs/TEST-org.apache.tomcat.util.net.jsse.TestPEMFile.NIO2.txt Testsuite: org.apache.tomcat.util.net.jsse.TestPEMFile Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.569 sec Testcase: testKeyEncryptedPkcs1DesEde3Cbc took 0.264 sec Testcase: testKeyPkcs1WithUnnecessaryPassword took 0.013 sec Testcase: testKeyEncryptedPkcs8 took 0.202 sec Caused an ERROR Cannot retrieve the PKCS8EncodedKeySpec java.security.spec.InvalidKeySpecException: Cannot retrieve the PKCS8EncodedKeySpec at javax.crypto.EncryptedPrivateKeyInfo.getKeySpec(EncryptedPrivateKeyInfo.java:258) at org.apache.tomcat.util.net.jsse.PEMFile$Part.toPrivateKey(PEMFile.java:228) at org.apache.tomcat.util.net.jsse.PEMFile.(PEMFile.java:153) at org.apache.tomcat.util.net.jsse.PEMFile.(PEMFile.java:102) at org.apache.tomcat.util.net.jsse.PEMFile.(PEMFile.java:97) at org.apache.tomcat.util.net.jsse.TestPEMFile.testKey(TestPEMFile.java:79) at org.apache.tomcat.util.net.jsse.TestPEMFile.testKeyEncrypted(TestPEMFile.java:74) at org.apache.tomcat.util.net.jsse.TestPEMFile.testKeyEncryptedPkcs8(TestPEMFile.java:69) Caused by: javax.crypto.BadPaddingException: Given final block not properly padded. Such issues can arise if a bad key is used during decryption. at com.sun.crypto.provider.CipherCore.unpad(CipherCore.java:975) at com.sun.crypto.provider.CipherCore.fillOutputBuffer(CipherCore.java:1056) at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:853) at com.sun.crypto.provider.PBES2Core.engineDoFinal(PBES2Core.java:323) at javax.crypto.Cipher.doFinal(Cipher.java:2168) at javax.crypto.EncryptedPrivateKeyInfo.getKeySpec(EncryptedPrivateKeyInfo.java:253) Testcase: testKeyPkcs1 took 0.001 sec Testcase: testKeyEncryptedPkcs1Aes256 took 0.025 sec Testcase: testKeyEncryptedPkcs1DesCbc took 0.007 sec ❯ cat /workspace/build/tomcat/8.5.x/build/logs/TEST-org.apache.tomcat.websocket.TestWsWebSocketContainerSSL.NIO2.txt Testsuite: org.apache.tomcat.websocket.TestWsWebSocketContainerSSL Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.864 sec - Standard Error - 09-Oct-2023 15:49:12.260 INFO [main] org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case [testConnectToServerEndpointSSL] 09-Oct-2023 15:49:13.038 INFO [main] org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler ["https-jsse-nio2-127.0.0.1-auto-1"] 09-Oct-2023 15:49:13.327 INFO [main] org.apache.tomcat.util.net.AbstractEndpoint.logCertificate Connector [https-jsse-nio2-127.0.0.1-auto-1], TLS virtual host [ _default_], certificate type [UNDEFINED] configured from keystore [/workspace/src/tomcat/8.5.x/test/org/apache/tomcat/util/net/localhost-rsa.jks] using alias [t omcat] with trust store [/workspace/src/tomcat/8.5.x/test/org/apache/tomcat/util/net/ca.jks] 09-Oct-2023 15:49:13.341 INFO [main] org.apache.catalina.core.StandardService.startInternal Starting service [Tomcat] 09-Oct-2023 15:49:13.342 INFO [main] org.apache.catalina.core.StandardEngine.startInternal Starting Servlet engine: [Apache Tomcat/8.5.94] 09-Oct-2023 15:49:13.633 INFO [main] org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler ["https-jsse-nio2-127.0.0.1-auto-1-44075"] 09-Oct-2023 15:49:13.677 INFO [main] org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler ["https-jsse-nio2-127.0.0.1-auto-1-44075"] 09-Oct-2023 15:49:13.679 INFO [main] org.apache.catalina.core.StandardService.stopInternal Stopping service [Tomcat] 09-Oct-2023 15:49:13.696 INFO [main] org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler ["https-jsse-nio2-127.0.0.1-auto-1-44075"] 09-Oct-2023 15:49:13.702 INFO [main] org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler ["https-jsse-nio2-127.0.0.1-auto-1-44075"] - --- Testcase: testConnectToServerEndpointSSL took 1.793 sec Caused an ERROR The HTTP request to initiate the WebSocket connection to [wss://localhost:44075/echoAsync] failed javax.websocket.DeploymentException: The HTTP request to initiate the WebSocket connection to [wss://localhost:44075/echoAsync]
Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]
Igal, On 10/9/23 18:13, Igal Sapir wrote: Chris, I'm getting some errors when I run `ant clean test` with Java 1.8.0_322 - any ideas? Yes, you will need to set some build properties. Have a look at this script and look ad what I do with the "opens": https://github.com/ChristopherSchultz/apache-tomcat-stuff/blob/master/bin/test-tomcat-release.sh#L269 -chris test-nio2: [junit] Unrecognized option: --add-opens=java.base/java.lang=ALL-UNNAMED [junit] Error: Could not create the Java Virtual Machine. [junit] Error: A fatal exception has occurred. Program will exit. [junit] Unrecognized option: --add-opens=java.base/java.lang=ALL-UNNAMED [junit] Error: Could not create the Java Virtual Machine. [junit] Error: A fatal exception has occurred. Program will exit. [junit] Unrecognized option: --add-opens=java.base/java.lang=ALL-UNNAMED [junit] Error: Could not create the Java Virtual Machine. [junit] Unrecognized option: --add-opens=java.base/java.lang=ALL-UNNAMED [junit] Error: Could not create the Java Virtual Machine. [junit] Error: A fatal exception has occurred. Program will exit. [junit] Error: A fatal exception has occurred. Program will exit. [junit] Unrecognized option: --add-opens=java.base/java.lang=ALL-UNNAMED [junit] Error: Could not create the Java Virtual Machine. [junit] Error: A fatal exception has occurred. Program will exit. [junit] Unrecognized option: --add-opens=java.base/java.lang=ALL-UNNAMED [junit] Error: Could not create the Java Virtual Machine. [junit] Error: A fatal exception has occurred. Program will exit. [junit] Running javax.el.TestArrayELResolver in thread 1 [junit] Running javax.el.TestBeanELResolver in thread 2 [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec, Thread: 1, Class: javax.el.TestArrayELResolver [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec, Thread: 2, Class: javax.el.TestBeanELResolver [junit] Test javax.el.TestArrayELResolver FAILED (crashed) [junit] Test javax.el.TestBeanELResolver FAILED (crashed) [junit] Running javax.el.TestBeanNameELResolver in thread 4 [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec, Thread: 4, Class: javax.el.TestBeanNameELResolver [junit] Test javax.el.TestBeanNameELResolver FAILED (crashed) [junit] Running javax.el.TestELContext in thread 6 [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec, Thread: 6, Class: javax.el.TestELContext [junit] Test javax.el.TestELContext FAILED (crashed) BUILD FAILED /workspace/src/tomcat/8.5.x/build.xml:1544: The following error occurred while executing this line: /workspace/src/tomcat/8.5.x/build.xml:1594: Context loader has not been reset Total time: 18 seconds Igal On Mon, Oct 9, 2023 at 3:02 PM Christopher Schultz < ch...@christopherschultz.net> wrote: All, On 10/9/23 17:55, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.94 release is now available for voting. The notable changes compared to 8.5.93 are: - Update Tomcat Native to 1.2.39 to pick up Windows binaries built with OpenSSL 3.0.11. - Provide a lifecycle listener that will automatically reload TLS configurations a set time before the certificate is due to expire. This is intended to be used with third-party tools that regularly renew TLS certificates. - Improve performance of EL expressions in JSPs that use implicit objects. - Several improvements to thread safety and recycling cleanup. Along with lots of other bug fixes and improvements. For full details, see the changelog: https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.94/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1436 I had the Maven staging URL incorrect. Please use this one instead: https://repository.apache.org/content/repositories/orgapachetomcat-1457 The tag is: https://github.com/apache/tomcat/tree/8.5.94/ 36d4f7d698f71cd322204a3b242a97c54860fb8c The proposed 8.5.94 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.5.94 (stable) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]
Chris, I'm getting some errors when I run `ant clean test` with Java 1.8.0_322 - any ideas? test-nio2: [junit] Unrecognized option: --add-opens=java.base/java.lang=ALL-UNNAMED [junit] Error: Could not create the Java Virtual Machine. [junit] Error: A fatal exception has occurred. Program will exit. [junit] Unrecognized option: --add-opens=java.base/java.lang=ALL-UNNAMED [junit] Error: Could not create the Java Virtual Machine. [junit] Error: A fatal exception has occurred. Program will exit. [junit] Unrecognized option: --add-opens=java.base/java.lang=ALL-UNNAMED [junit] Error: Could not create the Java Virtual Machine. [junit] Unrecognized option: --add-opens=java.base/java.lang=ALL-UNNAMED [junit] Error: Could not create the Java Virtual Machine. [junit] Error: A fatal exception has occurred. Program will exit. [junit] Error: A fatal exception has occurred. Program will exit. [junit] Unrecognized option: --add-opens=java.base/java.lang=ALL-UNNAMED [junit] Error: Could not create the Java Virtual Machine. [junit] Error: A fatal exception has occurred. Program will exit. [junit] Unrecognized option: --add-opens=java.base/java.lang=ALL-UNNAMED [junit] Error: Could not create the Java Virtual Machine. [junit] Error: A fatal exception has occurred. Program will exit. [junit] Running javax.el.TestArrayELResolver in thread 1 [junit] Running javax.el.TestBeanELResolver in thread 2 [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec, Thread: 1, Class: javax.el.TestArrayELResolver [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec, Thread: 2, Class: javax.el.TestBeanELResolver [junit] Test javax.el.TestArrayELResolver FAILED (crashed) [junit] Test javax.el.TestBeanELResolver FAILED (crashed) [junit] Running javax.el.TestBeanNameELResolver in thread 4 [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec, Thread: 4, Class: javax.el.TestBeanNameELResolver [junit] Test javax.el.TestBeanNameELResolver FAILED (crashed) [junit] Running javax.el.TestELContext in thread 6 [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec, Thread: 6, Class: javax.el.TestELContext [junit] Test javax.el.TestELContext FAILED (crashed) BUILD FAILED /workspace/src/tomcat/8.5.x/build.xml:1544: The following error occurred while executing this line: /workspace/src/tomcat/8.5.x/build.xml:1594: Context loader has not been reset Total time: 18 seconds Igal On Mon, Oct 9, 2023 at 3:02 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > All, > > On 10/9/23 17:55, Christopher Schultz wrote: > > The proposed Apache Tomcat 8.5.94 release is now available for voting. > > > > The notable changes compared to 8.5.93 are: > > > > - Update Tomcat Native to 1.2.39 to pick up Windows binaries built with > >OpenSSL 3.0.11. > > > > - Provide a lifecycle listener that will automatically reload TLS > >configurations a set time before the certificate is due to expire. > >This is intended to be used with third-party tools that regularly > >renew TLS certificates. > > > > - Improve performance of EL expressions in JSPs that use implicit > >objects. > > > > - Several improvements to thread safety and recycling cleanup. > > > > Along with lots of other bug fixes and improvements. > > > > For full details, see the changelog: > > https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html > > > > It can be obtained from: > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.94/ > > > > The Maven staging repo is: > > https://repository.apache.org/content/repositories/orgapachetomcat-1436 > > I had the Maven staging URL incorrect. Please use this one instead: > https://repository.apache.org/content/repositories/orgapachetomcat-1457 > > > The tag is: > > https://github.com/apache/tomcat/tree/8.5.94/ > > 36d4f7d698f71cd322204a3b242a97c54860fb8c > > > > The proposed 8.5.94 release is: > > [ ] Broken - do not release > > [ ] Stable - go ahead and release as 8.5.94 (stable) > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]
All, On 10/9/23 17:55, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.94 release is now available for voting. The notable changes compared to 8.5.93 are: - Update Tomcat Native to 1.2.39 to pick up Windows binaries built with OpenSSL 3.0.11. - Provide a lifecycle listener that will automatically reload TLS configurations a set time before the certificate is due to expire. This is intended to be used with third-party tools that regularly renew TLS certificates. - Improve performance of EL expressions in JSPs that use implicit objects. - Several improvements to thread safety and recycling cleanup. Along with lots of other bug fixes and improvements. For full details, see the changelog: https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.94/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1436 I had the Maven staging URL incorrect. Please use this one instead: https://repository.apache.org/content/repositories/orgapachetomcat-1457 The tag is: https://github.com/apache/tomcat/tree/8.5.94/ 36d4f7d698f71cd322204a3b242a97c54860fb8c The proposed 8.5.94 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.5.94 (stable) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
