Re: [VOTE] Release build 4.1.40 - Take 2
[X] Stable Filip Mark Thomas wrote: The (updated) candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ According to the release process, the release based on the 4.0.40 tag is: [ ] Broken [ ] Alpha [ ] Beta Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 4.1.40 - Take 2 - more votes please
Mark Thomas wrote: The (updated) candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ According to the release process, the release based on the 4.0.40 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Folks, So far there have been 2 +1's from PMC members and a +1 from Konstantin. We need at least one more +1 from a PMC member before this release can be considered official. Any and all votes gratefully appreciated. Mark Note: Konstantin and Sebb have identifided some minor issues that I will fix in svn once the release process is over. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 4.1.40 - Take 2
2009/6/16 Mark Thomas ma...@apache.org: The (updated) candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ Minor issues: a) When installing apache-tomcat-4.1.40.exe, the installer dialog page that allows to specify port number and name/password for the administrative user has wrong dimensions for those three input fields. It looks like their height is twice than necessary. They do work. It is just their look that is strange. b) Tomcat Home Page shortcut, created in the Programs menu by the Windows installer, points to http://jakarta.apache.org/tomcat c) http://localhost:8080/examples/jsp/cal/login.html http://localhost:8080/examples/jsp/cal/calendar.html These two pages display license text on top of the page That license comment should be !-- .. --, not /* ... */ d) http://localhost:8080/examples/jsp/snp/snoop.html The show source link is incorrect and images in the right top corner do not load (the links on them are ok). The source link: Wrong one: http://localhost:8080/examples/jsp/snp/snoop.jsp.html Should be: http://localhost:8080/examples/jsp/snp/snoop.txt The images: Wrong srcs: http://localhost:8080/examples/jsp/images/return.gif http://localhost:8080/examples/jsp/images/execute.gif Should be: http://localhost:8080/examples/images/return.gif http://localhost:8080/examples/images/execute.gif e) There could be %@ page session=false % in ROOT/index.jsp, like in TC 5.5 and later. Open a browser, and visit the following three pages, in order: http://localhost:8080/index.jsp http://localhost:8080/examples/servlet/SessionExample http://localhost:8080/examples/servlet/CookieExample The CookieExample page shows that there are two session cookies sent by the browser. I have not noticed any problems because of this extra session cookie. Changing the ROOT/index.jsp as I wrote, removes this extra cookie. f) http://localhost:8080/index.jsp Copyright years in the bottom right corner of the page could be 1999-2009, not -2002. g) exe installers do not install RELEASE-NOTES-4.1.txt file, neither in the root folder nor into the docs. (The rest of *.txt files are present in tomcat-docs webapp). Though, to be fair, if you select option to install TC sources, you will get it in src/container. From what I see in the sources, it is not a build error that this file is missing, It is just how it is implemented. All examples do work. Admin and manager applications do work. Zip and tgz distributions match each other. None of the above mentioned glitches affects Tomcat functionality. My vote: According to the release process, the release based on the 4.0.40 tag is: [x] Stable Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 4.1.40 - Take 2
On 16/06/2009, Mark Thomas ma...@apache.org wrote: The (updated) candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ According to the release process, the release based on the 4.0.40 tag is: Did you mean 4.1.40? Also, where can I find the tag? [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 4.1.40 - Take 2
sebb wrote: On 16/06/2009, Mark Thomas ma...@apache.org wrote: The (updated) candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ According to the release process, the release based on the 4.0.40 tag is: Did you mean 4.1.40? Yes. Also, where can I find the tag? It is actually 4 tags (the joys of the Tomcat 4 build process): http://svn.apache.org/repos/asf/tomcat/connectors/tags/tc4.1.x/TOMCAT_4_1_40/ http://svn.apache.org/repos/asf/tomcat/container/tags/tc4.1.x/TOMCAT_4_1_40/ http://svn.apache.org/repos/asf/tomcat/jasper/tags/tc4.1.x/TOMCAT_4_1_40/ http://svn.apache.org/repos/asf/tomcat/servletapi/tags/servlet2.3-jsp1.2-tc4.x/TOMCAT_4_1_40/ Mark [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 4.1.40 - Take 2
On 19/06/2009, Mark Thomas ma...@apache.org wrote: sebb wrote: On 16/06/2009, Mark Thomas ma...@apache.org wrote: The (updated) candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ According to the release process, the release based on the 4.0.40 tag is: Did you mean 4.1.40? Yes. Also, where can I find the tag? It is actually 4 tags (the joys of the Tomcat 4 build process): http://svn.apache.org/repos/asf/tomcat/connectors/tags/tc4.1.x/TOMCAT_4_1_40/ http://svn.apache.org/repos/asf/tomcat/container/tags/tc4.1.x/TOMCAT_4_1_40/ http://svn.apache.org/repos/asf/tomcat/jasper/tags/tc4.1.x/TOMCAT_4_1_40/ http://svn.apache.org/repos/asf/tomcat/servletapi/tags/servlet2.3-jsp1.2-tc4.x/TOMCAT_4_1_40/ Thanks, I used the following SVN URLs + revisions: http://svn.apache.org/repos/asf/tomcat/connectors/tags/tc4.1.x/TOMCAT_4_1_40 Last Changed Rev: 784715 http://svn.apache.org/repos/asf/tomcat/container/tags/tc4.1.x/TOMCAT_4_1_40 Last Changed Rev: 785257 http://svn.apache.org/repos/asf/tomcat/jasper/tags/tc4.1.x/TOMCAT_4_1_40 Last Changed Rev: 784716 http://svn.apache.org/repos/asf/tomcat/servletapi/tags/servlet2.3-jsp1.2-tc4.x/TOMCAT_4_1_40 Last Changed Rev: 784717 The source archives mostly agree with the tags, however there are code changes in the following files: connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java connectors/util/java/org/apache/tomcat/util/buf/CharChunk.java connectors/util/java/org/apache/tomcat/util/http/ServerCookie.java [I can provide a diff listing if required] The tags really ought to agree with the source archive. Unfortunately, I think I have found another problem, which is that the README file needs to mention the TSU exception: http://www.apache.org/dev/crypto.html#inform [This presumably applies to all the later Tomcat versions as well] Sorry, I should have noticed this before as IMO it is a release blocker. There ought really to be NOTICE files alongside the LICENSE files in the jasper and servletapi SVN trees (SVN is a form of distribution). Mark [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 4.1.40 - Take 2
sebb wrote: The source archives mostly agree with the tags, however there are code changes in the following files: connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java connectors/util/java/org/apache/tomcat/util/buf/CharChunk.java connectors/util/java/org/apache/tomcat/util/http/ServerCookie.java That happens automatically as part of the build process and is expected. [I can provide a diff listing if required] No need, I know exactly what has changed in those files. Unfortunately, I think I have found another problem, which is that the README file needs to mention the TSU exception: http://www.apache.org/dev/crypto.html#inform [This presumably applies to all the later Tomcat versions as well] Sorry, I should have noticed this before as IMO it is a release blocker. Having read http://www.apache.org/dev/crypto.html#inform, it makes clear that this requirement is quoteself imposed/quote. Therefore I propose that we take a little bit of latitude and do the following (assuming this gets the votes to pass) - include the text in the announcement e-mail - add the text to the README (post tag) - put the updated README in the download directory (currently it just includes the release notes) I think this meets the spirit of our self-imposed requirement without needing to re-roll the release. What I will do is update those read me files now, so the changes are in place for the next releases. There ought really to be NOTICE files alongside the LICENSE files in the jasper and servletapi SVN trees (SVN is a form of distribution). I think that is a grey area. I see where you are coming from but I don't propose to do anything about this for the 4.1.40 release. Post the svn re-org that will follow the final 4.1.x release, we can revisit that. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 4.1.40 - Take 2
Mark Thomas wrote: The (updated) candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ According to the release process, the release based on the 4.0.40 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable [x] Stable Tested on Linux and Windows. Regards -- ^(TM) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 4.1.40
The copyright year in the NOTICE files in the binary archive is still 2008; surely it should be 2009? The connectors/NOTICE file in the source archive is wrong. There are no NOTICE files for the jasper and servletapi directory sub-trees. It would be better to have a single NL file at the top of the directory structure, but failing that, each sub-tree needs the proper NL files. The binary tgz and zip archives agree with each other. The source tgz and zip archives are different. The binary files (*.exe and *.bin) are corrupted in the tgz archive. Also there are additional EOLs at the end of many source files in the tgz archive. There seems to be a bug in the packaging of the source files in the tar.gz format. The apache-tomcat-4.1.40.exe fails for me when trying to install a Full release on WinXP: It starts by saying it has found a Java development kit, but later on fails with the message: Couldn't find a Java development kit on this computer. Please download one from http://java.sun.com/ The last line in the installer dialogue is Created uninstaller: ... There seem to be a lot of files missing from the installation compared with the binary zip archive, but that is probably due to the premature failure of the installation. IMO the release is broken. On 16/06/2009, Mark Thomas ma...@apache.org wrote: The candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ According to the release process, the 4.0.40 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 4.1.40
sebb wrote: The copyright year in the NOTICE files in the binary archive is still 2008; surely it should be 2009? Yep, it should be 2009. This has been fixed. The connectors/NOTICE file in the source archive is wrong. There are no NOTICE files for the jasper and servletapi directory sub-trees. It would be better to have a single NL file at the top of the directory structure, but failing that, each sub-tree needs the proper NL files. That is a lingering side-effect of when we had multiple CVS trees. The files used for 4.1.x are the ones in the container sub-directory. While this is clear in the binaries, I agree it could be clearer in the source distributions. Copying them to the root of the source distro seems like the simplest solution to me. This has been fixed. The binary tgz and zip archives agree with each other. The source tgz and zip archives are different. The binary files (*.exe and *.bin) are corrupted in the tgz archive. Also there are additional EOLs at the end of many source files in the tgz archive. There seems to be a bug in the packaging of the source files in the tar.gz format. Looks like the binary files have always been that way. I copied an updated exclusion list from TC6 and added one final exclusion that a diff with winmerge found. The extra line is the same issue as TC6 - again I ported the fix. The apache-tomcat-4.1.40.exe fails for me when trying to install a Full release on WinXP: It starts by saying it has found a Java development kit, but later on fails with the message: Couldn't find a Java development kit on this computer. Please download one from http://java.sun.com/ The last line in the installer dialogue is Created uninstaller: ... Hmm. The installer works for me on a fairly clean 32-bit XP SP2 vm image. Which JDK does it find and where does it find it? Is it a valid JDK? I'm leaning towards this being an isolated rather than a general issue. There seem to be a lot of files missing from the installation compared with the binary zip archive, but that is probably due to the premature failure of the installation. Probably. IMO the release is broken. If the windows installer issue is an isolated one it, the release is no worse than any that have gone out of the door previously. That said, the issues are all fixed so I'll roll a 4.1.41 release. Before I do that, I'd really like to get to the bottom of the issues you are seeing with the installer. Mark On 16/06/2009, Mark Thomas ma...@apache.org wrote: The candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ According to the release process, the 4.0.40 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 4.1.40
Mark Thomas wrote: IMO the release is broken. If the windows installer issue is an isolated one it, the release is no worse than any that have gone out of the door previously. That said, the issues are all fixed so I'll roll a 4.1.41 release. Why not just re-tagging? It's no like it was released and picked up by the mirrors, and we already said 4.1.40 will be the last one :) Regards -- ^(TM) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 4.1.40
Mladen Turk wrote: Mark Thomas wrote: IMO the release is broken. If the windows installer issue is an isolated one it, the release is no worse than any that have gone out of the door previously. That said, the issues are all fixed so I'll roll a 4.1.41 release. Why not just re-tagging? It's no like it was released and picked up by the mirrors, and we already said 4.1.40 will be the last one :) True. And the various security announcements all say upgrade to 4.1.40 when released too. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
