On 07/04/2020 09:40, Emmanuel Bourg wrote:
> Le 07/04/2020 à 10:12, Mark Thomas a écrit :
>
>> The dependencies are only embedded to create a single JAR to make it
>> easier for users to use on the command line. If the code was re-used I'd
>> expect the "standard" JAR to be used and leave the
Le 07/04/2020 à 10:12, Mark Thomas a écrit :
> The dependencies are only embedded to create a single JAR to make it
> easier for users to use on the command line. If the code was re-used I'd
> expect the "standard" JAR to be used and leave the decision on how to
> handle the dependencies up to
On 06/04/2020 17:45, Emmanuel Bourg wrote:
> Le 06/04/2020 à 18:33, Mark Thomas a écrit :
>
>> OK. But that is still 7.2k of classes rather than 2.4k of classes for
>> zero benefit.
>>
>> I'll withdraw my -1 because we are approaching the point where the
>> differences aren't worth the time spent
Le 06/04/2020 à 18:33, Mark Thomas a écrit :
> OK. But that is still 7.2k of classes rather than 2.4k of classes for
> zero benefit.
>
> I'll withdraw my -1 because we are approaching the point where the
> differences aren't worth the time spent discussing them but I still
> don't like this
On 06/04/2020 17:18, Emmanuel Bourg wrote:
> Le 06/04/2020 à 17:50, Mark Thomas a écrit :
>
>>> from 5c96c0b Ignore the IntelliJ project files
>>> new 29ea189 Replaced NonClosing{In,Out}putStream with the equivalent
>>> classes from Commons IO
>>
>> -1. It adds 220k of bloat for no
Le 06/04/2020 à 17:50, Mark Thomas a écrit :
>> from 5c96c0b Ignore the IntelliJ project files
>> new 29ea189 Replaced NonClosing{In,Out}putStream with the equivalent
>> classes from Commons IO
>
> -1. It adds 220k of bloat for no benefit.
No the dependencies are shaded with the
On 06/04/2020 14:34, ebo...@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> ebourg pushed a change to branch master
> in repository
> https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git.
>
>
> from 5c96c0b Ignore the IntelliJ
