Ok. I get it. I'll close it.
Thank you, Romain.
On Sun, Aug 6, 2017 at 11:05 AM, Romain Manni-Bucau
wrote:
> Le 6 août 2017 14:12, "Daniel Cunha" a écrit :
>
> Hi Romain,
>
> Well, I see that:
>
Hi Romain,
Well, I see that:
Https://github.com/apache/tomee/blob/master/tomee/tomee-common/src/main/java/org/apache/tomee/installer/Installer.java#L729
So, do we forget the '\ n' on the previous line? It seems that this is
already expected to be true by default. So make sense we have that:
Hi Romain,
well, I get it. But If you don't want the defaults resources then I'll set
the flag to false. The server should always start with default resource
IMHO.
On Sun, Aug 6, 2017 at 4:35 AM, Romain Manni-Bucau
wrote:
> Hi Daniel
>
> The side note here is: having
Hi Daniel
The side note here is: having them by default was intended cause it breaks
tomee deeply in term of resource matching and user existing config. Idea
was to set the flag if you want ee7 behavior to stay backward compat (and
this solution is fine for a EE container).
Le 6 août 2017
Can you add a test? Other than that, they should be good.
Thanks
Jon
On 6 Aug 2017 1:06 am, "Daniel Cunha" wrote:
Hi folks,
I started some works with concurrency API and got some troubles with
default resources, let me know what do you think about my PRs:
Hi folks,
I started some works with concurrency API and got some troubles with
default resources, let me know what do you think about my PRs:
https://github.com/apache/tomee/pull/102
https://github.com/apache/tomee/pull/103
Best regard.
--
Daniel Cunha
https://twitter.com/dvlc_