Re: Pull Request Builder on Apache Jenkins

2017-08-08 Thread Volz, Dylan (Contractor)
Perhaps it could check for WIP prefix to prevent noisy(?) failures on incomplete work? On 8/8/17, 3:39 PM, "Dan Kirkwood" wrote: Hi all... We have projects in the Apache Jenkins server under this folder: https://builds.apache.org/view/S-Z/view/TrafficControl/ I've added a new

Re: Traffic Ops Rewrite Golang Dependency - sqlx

2017-09-12 Thread Volz, Dylan (Contractor)
It would be maintaining about a 1500 line codebase (excluding tests with ~70% coverage), it uses reflection and tag introspection so it isn’t the simplest go code but it does seem to be well commented. On 9/12/17, 6:36 PM, "Gelinas, Derek" wrote: After looking at the code, and given the wo

Re: Traffic Ops Rewrite Golang Dependency - sqlx

2017-09-13 Thread Volz, Dylan (Contractor)
>> write, >>> debug, and maintain. >>> >>> Is standard Go really that much more difficult to write? The above is one >>> of the worst cases (along with Deliveryservices), most of our tables >> aren't >

Re: Traffic Ops Rewrite Golang Dependency - sqlx

2017-09-13 Thread Volz, Dylan (Contractor)
; nearly that big. It doesn't seem likely to cause bugs, any mismatches > > should be immediately caught when running the first time, and certainly > by > > the tests we've been mandating. > > > > I'm not wholesale against third-party libr

Re: Traffic Ops Rewrite Golang Dependency - sqlx

2017-09-13 Thread Volz, Dylan (Contractor)
that isn't available in the standard `sql` library, and would definitely justify the inclusion of `sqlx`. I don't think that's something we really want, though, because we control the sql statements. On Wed, Sep 13, 2017 at 8:54 AM, Volz, Dylan (Contractor) <