Re: API Proposal: TSThreadSetCancelState, TSThreadSetCancelType, TSThreadCancel, TSThreadJoin

2019-02-28 Thread James Peach
> On Feb 28, 2019, at 9:17 AM, Fei Deng wrote: > > void TSThreadSetCancelState(TSThread thread, int state); > void TSThreadSetCancelType(TSThread thread, int type); I guess you are supposed to pass PTHREAD_CANCEL_* for type type parameter? I don't like how this leaks the pthread implementati

Re: [PROPOSAL] Move from the IRC to Slack

2019-05-11 Thread James Peach
> On May 12, 2019, at 4:57 AM, Evan Zelkowitz wrote: > > +1 > > Though it would be nice if there was an easier way to get new people > in rather than having to manually invite them. My only worry is people > who just want to ask a question dont have an easy way to be able to > get in. So mayb

Re: [PROPOSAL] Move from the IRC to Slack

2019-05-11 Thread James Peach
be able to join and participate unless they have some out of band way to ask for an invite? If that’s the case, I don’t think this is a good idea. > > Cheers, > > — Leif > > >> On May 11, 2019, at 23:26, James Peach wrote: >> >> >> >>&g

Re: [PROPOSAL] Rename ssl_server_name.yaml to sni.yaml

2019-05-30 Thread James Peach
> On May 31, 2019, at 9:39 AM, Randall Meyer > wrote: > > I'd like to rename ssl_server_name.yaml to sni.yaml for ATS 9. This would > also affect the toplevel key in the yaml config file (making the contents > rooted under "sni"). The code/classes it is used to configure is SNIConfig. > An

Re: Proposal for TS API in 9.2.1: Remove TSSslSecretXxx functions

2023-04-26 Thread James Peach
> On 25 Apr 2023, at 1:01 pm, Walt Karas wrote: > > https://github.com/apache/trafficserver/pull/9587 indicates they do not > work. There are no definite plans to fix them. So, seems they are > unlikely to be fixed before the release of 9.2.1. Fixing or removing them > in 10.0 is a related

Re: [E] Proposal for TS API in 9.2.1: Remove TSSslSecretXxx functions

2023-04-26 Thread James Peach
ugh. The link to #9587 in your original email wasn’t enough for me :) > > On Wed, Apr 26, 2023 at 9:48 PM James Peach wrote: > >> >> >>> On 25 Apr 2023, at 1:01 pm, Walt Karas >> wrote: >>> >>> >> https://urldefense

Re: [E] Proposal for TS API in 9.2.1: Remove TSSslSecretXxx functions

2023-04-27 Thread James Peach
saw a comment from Susan that said Y! have production plugins using these APIs? > > On Thu, Apr 27, 2023 at 12:17 AM James Peach wrote: > >> >> >>> On 27 Apr 2023, at 1:52 pm, Walt Karas >> wrote: >>> >>> Everything I know is in this

Re: [Discussion/Proposal] Regex support in sni.yaml

2023-06-18 Thread James Peach
IIUC, the regex is used to match a policy configuration based on the requested hostname (either inbound or outbound). This means that the matching doesn’t need to be constrained by wildcard certificate semantics. It’s not made explicit in the documentation, but it looks like the policy match de

Re: [Discussion/Proposal] Regex support in sni.yaml

2023-06-19 Thread James Peach
"susan.swoc.io" and "amc.swoc.io"). Yup there are various ways to redesign the feature to improve lookup performance, but I expect they would all be breaking changes to existing config. > -Original Message- > From: James Peach > Sent: Monday, June 19, 2023 1

Re: [proposal] Minimum supported version for openssl is 1.1.1 for ATS 10.

2023-06-24 Thread James Peach
> On 24 Jun 2023, at 2:52 am, Chris McFarlen wrote: > > As part of updating the build system to cmake we are looking for areas to > simplify the build. One area could be the conditional checks and preprocessor > defines around features added to openssl on or before 1.1.1. This email is to >

Re: [proposal] Minimum supported version for openssl is 1.1.1 for ATS 10.

2023-06-24 Thread James Peach
somewhere listing the current minimum versions? > > — Leif > > > >> On Jun 24, 2023, at 20:41, James Peach wrote: >> >>  >> >>> On 24 Jun 2023, at 2:52 am, Chris McFarlen wrote: >>> >>> As part of updating the build system

Re: TS API Proposal: TS_FETCH_FLAGS_SKIP_REMAP

2023-08-06 Thread James Peach
> On 4 Aug 2023, at 1:45 am, Masakazu Kitajo wrote: > > Hi, > > I'd like to propose a new flag for FetchSM that'd allow making HTTP > requests for other servers without remap rules regardless of ATS > configuration (proxy.config.url_remap.remap_required). Could you achieve the same result m

Re: [E] Proposal: make utilities declared in Cleanup.h part of TS API

2023-09-02 Thread James Peach
> On 2 Sep 2023, at 3:44 am, Masakazu Kitajo wrote: > >> Its a judgement call, how much to minimize the API. > > Yes, that's why we send API proposals on the dev list. And I don't think > I'm absolutely right. If we, as a community, want to have utilities as TS > API, that's what we should do.

Re: Proposal: TS API: Don' t require a DbgCtl instance of have a tag when constructed.

2023-09-07 Thread James Peach
> On 6 Sep 2023, at 10:30 am, Walt Karas wrote: > > See https://github.com/apache/trafficserver/pull/10375 . There’s no description either here or in the PR; could you please explain the use case for this? thanks, James

Re: Vote: Remove autotools build files from the repository (ATS 10)

2023-10-19 Thread James Peach
Could you please summarize the current state of the cmake work? Is there any documentation for users of how to switch from autotools to cmake? Are there any autotools build features that are not supported in cmake? FWIW I have builds that are using --prefix --with-user --

Re: Vote: Remove autotools build files from the repository (ATS 10)

2023-10-21 Thread James Peach
BLE_CCACHE=OFF) > —-enable-ccache > BUILD_NUMBER.> —-with-build-number > > > Sent with Proton Mail secure email. > > --- Original Message --- > On Thursday, October 19th, 2023 at 8:44 PM, James Peach > wrote: > > >> Could you please summa

Re: Vote: Remove autotools build files from the repository (ATS 10)

2023-10-24 Thread James Peach
> On 22 Oct 2023, at 10:50 am, James Peach wrote: > > Thanks Chris, that list is pretty helpful. > > BTW, the default cmake biuld doesn’t work on macOS: > > $ cmake -B build && make -j10 -C build > … > In file included from > /Users/jpeach/src/traffics

Re: [PROPOSAL] Remove "proxy.process" prefix from all core metrics

2023-12-18 Thread James Peach
> On 18 Dec 2023, at 1:28 pm, Leif Hedstrom wrote: > > Through all our cleanup and refactoring in the past, as far as I can tell, > all metrics are now prefixed with proxy.process. > > This seems a little superfluous. I’d like to suggests one of two options: > > 1. Just drop the prefix enti

Re: SPDY/H2 and Session hooks

2015-05-12 Thread James Peach
> On May 12, 2015, at 12:48 PM, Alan M. Carroll wrote: > > My view is the SSN hooks should be called on the user agent connect / > disconnect, the base client session object. That would mean that for an > Http/2 session, the SSN hook is called only when the user agent initially > connects for

Re: broken tsqa dependencies?

2015-05-12 Thread James Peach
If you do "make clean" > and "make test" it should recreate the virtualenv-- does that help? Yup the virtualenv was recreated correctly after I nuked it :) > > On Sun, May 10, 2015 at 2:05 PM, James Peach wrote: > Hi all, > > Can anyone give me a hint how

Re: Removing CHANGES file from git

2015-05-28 Thread James Peach
> On May 28, 2015, at 9:09 AM, Phil Sorber wrote: > > There was some discussion in IRC about removing the CHANGES file. It is > generally disliked and we have JIRA release notes that serve a similar > purpose. Here is an example of JIRA release notes for 6.0.0: > > https://issues.apache.org/jir

redirect following methodology

2015-06-04 Thread James Peach
Hi all, There's been a lot of discussion on IRC about following redirects in ATS, and I thought it might be helpful to give my thoughts on the two useful approaches and establish some terminology. Logically, the HTTP redirects form a chain of HTTP requests, where each link is given by the Locat

Re: redirect following methodology

2015-06-05 Thread James Peach
g to create up to 10 TXNs for a single client request seems very > inefficient and could get quite tricky to debug/understand. > Thanks, > Sudheer > > > > On Thursday, June 4, 2015 9:39 AM, James Peach wrote: > > > Hi all, > > There's been a lot o

Re: redirect following methodology

2015-06-05 Thread James Peach
> On Jun 5, 2015, at 10:45 AM, Leif Hedstrom wrote: > > >> On Jun 5, 2015, at 1:22 PM, Alan Carroll >> wrote: >> >> The chaining would only be inefficient the first time, after that the >> original request (that starts the chain) will just serve the cached content. >> Even if the chain is

Re: [ANNOUNCE/DISCUSS] Removing support for Debian6 and Ubuntu12

2015-06-05 Thread James Peach
> On Jun 5, 2015, at 10:25 AM, Leif Hedstrom wrote: > > Hi all, > > In addition to removing build support for RHEL5 (and derivatives), I think we > need to ditch Debian6 and Ubuntu12 as well. Debian6 comes, from what I can > tell, with OpenSSL 0.9.8, and Ubuntu12 comes with OpenSSL1.0.0. The

Re: redirect following methodology

2015-06-05 Thread James Peach
chain go through remapping? For the purposes of metrics, how many txns is it? All these questions have obvious answers if chained redirects are fully modeled as separate transactions. > > Thanks, > Sudheer > > > On Friday, June 5, 2015 11:21 AM, Leif Hedstrom wrote:

Re: trafficserver git commit: TS-3122: Add support for hugepages on Linux

2015-06-08 Thread James Peach
> On Jun 8, 2015, at 8:40 AM, sor...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master 1a0832b3b -> bba557870 > > > TS-3122: Add support for hugepages on Linux > > > Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo > Commit: http://git-

Re: [1/6] trafficserver git commit: Document which configurations are overwritable

2015-06-08 Thread James Peach
Do you mean "overridable"? TSHttpOverridableConfig(). > On Jun 8, 2015, at 3:46 PM, mlib...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master 9bb97769e -> dfb14525a > > > Document which configurations are overwritable > > > Project: http://git-wip-us.ap

Re: SSL Session Plugin API proposal

2015-06-10 Thread James Peach
> On Jun 10, 2015, at 3:24 PM, Susan Hinrichs > wrote: > > I haven't heard anything about this. We did discuss it at the Austin Summit. > There was general agreement to the idea. I've updated the document to > reflect what I have implemented. I will create a pull request with the code >

Re: SSL Session Plugin API proposal

2015-06-11 Thread James Peach
ample plugin which exercises the new hook > > https://github.com/shinrich/trafficserver/blob/TS-3527/example/ssl-session/ssl-session.cc > > I've also created a pull request on my working branch. > > https://github.com/apache/trafficserver/pull/217https://github.com/apa

Re: API change for TS-3683: provide a SSL setter for Session/Ticket Cache Hit

2015-06-12 Thread James Peach
> On Jun 11, 2015, at 2:06 PM, François wrote: > > - JIRA ticket: TS-3683 ( https://issues.apache.org/jira/browse/TS-3683 ) > > - While metrics/statistics provide an aggregated result, we want to improve > our > analysis on a per-request basis, possibly running map reduce tasks to > precisely

Re: [IMPORTANT] Procedure around committing pull requests (and commits in general)

2015-07-10 Thread James Peach
> On Jul 10, 2015, at 11:21 AM, Leif Hedstrom wrote: > > Hi all, > > since we’re seeing a pretty significant increase in pull requests (primarily > from github), I’d like to remind everyone about some guidelines for > committing and testing. This applies to both commits you make on someone >

Re: TLS Session Ticket: Key Rotation

2015-08-04 Thread James Peach
> On Aug 4, 2015, at 3:30 PM, Nikhil Marathe > wrote: > > Hi, > > This is Nikhil from Linkedin Engineering. > > A Key Rotation feature has been added to TLS session tickets; details: > http://comments.gmane.org/gmane.comp.apache.trafficserver.devel/2084 > > At present, this feature relies on

Re: trafficserver git commit: TS-3497: Define Http2Error to classify errors

2015-08-05 Thread James Peach
> On Aug 5, 2015, at 9:05 AM, zw...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master 7d63eae28 -> 0fc4dcdea > > > TS-3497: Define Http2Error to classify errors > > This closes #267 > > > Project: http://git-wip-us.apache.org/repos/asf/trafficserver/rep

Re: TLS Session Ticket: Key Rotation

2015-08-05 Thread James Peach
>> Being able to reload just the keys is much safer than trying to reload the >> world, or configs that have changed. Especially since key rotation will >> likely be automatic on a schedule. >> >> -Bret >> >> On Tue, Aug 4, 2015 at 8:56 PM, James Peach

Re: TLS Session Ticket: Key Rotation

2015-08-06 Thread James Peach
> On Aug 6, 2015, at 9:56 AM, Leif Hedstrom wrote: > > >> On Aug 5, 2015, at 10:16 AM, James Peach wrote: >> >> >>> On Aug 5, 2015, at 8:22 AM, Susan Hinrichs >>> wrote: >>> >>> I would argue that the specification of

Re: [GIT] Yes, git pull --rebase is my friend

2015-08-07 Thread James Peach
> On Aug 6, 2015, at 8:03 PM, Leif Hedstrom wrote: > > Hi all, > > gentle reminder for everyone. And this is important, to not get all these > incredibly ugly merge commits Let's get Infra to install a git hook to reject merge commits on master. > over and over again (which also makes RM’ing

Re: Proposal: Consistent hashing DNS selection

2015-08-11 Thread James Peach
> On Aug 9, 2015, at 8:08 PM, Brian Geffon wrote: > > All, > We currently support strict and timed round robin for round robin DNS > records and I'd like to propose adding consistent hashing based DNS > selection. We're trying to replace our current ATS -> Haproxy setup with > only ATS and that'

Re: trafficserver git commit: Coverity issues: making the sanity check calls useful!

2015-08-12 Thread James Peach
This has multiple, independent changes, so it should have been a series of separate commits. I think it is also worth referencing the Coverity CID (I assume that this fixes a number of them?) > On Aug 11, 2015, at 2:18 PM, a...@apache.org wrote: > > Repository: trafficserver > Updated Branches

Re: User account for pushing to repository

2015-08-17 Thread James Peach
> On Aug 16, 2015, at 8:45 PM, Pushkar Pradhan > wrote: > > Hello,I am working on ATS and I have created my own branch for it. I want to > push to the repository (to my branch so that I don't lose my commits on my > box) and later plan to send a pull request.I created an account on github but

Re: TLS Session Ticket: Key Rotation

2015-08-25 Thread James Peach
cated was required we could >>> implement it via early ssl hooks and a plugin. >>> >>> Does this accurately sum things up? >>> >>> Nikhil / Bret, do you guys think rotating a global ticket file via >>> records.config works both from a securit

Re: New TS API TSHttpTxnCacheStateGet

2015-09-02 Thread James Peach
> On Sep 1, 2015, at 3:41 PM, Sudheer Vinukonda > wrote: > > [resending with (hopefully) better formatting] Summarizing the IRC discussion, this specific proposal is a move towards a generalized API that aligns with logging tags. The goal there is to give plugins access to the same informati

Re: astats_over_http rpm installation error

2015-09-03 Thread James Peach
> On Sep 3, 2015, at 8:48 AM, Sudheer Vinukonda > wrote: > > Not sure what is. We have a plugin called > stats_over_http, and that should come with the ATS default install. > Adding dev@ and users@. astats_over_http is part of the http://traffic-control-cdn.net package. I expect you could

Re: [VOTE] Release Apache Traffic Server 5.3.2 (RC0)

2015-09-08 Thread James Peach
> On Sep 4, 2015, at 9:08 AM, Phil Sorber wrote: > > Hello All, > > I've prepared a release for v5.3.2 (RC0) which is the latest stable release > in the 5.3.x series. This is the third release in our Long Term Support > (LTS) version as detailed in our Release Management document: > > https://

Re: [VOTE] Release Apache Traffic Server 5.3.2 (RC0)

2015-09-08 Thread James Peach
+1 CentOS 6 x86_64 OS X 10.10.5 x86_64 > On Sep 4, 2015, at 9:08 AM, Phil Sorber wrote: > > Hello All, > > I've prepared a release for v5.3.2 (RC0) which is the latest stable release > in the 5.3.x series. This is the third release in our Long Term Support > (LTS) version as detailed in our Re

Re: TS on Sparc, Solaris 11

2015-09-15 Thread James Peach
> On Sep 15, 2015, at 2:21 AM, Mohd Akhbar wrote: > > Hi, > > Just a question, has anybody compiled TS on Solaris 11 (Sparc) ? If > can, then is the re any tips or guide ? It should be fine. There are people running on OmniOS, which is similar. Since we don't have a Solaris buildbot yo umight

Re: trafficserver git commit: TS-3928: Make TSRemapNewInstance not required in remap plugins

2015-09-21 Thread James Peach
Phil, can you please update the man page for TSRemapNewInstance? https://docs.trafficserver.apache.org/en/latest/reference/api/TSRemap.en.html thanks! > On Sep 21, 2015, at 1:14 PM, sor...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master 0a58767f7 -> 9043

Re: [NOTE] Marking Jira's with "Regression" Label

2015-09-27 Thread James Peach
> On Sep 23, 2015, at 4:42 PM, Leif Hedstrom wrote: > > Hi all, > > in order to help look for bugs that are for certain regressions, I’d like to > suggest that we start using the “Regression” label in Jira. This is easy to > do, but just make sure it truly is a regression before you tag it as

Re: trafficserver git commit: [TS-3949] Prevent active timeout event from firing after PluginVC is closed.

2015-09-27 Thread James Peach
> On Sep 26, 2015, at 10:41 PM, sudhe...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master f9a6930fc -> ae9a343a9 > > > [TS-3949] Prevent active timeout event from firing > after PluginVC is closed. > > > Project: http://git-wip-us.apache.org/repos/asf/t

docs update

2015-10-05 Thread James Peach
Hi all, The RTD documentation build was failing somewhere in a Python Latex module. I could not reproduce it locally, so I turned off the PDF and ePUB outputs on readthedocs.org and it is now building OK. I also enabled build failure notifications, so next time the documentation build starts fa

#traffic-server IRC logs

2015-10-09 Thread James Peach
Hi all, Just a note that we have enabled logging for #traffic-server IRC channel. You can view the archives here: http://wilderness.apache.org/channels/#logs-#traffic-server cheers, James

Re: trafficserver git commit: TS-315: Add switch to disable config file generation/runtime behavior changing

2015-10-22 Thread James Peach
Hey Bryan, I think that proxy.config.disable_configuration_modification should prevent rewriting the config, but you should still be able to update proxy.config.disable_configuration_modification out of band and have it update without a restart. Apart from that, disabling the update threads pre

Re: trafficserver git commit: TS-4007: ClassAllocator: don't attempt to destruct the prototype object when ClassAllocator goes out of scope

2015-11-10 Thread James Peach
> On Nov 9, 2015, at 10:38 PM, bri...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master c7610467e -> e4cb30531 > > > TS-4007: ClassAllocator: don't attempt to destruct the prototype object when > ClassAllocator goes out of scope > > > Project: http://gi

Re: ATS does not log traffic any more -- WARNING: Access logging to local log directory suspended - configured space allocation exhausted.

2015-11-24 Thread James Peach
> On Nov 24, 2015, at 8:12 AM, Ye, Hong wrote: > > Hi dev team, > > I need some help to figure out why one of my server stopped logging traffic. > I saw that warning in digs.log. But I have plenty of disk space on the server. > I tried to bounce the service and reboot server. But still, I do n

Re: Github vs Jira for comments

2015-12-01 Thread James Peach
> On Nov 30, 2015, at 10:55 AM, Leif Hedstrom wrote: > > Now that we agreed to use Github as a patch / review board, the question is: > Where do we post comments? On the Jira, or the Github pull request? My > preference is constantly using Jira, for two reasons > > 1) Our automated release no

Re: Github vs Jira for comments

2015-12-01 Thread James Peach
at the time, > but it predates today's better tools. Unfortunately we can't assign github PRs :( > > -- Leif > >> On Dec 1, 2015, at 4:46 PM, Leif Hedstrom wrote: >> >> >>> On Dec 1, 2015, at 9:28 AM, James Peach wrote: >>> >&

Re: Question regarding FIPS mode support for Apache Traffic Server

2015-12-27 Thread James Peach
> On Dec 24, 2015, at 10:38 AM, Craig Schomburg (craigs) > wrote: > > Thanks Brian. > > We just started our investigation of what it will take to FIPS'ify ATS (have > a config option). Also looking into what additional work would be required > to complete this work. We can figure out the b

Re: trafficserver git commit: [TS-4024] wire tracing enhancements. This closes #337.

2016-01-12 Thread James Peach
This doesn't look like it addresses Alan's last comment about "unifying the SSL error reporting logic" > On Jan 12, 2016, at 7:48 AM, shinr...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master 9399a7641 -> bb40d788b > > > [TS-4024] wire tracing enhancemen

Re: poll external server

2016-01-21 Thread James Peach
> On Jan 20, 2016, at 3:55 PM, Dk Jack wrote: > > Hi, > I am new to ATS and I am trying to write a plugin. My plugin needs to do > two things: > > 1) Periodically poll an external server and get some info and cache the > info locally. TSFetchUrl is probably what you want > 2) Use this cached

Re: backtrace

2016-01-21 Thread James Peach
> On Jan 21, 2016, at 6:37 PM, Dk Jack wrote: > > Hi, > I am a newbie to ATS and I am trying to write a plugin. My plugin is > crashing... and the crashlog > has this message > > "Unable to retrieve backtrace: [6] Error reading from socket." This means that traffic_crashlog was unable to make

Re: [VOTE] Release v6.1.0 RC2

2016-01-25 Thread James Peach
> On Jan 22, 2016, at 12:58 PM, Leif Hedstrom wrote: > > >> On Jan 19, 2016, at 11:51 AM, Leif Hedstrom wrote: >> >> Hi all, >> >> I've prepared a release candidate for v6.1.0-RC1, changes since v6.0.0 >> include: >> >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projec

Re: Proposal for how to update source code layout.

2016-01-26 Thread James Peach
I really think that developer time would be better spent on projects like removing the Tcl dependency, figuring out whether proxy/StatSystem.cc is really needed any more, cleaning up the XML dependencies, removing STL containers where it makes sense, improving test coverage and usability, making

Re: Proposal for how to update source code layout.

2016-01-26 Thread James Peach
> On Jan 26, 2016, at 11:07 AM, Alan Carroll > wrote: > > My view is that getting or at least having a target source tree that is > better organized is a big help in doing the things HRP wants to do. Certainly > when I have looked at doing that sort of cleanup, the current structure is an >

Re: Proposal for how to update source code layout.

2016-01-27 Thread James Peach
as you find code that deserves to be an independent module, or could be in a better source location, that is great! > > Jason > > > - Original Message - > From: James Peach > To: dev@trafficserver.apache.org; Alan Carroll > Sent: Tuesday, January 26, 2016 3:36

Re: API/Library to parse URLs in ATS 6.0.0

2016-02-02 Thread James Peach
> On Feb 2, 2016, at 7:21 AM, Devaki Chokshi (dchokshi) > wrote: > > Hello, > > I am fairly new to ATS. > > Are there any available APIs/libraries in ATS 6.0 that will parse a URL? https://docs.trafficserver.apache.org/en/latest/developer-guide/api/functions/TSUrlCreate.en.html#c.TSUrlParse

Re: [VOTE] Release v6.1.1

2016-02-05 Thread James Peach
+1 build and regressions on OS X and Fedora 23. > On Feb 2, 2016, at 8:27 PM, Leif Hedstrom wrote: > > Hi all, > > I've prepared a release candidate for v6.1.1, which includes: > > * [TS-4142] - Compile errors on OmniOS > * [TS-4165] - Logging breaks if changing log format > * [TS

master branch is now protected

2016-02-08 Thread James Peach
Hi all, As of https://issues.apache.org/jira/browse/INFRA-11234, the paster branch is now protected and force pushes are not allowed thanks, James

Re: Parent-child-child caching issue

2016-02-17 Thread James Peach
> On Feb 16, 2016, at 10:59 AM, Randeep wrote: > > Hi all, > > I am using parent-child heirarchy caching for hls and dash. > > main parent(172.16.0.40) middle-child(172.16.6.5) end-child(172.16.48.20) I think you need to break the problem down. Start from the parent that is closest to the or

Re: trafficserver git commit: TS-3977: Add cache-key-genid to experimental plugins. This closes #309.

2016-03-03 Thread James Peach
> On Mar 3, 2016, at 12:16 PM, a...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master 1d1cb8fae -> fbdf0221d > > > TS-3977: Add cache-key-genid to experimental plugins. > This closes #309. > > > Project: http://git-wip-us.apache.org/repos/asf/trafficserv

Re: trafficserver git commit: New documentation for escalation plugin

2016-03-22 Thread James Peach
Hi Miles, Next time, would you mind splitting this into separate commits? That makes it easier to see what was fixed in the commit history ... > On Mar 22, 2016, at 2:41 PM, mlib...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master 41441da8e -> 015b77176 >

Re: trafficserver git commit: TS-4087: Reduce SETTINGS_MAX_CONCURRENT_STREAMS when too many streams

2016-03-22 Thread James Peach
> On Mar 21, 2016, at 6:57 PM, masa...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master 1e9c9484c -> 0e6e5c151 > > > TS-4087: Reduce SETTINGS_MAX_CONCURRENT_STREAMS when too many streams > > Add below variables in records.config > - proxy.config.http2.mi

Re: trafficserver git commit: TS-4087: Reduce SETTINGS_MAX_CONCURRENT_STREAMS when too many streams

2016-03-25 Thread James Peach
> On Mar 24, 2016, at 2:57 AM, Masaori Koshiba wrote: > > 2016年3月23日(水) 14:23 James Peach : > >> [snip] >>> } >>> + >>> +return Http2::min_concurrent_streams_in; >>> + } else { >>> +if (Http2::throttling) { >>&

Re: [HEADSUP] clang-format updates

2016-03-29 Thread James Peach
> On Mar 29, 2016, at 1:32 PM, Leif Hedstrom wrote: > > Hi, > > as part of the 6.2.0 branching, and moving unto the 7.0.0 development train, > I’d like to update the clang-format binary packages that we use. I will > produce all these packages soon, but it’s important that we switch packages

Re: Congestion_control is it dead?

2016-04-07 Thread James Peach
> On Apr 7, 2016, at 9:33 AM, Susan Hinrichs > wrote: > > I'm testing congestion_control to enforce per-origin connection limits. In > my micro tests, all is looking good. However, as I'm reviewing jira for open > issues, I came across the following comment from Leif in TS-1221 > > "I'm no

Re: Updates to clang-format for v6.2 LTS / 7.0.

2016-04-11 Thread James Peach
> On Apr 11, 2016, at 11:01 AM, Leif Hedstrom wrote: > > Hi, > > James and I’ve been looking at some changes to clang-format, wanted to take > it here first. Just running the new version of clang-format produces a patch > of about 6,500 lines. This is mostly removal of superfluous empty lines

Re: Updates to clang-format for v6.2 LTS / 7.0.

2016-04-11 Thread James Peach
> On Apr 11, 2016, at 12:47 PM, James Peach wrote: > >> >> On Apr 11, 2016, at 11:01 AM, Leif Hedstrom wrote: >> >> Hi, >> >> James and I’ve been looking at some changes to clang-format, wanted to take >> it here first. Just running the new

Re: [trafficserver] branch master updated: TS-4321: Keep response headers in FetchSM as they are (#551)

2016-04-13 Thread James Peach
> On Apr 13, 2016, at 9:45 PM, Masakazu Kitajo wrote: > > I merged a pull request on GitHub with "squash and merge" button. > https://github.com/blog/2141-squash-your-commits > > This makes only one commits on master like we used to. It looks better > than making a merge commit. Is there a reb

Re: [trafficserver] branch master updated: TS-4340: fix small issue related to match typ e NONE

2016-04-14 Thread James Peach
> On Apr 14, 2016, at 1:44 PM, bri...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > briang pushed a commit to branch master > in repository https://git-dual.apache.org/repos/asf/trafficserver.git > > The following commit(s) were added to refs/head

merging github pull requests

2016-04-15 Thread James Peach
s now "Daniel Xu " - The committer is my github account "James Peach ", rather than my Apache one - The commit message contains the actual commit messages for 2 commits, but one of those was already in master so this commit doesn't contain the content matching the message.

Re: merging github pull requests

2016-04-15 Thread James Peach
> On Apr 15, 2016, at 10:09 AM, Leif Hedstrom wrote: > > >> On Apr 15, 2016, at 9:34 AM, Brian Geffon wrote: >> >> I'm not thrilled with it either. I agree that the email addresses are >> definitely not desireable, also I don't like how it also produces a merge >> commit. > > > I can deal w

Re: [trafficserver] 01/01: Merge pull request #567 from sudheerv/ts-3857

2016-04-15 Thread James Peach
I can't find an email with the actual diff? Is there one, or does that only happen on squashed merges? > On Apr 14, 2016, at 3:06 PM, sudhe...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > sudheerv pushed a commit to branch master > in repository

Re: [trafficserver] branch master updated: TS-4312 Add config to strictly parse URL according to RFC 3986. This closes #574

2016-04-18 Thread James Peach
> On Apr 18, 2016, at 1:05 AM, bri...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > briang pushed a commit to branch master > in repository https://git-dual.apache.org/repos/asf/trafficserver.git > > The following commit(s) were added to refs/head

Re: [trafficserver] branch master updated: TS-3922: Websocket Timeouts, transaction overrideable & clang format

2016-04-21 Thread James Peach
This commit broke the Lua build. Did you run ./ci/regression before committing? https://ci.trafficserver.apache.org/job/out_of_tree-master/1631/changes > On Apr 21, 2016, at 7:45 PM, bri...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > briang pus

Re: [trafficserver] branch master updated: TS-3922: Websocket Timeouts, transaction overrideable & clang format

2016-04-22 Thread James Peach
> On Apr 21, 2016, at 9:49 PM, Brian Geffon wrote: > > Should be fixed now, thanks! > yes I ran the regressions they passed with -R1 Hmm … maybe you didn’t build with —enable-experimental-plugins? > > Brian > > On Friday, April 22, 2016, James Peach wrote: > &

Re: Unit testing for plugin

2016-04-22 Thread James Peach
> On Apr 22, 2016, at 7:01 AM, Karthik Sivaraman > wrote: > > Hi > > > We are planning to maintain a plug-in that does third party feed based URL > filtering. Are there any recommendations for unit test/regression test > frameworks? What does trafficserver use for its unit/regression tests?

Re: Proposal: NetVC Context

2016-04-24 Thread James Peach
> On Apr 22, 2016, at 7:28 PM, Chao Xu wrote: > > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). Each side would be a separate NetVConnection. > Add a new member 'netvc_context' into class NetVConnection to indicate > which side the Net

Re: Add TSSslContextCreate and TSSslContextDestroy to the API

2016-04-24 Thread James Peach
This looks pretty reasonable to me. One concern I have is that this API creates SSL server contexts, so we ought to distinguish that in the API name. I propose that TSSslContextCreate() be named TSSslServerContextCreate(), and that we define TSSslContextDestroy() will be able to destroy both ser

Re: Add TSSslContextCreate and TSSslContextDestroy to the API

2016-04-28 Thread James Peach
SL server context: `TSSslServerContextCreate` >>> - Method to destroy any kind of SSL context: `TSSslContextDestroy` >>> >>> On Sun, Apr 24, 2016 at 2:57 PM, James Peach wrote: >>> >>>> This looks pretty reasonable to me. One concern I have is

client CA list in TS-3125

2016-05-01 Thread James Peach
Hi Brian, In TS-3125 you generate a server ID by hashing all the subject names in the server CA cert file (assuming there is one). You also set the client CA list using SSL_CTX_set_client_CA_list() … why is that? J

FYI: traffic_line removed from 7.0 branch

2016-05-12 Thread James Peach
Hi all, Just a heads-up in case. We have removed traffic_line in preparation for the 7.0 release. If you have any tooling that uses traffic_line, now is the time to switch over to traffic_ctl. Please file bugs if you find any problems with traffic_ctl or have any suggestions for features. than

RCF: [TS-4441] Fatal() should not dump core

2016-05-13 Thread James Peach
Hi all, Let me know what you think of this. I think that dumping core with Fatal() is unlikely to be a useful behaviour, so I want to change it to just exit with an error status. > https://issues.apache.org/jira/browse/TS-4441 >

Re: API-review: UUID APIs

2016-06-10 Thread James Peach
> On Jun 10, 2016, at 10:29 AM, Leif Hedstrom wrote: > > Hi, > > as part generalizing the concept from > https://github.com/apache/trafficserver/pull/199 > , I’ve filed a Jira to add > appropriate APIs and I_Machine.h / Machine.cc

Re: API-review: UUID APIs

2016-06-11 Thread James Peach
> On Jun 10, 2016, at 3:19 PM, Leif Hedstrom wrote: > > Thanks James, as usual great review. Replies inline. > >> On Jun 10, 2016, at 2:30 PM, James Peach wrote: >> >> >>> On Jun 10, 2016, at 10:29 AM, Leif Hedstrom wrote: >>> >&g

Re: [DISCUSS] Relax minimum OS version requirements ?

2016-06-16 Thread James Peach
> On Jun 16, 2016, at 12:25 PM, Alan Carroll > wrote: > > "This is not a reason to go nuts and use every damn C++11 and STL feature > there is" > > Exactly. One doesn't need a reason for that. > > Yes, I think we should move this up. Two feature at least that I think would > help making the

Re: [PROPOSAL] One more clang-format change for 7.0.0

2016-06-17 Thread James Peach
> On Jun 16, 2016, at 2:04 PM, Leif Hedstrom wrote: > > Hi all, > > James and I would like to make this small, but powerful, change to > clang-format: > > -AlignConsecutiveAssignments: false >+AlignConsecutiveAssignments: true > > > This will try to align assignments such that

Re: ATS5.3 does not reset stats?

2016-06-20 Thread James Peach
> On Jun 20, 2016, at 9:03 AM, Ye, Hong wrote: > > Hi guys, > > Stats went resetting on my ATS5.3 box. Does anyone have any idea what could > be wrong or missed? > It worked fine in ATS4. > > [root@denv-urlrw03 ~]# /usr/bin/curl -s localhost/_stats | grep > completed_requests > "proxy.proce

Re: ATS5.3 does not reset stats?

2016-06-20 Thread James Peach
> On Jun 20, 2016, at 10:31 AM, Ye, Hong wrote: > > Does anyone have any idea how this can be fixed? I am in the middle of > upgrade and need to > make decision quickly if I can move forward. AFAIK there's no workaround other than backporting the patch. > > Thank you very much for any help.

Re: [PROPOSAL] One more clang-format change for 7.0.0

2016-06-21 Thread James Peach
> If everyone is still onboard then lets stick with it, but just wanted to > talk this out. Yeh I agree that there are ugly cases, but on balance I think this made the formatting cleaner. With some judicious blank lines to reset the indentation and application of clang-format-off, can we impro

Re: TS-4523: Add the ability to pause/resume data consumption in the CPP API

2016-06-21 Thread James Peach
> On Jun 16, 2016, at 11:43 AM, David Ben Zakai > wrote: > > Hi all, > > I'd like to suggest an API change in the CPP API Transformation interface. > > My own use case is that I'd like to be able to pause the transformation, > handle what I can from the file and release the buffered content b

RFC: self-contained headers

2016-07-02 Thread James Peach
Hi all, I’ve posted a pull request that integrates clang-tidy into the build. The usual way to do this is to use the bear tool to build a JSON compilation database, however that has a couple of drawbacks. First, dynamic library preloading is di

  1   2   3   4   5   6   7   8   9   10   >