[jira] [Commented] (VCL-1029) add a section for managing affiliations to Site Configuration
[ https://issues.apache.org/jira/browse/VCL-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1619#comment-1619 ] ASF subversion and git services commented on VCL-1029: -- Commit 1804716 from [~jfthomps] in branch 'vcl/trunk' [ https://svn.apache.org/r1804716 ] VCL-1029 - add a section for managing affiliations to Site Configuration siteconfig.php: modified AffilTextVariable::getHTML: added $nooptions variable to track if there are no options to display for a given block - this is mainly for Shibboleth related variables when there are only the Global and Local affiliations > add a section for managing affiliations to Site Configuration > - > > Key: VCL-1029 > URL: https://issues.apache.org/jira/browse/VCL-1029 > Project: VCL > Issue Type: Improvement > Components: web gui (frontend) >Reporter: Josh Thompson > Fix For: 2.5 > > > The database must be directly modified to add or remove affiliations. Admins > should not need to directly modify the database, especially for something as > simple as adding an affiliation. This can easily be added to the Site > Configuration page. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (VCL-1029) add a section for managing affiliations to Site Configuration
[ https://issues.apache.org/jira/browse/VCL-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991109#comment-15991109 ] ASF subversion and git services commented on VCL-1029: -- Commit 1793377 from [~jfthomps] in branch 'vcl/trunk' [ https://svn.apache.org/r1793377 ] VCL-1029 - add a section for managing affiliations to Site Configuration siteconfig.php: modified Affiliations::deleteValue: fixed bug where most of the stuff in the variable table was getting deleted when deleting an affiliation - backslashes needed another set of escaping > add a section for managing affiliations to Site Configuration > - > > Key: VCL-1029 > URL: https://issues.apache.org/jira/browse/VCL-1029 > Project: VCL > Issue Type: Improvement > Components: web gui (frontend) >Reporter: Josh Thompson > Fix For: 2.5 > > > The database must be directly modified to add or remove affiliations. Admins > should not need to directly modify the database, especially for something as > simple as adding an affiliation. This can easily be added to the Site > Configuration page. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (VCL-1029) add a section for managing affiliations to Site Configuration
[ https://issues.apache.org/jira/browse/VCL-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989286#comment-15989286 ] ASF subversion and git services commented on VCL-1029: -- Commit 1793126 from [~jfthomps] in branch 'vcl/trunk' [ https://svn.apache.org/r1793126 ] VCL-1029 - add a section for managing affiliations to Site Configuration siteconfig.php: -modified generalOptions: reordered several options; added conditional to only print AffilShibName block if user has global config permission or the user's affiliation is not Local -modified AffilTextVariable: added $updatefailmsg, $affils, $allowempty, $allowglobalempty, $globalid, and initializations for them in the __construct function -modified AffilTextVariable::validateValue: escaped any slashes in $this->constraints before doing the preg_match -modified AffilTextVariable::getHTML: modified to better handle users not having global site config so that they see the default value from the Global setting and can set the value to an empty string to cause the default value to be used -modified AffilTextVariable::AJaddAffiliationSetting: set $affils from $this->affils instead of calling getAffiliations -modified AffilTextVariable::AJupdateAllSettings: modified to better handle users not having global site config so that they can set the value to an empty string to cause the default value to be used -modified AffilHelpAddress: set $this->allowempty to 1 -modified AffilHelpAddress::setValue: modified to handle $value being NULL -added AffilWebAddress -modified AffilKMSserver: set $this->allowempty to 1; set $this->allowglobalempty to 1 -modified AffilTheme: set $this->allowempty to 1 -modified AffilTheme::deleteValue: added code to set theme value to NULL in database rather than just returning 0 -added AffilShibOnly -added AffilShibName states.php: -added affilwebaddress classmapping -added affilshibonly classmapping -added affilshibname classmapping utils.php: modified getAffiliationTheme: updated query to return theme from Global affiliation if passed in affiliation's setting is NULL; if no value found for either, return DEFAULTTHEME setting siteconfig.js: -modified AffilTextVariable.prototype.addAffiliationSettingCBextra: fixed problem when adding a new value where the savekeys value was getting an empty string in the list -modified AffilTextVariable.prototype.saveSettings: if a value of 0 is going to be submitted, change it to 'zero' so that the php function processInputVar will handle it correctly -added affilwebaddr -added affilshibonly -added affilshibname -modified messages.prototype.init: changed setTimeout from calling this.init to calling messages.init or messages.prototype.init, depending on which one exists > add a section for managing affiliations to Site Configuration > - > > Key: VCL-1029 > URL: https://issues.apache.org/jira/browse/VCL-1029 > Project: VCL > Issue Type: Improvement > Components: web gui (frontend) >Reporter: Josh Thompson > Fix For: 2.5 > > > The database must be directly modified to add or remove affiliations. Admins > should not need to directly modify the database, especially for something as > simple as adding an affiliation. This can easily be added to the Site > Configuration page. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (VCL-1029) add a section for managing affiliations to Site Configuration
[ https://issues.apache.org/jira/browse/VCL-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945120#comment-15945120 ] ASF subversion and git services commented on VCL-1029: -- Commit 1789130 from [~jfthomps] in branch 'vcl/trunk' [ https://svn.apache.org/r1789130 ] VCL-1029 - add a section for managing affiliations to Site Configuration siteconfig.php: modified generalOptions: ...and actually made it check for *having* global site configuration permissions rather than *not* having them > add a section for managing affiliations to Site Configuration > - > > Key: VCL-1029 > URL: https://issues.apache.org/jira/browse/VCL-1029 > Project: VCL > Issue Type: Improvement > Components: web gui (frontend) >Reporter: Josh Thompson > Fix For: 2.5 > > > The database must be directly modified to add or remove affiliations. Admins > should not need to directly modify the database, especially for something as > simple as adding an affiliation. This can easily be added to the Site > Configuration page. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (VCL-1029) add a section for managing affiliations to Site Configuration
[ https://issues.apache.org/jira/browse/VCL-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945114#comment-15945114 ] ASF subversion and git services commented on VCL-1029: -- Commit 1789127 from [~jfthomps] in branch 'vcl/trunk' [ https://svn.apache.org/r1789127 ] VCL-1029 - add a section for managing affiliations to Site Configuration siteconfig.php: modified generalOptions: fixed problem from last commit where conditional checking for user having global site configuration permissions was around the wrong lines > add a section for managing affiliations to Site Configuration > - > > Key: VCL-1029 > URL: https://issues.apache.org/jira/browse/VCL-1029 > Project: VCL > Issue Type: Improvement > Components: web gui (frontend) >Reporter: Josh Thompson > Fix For: 2.5 > > > The database must be directly modified to add or remove affiliations. Admins > should not need to directly modify the database, especially for something as > simple as adding an affiliation. This can easily be added to the Site > Configuration page. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (VCL-1029) add a section for managing affiliations to Site Configuration
[
https://issues.apache.org/jira/browse/VCL-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943438#comment-15943438
]
ASF subversion and git services commented on VCL-1029:
--
Commit 1788944 from [~jfthomps] in branch 'vcl/trunk'
[ https://svn.apache.org/r1788944 ]
VCL-1029 - add a section for managing affiliations to Site Configuration
siteconfig.php:
-modified generalOptions: added affiliation section to top of left column
-modified timeSourceHTML, TimeVariable::getHTML, AffilTextVariable::getHTML,
GlobalSingleVariable::getHTML, and GlobalMultiVariable::getHTML: changed object
for siteconfigdesc from span to div
-modified GlobalMultiVariable: added $addCBextra, $deleteCBextra, and
$saveCBextra class variables
-modified GlobalMultiVariable::__construct: set $type as $this->type; set
default values for $addCBextra, $deleteCBextra, and $saveCBextra
-modified GlobalMultiVariable::getHTML: added a div wrapper for everything
after the h3 title with a class name of GMV{$this->domidbase}wrapper
-modified GlobalMultiVariable::AJaddConfigMultiVal: changed extrafunc value
from hard coded "addNewMultiValCBextra" to "$this->addCBextra"
-modified GlobalMultiVariable::AJdeleteMultiSetting: changed call to
deleteVariable to wrapper that calls $this->deleteValue that also checks for
return value
-added GlobalMultiVariable::deleteValue
-modified GlobalMultiVariable::AJupdateAllSettings: if call to
$this->validateValue returns false, also check for function having set a
specific error message; added check for duplicate values being submitted; added
check for nothing being changed and if so, return 'noaction' status; changed
call to setVariable to call $this->updateValue instead; added extrafunc to
returned data
-added GlobalMultiVariable::updateValue
-added Affiliations class that inherits from GlobalMultiVariable
states.php: added $actions['classmapping']['affiliations'] = 'siteconfig';
siteconfig.js:
-modified generalSiteConfigCB: added section to handle 'noaction' response
status
-modified GlobalMultiVariable.prototype.addNewMultiValCBextra: added missing
semicolon after var func = this.deleteMultiVal
-added GlobalMultiVariable.prototype.saveCBextra
-added affiliation class and instantiation
siteconfig.css:
-modified ".configwidget h3": set margin-bottom to 0
-modified .siteconfigdesc: set top padding to 5px
-added .GMVaffiliationwrapper
-added #siteconfigconfirmoverlay
-added #affiliationconfirmbox
-added #affilconfirmname
-added #affilconfbox-table
-added #affilconfbox-cell
> add a section for managing affiliations to Site Configuration
> -
>
> Key: VCL-1029
> URL: https://issues.apache.org/jira/browse/VCL-1029
> Project: VCL
> Issue Type: Improvement
> Components: web gui (frontend)
>Reporter: Josh Thompson
> Fix For: 2.5
>
>
> The database must be directly modified to add or remove affiliations. Admins
> should not need to directly modify the database, especially for something as
> simple as adding an affiliation. This can easily be added to the Site
> Configuration page.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
