Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available
That's a good point: the name of the logger used to log deprecations should start with "org.apache.velocity" so that it does respect the logging hierarchy. On 15/03/2019 09:59, Greg Huber wrote: If I change in class org.apache.velocity.util.DeprecationAwareExtProperties protected static Logger logger = LoggerFactory.getLogger("deprecation"); to protected static Logger logger = LoggerFactory.getLogger(DeprecationAwareExtProperties.class); It now logs correctly: 2019-03-15 08:53:10,076 WARN org.apache.velocity.util.DeprecationAwareExtProperties DeprecationAwareExtProperties:warnDeprecated - configuration key ' my.resource.loader.public.name' has been deprecated in favor of ' resource.loader.my.public.name' ## Don't have a log entry for "deprecation". log4j2.xml Can this be updated so it works without any changes? Cheers Greg On Thu, 14 Mar 2019 at 19:35, Claude Brisson wrote: Those logs are emitted quite early in the webapp initialization. So chances are the logger is initialized afterwards. If you are using the webapp-slf4j-logger to forwards slf4j logs towards tomcat, be sure to: - use the latest version (1.4) - put this at the very beginning of your web.xml file: com.republicate.slf4j.impl.ServletContextLoggerListener so that the logger is initialized first. I'll document that. If that didn't work, did you check that there wasn't an older velocity-engine-core jar in the classpath? On 14/03/2019 17:42, Greg Huber wrote: Tomcat logs (would be the most useful). I know the logging works because if there is an invalid #if I get a log message. On Thu, 14 Mar 2019 at 16:31, Claude Brisson I would say yes, since most test cases still use the deprecated properties. One of the test cases explicitly checks for the warning in the logs, which should be something like: [warn] configuration key 'webapp.resource.loader.description' has been deprecated in favor of 'resource.loader.webapp.description' Which logs are you talking about? Yours or maven's? Most test cases logs aren't visible in maven output. Claude On 14/03/2019 10:56, Greg Huber wrote: Is there any way to check if the depreciated properties logging is working? I would have thought I would see some messages in the logs: eg for my resource.loader = webapp, my 2.0: webapp.resource.loader.description=Webapp Resource Loader 2.1 property name: resource.loader.. Cheers Greg On Mon, 11 Mar 2019 at 12:28, Claude Brisson wrote: The test build of Velocity Engine 2.1 RC2 is available. No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity Engine 2.1 RC2 has been made, and at this time it is simply a "test build". We welcome any comments you may have, and will take all feedback into account if a quality vote is called for this build. Release notes: * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html Distribution: * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/ Maven 2 staging repository: * https://repository.apache.org/content/repositories/orgapachevelocity-1026/ Documentation: * http://velocity.apache.org/engine/2.1/ Sources: * https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/ -- Claude - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available
For slf4j to work properly, you need to have only one slf4j binding jar in your classpath, otherwise the results are unpredictable as to which binding will be chosen by slf4j. So you really need to get rid of either log4j-slf4j-impl-2.11.2.jar (which redirects slf4j logs towards log4j) or webapp-slf4j-logger-1.4.jar (which redirects slf4j logs towards tomcat). On 15/03/2019 09:16, Greg Huber wrote: ...logging..nightmare...I should already be logging with SLF4J, adding the listener I now get in catalina.out and still no log messages. SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/home/ghuber/git/events/events/src/main/webapp/WEB-INF/lib/log4j-slf4j-impl-2.11.2.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/home/ghuber/git/events/events/src/main/webapp/WEB-INF/lib/webapp-slf4j-logger-1.4.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory] Looking at the source which class would be doing the depreciation logging? I can check to see why its not logging. On Thu, 14 Mar 2019 at 19:35, Claude Brisson wrote: Those logs are emitted quite early in the webapp initialization. So chances are the logger is initialized afterwards. If you are using the webapp-slf4j-logger to forwards slf4j logs towards tomcat, be sure to: - use the latest version (1.4) - put this at the very beginning of your web.xml file: com.republicate.slf4j.impl.ServletContextLoggerListener so that the logger is initialized first. I'll document that. If that didn't work, did you check that there wasn't an older velocity-engine-core jar in the classpath? On 14/03/2019 17:42, Greg Huber wrote: Tomcat logs (would be the most useful). I know the logging works because if there is an invalid #if I get a log message. On Thu, 14 Mar 2019 at 16:31, Claude Brisson I would say yes, since most test cases still use the deprecated properties. One of the test cases explicitly checks for the warning in the logs, which should be something like: [warn] configuration key 'webapp.resource.loader.description' has been deprecated in favor of 'resource.loader.webapp.description' Which logs are you talking about? Yours or maven's? Most test cases logs aren't visible in maven output. Claude On 14/03/2019 10:56, Greg Huber wrote: Is there any way to check if the depreciated properties logging is working? I would have thought I would see some messages in the logs: eg for my resource.loader = webapp, my 2.0: webapp.resource.loader.description=Webapp Resource Loader 2.1 property name: resource.loader.. Cheers Greg On Mon, 11 Mar 2019 at 12:28, Claude Brisson wrote: The test build of Velocity Engine 2.1 RC2 is available. No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity Engine 2.1 RC2 has been made, and at this time it is simply a "test build". We welcome any comments you may have, and will take all feedback into account if a quality vote is called for this build. Release notes: * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html Distribution: * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/ Maven 2 staging repository: * https://repository.apache.org/content/repositories/orgapachevelocity-1026/ Documentation: * http://velocity.apache.org/engine/2.1/ Sources: * https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/ -- Claude - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available
If I change in class org.apache.velocity.util.DeprecationAwareExtProperties protected static Logger logger = LoggerFactory.getLogger("deprecation"); to protected static Logger logger = LoggerFactory.getLogger(DeprecationAwareExtProperties.class); It now logs correctly: 2019-03-15 08:53:10,076 WARN org.apache.velocity.util.DeprecationAwareExtProperties DeprecationAwareExtProperties:warnDeprecated - configuration key ' my.resource.loader.public.name' has been deprecated in favor of ' resource.loader.my.public.name' ## Don't have a log entry for "deprecation". log4j2.xml Can this be updated so it works without any changes? Cheers Greg On Thu, 14 Mar 2019 at 19:35, Claude Brisson wrote: > Those logs are emitted quite early in the webapp initialization. So > chances are the logger is initialized afterwards. > > If you are using the webapp-slf4j-logger to forwards slf4j logs towards > tomcat, be sure to: > > - use the latest version (1.4) > > - put this at the very beginning of your web.xml file: > > > com.republicate.slf4j.impl.ServletContextLoggerListener > > > > > so that the logger is initialized first. > > I'll document that. > > If that didn't work, did you check that there wasn't an older > velocity-engine-core jar in the classpath? > > On 14/03/2019 17:42, Greg Huber wrote: > > Tomcat logs (would be the most useful). I know the logging works because > > if there is an invalid #if I get a log message. > > > > On Thu, 14 Mar 2019 at 16:31, Claude Brisson > > > wrote: > > > >> I would say yes, since most test cases still use the deprecated > properties. > >> > >> One of the test cases explicitly checks for the warning in the logs, > >> which should be something like: > >> > >> [warn] configuration key 'webapp.resource.loader.description' has > >> been deprecated in favor of 'resource.loader.webapp.description' > >> > >> Which logs are you talking about? Yours or maven's? Most test cases logs > >> aren't visible in maven output. > >> > >> > >> Claude > >> > >> On 14/03/2019 10:56, Greg Huber wrote: > >>> Is there any way to check if the depreciated properties logging is > >>> working? I would have thought I would see some messages in the logs: > >>> > >>> eg for my > >>> resource.loader = webapp, > >>> > >>> my 2.0: > >>> webapp.resource.loader.description=Webapp Resource Loader > >>> > >>> 2.1 property name: > >>> resource.loader.. > >>> > >>> Cheers Greg > >>> > >>> On Mon, 11 Mar 2019 at 12:28, Claude Brisson > >>> > >>> wrote: > >>> > The test build of Velocity Engine 2.1 RC2 is available. > > No determination as to the quality ('alpha,' 'beta,' or 'GA') of > Velocity Engine 2.1 RC2 has been made, and at this time it is simply a > "test build". We welcome any comments you may have, and will take all > feedback into account if a quality vote is called for this build. > > Release notes: > > * > > > >> > https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html > > Distribution: > > * > >> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/ > Maven 2 staging repository: > > * > > >> > https://repository.apache.org/content/repositories/orgapachevelocity-1026/ > Documentation: > > * http://velocity.apache.org/engine/2.1/ > > Sources: > > * https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/ > > > -- > Claude > > > > - > To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > For additional commands, e-mail: dev-h...@velocity.apache.org > > > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > >> For additional commands, e-mail: dev-h...@velocity.apache.org > >> > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > For additional commands, e-mail: dev-h...@velocity.apache.org > >
Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available
...logging..nightmare...I should already be logging with SLF4J, adding the listener I now get in catalina.out and still no log messages. SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/home/ghuber/git/events/events/src/main/webapp/WEB-INF/lib/log4j-slf4j-impl-2.11.2.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/home/ghuber/git/events/events/src/main/webapp/WEB-INF/lib/webapp-slf4j-logger-1.4.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory] Looking at the source which class would be doing the depreciation logging? I can check to see why its not logging. On Thu, 14 Mar 2019 at 19:35, Claude Brisson wrote: > Those logs are emitted quite early in the webapp initialization. So > chances are the logger is initialized afterwards. > > If you are using the webapp-slf4j-logger to forwards slf4j logs towards > tomcat, be sure to: > > - use the latest version (1.4) > > - put this at the very beginning of your web.xml file: > > > com.republicate.slf4j.impl.ServletContextLoggerListener > > > > > so that the logger is initialized first. > > I'll document that. > > If that didn't work, did you check that there wasn't an older > velocity-engine-core jar in the classpath? > > On 14/03/2019 17:42, Greg Huber wrote: > > Tomcat logs (would be the most useful). I know the logging works because > > if there is an invalid #if I get a log message. > > > > On Thu, 14 Mar 2019 at 16:31, Claude Brisson > > > wrote: > > > >> I would say yes, since most test cases still use the deprecated > properties. > >> > >> One of the test cases explicitly checks for the warning in the logs, > >> which should be something like: > >> > >> [warn] configuration key 'webapp.resource.loader.description' has > >> been deprecated in favor of 'resource.loader.webapp.description' > >> > >> Which logs are you talking about? Yours or maven's? Most test cases logs > >> aren't visible in maven output. > >> > >> > >> Claude > >> > >> On 14/03/2019 10:56, Greg Huber wrote: > >>> Is there any way to check if the depreciated properties logging is > >>> working? I would have thought I would see some messages in the logs: > >>> > >>> eg for my > >>> resource.loader = webapp, > >>> > >>> my 2.0: > >>> webapp.resource.loader.description=Webapp Resource Loader > >>> > >>> 2.1 property name: > >>> resource.loader.. > >>> > >>> Cheers Greg > >>> > >>> On Mon, 11 Mar 2019 at 12:28, Claude Brisson > >>> > >>> wrote: > >>> > The test build of Velocity Engine 2.1 RC2 is available. > > No determination as to the quality ('alpha,' 'beta,' or 'GA') of > Velocity Engine 2.1 RC2 has been made, and at this time it is simply a > "test build". We welcome any comments you may have, and will take all > feedback into account if a quality vote is called for this build. > > Release notes: > > * > > > >> > https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html > > Distribution: > > * > >> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/ > Maven 2 staging repository: > > * > > >> > https://repository.apache.org/content/repositories/orgapachevelocity-1026/ > Documentation: > > * http://velocity.apache.org/engine/2.1/ > > Sources: > > * https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/ > > > -- > Claude > > > > - > To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > For additional commands, e-mail: dev-h...@velocity.apache.org > > > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > >> For additional commands, e-mail: dev-h...@velocity.apache.org > >> > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > For additional commands, e-mail: dev-h...@velocity.apache.org > >
Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available
Those logs are emitted quite early in the webapp initialization. So chances are the logger is initialized afterwards. If you are using the webapp-slf4j-logger to forwards slf4j logs towards tomcat, be sure to: - use the latest version (1.4) - put this at the very beginning of your web.xml file: com.republicate.slf4j.impl.ServletContextLoggerListener so that the logger is initialized first. I'll document that. If that didn't work, did you check that there wasn't an older velocity-engine-core jar in the classpath? On 14/03/2019 17:42, Greg Huber wrote: Tomcat logs (would be the most useful). I know the logging works because if there is an invalid #if I get a log message. On Thu, 14 Mar 2019 at 16:31, Claude Brisson wrote: I would say yes, since most test cases still use the deprecated properties. One of the test cases explicitly checks for the warning in the logs, which should be something like: [warn] configuration key 'webapp.resource.loader.description' has been deprecated in favor of 'resource.loader.webapp.description' Which logs are you talking about? Yours or maven's? Most test cases logs aren't visible in maven output. Claude On 14/03/2019 10:56, Greg Huber wrote: Is there any way to check if the depreciated properties logging is working? I would have thought I would see some messages in the logs: eg for my resource.loader = webapp, my 2.0: webapp.resource.loader.description=Webapp Resource Loader 2.1 property name: resource.loader.. Cheers Greg On Mon, 11 Mar 2019 at 12:28, Claude Brisson The test build of Velocity Engine 2.1 RC2 is available. No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity Engine 2.1 RC2 has been made, and at this time it is simply a "test build". We welcome any comments you may have, and will take all feedback into account if a quality vote is called for this build. Release notes: * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html Distribution: * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/ Maven 2 staging repository: * https://repository.apache.org/content/repositories/orgapachevelocity-1026/ Documentation: * http://velocity.apache.org/engine/2.1/ Sources: * https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/ -- Claude - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available
Tomcat logs (would be the most useful). I know the logging works because if there is an invalid #if I get a log message. On Thu, 14 Mar 2019 at 16:31, Claude Brisson wrote: > I would say yes, since most test cases still use the deprecated properties. > > One of the test cases explicitly checks for the warning in the logs, > which should be something like: > > [warn] configuration key 'webapp.resource.loader.description' has > been deprecated in favor of 'resource.loader.webapp.description' > > Which logs are you talking about? Yours or maven's? Most test cases logs > aren't visible in maven output. > > >Claude > > On 14/03/2019 10:56, Greg Huber wrote: > > Is there any way to check if the depreciated properties logging is > > working? I would have thought I would see some messages in the logs: > > > > eg for my > > resource.loader = webapp, > > > > my 2.0: > > webapp.resource.loader.description=Webapp Resource Loader > > > > 2.1 property name: > > resource.loader.. > > > > Cheers Greg > > > > On Mon, 11 Mar 2019 at 12:28, Claude Brisson > > > wrote: > > > >> The test build of Velocity Engine 2.1 RC2 is available. > >> > >> No determination as to the quality ('alpha,' 'beta,' or 'GA') of > >> Velocity Engine 2.1 RC2 has been made, and at this time it is simply a > >> "test build". We welcome any comments you may have, and will take all > >> feedback into account if a quality vote is called for this build. > >> > >> Release notes: > >> > >> * > >> > >> > https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html > >> > >> > >> Distribution: > >> > >>* > https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/ > >> > >> Maven 2 staging repository: > >> > >>* > >> > https://repository.apache.org/content/repositories/orgapachevelocity-1026/ > >> > >> Documentation: > >> > >> * http://velocity.apache.org/engine/2.1/ > >> > >> Sources: > >> > >>* https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/ > >> > >> > >> -- > >> Claude > >> > >> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > >> For additional commands, e-mail: dev-h...@velocity.apache.org > >> > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > For additional commands, e-mail: dev-h...@velocity.apache.org > >
Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available
I would say yes, since most test cases still use the deprecated properties. One of the test cases explicitly checks for the warning in the logs, which should be something like: [warn] configuration key 'webapp.resource.loader.description' has been deprecated in favor of 'resource.loader.webapp.description' Which logs are you talking about? Yours or maven's? Most test cases logs aren't visible in maven output. Claude On 14/03/2019 10:56, Greg Huber wrote: Is there any way to check if the depreciated properties logging is working? I would have thought I would see some messages in the logs: eg for my resource.loader = webapp, my 2.0: webapp.resource.loader.description=Webapp Resource Loader 2.1 property name: resource.loader.. Cheers Greg On Mon, 11 Mar 2019 at 12:28, Claude Brisson wrote: The test build of Velocity Engine 2.1 RC2 is available. No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity Engine 2.1 RC2 has been made, and at this time it is simply a "test build". We welcome any comments you may have, and will take all feedback into account if a quality vote is called for this build. Release notes: * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html Distribution: * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/ Maven 2 staging repository: * https://repository.apache.org/content/repositories/orgapachevelocity-1026/ Documentation: * http://velocity.apache.org/engine/2.1/ Sources: * https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/ -- Claude - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available
Is there any way to check if the depreciated properties logging is working? I would have thought I would see some messages in the logs: eg for my resource.loader = webapp, my 2.0: webapp.resource.loader.description=Webapp Resource Loader 2.1 property name: resource.loader.. Cheers Greg On Mon, 11 Mar 2019 at 12:28, Claude Brisson wrote: > The test build of Velocity Engine 2.1 RC2 is available. > > No determination as to the quality ('alpha,' 'beta,' or 'GA') of > Velocity Engine 2.1 RC2 has been made, and at this time it is simply a > "test build". We welcome any comments you may have, and will take all > feedback into account if a quality vote is called for this build. > > Release notes: > > * > > https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html > > > Distribution: > > * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/ > > Maven 2 staging repository: > > * > https://repository.apache.org/content/repositories/orgapachevelocity-1026/ > > Documentation: > > * http://velocity.apache.org/engine/2.1/ > > Sources: > > * https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/ > > >-- >Claude > > > > - > To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > For additional commands, e-mail: dev-h...@velocity.apache.org > >
Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available
On Mon, Mar 11, 2019 at 4:04 PM Claude Brisson wrote: > > On 11/03/2019 14:53, Thomas Mortagne wrote: > > > Compared to RC1: > > > > I cannot find anymore the RuntimeConstants.PARSER_DASH_ALLOWED > > introduced in https://issues.apache.org/jira/browse/VELOCITY-542 . Its > > value used to be "parser.allows.dash.in.identifiers". > RuntimeConstants.PARSER_DASH_ALLOWED was introduced in 2.1 RC1. > It has been renamed to RuntimeConstants.PARSER_HYPHEN_ALLOWED in 2.1 RC2, > with value "parser.allow_hyphen_in_identifiers". OK thanks, I searched with "dash" and totally forgot the mail about "dash" vs "hyphen" :) > > > > Same issue for RuntimeConstants.VM_MESSAGES_ON which is much older. > > Used to be "velocimacro.messages.on" property which I don't see listed > > in > > https://velocity.apache.org/engine/devel/configuration-property-changes-in-2.1.html. > > This property was unused. It has simply been removed. Maybe it should > only have been deprecated. I'll mention it in the changes table. I did not notice any unwanted log during my quick tests so if it does not do anything I will just remove its use on our side. > > >Claude > > > > > On Mon, Mar 11, 2019 at 1:28 PM Claude Brisson > > wrote: > >> The test build of Velocity Engine 2.1 RC2 is available. > >> > >> No determination as to the quality ('alpha,' 'beta,' or 'GA') of > >> Velocity Engine 2.1 RC2 has been made, and at this time it is simply a > >> "test build". We welcome any comments you may have, and will take all > >> feedback into account if a quality vote is called for this build. > >> > >> Release notes: > >> > >> * > >> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html > >> > >> > >> Distribution: > >> > >>* https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/ > >> > >> Maven 2 staging repository: > >> > >>* > >> https://repository.apache.org/content/repositories/orgapachevelocity-1026/ > >> > >> Documentation: > >> > >> * http://velocity.apache.org/engine/2.1/ > >> > >> Sources: > >> > >>* https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/ > >> > >> > >> -- > >> Claude > >> > >> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > >> For additional commands, e-mail: dev-h...@velocity.apache.org > >> > > > > - > To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > For additional commands, e-mail: dev-h...@velocity.apache.org > -- Thomas Mortagne - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available
On 11/03/2019 14:53, Thomas Mortagne wrote: Compared to RC1: I cannot find anymore the RuntimeConstants.PARSER_DASH_ALLOWED introduced in https://issues.apache.org/jira/browse/VELOCITY-542 . Its value used to be "parser.allows.dash.in.identifiers". RuntimeConstants.PARSER_DASH_ALLOWED was introduced in 2.1 RC1. It has been renamed to RuntimeConstants.PARSER_HYPHEN_ALLOWED in 2.1 RC2, with value "parser.allow_hyphen_in_identifiers". Same issue for RuntimeConstants.VM_MESSAGES_ON which is much older. Used to be "velocimacro.messages.on" property which I don't see listed in https://velocity.apache.org/engine/devel/configuration-property-changes-in-2.1.html. This property was unused. It has simply been removed. Maybe it should only have been deprecated. I'll mention it in the changes table. Claude On Mon, Mar 11, 2019 at 1:28 PM Claude Brisson wrote: The test build of Velocity Engine 2.1 RC2 is available. No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity Engine 2.1 RC2 has been made, and at this time it is simply a "test build". We welcome any comments you may have, and will take all feedback into account if a quality vote is called for this build. Release notes: * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html Distribution: * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/ Maven 2 staging repository: * https://repository.apache.org/content/repositories/orgapachevelocity-1026/ Documentation: * http://velocity.apache.org/engine/2.1/ Sources: * https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/ -- Claude - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available
Compared to RC1: I cannot find anymore the RuntimeConstants.PARSER_DASH_ALLOWED introduced in https://issues.apache.org/jira/browse/VELOCITY-542 . Its value used to be "parser.allows.dash.in.identifiers". Same issue for RuntimeConstants.VM_MESSAGES_ON which is much older. Used to be "velocimacro.messages.on" property which I don't see listed in https://velocity.apache.org/engine/devel/configuration-property-changes-in-2.1.html. On Mon, Mar 11, 2019 at 1:28 PM Claude Brisson wrote: > > The test build of Velocity Engine 2.1 RC2 is available. > > No determination as to the quality ('alpha,' 'beta,' or 'GA') of > Velocity Engine 2.1 RC2 has been made, and at this time it is simply a > "test build". We welcome any comments you may have, and will take all > feedback into account if a quality vote is called for this build. > > Release notes: > > * > https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html > > > Distribution: > > * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/ > > Maven 2 staging repository: > > * > https://repository.apache.org/content/repositories/orgapachevelocity-1026/ > > Documentation: > > * http://velocity.apache.org/engine/2.1/ > > Sources: > > * https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/ > > >-- >Claude > > > > - > To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > For additional commands, e-mail: dev-h...@velocity.apache.org > -- Thomas Mortagne - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org