[GitHub] [wicket] papegaaij commented on pull request #439: Wicket 6786: Add Fetch Metadata support

papegaaij commented on pull request #439: URL: https://github.com/apache/wicket/pull/439#issuecomment-669769314 > > I've noticed that the code formatting is way off from Wicket standards. The code will need to be reformatted before it can be merged. > > We can do that after merging.

[GitHub] [wicket] martin-g commented on pull request #439: Wicket 6786: Add Fetch Metadata support

martin-g commented on pull request #439: URL: https://github.com/apache/wicket/pull/439#issuecomment-669745946 > I've noticed that the code formatting is way off from Wicket standards. The code will need to be reformatted before it can be merged. We can do that after merging. This

[GitHub] [wicket] martin-g commented on a change in pull request #440: WICKET-6807 Improve the check for the submitting component

martin-g commented on a change in pull request #440: URL: https://github.com/apache/wicket/pull/440#discussion_r466333061 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java ## @@ -1711,7 +1725,7 @@ public final void writeHiddenFields()

[GitHub] [wicket] martin-g merged pull request #441: Updated eclipse settings to reflect minimum java level of 11.

martin-g merged pull request #441: URL: https://github.com/apache/wicket/pull/441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [wicket] haster opened a new pull request #441: Updated eclipse settings to reflect minimum java level of 11.

haster opened a new pull request #441: URL: https://github.com/apache/wicket/pull/441 While trying to create a test for WICKET-6810 my eclipse kept complaining about code that shouldn't be on issue on java 11 (specifically, the use of the diamond operator in anonymous subclasses).

[GitHub] [wicket] martin-g commented on pull request #441: Updated eclipse settings to reflect minimum java level of 11.

martin-g commented on pull request #441: URL: https://github.com/apache/wicket/pull/441#issuecomment-669862100 Thank you, @haster ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [wicket] svenmeier commented on pull request #440: WICKET-6807 Improve the check for the submitting component

svenmeier commented on pull request #440: URL: https://github.com/apache/wicket/pull/440#issuecomment-669913170 Always writing parameters into hidden fields will mix them into the post parameters. This makes it impossible to differentiate them with form fields - something WICKET-6807

[GitHub] [wicket] martin-g commented on a change in pull request #440: WICKET-6807 Improve the check for the submitting component

martin-g commented on a change in pull request #440: URL: https://github.com/apache/wicket/pull/440#discussion_r466298812 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java ## @@ -1711,7 +1725,7 @@ public final void writeHiddenFields()

[GitHub] [wicket] martin-g opened a new pull request #440: WICKET-6807 Improve the check for the submitting component

martin-g opened a new pull request #440: URL: https://github.com/apache/wicket/pull/440 First check for the special 'name.x' parameter If there is no such then check that there is exactly one 'name' parameter Always use only the GET/POST parameters as the form's method

[GitHub] [wicket] martin-g commented on a change in pull request #440: WICKET-6807 Improve the check for the submitting component

martin-g commented on a change in pull request #440: URL: https://github.com/apache/wicket/pull/440#discussion_r466298364 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java ## @@ -1711,7 +1725,7 @@ public final void writeHiddenFields()

[GitHub] [wicket] martin-g commented on a change in pull request #440: WICKET-6807 Improve the check for the submitting component

martin-g commented on a change in pull request #440: URL: https://github.com/apache/wicket/pull/440#discussion_r466298364 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java ## @@ -1711,7 +1725,7 @@ public final void writeHiddenFields()