Re: Google Chart integration as candidate for wicketstuff

Hi Dieter, I've made some comments and approved the PR. Mostly minor things. I've also invited you to the WicketStuff collaborators team so you can commit in the repo, and merge PRs. You can still use PRs for your contributions when you want someone else to take a look before applying the

Re: Google Chart integration as candidate for wicketstuff

Hello Dieter, I had no time to check this "in action" :( Will try to during weekend On Wed, Aug 23, 2017 at 11:36 PM, Dieter Tremel wrote: > Hi, > > sorry for my lack of experience with pull requests. > > Did you have time to look at the sources? > > Is there

Re: Google Chart integration as candidate for wicketstuff

Hi, sorry for my lack of experience with pull requests. Did you have time to look at the sources? Is there anything expected from me now? What are the next steps? What issues to solve do you see? Dieter Am 13.08.2017 um 12:56 schrieb Martin Grigorov: > Hi Dieter, > > Are Google Charts

Re: Google Chart integration as candidate for wicketstuff

Hi Maxim, thank you for looking at my source, I changed this. Uploaded new commits added to the pull request. Dieter Am 17.08.2017 um 15:14 schrieb Maxim Solodovnik: > I have added few comments > > On Thu, Aug 17, 2017 at 4:24 PM, Dieter Tremel > wrote: >> Hello

Re: Google Chart integration as candidate for wicketstuff

I have added few comments On Thu, Aug 17, 2017 at 4:24 PM, Dieter Tremel wrote: > Hello Martin, > > made pull request #608 to wicket 7 branch. Hope it's all done as required. > > Did not rename till now, hope it is still possible. Just wanted to give > you a view. > >

Re: Google Chart integration as candidate for wicketstuff

Hello Martin, made pull request #608 to wicket 7 branch. Hope it's all done as required. Did not rename till now, hope it is still possible. Just wanted to give you a view. AJAX is not working yet, have a look at example, bar chart, AjaxCheckBox for stacked percent. Cheers Dieter Am

Re: Google Chart integration as candidate for wicketstuff

Hi Dieter. On Wed, Aug 16, 2017 at 12:53 PM, Dieter Tremel wrote: > Hi Martin, > > Google Chart is versioned > (https://developers.google.com/chart/interactive/docs/ > release_notes#Releases) > but only in newer "frozen versions", 41 .. 45. 45 is current. Not ideal >

Re: Google Chart integration as candidate for wicketstuff

Hi Dieter, Are Google Charts versioned ? Maybe we can add your library as wicketstuff-google-charts2, or whatever is the correct version. As we did with Google Maps APIs. Please create a Pull Request! Thank you! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On

Re: Google Chart integration as candidate for wicketstuff

Not my candidate in this case :) On Wed, Aug 9, 2017 at 7:51 PM, Dieter Tremel wrote: > Unfortunately not, as expected. The FAQ say: > > > Can I use charts offline? > > Your users' computers must have access to https://www.gstatic.com/ > charts/loader.js in order to

Re: Google Chart integration as candidate for wicketstuff

Unfortunately not, as expected. The FAQ say: > Can I use charts offline? > Your users' computers must have access to > https://www.gstatic.com/charts/loader.js in order to use the interactive > features of Google Charts. This is because the visualization libraries that > your page requires are

Re: Google Chart integration as candidate for wicketstuff

I, personally, don't mind if you will change existing googlecharts module with new one and provide reasonable number of examples BTW is there an option to have "local google charts" i.e. without contacting external CDNs? On Tue, Aug 8, 2017 at 6:24 PM, Dieter Tremel

Re: Google Chart integration as candidate for wicketstuff

Am 07.08.2017 um 13:31 schrieb Maxim Solodovnik: > Maybe it would be possible to update current version? > I'm afraid having 2 different Google Chart modules would be too much :) You are right, and I had a look at the existing module. But the Google API is so much different, that I decided to

Re: Google Chart integration as candidate for wicketstuff

Maybe it would be possible to update current version? I'm afraid having 2 different Google Chart modules would be too much :) BTW there are also https://github.com/wicketstuff/core/tree/master/jqplot-parent for chart drawing :) On Mon, Aug 7, 2017 at 2:36 PM, Dieter Tremel

Google Chart integration as candidate for wicketstuff

Hello wicket-team, for a project visualizing metar weather data I used wicket-charts based on Highcharts in a former version (http://tremel-computer.no-ip.org:8080/metarstation/). Due to licensing of Highcharts I decided to move to Google charts, but found the implementation in wicketstuf