Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-10-10 Thread Ruwan Abeykoon
Hi All, Created https://github.com/wso2/carbon-kernel/tree/4.4.x_java10 I do not have permission to following repos. I added respective owners on this tread. maven-tools carbon-metrics carbon-apimgt product-apim Cheers, Ruwan On Thu, Oct 11, 2018 at 10:42 AM Tharindu Wijewardane wrote: > Hi

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-10-10 Thread Tharindu Wijewardane
Hi Ruwan, Will you be able to create following new branches. Once created I will send PRs to those new branches. WSO2 repo Base branch New branch maven-tools master master_java10 carbon-kernel 4.4.x 4.4.x_java10 carbon-metrics 1.x.x 1.x.x_java10 carbon-apimgt 6.x 6.x_java10

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-10-07 Thread Tharindu Wijewardane
Hi all, Carbon kernel can be now started on java 10 without any exceptions. The management console is accessible through a web browser. Also all the tests in maven build are passing (java 8). Moving onto the APIM, As I mentioned in a previous email, I temporally commented out following 3 feature

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-10-03 Thread Selvaratnam Uthaiyashankar
Great!. Thanks for the update. On Wed, Oct 3, 2018 at 11:22 AM Tharindu Wijewardane wrote: > Hi all, > > With the help of eclipse community I got to know that they have removed > org.eclipse.osgi.service.resolver.PlatformAdmin service from the osgi > framework in Luna version and adding the >

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-10-02 Thread Tharindu Wijewardane
Hi all, With the help of eclipse community I got to know that they have removed org.eclipse.osgi.service.resolver.PlatformAdmin service from the osgi framework in Luna version and adding the bundle: org.eclipse.osgi.compatibility.state to Carbon runtime feature fixed the missing service issue.

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-09-27 Thread Tharindu Wijewardane
Hi all, The logs were not getting printed because following exception is thrown through CarbonConsoleAppender. "NoClassDefFoundError: Could not initialize class CarbonContextDataHolder" CarbonContextDataHolder has a set of javax.naming* imports and since java 10 has deprecated using them I

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-09-21 Thread Tharindu Wijewardane
Hi all, I was able to fix the previous issue (some osgi services were not found) by changing tycho/sisu p2 dependency versions of carbon p2 plugin to the versions used in carbon feature plugin. Then there were issues installing features which includes bundles from identity server related

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-09-12 Thread Tharindu Wijewardane
Hi all, I am trying to build APIM 2.x branch with modified versions of following dependencies (with upgraded osgi and some plugins) carbon-apimgt version 6.4.27 (6.x branch) carbon-kernel version 4.4.35 (4.4.x branch) carbon-metrics version 1.2.4 (1.x.x branch) carbon p2 plugin version 1.6.1

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-09-10 Thread Tharindu Wijewardane
clarification: I am trying to build APIM using java 8 (with the other upgraded dependencies built with java 8) and run on java 10 as Shankar instructed. On Mon, Sep 10, 2018 at 1:45 PM, Tharindu Wijewardane wrote: > Hi, > > Finally I got the carbon kernel to build using java 10. It can be

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-09-10 Thread Tharindu Wijewardane
Hi, Finally I got the carbon kernel to build using java 10. It can be started on java 10 too. However, The last fix I did was to add "--add-modules=java.activation" jvm argument to maven ant run plugin for generating stub classes from wsdl files. Since Java 9, access to some javax* modules has

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-09-06 Thread Selvaratnam Uthaiyashankar
Then, can you get APIM to build using JDK8, but run on JDK 10 please? We'll see how to proceed after doing that. On Thu, Sep 6, 2018 at 2:29 PM Tharindu Wijewardane wrote: > Hi all, > > As KasunG suggested I tried to get the carbon kernel (built with java 8) > to run on java 10 first.

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-09-06 Thread Tharindu Wijewardane
Hi all, As KasunG suggested I tried to get the carbon kernel (built with java 8) to run on java 10 first. Followings are the things I tried/found out. - Existing carbon 4 cannot be run on java 10 as the equinox version Kepler is not compatible with java 9 or 10. There are known issues

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-09-03 Thread Tharindu Wijewardane
Hi Kasun, 1.) The fix I did was in a very old version of felix.scr.generator which was released in 2011. I could not find the source on github so I downloaded the source jar from maven repo and modified and installed to my local m2 repo by changing the version. Since this issue does not exist in

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-09-03 Thread KasunG Gajasinghe
On Mon, Sep 3, 2018 at 11:38 AM Tharindu Wijewardane wrote: > Hi all, > > An update on the previous email. > > In order to automatically generate osgi metadata xmls during the maven > build either of following annotation schemas can be used. > > >- Felix SCR annotations >- OSGi

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-09-03 Thread Tharindu Wijewardane
Hi all, An update on the previous email. In order to automatically generate osgi metadata xmls during the maven build either of following annotation schemas can be used. - Felix SCR annotations - OSGi declarative services (DS) annotations Older versions of maven scr plugin has used

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-08-29 Thread Tharindu Wijewardane
Hi all, registry.xboot module has 3 java interfaces (SQLXML, RowId and NClob) they were empty and has the comment: Dummy implementation for jdk6. I removed that module and went ahead. However I'm facing issues getting the maven-scr-plugin to generate the "scr-plugin-generated" folder which

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-08-27 Thread Praminda Jayawardana
Yes, even if we get passed this error now, this will be problematic later at the startup. On Mon, Aug 27, 2018 at 1:19 PM KasunG Gajasinghe wrote: > > Why a java.* package classes are added to our source tree? > > >

Re: [Dev] Upgrading C4 OSGi to support Java 10

2018-08-27 Thread KasunG Gajasinghe
Why a java.* package classes are added to our source tree? carbon-kernel/core/org.wso2.carbon.registry.xboot/src/main/java/java/sql/SQLXML.java On Mon, Aug 27, 2018 at 1:13 PM Tharindu Wijewardane wrote: > > Thanks Praminda. > I used sisu_ artifacts to build carbon p2 plugin. > > As for the