[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-12-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 @AhyoungRyu @soralee Yeah! CI is green! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

2016-12-01 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1689 @bzz I'v just rebased I will add some commits enumerated above and then mention you when ready. Thanks! --- If your project is set up for it, you can reply to this email and have your re

[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

2016-12-01 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 With number of PRs we have I'm a bit lost, which one will introduce a separate checkstyle CI profile and skip it in all the rest? --- If your project is set up for it, you can reply to this email and

[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

2016-12-01 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1689 @bzz https://github.com/apache/zeppelin/pull/1689/commits/56dfa5232ef3cc58c147f8512cd37d4d3d6e8c4f This commit added the `CHECKSTYLE=1` profile which printing all WARN. And rest

[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

2016-12-01 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 Sounds great! What is rationale for having checkstyle running everywhere + a separate profile? Would it make sense to measure the CI build time with\without separate profile and see if there

[GitHub] zeppelin pull request #1660: [WIP][ZEPPELIN-1594] Personalized mode

2016-12-01 Thread jongyoul
Github user jongyoul closed the pull request at: https://github.com/apache/zeppelin/pull/1660 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (ZEPPELIN-1742) Failed or non-supported checkpoint of note doesn't notify user

2016-12-01 Thread Khalid Huseynov (JIRA)
Khalid Huseynov created ZEPPELIN-1742: - Summary: Failed or non-supported checkpoint of note doesn't notify user Key: ZEPPELIN-1742 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1742 Project:

[GitHub] zeppelin pull request #1712: send error info popup

2016-12-01 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1712 send error info popup ### What is this PR for? To notify user when commit of note revision have failed. ### What type of PR is it? Bug Fix | Improvement ### T

[GitHub] zeppelin pull request #1697: [ZEPPELIN-1352] Refactor Notebook repo versioni...

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1697 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

2016-12-01 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1689 @bzz Recently, i found that checkstyle doesn't need too much time. It takes apprx 12 seconds in my labtop. So i believe it is such a big problem of executing checkstyle plugin in all

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-12-01 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 @bzz I removed `curl build-base make gcc g++` for decreasing the image size, now it's `301 MB`. And `R` is run well. --- If your project is set up for it, you can reply to this email and ha

[GitHub] zeppelin pull request #1702: [ZEPPELIN-1727] Shift + Enter runs two paras in...

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1702 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #1707: Add PythonDockerInterpreter to interpreter grou...

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #1697: [ZEPPELIN-1352] Refactor Notebook repo versioning to r...

2016-12-01 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1697 normally when doing this kind of changes, need to: 1. either override `equals` method or make explicitly static `isEmpty` method that would handle comparison cases. (e.g. `revision1.e

[GitHub] zeppelin pull request #1284: [ZEPPELIN-1291]Tagging meta value on interprete...

2016-12-01 Thread astroshim
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/1284 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] zeppelin pull request #1713: [ZEPPELIN-1530] Update common scripts for Linux...

2016-12-01 Thread lresende
GitHub user lresende opened a pull request: https://github.com/apache/zeppelin/pull/1713 [ZEPPELIN-1530] Update common scripts for Linux and Windows platforms ### What is this PR for? Avoid forcing set the DEBUG environment variable and also review the two common scripts for Lin

Re: Your thoughts on adding webhooks for Slack/Mattermost

2016-12-01 Thread Peter McCaffrey
Hi there! Sorry for such a late reply! In the screenshot, I was thinking that run would refer to a circumstance where someone runs the entire note (as a cron or something) while update would be upon paragraph execution. However, those are very much open to change as they were just general use cases

[GitHub] zeppelin pull request #1710: CI test for #1705

2016-12-01 Thread rhymoid
Github user rhymoid closed the pull request at: https://github.com/apache/zeppelin/pull/1710 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1705: [ZEPPELIN-1729] With CRLF line endings, Livy ge...

2016-12-01 Thread rhymoid
Github user rhymoid closed the pull request at: https://github.com/apache/zeppelin/pull/1705 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1705: [ZEPPELIN-1729] With CRLF line endings, Livy gets HTTP...

2016-12-01 Thread rhymoid
Github user rhymoid commented on the issue: https://github.com/apache/zeppelin/pull/1705 I'm closing this PR, as I now understand that 0.6.3 will not happen. The only thing this PR contributes is some tests for `LivyHelper`, but that class needs a complete rewrite anyway. --- If you

[GitHub] zeppelin issue #1587: [ZEPPELIN-1609] using pyspark(python3) with livy inter...

2016-12-01 Thread purechoc
Github user purechoc commented on the issue: https://github.com/apache/zeppelin/pull/1587 @zjffdu thanks to comment. i am wait #1612 #1612 is LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] zeppelin pull request #1612: ZEPPELIN-1607. Refactor Livy Interpreter to ada...

2016-12-01 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1612 ZEPPELIN-1607. Refactor Livy Interpreter to adapt scope mode ### What is this PR for? ZEPPELIN-1606 will make scoped mode as the default interpreter mode of livy. This PR is to refactor livy

[GitHub] zeppelin pull request #1612: ZEPPELIN-1607. Refactor Livy Interpreter to ada...

2016-12-01 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1612 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #1705: [ZEPPELIN-1729] With CRLF line endings, Livy gets HTTP...

2016-12-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1705 Thanks @rhymoid, I am refactoring LivyInterpreter now in #1612 , refactoring LivyHelp is my next step. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin pull request #1703: [DOCS] Update Shiro conf file with new package ...

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1703 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

2016-12-01 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 I see what you mean, for profile not included in build roster by default we would need to update the CI profile. Well, it's 12s * 10 (number of profile we have no), which looks like 2min time, but we

[GitHub] zeppelin pull request #1500: [ZEPPELIN-1371]add text/numeric conversion supp...

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1500 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #1708: [ZEPPELIN-1728] Add an example configuring clas...

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1708 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #1714: Fe explicit arguments

2016-12-01 Thread felizbear
GitHub user felizbear opened a pull request: https://github.com/apache/zeppelin/pull/1714 Fe explicit arguments ### What is this PR for? This is `paragraph.controller.js` maintenance PR. It refactors most functions in paragraph controller to accept explicit parameters instead of

[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

2016-12-01 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1689 Now `CHECKSTYLE=1` passes CI. (https://travis-ci.org/1ambda/zeppelin/jobs/180609577) But I can't find checkstyle `WARN` log starting with prefix `[WARN]` in travis CI log for example,

[GitHub] zeppelin issue #1714: Use explicit arguments in functions in paragraph.contr...

2016-12-01 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1714 Looks great to me, thank you @felizbear for frontend code improvements! Let's wait for CI, meanwhile, would you mind creating a JIRA issue please? --- If your project is set up for it, you c

[jira] [Created] (ZEPPELIN-1743) Frontend refactoring: use explicit arguments in functions in paragraph.controller.js

2016-12-01 Thread Ilya Malyanov (JIRA)
Ilya Malyanov created ZEPPELIN-1743: --- Summary: Frontend refactoring: use explicit arguments in functions in paragraph.controller.js Key: ZEPPELIN-1743 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1743

[GitHub] zeppelin pull request #1715: [ZEPPELIN-1740] Focus next paragraph after para...

2016-12-01 Thread soralee
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/1715 [ZEPPELIN-1740] Focus next paragraph after paragraph deletion ### What is this PR for? This PR is for moving focus next paragraph after paragraph deletion using Ctrl-Alt-D. After paragrap

[GitHub] zeppelin issue #1712: [ZEPPELIN-1742] send error info to popup when commit f...

2016-12-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1712 Tested and LGTM. Thanks @khalidhuseynov for the update. Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have y

[GitHub] zeppelin issue #1711: [ZEPPELIN-1721] Let each visualization define 'setting...

2016-12-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1711 I think test failures are irrelevant to this change. Ready to review. ``` AngularElem - should able to be created from implicit conversion Run completed in 1 second, 632 mill

[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] [WIP] Visit and switch notebook...

2016-12-01 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1675 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] [WIP] Visit and switch notebook...

2016-12-01 Thread khalidhuseynov
GitHub user khalidhuseynov reopened a pull request: https://github.com/apache/zeppelin/pull/1675 [ZEPPELIN-1190] [WIP] Visit and switch notebook revisions ### What is this PR for? This is the last step for enabling Zeppelin to work with revisions. It addresses ability to visit c

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

2016-12-01 Thread cloverhearts
GitHub user cloverhearts opened a pull request: https://github.com/apache/zeppelin/pull/1716 [ ZEPPELIN-531 ] execute and stop note in job menu ### What is this PR for? We can note start and stop in job menu. ### What type of PR is it? Improvement ### T

[GitHub] zeppelin issue #1715: [ZEPPELIN-1740] Focus next paragraph after paragraph d...

2016-12-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1715 Thanks @soralee for the nice improvement. Tested and LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] zeppelin issue #1715: [ZEPPELIN-1740] Focus next paragraph after paragraph d...

2016-12-01 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1715 Good feature! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] zeppelin issue #1715: [ZEPPELIN-1740] Focus next paragraph after paragraph d...

2016-12-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1715 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] zeppelin issue #1661: [ZEPPELIN-1605] zeppelin-interpreter: don't publish sh...

2016-12-01 Thread minahlee
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1661 @bzz Thank you for review, I just rebased. And yes, the way you described is correct way to test this PR, I updated it in description. --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

2016-12-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1688 CI test failed with ``` Results : Tests in error: ParagraphActionsIT.testRemoveButton:155->AbstractZeppelinIT.clickAndWait:131 » ElementNotVisible ParagraphActi

[jira] [Created] (ZEPPELIN-1744) We should move to editable paragraph move in job menu

2016-12-01 Thread CloverHearts (JIRA)
CloverHearts created ZEPPELIN-1744: -- Summary: We should move to editable paragraph move in job menu Key: ZEPPELIN-1744 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1744 Project: Zeppelin

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-12-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1630 Tested and working really nicely. Looks awesome to me! Thanks @tae-jun for the great contribution! --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] zeppelin pull request #1718: [HOTFIX] Restore uninteded change of exit code ...

2016-12-01 Thread minahlee
GitHub user minahlee opened a pull request: https://github.com/apache/zeppelin/pull/1718 [HOTFIX] Restore uninteded change of exit code in testing/dowloadSpark.sh ### What is this PR for? This PR rollbacks unintended change of exit code in `testing/downloadSpark.sh` after #1599

[GitHub] zeppelin pull request #1717: replace to movement for paragraph in job menu

2016-12-01 Thread cloverhearts
GitHub user cloverhearts opened a pull request: https://github.com/apache/zeppelin/pull/1717 replace to movement for paragraph in job menu ### What is this PR for? We should move to editable paragraph move in job menu currently, moved to readonly mode ### What type o

[GitHub] zeppelin pull request #1672: ZEPPELIN-1701: User impersonation not work with...

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1672 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #:

2016-12-01 Thread minahlee
Github user minahlee commented on the pull request: https://github.com/apache/zeppelin/commit/b6cd47996038bafd3c05caf8f17b26f0d30f3224#commitcomment-20043963 In testing/downloadSpark.sh: In testing/downloadSpark.sh on line 23: Thank you for pointing it out! I created #1718 to r

[GitHub] zeppelin issue #1715: [ZEPPELIN-1740] Focus next paragraph after paragraph d...

2016-12-01 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1715 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1719: missing lastExecuteTime function

2016-12-01 Thread cloverhearts
GitHub user cloverhearts opened a pull request: https://github.com/apache/zeppelin/pull/1719 missing lastExecuteTime function ### What is this PR for? Added last note run time. This was a bug. The function was configured, but the function to output it was missing.

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

2016-12-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1672 @prabhjyotsingh I can not run pyspark interpreter. Can you try that in your enviroment ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

2016-12-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1672 Please ignore it,I can ran it successfully now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

2016-12-01 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1672 Thank you for the verification. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] zeppelin pull request #1720: Fix case where user use zeppelin in normal mode...

2016-12-01 Thread anthonycorbacho
GitHub user anthonycorbacho opened a pull request: https://github.com/apache/zeppelin/pull/1720 Fix case where user use zeppelin in normal mode with token ### What is this PR for? Fix the case where user use zeppelin in normal mode (doesnt use authentication) and set zeppelinhub

[GitHub] zeppelin pull request #1721: order by note name in job menu

2016-12-01 Thread cloverhearts
GitHub user cloverhearts opened a pull request: https://github.com/apache/zeppelin/pull/1721 order by note name in job menu ### What is this PR for? we can sort by note name in job menu. Sorting supports ascending and descending order. Sort by note name. ### What

[GitHub] zeppelin pull request #1688: [ZEPPELIN-1637] Add button for "create next blo...

2016-12-01 Thread krskoondra
GitHub user krskoondra reopened a pull request: https://github.com/apache/zeppelin/pull/1688 [ZEPPELIN-1637] Add button for "create next block as copy of this block" ### What is this PR for? Added new buttton "Copy paragraph" near run button. This new button create copy of curre

[GitHub] zeppelin pull request #1688: [ZEPPELIN-1637] Add button for "create next blo...

2016-12-01 Thread krskoondra
Github user krskoondra closed the pull request at: https://github.com/apache/zeppelin/pull/1688 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature