[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-07-26 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 I would like your views @felixcheung @zjffdu @Tagar on the following approach to escaping and regex errors etc: I wish to suggest that no escaping is needed, as the substitution

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

2017-07-26 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2326 Hi @vipul1409 , Could you check https://github.com/apache/zeppelin/pull/2505? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note

2017-07-26 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2490 @tinkoff-dwh It's the default binding in emacs mode. ## in default modes https://github.com/ajaxorg/ace/wiki/Default-Keyboard-Shortcuts

[GitHub] zeppelin issue #2495: [HOTFIX] JDBC completions. fix cursor position

2017-07-26 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2495 @felixcheung another solution to count whitespaces CI green https://travis-ci.org/tinkoff-dwh/zeppelin/builds/257656645 --- If your project is set up for it, you can reply to this

[GitHub] zeppelin pull request #2495: [HOTFIX] JDBC completions. fix cursor position

2017-07-26 Thread tinkoff-dwh
GitHub user tinkoff-dwh reopened a pull request: https://github.com/apache/zeppelin/pull/2495 [HOTFIX] JDBC completions. fix cursor position ### What is this PR for? If text of paragraph contains interpreter name then parser works incorrect (cursor position incorrect).

[GitHub] zeppelin pull request #2495: [HOTFIX] JDBC completions. fix cursor position

2017-07-26 Thread tinkoff-dwh
Github user tinkoff-dwh closed the pull request at: https://github.com/apache/zeppelin/pull/2495 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2504: ZEPPELIN-2811. Specify precise explicitly for travis b...

2017-07-26 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2504 This is because travis use 'precise' by default before, so at that time it is OK when we don't specify dist. But now travis is upgrading ubuntu from `precise` to `trusty`, `trusty` will become

[GitHub] zeppelin issue #1151: Fonted download chinese garbled fix

2017-07-26 Thread ebuildy
Github user ebuildy commented on the issue: https://github.com/apache/zeppelin/pull/1151 Hello, the Jira issue is still opened https://issues.apache.org/jira/browse/ZEPPELIN-1137 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #2504: ZEPPELIN-2811. Specify precise explicitly for travis b...

2017-07-26 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2504 I will merge it soon, as it affect all the following PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2504: ZEPPELIN-2811. Specify precise explicitly for travis b...

2017-07-26 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2504 I get that, I see one test matrix is explicitly setting dist to trusty, and so I assume some tests passes on trusty at least e2e test

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-07-26 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 Thank you for the observations @felixcheung. Will review these points and make suitable changes. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin pull request #2504: ZEPPELIN-2811. Specify precise explicitly for t...

2017-07-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2504 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2504: ZEPPELIN-2811. Specify precise explicitly for travis b...

2017-07-26 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2504 fair enough --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] zeppelin issue #2504: ZEPPELIN-2811. Specify precise explicitly for travis b...

2017-07-26 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2504 yeah, seems e2e tests needs trusty. @1ambda may have more context. A long term solution might be to upgrade all tests to trusty, but may need more changes. This PR is just trying to make the

[jira] [Created] (ZEPPELIN-2812) JDBC driver for Denodo

2017-07-26 Thread Pasha (JIRA)
Pasha created ZEPPELIN-2812: --- Summary: JDBC driver for Denodo Key: ZEPPELIN-2812 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2812 Project: Zeppelin Issue Type: Improvement

[GitHub] zeppelin issue #497: ZEPPELIN-143: Git as a versioned notebook storage

2017-07-26 Thread p0wl
Github user p0wl commented on the issue: https://github.com/apache/zeppelin/pull/497 Thanks for the feature! Any news on automatic github integration? Or a guidline how to setup github sync? --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-07-26 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2502 @sanjaydasgupta great job on getting this done. ZEPPELIN-1967 was inspired by Jupyter so I just we should do the same as it is done there. So it's less confusing for users who are switching

[GitHub] zeppelin issue #497: ZEPPELIN-143: Git as a versioned notebook storage

2017-07-26 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/497 @p0wl I started remote git support here: https://github.com/herval/zeppelin/tree/remote-git-support - it's a WIP, if someone wants to take over (it would work w/ github or any other git repo) ---

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-07-26 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2502 The choice of {...} for identifying parameter/variable names comes from the parent issue [ZEPPELIN-1967](https://issues.apache.org/jira/browse/ZEPPELIN-1967). Though #{...} seems more

[GitHub] zeppelin issue #2479: [ZEPPELIN-2762] Use regex to retrieve interpreter/repl...

2017-07-26 Thread dabaitu
Github user dabaitu commented on the issue: https://github.com/apache/zeppelin/pull/2479 Ping for review. This regex will avoid a lot of bugs... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2505: [ZEPPELIN-2806] New paragraph does not displayed befor...

2017-07-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2505 I'll merge this guy as to master as a hotfix. and reopen https://issues.apache.org/jira/browse/ZEPPELIN-2519 --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin pull request #2505: [ZEPPELIN-2806] New paragraph does not displaye...

2017-07-26 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/2505 [ZEPPELIN-2806] New paragraph does not displayed before refresh the page ### What is this PR for? Problem reported in [ZEPPELIN-2806](https://issues.apache.org/jira/browse/ZEPPELIN-2806).

[GitHub] zeppelin pull request #2465: [ZEPPELIN-2724] Move NotebookSocket.send() out ...

2017-07-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2465 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2422: [WIP] [ZEPPELIN-2627] Interpreter refactor

2017-07-26 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2422 Thanks @herval for the review. If you have time, you can also check the unit test which is much more readable and will easy for you to get what I done in this PR. (InterpreterFactoryTest,