[GitHub] [zeppelin] Reamer commented on pull request #3752: [Zeppelin 4779] Allow Notebook directory to be nested within Git Repo

Reamer commented on pull request #3752: URL: https://github.com/apache/zeppelin/pull/3752#issuecomment-620648549 I think I understand your approach. You should change your view. `ZEPPELIN_NOTEBOOK_DIR` should handle the Git Root-Directory you should introduce a new variable like

[GitHub] [zeppelin] zjffdu commented on pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter

zjffdu commented on pull request #3640: URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-620613910 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] rhajek commented on pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter

rhajek commented on pull request #3640: URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-620538963 I rebased PR, Travis also build looks ok. This is an automated message from the Apache Git Service. To

[GitHub] [zeppelin] rhajek edited a comment on pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter

rhajek edited a comment on pull request #3640: URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-620538963 I rebased PR, Travis build also looks ok. This is an automated message from the Apache Git Service.

[GitHub] [zeppelin] Muhammad-ms commented on a change in pull request #3752: [Zeppelin 4779] Allow Notebook directory to be nested within Git Repo

Muhammad-ms commented on a change in pull request #3752: URL: https://github.com/apache/zeppelin/pull/3752#discussion_r416428993 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/GitNotebookRepo.java ## @@ -20,6 +20,7 @@ import

[GitHub] [zeppelin] Reamer edited a comment on pull request #3752: [Zeppelin 4779] Allow Notebook directory to be nested within Git Repo

Reamer edited a comment on pull request #3752: URL: https://github.com/apache/zeppelin/pull/3752#issuecomment-620464378 Why don't you work with a subpath (concat a subpath to nodebookdir)? I think it should make things easier.

[GitHub] [zeppelin] Reamer commented on pull request #3752: [Zeppelin 4779] Allow Notebook directory to be nested within Git Repo

Reamer commented on pull request #3752: URL: https://github.com/apache/zeppelin/pull/3752#issuecomment-620464378 Why don't you work with a subpath? I think it should make things easier. This is an automated message from the

[GitHub] [zeppelin] Muhammad-ms commented on pull request #3752: [Zeppelin 4779] Allow Notebook directory to be nested within Git Repo

Muhammad-ms commented on pull request #3752: URL: https://github.com/apache/zeppelin/pull/3752#issuecomment-620469750 > Why don't you work with a subpath (concat a subpath to nodebookdir)? I think it should make things easier. Using subpath changes git commands in a way which breaks

[GitHub] [zeppelin] Muhammad-ms edited a comment on pull request #3752: [Zeppelin 4779] Allow Notebook directory to be nested within Git Repo

Muhammad-ms edited a comment on pull request #3752: URL: https://github.com/apache/zeppelin/pull/3752#issuecomment-620469750 > Why don't you work with a subpath (concat a subpath to nodebookdir)? I think it should make things easier. Using subpath changes git commands in a way which

[GitHub] [zeppelin] Muhammad-ms opened a new pull request #3752: [Zeppelin 4779] Allow Notebook directory to be nested within Git Repo

Muhammad-ms opened a new pull request #3752: URL: https://github.com/apache/zeppelin/pull/3752 ### What is this PR for? This PR allows Git repo directory and notebook directory to be separated so users have the option of having notebook directory nested within git repo. This would

[GitHub] [zeppelin] Reamer commented on a change in pull request #3752: [Zeppelin 4779] Allow Notebook directory to be nested within Git Repo

Reamer commented on a change in pull request #3752: URL: https://github.com/apache/zeppelin/pull/3752#discussion_r416426383 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/GitNotebookRepo.java ## @@ -20,6 +20,7 @@ import

[GitHub] [zeppelin] alexott commented on pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter

alexott commented on pull request #3640: URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-620554272 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to