[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1464 @corneadoug : If a user creates a note with same name, it would do no good to that user itself as it confuses him. For resolving the scenario, we can pick one of the below ways 1. we should have one unique notebook name across the server.(Not quite a solution) 2. we can follow unique notebook name per user in server. In case if a note is shared by the creator with other users, an extra information should be available to user like below in home page of notebook **NoteName** _**(created by user1)**_ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user rajarajan-g commented on the issue:
https://github.com/apache/zeppelin/pull/1464
@jongyoul : Hey i was quite busy for sometime.
I was trying to resolve the commit issues that you have pointed out.
but while during rebase i am getting below error
```
git rebase master
First, rewinding head to replay your work on top of it...
Applying: Code changes for ZEPPELIN-796
Using index info to reconstruct a base tree...
M
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
M zeppelin-web/src/components/noteName-create/notename.controller.js
M zeppelin-web/src/components/noteName-import/note-import-dialog.html
M zeppelin-web/src/components/noteName-import/notenameImport.controller.js
M zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js
:18: trailing whitespace.
* @throws DuplicateNameException
:40: trailing whitespace.
* @throws DuplicateNameException
:98: trailing whitespace.
* @throws DuplicateNameException
:175: trailing whitespace.
:187: trailing whitespace.
conn.send(serializeMessage(new Message(OP.ERROR_DIALOG).put("info",
warning: squelched 21 whitespace errors
warning: 26 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging
zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js
CONFLICT (content): Merge conflict in
zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js
Auto-merging
zeppelin-web/src/components/noteName-import/notenameImport.controller.js
CONFLICT (content): Merge conflict in
zeppelin-web/src/components/noteName-import/notenameImport.controller.js
Auto-merging
zeppelin-web/src/components/noteName-import/note-import-dialog.html
Auto-merging
zeppelin-web/src/components/noteName-create/notename.controller.js
CONFLICT (content): Merge conflict in
zeppelin-web/src/components/noteName-create/notename.controller.js
Auto-merging
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
Failed to merge in the changes.
Patch failed at 0001 Code changes for ZEPPELIN-796
The copy of the patch that failed is found in:
/home/rajarajang/Workspace/stsWorksapce/zeppelin/.git/rebase-apply/patch
When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase
--abort".
```
Even though after i resolve the conflicts, again it shows conflict again
and not able to remove that unnecessary commit that you pointed out. Please
help me out on resolving that issue
Please let me know if anyone has faced this issue and also please let me if
there is a way to resolve this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1464 Well the problem here is that there is really nothing you can do, you are not going to change your Notebook name, or somebody else notebook name because both name are the same --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1464 @corneadoug : Nice catch. I didn't check that scenario. Will let you once, i figure out a way. Let me check the current implementation too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1464 @jongyoul : Thanks for noticing that. I didn't make those changes. Those changes seems to come from another commit. Need to check that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1464 @rajarajan-g How do you handle if another user with same notebook name decides to gives you read ability on his notebook? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1464 I think this PR contains wrong changes like JDBC*. Is it correct? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1464 CI build is green & success. Please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1464 Going to reopen the pull request to trigger CI build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1464 @khalidhuseynov : Lets say if i create a note with name 'Note'. If zeppelin allows me to create a new note with name 'Note', then after sometime when i search for one of this note, I am going to get confused here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1464 @rajarajan-g why do you think it's a problem having same note title/name with existing one. could you give more context? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
