Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2322
Merge to master and branch-0.7 if no further comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2322
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2322
I reverted back modifications to concurrency management since it looks like
they result in Ui response instability, I'm not sure why this happens, I
believe that we can conclude with a clean PR
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2322
Thanks @andreaTP !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2322
@Leemoonsoo sounds good :-) I'll do that tomorrow!
and I will follow up with this PR. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2322
@andreaTP Yes. separate PR would be more helpful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2322
@Leemoonsoo I can reproduce the error locally running on Chrome (i.e. the
current encoding of the test doesn't work for me out of the box with chrome),
should I separate these modifications in a
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2322
@andreaTP Changes on file ZeppelinIT.java are required? And It'll be great
if this branch is rebased (or merge) to master and see CI becomes green.
---
If your project is set up for it, you
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2322
am I supposed to do anything else?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2322
LGTM
> Looking at the code it looks quite harmful also the pattern used here,
here and here
Further refactoring on codes pointed out sounds good as well.
---
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2322
I have had to fix some escaping problems to make travis happy, and it also
required some retries
anyhow travis is now happy:
https://travis-ci.org/nokia/zeppelin/builds/230331180
Github user FireArrow commented on the issue:
https://github.com/apache/zeppelin/pull/2322
I'm all for refactoring the use of synchronized into using more proper data
types instead. It's to easy to get stuck in a [live|dead]lock when doing the
synchronized yourself
---
If your
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2322
Looking at the code it looks quite harmful also the pattern used
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2322
I think you are getting a ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
14 matches
Mail list logo
