[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-08-16 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2923 Can you guys please have a look at https://issues.apache.org/jira/browse/ZEPPELIN-3719 in case if this change caused that problem ? ---

[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-04-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2923 https://travis-ci.org/VipinRathor/zeppelin/builds/369033290 looks flaky, works well on local. Merging this to master and branch-0.8 if no more discussion. ---

[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-04-20 Thread VipinRathor
Github user VipinRathor commented on the issue: https://github.com/apache/zeppelin/pull/2923 @Tagar, me & @prabhjyotsingh did discuss notebook authorization changes but somehow I missed to include them. I committed those changes yesterday. Now notebook authorization will also be mindf

[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-04-18 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2923 I was thinking we should also lower-case usernames that are stored in `notebook-authorization.json`, when doing authorization. Otherwise users wouldn't be able to see their own notebooks when this o

[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-04-17 Thread VipinRathor
Github user VipinRathor commented on the issue: https://github.com/apache/zeppelin/pull/2923 After few more retries, only 2/11 are failing now. Just restarted them again with the hope that those 2 will succeed too. ---

[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-04-17 Thread VipinRathor
Github user VipinRathor commented on the issue: https://github.com/apache/zeppelin/pull/2923 5/11 builds are still failing but due to unrelated errors. Tried restarting failed one multiple times. All 5 are showing different errors. We can either ignore them or fix them in separate iss

[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-04-14 Thread r-kamath
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/2923 @VipinRathor #2928 ---

[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-04-14 Thread r-kamath
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/2923 @VipinRathor can you try removing `npm cache clear` from .travis.yml ? otherwise add `--force`. npm doc says. > All data that passes through the cache is fully verified for integrity

[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-04-12 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2923 LGTM @prabhjyotsingh could you help take a look at the npm error in travis ? Some other contributors also hit this same in other PR recently. ---

[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-04-12 Thread VipinRathor
Github user VipinRathor commented on the issue: https://github.com/apache/zeppelin/pull/2923 All Travis CI builds are failing for some npm error. Looks unrelated but I'm not sure. I need some help in getting this through. CC: @prabhjyotsingh @r-kamath ---

[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-04-12 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2923 Great idea.. I had a similar jira https://issues.apache.org/jira/browse/ZEPPELIN-2886 Thanks! ---

[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-04-12 Thread VipinRathor
Github user VipinRathor commented on the issue: https://github.com/apache/zeppelin/pull/2923 This can also be tested via REST APIs like this: 1. Login and get cookie as CaMel case user: curl -iv -b /tmp/cookie -c /tmp/cookie --data "userName=CaMel&password=passw0rd" -X POST ht

[GitHub] zeppelin issue #2923: ZEPPELIN-3312 Add option to convert username to lower ...

2018-04-12 Thread VipinRathor
Github user VipinRathor commented on the issue: https://github.com/apache/zeppelin/pull/2923 @prabhjyotsingh @felixcheung @zjffdu Can you please help review? Thanks. ---