Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/561#discussion_r201620682
--- Diff: src/java/main/org/apache/zookeeper/jmx/MBeanRegistry.java ---
@@ -124,9 +124,7 @@ private void unregister(String path,ZKMBeanInfo bean)
throws
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539817#comment-16539817
]
Andor Molnar commented on ZOOKEEPER-3084:
-
[~lvfangmin] Would you please kind
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/548
@mjeelanimsft I keep trying to refresh the page, but again I can't see the
new tests.
Also the patch has some conflicts with the latest master, would you please
resolve them?
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2930:
--
Labels: pull-request-available (was: )
> Leader cannot be elected due to network t
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/465
Will this patch be merged to 3.4 branchï¼
---
Github user JonathanO commented on the issue:
https://github.com/apache/zookeeper/pull/456
Rebased on top of latest master.
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/534#discussion_r201723327
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -149,15 +185,12 @@ public
StaticHostProvider(Collection serverAddress
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540221#comment-16540221
]
Hadoop QA commented on ZOOKEEPER-2184:
--
-1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1925/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 35.14 KB...]
[exec]
[exec
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1924/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 84.95 MB...]
[exec]
[exec
+1. the xsum/sig are good. rat seemed fine. ran through a number of cluster
scenarios and it seemed to work fine.
I notice that the dynamic IP change is in - I'd recommend folks that have
been advocating for that change to give the RC a try and verify that it's
working for them. Great way to pay b
GitHub user cpoerschke opened a pull request:
https://github.com/apache/zookeeper/pull/566
ZOOKEEPER-3062: mention fsync.warningthresholdms in FileTxnLog LOG.warn
message
https://issues.apache.org/jira/browse/ZOOKEEPER-3062
You can merge this pull request into a Git repository by r
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3062:
--
Labels: pull-request-available (was: )
> mention fsync.warningthresholdms in FileT
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540578#comment-16540578
]
Hadoop QA commented on ZOOKEEPER-3062:
--
-1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1926/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 86.02 MB...]
[exec]
[exec
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540583#comment-16540583
]
Christine Poerschke commented on ZOOKEEPER-3062:
bq. ... Findbugs war
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540621#comment-16540621
]
Hadoop QA commented on ZOOKEEPER-2184:
--
-1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1927/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 85.91 MB...]
[exec]
[exec
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/534
@lvfangmin Unit tests failed, but it seems like we also introduced a
findbug issue with #562
Shall I fix it in this patch or would you like to do it separately?
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1928/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 2.29 KB...]
stderr:
Also: hudson
Github user mjeelanimsft commented on the issue:
https://github.com/apache/zookeeper/pull/548
@anmolnar Resolved the merge conflict. You can see the commit with the unit
test changes here -
https://github.com/apache/zookeeper/pull/548/commits/ff4704984203921071877bdee4efef47b8c2a706
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated ZOOKEEPER-1859:
--
Description:
{code}
final PrintWriter pwriter = new PrintWriter(
new Buffer
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1929/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 85.86 MB...]
[exec] +1 java
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540812#comment-16540812
]
Hadoop QA commented on ZOOKEEPER-3057:
--
-1 overall. GitHub Pull Request Build
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1458/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 40.00 KB...]
[junit] Running org.apache.zookeep
See https://builds.apache.org/job/ZooKeeper-trunk/96/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 142.50 KB...]
[junit] Tests run: 1, Failures: 0, Errors:
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/466
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt resolved ZOOKEEPER-2940.
-
Resolution: Fixed
Fix Version/s: 3.5.5
3.6.0
Issue resolved
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/466
+1, lgtm. Also tried running against a runtime cluster and it worked ok.
committed to 3.5.5 and master. Thanks @anmolnar .
---
Github user lavacat closed the pull request at:
https://github.com/apache/zookeeper/pull/521
---
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1036/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 61.90 KB...]
[junit] Running org.apache.zookeep
Thanks Pat!
Just double check, a release requires at least three binding (PMC) votes,
right? I guess my own vote (as the release manager) does not count, so we
need one more vote from a PMC member before we can release this (currently
two bindings are from you and Rakesh).
On Wed, Jul 11, 2018 at
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1989/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 40.25 KB...]
[junit] Running org.apache.zookeep
Your vote counts - 3 +1 from PMC is all we need. Would be great to see some
of the other folks vote though.
Patrick
On Wed, Jul 11, 2018 at 6:54 PM Michael Han wrote:
> Thanks Pat!
>
> Just double check, a release requires at least three binding (PMC) votes,
> right? I guess my own vote (as the
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/534#discussion_r201894799
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -149,15 +185,12 @@ public
StaticHostProvider(Collection serverAddresses,
Thanks Pat for confirmation.
I'll leave the rest of the week for folks to try the release candidate and
provide feedback. As Pat mentioned, helping voting a release is a great way
to make contributions to ZooKeeper, so any help will be very welcome!
I'll start publish the new release early next w
Github user maoling closed the pull request at:
https://github.com/apache/zookeeper/pull/533
---
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r201923793
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -226,17 +230,25 @@ static public InitialMessage parse(Long
protoc
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r201926608
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -857,15 +869,15 @@ public void run() {
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r201923508
--- Diff: src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java
---
@@ -61,10 +61,16 @@ static public String getClientConfigStr(String
configDa
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r201901490
--- Diff:
src/java/test/org/apache/zookeeper/server/util/ConfigUtilsTest.java ---
@@ -29,4 +30,21 @@ public void testSplitServerConfig() throws
ConfigExc
41 matches
Mail list logo