See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/121/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 43.45 KB...]
[junit] Running
I also wanted to get other's views on this.
My opinion is that the current server configuration format
(server.x=ip:port:port:role;ip:port) has run its course. There are multiple
proposals for additions/changes to the server configuration,
that would be simplified from having a more extensible
Il giorno mar 13 nov 2018 alle ore 16:47 Alexander Shraer
ha scritto:
>
> I also wanted to get other's views on this.
>
> My opinion is that the current server configuration format
> (server.x=ip:port:port:role;ip:port) has run its course. There are multiple
> proposals for additions/changes to
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2121/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 43.50 KB...]
[junit] Running
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685352#comment-16685352
]
Andor Molnar commented on ZOOKEEPER-3018:
-
[~danielchan] [~clouds xu] Clock skew?
>
Hi Ted,
Thanks for your contribution and the accurate design of this proposal. I
have the following comments on it:
1)
What's the need of the explicit support of multiple network interfaces? DNS
names can resolve into multiple address and we could easily implement
trying the multiple addresses
I think there are two outstanding topics we need converge here.
First - does this work (ZOOKEEPER-3188) require a new configuration
subsystem (with new syntax, more powerful features etc)?
Second - what releases should ZOOKEEPER-3188 go in?
For first, technically ZOOKEEPER-3188 is not blocked by
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dinesh Appavoo updated ZOOKEEPER-3190:
--
Summary: Spell check on the Zookeeper server files (was: Spell check the
Github user yisong-yue commented on the issue:
https://github.com/apache/zookeeper/pull/690
ð Thanks for the feedback! ð
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/689
@tumativ There is a very short window that we'll still add the dead watcher
to the cleaner thread, I don't expect that will add too much GC overhead for
these small amount of dead watch bits.
Dinesh Appavoo created ZOOKEEPER-3190:
-
Summary: Spell check the Zookeeper server files
Key: ZOOKEEPER-3190
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3190
Project: ZooKeeper
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685975#comment-16685975
]
Clouds Xu commented on ZOOKEEPER-3018:
--
Yes, if leader clock skewed, the thread
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233282137
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -316,16 +251,17 @@ public void
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233278670
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233286512
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/test/TestByteBufAllocator.java
---
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233289109
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +105,102 @@
boolean isConnected() {
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233288683
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +105,102 @@
boolean isConnected() {
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233279457
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
I am going to push this feature out sooner rather than later. That isn't a
question. I and my team are going to do the work. Others are very welcome
to help and I am sure that there will be high value in getting reviews from
a wide group.
But we are already working on the code. And we will be
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685929#comment-16685929
]
Michael Han commented on ZOOKEEPER-3188:
A couple of comments on the high level design:
*
This seems like a good feature for ZooKeeper to eventually have, but I
don't see why it must make 3.4 and 3.5 while other features are pushed out
to 3.6.
Like any other feature, it would be subject to a vote and isn't a
unilateral decision.
On Tue, Nov 13, 2018 at 1:59 PM Ted Dunning wrote:
> I
The general rule at Apache is that if somebody has an itch to implement
something, they do it.
I have a strong need for this feature and will be implementing it. Doing so
doesn't change what features get pushed.
Regarding votes and such, commits are normally only subject to technical
blocks.
Github user yisong-yue commented on the issue:
https://github.com/apache/zookeeper/pull/690
@anmolnar
One drawback I see with this structure is that it makes it harder to
dynamically pick deserialization mode based on a snapshot's filename, since
`FileSnap` manages a whole
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/690
@yisong-yue
Yeah, that's true. Perhaps it would be too much hassle and I'm trying to
over-engineer things here. Let's just leave it as it is now and only do
refactoring if we could benefit
24 matches
Mail list logo
