Re: Maven migration and C client

New JIRA ticket https://issues.apache.org/jira/browse/ZOOKEEPER-3226 I have assigned it to you Norbert as you are working on it. I can pick it up as well Enrico Il giorno gio 20 dic 2018 alle ore 14:44 Norbert Kalmar ha scritto: > > Great question Enrico, I also thought about it. > > There is

Re: Maven migration and C client

Here's the PR, open for feedback! :) https://github.com/apache/zookeeper/pull/741 Regards, Norbert On Thu, Dec 20, 2018 at 2:47 PM Enrico Olivelli wrote: > New JIRA ticket > https://issues.apache.org/jira/browse/ZOOKEEPER-3226 > > I have assigned it to you Norbert as you are working on it. > I

[jira] [Created] (ZOOKEEPER-3226) Activate C Client with a profile, disabled by default

Enrico Olivelli created ZOOKEEPER-3226: -- Summary: Activate C Client with a profile, disabled by default Key: ZOOKEEPER-3226 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3226 Project:

[jira] [Updated] (ZOOKEEPER-3226) Activate C Client with a profile, disabled by default

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3226: -- Affects Version/s: 3.6.0 3.5.4 3.4.13

[jira] [Updated] (ZOOKEEPER-3226) Activate C Client with a profile, disabled by default

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3226: -- Fix Version/s: (was: 3.6.0) > Activate C Client with a profile, disabled by

[jira] [Resolved] (ZOOKEEPER-3216) Make init/sync limit tunable via JMX

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv resolved ZOOKEEPER-3216. --- Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 738

Maven migration and C client

Hi, can't we create a "profile" in order to build and test the C Client ? I think that very few developers are working on it, it is only a burden for Java developers. CI will build and run tests Thoughts ? Enrico

Re: Maven migration and C client

Great question Enrico, I also thought about it. There is actually already a "Linux profile", so that tests only run when it is on Linux system. I wanted to fine grain thath, as ant checks if the required make commands are available. But for a "quick-fix" I made it so that it only runs on Linux.

[jira] [Resolved] (ZOOKEEPER-3219) Fix flaky FileChangeWatcherTest

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv resolved ZOOKEEPER-3219. --- Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 739

Re: Re: ZooKeeper 3.5 blocker issues

I checked the https://issues.apache.org/jira/browse/ZOOKEEPER-3107 - checkstyle ticket. I think we should definitely leave this after maven migration is complete. It needs a lot of code cleanup, and as Enrico have mentioned, probably breaks most current PRs. Also, I think this needs to be voted by

[jira] [Commented] (ZOOKEEPER-3197) Improve documentation in ZooKeeperServer.superSecret

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725816#comment-16725816 ] Colm O hEigeartaigh commented on ZOOKEEPER-3197: Any feedback from the community on

[jira] [Created] (ZOOKEEPER-3228) [TLS] Fix key usage extension in test certs

Ilya Maykov created ZOOKEEPER-3228: -- Summary: [TLS] Fix key usage extension in test certs Key: ZOOKEEPER-3228 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3228 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-3229) [TLS] add AES-256 ciphers to default cipher list

Ilya Maykov created ZOOKEEPER-3229: -- Summary: [TLS] add AES-256 ciphers to default cipher list Key: ZOOKEEPER-3229 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3229 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-3219) Fix flaky FileChangeWatcherTest

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725973#comment-16725973 ] Hudson commented on ZOOKEEPER-3219: --- SUCCESS: Integrated in Jenkins build

[jira] [Commented] (ZOOKEEPER-3216) Make init/sync limit tunable via JMX

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725974#comment-16725974 ] Hudson commented on ZOOKEEPER-3216: --- SUCCESS: Integrated in Jenkins build

[jira] [Commented] (ZOOKEEPER-3219) Fix flaky FileChangeWatcherTest

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726028#comment-16726028 ] Hudson commented on ZOOKEEPER-3219: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #317 (See

[jira] [Commented] (ZOOKEEPER-3216) Make init/sync limit tunable via JMX

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726030#comment-16726030 ] Hudson commented on ZOOKEEPER-3216: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #317 (See

[jira] [Commented] (ZOOKEEPER-3223) Configure Spotbugs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725985#comment-16725985 ] Enrico Olivelli commented on ZOOKEEPER-3223: [~nkalmar] here it is the patch

Re: Maven migration and C client

Spotbugs: https://github.com/apache/zookeeper/pull/742 Enrico Il giorno gio 20 dic 2018 alle ore 15:09 Norbert Kalmar ha scritto: > > Here's the PR, open for feedback! :) > https://github.com/apache/zookeeper/pull/741 > > Regards, > Norbert > > On Thu, Dec 20, 2018 at 2:47 PM Enrico Olivelli

[jira] [Assigned] (ZOOKEEPER-3228) [TLS] Fix key usage extension in test certs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilya Maykov reassigned ZOOKEEPER-3228: -- Assignee: Ilya Maykov > [TLS] Fix key usage extension in test certs >

[jira] [Commented] (ZOOKEEPER-3223) Configure Spotbugs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726025#comment-16726025 ] Enrico Olivelli commented on ZOOKEEPER-3223: I did not use the old exclusions file but I

[jira] [Updated] (ZOOKEEPER-3227) Address Spotbugs: DM_DEFAULT_ENCODING issues

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3227: --- Description: In a lot of places we are using the default encoding. Spotbugs is

[jira] [Commented] (ZOOKEEPER-3228) [TLS] Fix key usage extension in test certs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726107#comment-16726107 ] Ilya Maykov commented on ZOOKEEPER-3228: See https://github.com/apache/zookeeper/pull/743 >

[jira] [Commented] (ZOOKEEPER-3125) Pzxid inconsistent issue when replaying a txn for a deleted node

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726031#comment-16726031 ] Hudson commented on ZOOKEEPER-3125: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #317 (See

[jira] [Created] (ZOOKEEPER-3227) Address Spotbugs: DM_DEFAULT_ENCODING issues

Enrico Olivelli created ZOOKEEPER-3227: -- Summary: Address Spotbugs: DM_DEFAULT_ENCODING issues Key: ZOOKEEPER-3227 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3227 Project: ZooKeeper

Re: owasp job just started flagging slf4j

Thanks Enrico, I commented on the PR, lmk if that doesn't make sense. Patrick On Mon, Dec 17, 2018 at 8:34 AM Enrico Olivelli wrote: > Here it is > https://github.com/apache/zookeeper/pull/736 > > I have disable all jars for slf4j, I can narrow the patch down to the > single file. I don't know

回复：Re: ZooKeeper 3.5 blocker issues

@Norbert @Enrico About the checkstyle Since there were so many,many checkstyle violations in the zk code base so the CI with checkstyle should ingore the existing codes, only act upon the new codes(new PR) After that, we can clean up the violations in the code base one module by another,one

[jira] [Commented] (ZOOKEEPER-3197) Improve documentation in ZooKeeperServer.superSecret

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726410#comment-16726410 ] maoling commented on ZOOKEEPER-3197: [~coheigea] just go ahead! The contributor guideline is

Re: Re: ZooKeeper 3.5 blocker issues

Il ven 21 dic 2018, 04:24 毛蛤丝 ha scritto: > @Norbert @Enrico > About the checkstyle > Since there were so many,many checkstyle violations in the zk code base > so the CI with checkstyle should ingore the existing codes, only act upon > the new codes(new PR) > After that, we can clean up the

[jira] [Assigned] (ZOOKEEPER-3224) CI integration with maven

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli reassigned ZOOKEEPER-3224: -- Assignee: Enrico Olivelli > CI integration with maven >

[jira] [Updated] (ZOOKEEPER-3223) Configure Spotbugs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3223: --- Description: First, master only. (was: Create the static code analyser : -

Re: ZooKeeper 3.5 blocker issues

One more thing - for the CI integration, actually, Java reports from Clover - by maven - should be already available on master. Basically we only analyse zookeeper-server, but as it is planned to be seperated, I wrote Clover so it starts from root pom and aggregates the results. On Thu, Dec 20,

Re: ZooKeeper 3.5 blocker issues

Il giorno gio 20 dic 2018 alle ore 10:20 Norbert Kalmar ha scritto: > > One more thing - for the CI integration, actually, Java reports from Clover > - by maven - should be already available on master. Basically we only > analyse zookeeper-server, but as it is planned to be seperated, I wrote >

Build failed in Jenkins: ZooKeeper-trunk-owasp #211

See Changes: [andor] ZOOKEEPER-3029: add pom.xml for jute, client and server -- [...truncated 13.42 KB...] [ivy:retrieve] found commons-cli#commons-cli;1.2 in maven2

回复：Re: ZooKeeper 3.5 blocker issues

@Norbert this issue about Checkstyle is on your plan? https://issues.apache.org/jira/browse/ZOOKEEPER-3107 - 原始邮件 - 发件人：Norbert Kalmar 收件人：dev@zookeeper.apache.org 主题：Re: ZooKeeper 3.5 blocker issues 日期：2018年12月20日 17点07分 Subtasks: Findbugs, checkstyle -

[jira] [Updated] (ZOOKEEPER-3029) Create pom files for jute, server and client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3029: -- Summary: Create pom files for jute, server and client (was: Create assembly for

[jira] [Assigned] (ZOOKEEPER-3029) Create pom files for jute, server and client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar reassigned ZOOKEEPER-3029: - Assignee: Norbert Kalmar > Create pom files for jute, server and client >

[jira] [Updated] (ZOOKEEPER-3029) Create pom files for jute, server and client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3029: -- Description: After the directory structures has been created, it is time to create

Re: Re: ZooKeeper 3.5 blocker issues

Hi, I created this jira for static code analysis - https://issues.apache.org/jira/browse/ZOOKEEPER-3223 Enrico mentioned he doesn't recommend it. I didn't go into this topic in detail yet, so maybe you should check in on that jira. I'll have a look later today. Thanks for bringing attention to

Re: Re: ZooKeeper 3.5 blocker issues

Il giorno gio 20 dic 2018 alle ore 10:44 Norbert Kalmar ha scritto: > > Hi, > > I created this jira for static code analysis - > https://issues.apache.org/jira/browse/ZOOKEEPER-3223 I have picked this up and renamed to "Configure spotbugs" Enrico > Enrico mentioned he doesn't recommend it. I

Re: ZooKeeper 3.5 blocker issues

Great. Can you create JIRA tickets for remaining subtask? So that I can pick them up? I volounter for spotbugs and for CI integration, but let's see the list Enrico Il gio 20 dic 2018, 07:21 Andor Molnar ha scritto: > Ok. Looks like ant still works properly, so let’s commit this patch and > you

[jira] [Created] (ZOOKEEPER-3223) Create static code analyser

Norbert Kalmar created ZOOKEEPER-3223: - Summary: Create static code analyser Key: ZOOKEEPER-3223 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3223 Project: ZooKeeper Issue Type:

[jira] [Assigned] (ZOOKEEPER-3223) Create static code analyser

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar reassigned ZOOKEEPER-3223: - Assignee: (was: Norbert Kalmar) > Create static code analyser >

[jira] [Commented] (ZOOKEEPER-3029) Create pom.xml for jute and server

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725668#comment-16725668 ] Norbert Kalmar commented on ZOOKEEPER-3029: --- It's master only for now, will need a patch

ZooKeeper-trunk - Build # 316 - Failure

See https://builds.apache.org/job/ZooKeeper-trunk/316/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 177.20 KB...] [junit] Tests run: 1, Failures: 0,

[jira] [Commented] (ZOOKEEPER-3029) Create pom.xml for jute and server

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725673#comment-16725673 ] Hudson commented on ZOOKEEPER-3029: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #316 (See

[jira] [Assigned] (ZOOKEEPER-3224) CI integration with maven

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar reassigned ZOOKEEPER-3224: - Assignee: (was: Norbert Kalmar) > CI integration with maven >

[jira] [Updated] (ZOOKEEPER-3223) Create static code analyser

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3223: -- Description: Create the static code analyser (findbugs or spotbugs) and reporting

[jira] [Created] (ZOOKEEPER-3224) Create audit workflow for maven build

Norbert Kalmar created ZOOKEEPER-3224: - Summary: Create audit workflow for maven build Key: ZOOKEEPER-3224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3224 Project: ZooKeeper

[jira] [Updated] (ZOOKEEPER-3225) Create code coverage analysis with maven build

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3225: -- Description: Add clover and cobertura to maven build. First, master only. was:

[jira] [Commented] (ZOOKEEPER-3223) Create static code analyser

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725697#comment-16725697 ] Enrico Olivelli commented on ZOOKEEPER-3223: [~nkalmar] it is better to split this issue

[jira] [Updated] (ZOOKEEPER-3223) Create static code analyser

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3223: -- Description: Create the static code analyser (findbugs, spotbugs) and reporting

[jira] [Updated] (ZOOKEEPER-3224) CI integration with maven

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3224: -- Description: Integrate maven build and audit with Jenkins. First, master only. >

[jira] [Updated] (ZOOKEEPER-3224) Create audit workflow for maven build

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3224: -- Description: (was: After the directory structures has been created, it is time

[jira] [Updated] (ZOOKEEPER-3224) CI integration with maven

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3224: -- Summary: CI integration with maven (was: Create audit workflow for maven build)

[jira] [Updated] (ZOOKEEPER-3223) Create static code analyser

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3223: -- Description: Create the static code analyser : - findbugs or spotbugs - checkstyle

[jira] [Created] (ZOOKEEPER-3225) Create code coverage analysis with maven build

Norbert Kalmar created ZOOKEEPER-3225: - Summary: Create code coverage analysis with maven build Key: ZOOKEEPER-3225 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3225 Project: ZooKeeper

Re: ZooKeeper 3.5 blocker issues

Subtasks: Findbugs, checkstyle - https://issues.apache.org/jira/browse/ZOOKEEPER-3223 CI integration - https://issues.apache.org/jira/browse/ZOOKEEPER-3224 Code coverage - https://issues.apache.org/jira/browse/ZOOKEEPER-3225 - I laready started this one and some of it is committed with the patch,

[jira] [Updated] (ZOOKEEPER-3029) Create assembly for maven

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3029: -- Description: Create the tarball assembly for the maven build. End results should

[jira] [Assigned] (ZOOKEEPER-3029) Create assembly for maven

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar reassigned ZOOKEEPER-3029: - Assignee: (was: Norbert Kalmar) > Create assembly for maven >

Re: ZooKeeper 3.5 blocker issues

Great Il giorno gio 20 dic 2018 alle ore 10:07 Norbert Kalmar ha scritto: > > Subtasks: > Findbugs, checkstyle - https://issues.apache.org/jira/browse/ZOOKEEPER-3223 We don't have checksyle. In my experience introducing checkstyle break every pending patch. I would like to narrow down this

[jira] [Updated] (ZOOKEEPER-3029) Create assembly for maven

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3029: -- Summary: Create assembly for maven (was: Create pom.xml for jute and server) >

Re: ZooKeeper 3.5 blocker issues

Sure, sorry about that, I didn't check thoroughly the static analyser part. Spotbugs works for me! Thanks Enrico! On Thu, Dec 20, 2018 at 10:10 AM Enrico Olivelli wrote: > Great > > Il giorno gio 20 dic 2018 alle ore 10:07 Norbert Kalmar > ha scritto: > > > > Subtasks: > > Findbugs,

[jira] [Updated] (ZOOKEEPER-3223) Configure Spotbugs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3223: --- Summary: Configure Spotbugs (was: Create static code analyser) > Configure

[jira] [Assigned] (ZOOKEEPER-3223) Create static code analyser

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli reassigned ZOOKEEPER-3223: -- Assignee: Enrico Olivelli > Create static code analyser >