Re: Maven migration and CI

Awesome! I really looking forward to it. Andor > On 2019. Jan 3., at 22:34, Enrico Olivelli wrote: > > Hi Zookeepers > Now that we have Maven it is time to set up new CI jobs and compare the > results with the Ant based build. > > My proposal is to set up a few jobs and see the results.

[GitHub] eolivelli commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

eolivelli commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-451433617 For what is worth I have been running 3.5 in production on jdk11 for some month without

[GitHub] anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-451442468 @eolivelli Let's move the discussion to the mailing list.

[GitHub] anmolnar commented on issue #754: ZOOKEEPER-3233: Run github pre-commit hook tests on 4 threads (branch-3.5)

anmolnar commented on issue #754: ZOOKEEPER-3233: Run github pre-commit hook tests on 4 threads (branch-3.5) URL: https://github.com/apache/zookeeper/pull/754#issuecomment-451417583 retest this please This is an automated

[GitHub] anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-451428246 @eolivelli Unfortunately I have to agree with you. But that also means Java 11 support of

JAVA 11 build is broken on 3.5

Hi team / Enrico, I’d like to get feedback from the community on the following patch (moving the discussion from GitHub to here): https://issues.apache.org/jira/browse/ZOOKEEPER-3204 https://github.com/apache/zookeeper/pull/753

[jira] [Updated] (ZOOKEEPER-3204) Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3204: -- Labels: pull-request-available (was: ) > Reconfig tests are constantly failing on

[GitHub] anmolnar opened a new pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar opened a new pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753 Looks like that Netty 3 also having problems with correctly closing sockets and we keep getting "Bind failed"

[GitHub] anmolnar opened a new pull request #754: ZOOKEEPER-3233: Run github pre-commit hook tests on 4 threads (branch-3.5)

anmolnar opened a new pull request #754: ZOOKEEPER-3233: Run github pre-commit hook tests on 4 threads (branch-3.5) URL: https://github.com/apache/zookeeper/pull/754 1. Changed number of threads: 8 -> 4 2. Turned off test.output: yes -> no (backport from master)

[jira] [Updated] (ZOOKEEPER-3233) Run github pre-commit hook tests on 4 threads

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3233: -- Labels: pull-request-available (was: ) > Run github pre-commit hook tests on 4

[jira] [Assigned] (ZOOKEEPER-3028) Create assembly in pom.xml

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar reassigned ZOOKEEPER-3028: - Assignee: Norbert Kalmar (was: Tamas Penzes) > Create assembly in pom.xml

[GitHub] nkalmar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

nkalmar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-451432777 Tough call, maybe worth a vote on DEV list. A freshly released 3.5 stable not supporting java11

Re: Jira - GitHub linkage broken?

It’s fixed now. Andor > On 2019. Jan 3., at 11:31, Andor Molnar wrote: > > I opened Infra ticket: > > https://issues.apache.org/jira/browse/INFRA-17532 > > > Andor > > > >> On 2019. Jan 2., at 15:41, Enrico Olivelli >

Re: Jenkins issues

Il ven 4 gen 2019, 09:38 Andor Molnar ha scritto: > Holy … ! It does kill other test processes! > > In test-github-pr.sh: > > "### Kill any rogue build processes from the last attempt” > > Following a kill command which checks for process IDs of previous runs > which potentially matches other

Re: Maven migration and CI

Nicely planned, thanks Enrico! On Fri, Jan 4, 2019 at 9:33 AM Andor Molnar wrote: > Awesome! > > I really looking forward to it. > > Andor > > > > On 2019. Jan 3., at 22:34, Enrico Olivelli wrote: > > > > Hi Zookeepers > > Now that we have Maven it is time to set up new CI jobs and compare the

Re: Jenkins issues

Holy … ! It does kill other test processes! In test-github-pr.sh: "### Kill any rogue build processes from the last attempt” Following a kill command which checks for process IDs of previous runs which potentially matches other executions on the same machine. Is it possible to setup the

[GitHub] anmolnar closed pull request #754: ZOOKEEPER-3233: Run github pre-commit hook tests on 4 threads (branch-3.5)

anmolnar closed pull request #754: ZOOKEEPER-3233: Run github pre-commit hook tests on 4 threads (branch-3.5) URL: https://github.com/apache/zookeeper/pull/754 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

Re: JAVA 11 build is broken on 3.5

What are those patches exactly? Comparing the ported version of 3.5 with master I’ve only found 2 patches which are missing: ZOOKEEPER-3146 Limit the maximum client connections per IP in NettyServerCnxnFactory ZOOKEEPER-3177 Refactor request throttle logic in NIO and Netty to keep the same

[GitHub] eolivelli commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

eolivelli commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-451474494 I will answer to the mailing list as well. I have thought more about this problem, and

[GitHub] anmolnar commented on issue #754: ZOOKEEPER-3233: Run github pre-commit hook tests on 4 threads (branch-3.5)

anmolnar commented on issue #754: ZOOKEEPER-3233: Run github pre-commit hook tests on 4 threads (branch-3.5) URL: https://github.com/apache/zookeeper/pull/754#issuecomment-451473571 Merged. Thanks. This is an automated

Re: JAVA 11 build is broken on 3.5

+1 for Netty 4 in 3.5 Pretty much all the pros and cons has been said before me. I would only add that this is not a new functionality that we wan't to backport. It's a criticall(ish?) bugfix, which requires quite a bit of change unfortunately. Regards, Norbert On Fri, Jan 4, 2019 at 4:36 PM

ZooKeeper_branch35_jdk8 - Build # 1251 - Failure

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1251/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 106.62 KB...] [junit] Tests run: 1, Failures:

Re: JAVA 11 build is broken on 3.5

Il giorno ven 4 gen 2019 alle ore 14:23 Andor Molnar ha scritto: > > Hi team / Enrico, > > I’d like to get feedback from the community on the following patch (moving > the discussion from GitHub to here): > > https://issues.apache.org/jira/browse/ZOOKEEPER-3204 >

Re: JAVA 11 build is broken on 3.5

I got another one: ZOOKEEPER-3163 Use session map to improve the performance when closing session in Netty So, that doesn't seem too many. We can talk about backporting them, but I don't think they're super critical for the first stable release. Regarding 3.4, I need to validate the embedded

Re: Jenkins issues

I have set "Maximum Concurrent Builds Per Node = 1" in https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/ Enrico Il giorno ven 4 gen 2019 alle ore 09:51 Enrico Olivelli ha scritto: > > > > Il ven 4 gen 2019, 09:38 Andor Molnar ha scritto: >> >> Holy … ! It does kill other test

Re: JAVA 11 build is broken on 3.5

Il giorno ven 4 gen 2019 alle ore 17:04 Norbert Kalmar ha scritto: > > +1 for Netty 4 in 3.5 > > Pretty much all the pros and cons has been said before me. > I would only add that this is not a new functionality that we wan't to > backport. It's a criticall(ish?) bugfix, which requires quite a

ZooKeeper_branch34_openjdk7 - Build # 2170 - Failure

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2170/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 44.97 KB...] [junit] Running

Re: Maven migration and CI

Here it is the build on master https://builds.apache.org/job/zookeeper-master-maven/3/ This is running only mvn verify and tests are passing, we have to enable all of the other plugins (spotbugs, OWASP, code coverage...) and enable the C client profile but it is a good starting point Enrico