Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/714
I updated this PR to match the changes made to #703 during review.
Anything else I can do to help?
---
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/719
I believe #707 has @eolivelli's LGTM now.
---
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/715
This is the branch where my colleague Eric Schwartz and I are trying to get
to a "zero flaky tests" standard. (It started as the branch where I worked
on ZOOKEEPER-2778, and
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/707
---
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/719
[ZOOKEEPER-2778] QuorumPeer: address potential reconfiguration deadlocks
* QuorumPeer: encapsulate quorum/election/client addresses in an
AddressTuple held through an AtomicReference
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/719
I don't understand the test failures. Are these unrelated problems in
master?
---
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/713
Zookeeper 1636 (on top of #707 to fix ZOOKEEPER-2778 for a green build)
(Rebased Thawan Kooburat's patch on current layout of 3.5 branch)
You can merge this pull request into a Git repository
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/714
Zookeeper 1818 (on top of #713 to fix ZOOKEEPER-2778 and ZOOKEEPER-1636 for
a green build)
Rebasing Fangmin Lyu's patch from
https://github.com/lvfangmin/zookeeper/tree/ZOOKEEPER-1818 onto
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
The `LeaderBeanTest` failure was real-ish; the mock `QuorumVerifier` wasn't
set up properly for address resolution, so it would NPE (without the new
condvar-style wait for addresses to be set
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
Whoops, just pushed some unrelated stuff to this branch. The code state
that fixes just ZOOKEEPER-2778 is
https://github.com/apache/zookeeper/pull/707/commits
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/528
I'd like to see this brought back. Not cool to drop autoconf when the
CMake setup can't build shared libraries. From
`zookeeper-client/zookeeper-client-c/README`:
```
Current
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
I have pushed an incremental change which should address the lock inversion
scenario more completely, along with condition-variable-style waiting for the
quorum/election address to become non
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
Note that this patch is targeted at the 3.5 release branch, which I'm
trying to help whip into shape for testing in our environment (where 3.4.13 is
already in production use). What else can I
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
Review comments addressed. It's a little bit weird that `ant test` doesn't
recompile the tests when the implementation has changed; an `ant clean`/`ant
test` cycle caught another test failure
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
@afine , does this approach address your concerns with #247?
---
GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/721
ZOOKEEPER-3046: wait for clients to reconnect after restarting server
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mkedwards
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/721
retest this please
---
Github user mkedwards commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/721#discussion_r236097804
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/test/DisconnectedWatcherTest.java
---
@@ -221,6 +228,7 @@ public void
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/721
Except, er, that seems to make the tests fail. ð Investigating.
---
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/721
Fixed that (and tested it locally before pushing this time).
---
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/721
---
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/721
ZOOKEEPER-3046: wait for clients to reconnect after restarting server
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mkedwards/zookeeper
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/723
ZOOKEEPER-3202: Add timing margin to improve reliability of
testClientServerSSL()
Allowing just 5 seconds for 3 quorum peers to start and elect a leader is a
bit tight, at least when running
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/721
I think so too! Done ð
---
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/724
ZOOKEEPER-2488: Synchronized access to shuttingDownLE in QuorumPeer
I think this can be reviewed separately from the (functionally somewhat
related) changes in #707.
You can merge this pull
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/719
Does this look fit to merge? I'm not a committer, so I'll need help
getting it merged. (The version targeted to branch-3.5 is #707.)
---
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
@eolivelli , have I addressed all your concerns? Does this look to you
like a complete fix to ZOOKEEPER-2778?
---
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
That makes perfect sense. Thanks for keeping an eye on this.
---
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/721
retest this please
---
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
After groveling through
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2708/consoleText,
I think this may be a contributing factor to flaky tests:
```
[exec
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
Thanks maoling; I'm familiar with the procedure, just hadn't gotten around
to juggling branches.
---
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/715
Rollup of blocker/critical fixes for 3.5 (to trigger CI)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mkedwards/zookeeper rollup-3.5
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
This PR now has the extraneous changes removed and is green in CI. Please
re-review at your convenience.
---
Github user mkedwards commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/707#discussion_r235807260
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -121,6 +126,18 @@
*/
private
Github user mkedwards commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/707#discussion_r235808196
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -108,7 +109,11 @@
LocalPeerBean
GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/718
ZOOKEEPER-1818: Correctly handle potentially inconsistent
zxid/electionEpochâ¦
⦠and peerEpoch during leader election. (This is Fangmin's patch, I'm
just firing off a CI build against
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/718
---
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/718
---
GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/718
ZOOKEEPER-1818: Correctly handle potentially inconsistent
zxid/electionEpochâ¦
⦠and peerEpoch during leader election. (This is Fangmin's patch, I'm
just firing off a CI build against
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/717
ZOOKEEPER-1636: cleanup completion list of a failed multi request
(from Thawan Kooburat)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/717
ZOOKEEPER-1636: cleanup completion list of a failed multi request
(from Thawan Kooburat)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/717
---
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/718
ZOOKEEPER-1818: Correctly handle potentially inconsistent
zxid/electionEpochâ¦
⦠and peerEpoch during leader election. (This is Fangmin's patch, I'm
just firing off a CI build against
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/717
---
GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/717
ZOOKEEPER-1636: cleanup completion list of a failed multi request
(from Thawan Kooburat)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/718
ZOOKEEPER-1818: Correctly handle potentially inconsistent
zxid/electionEpochâ¦
⦠and peerEpoch during leader election. (This is Fangmin's patch, I'm
just firing off a CI build against
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/718
---
Github user mkedwards commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/707#discussion_r235458260
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1566,32 +1585,50 @@ public String
Github user mkedwards commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/707#discussion_r235460740
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1556,32 +1573,50 @@ public String
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
> `private` should be changed back to `public `
> Jenkins complains about
[this](https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2685/artifact/patchp
Github user mkedwards commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/707#discussion_r235467449
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1556,32 +1573,50 @@ public String
Github user mkedwards commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/707#discussion_r235470421
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1566,32 +1585,50 @@ public String
Github user mkedwards commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/707#discussion_r235463520
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -755,39 +769,55 @@ public void
GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/715
Rollup of blocker/critical fixes for 3.5 (to trigger CI)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mkedwards/zookeeper rollup-3.5
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/715
---
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/707
[ZOOKEEPER-2778] QuorumPeer: encapsulate addresses
[ZOOKEEPER-2778] QuorumPeer: encapsulate quorum/election/client addresses
in an AddressTuple held through an AtomicReference
You can merge
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
There appear to be test failures in LeaderBeanTest:
```
[exec] [junit] Tests run: 5, Failures: 0, Errors: 5, Skipped: 0,
Time elapsed: 0.619 sec, Thread: 8, Class
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
The deadlock, as I understand it, comes from an attempt to take `QV_LOCK`
in order to access `myElectionAddress` in thread A, while holding the lock on
the `QuorumCnxManager` object; meanwhile
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/724
retest this please
---
59 matches
Mail list logo
