[GitHub] zookeeper issue #440: ZOOKEEPER-2939 Deal with maxbuffer as it relates to pr...

2018-02-09 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/440 @afine PR has been rebased on top of the previous jutemaxbuffer commit as discussed. Please review. ---

[GitHub] zookeeper issue #440: ZOOKEEPER-2939 Deal with maxbuffer as it relates to pr...

2018-02-06 Thread afine
Github user afine commented on the issue: https://github.com/apache/zookeeper/pull/440 I merged https://github.com/apache/zookeeper/pull/415. Please go ahead and create a new JIRA to correspond to this PR and I'll mark ZOOKEEPER-2939 as resolved. ---

[GitHub] zookeeper issue #440: ZOOKEEPER-2939 Deal with maxbuffer as it relates to pr...

2018-01-24 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/440 @aberghage Thanks for reviewing this. @phunt 1. This library has some performance impact for sure, because it calculates more complicated statistics, while my original solution only expos

[GitHub] zookeeper issue #440: ZOOKEEPER-2939 Deal with maxbuffer as it relates to pr...

2018-01-23 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/440 No apologies necessary @aberghage - appreciate the feedback. ---

[GitHub] zookeeper issue #440: ZOOKEEPER-2939 Deal with maxbuffer as it relates to pr...

2018-01-23 Thread aberghage
Github user aberghage commented on the issue: https://github.com/apache/zookeeper/pull/440 I apologize for the somewhat substance-light addition to the conversation, but having grafted some super crude histogram upgrades on counters in our patchset I'd be very much in favor of pulling

[GitHub] zookeeper issue #440: ZOOKEEPER-2939 Deal with maxbuffer as it relates to pr...

2018-01-23 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/440 I like the idea of moving to dropwizard vs our own homebrew. Seems like it would allow us richer insight for metrics. Here are my concerns: 1) performance. Do we know the impact of this libr

[GitHub] zookeeper issue #440: ZOOKEEPER-2939 Deal with maxbuffer as it relates to pr...

2018-01-15 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/440 @phunt Do you have a chance to take a look at this approach? ---