Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/499
Thanks @hanm and @anmolnar!
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/499
@andschwa yeah, I've managed to run it locally fine.
---
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/499
Yay @anmolnar the tests were flaky, last CI run was clean.
---
Github user dforsyth commented on the issue:
https://github.com/apache/zookeeper/pull/499
Looks like it came out clean this time.
---
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/499
The change is this:
```
-target_link_libraries(hashtable PUBLIC $<$:m>)
+target_link_libraries(hashtable PUBLIC
$<$,$>:m>)
```
This code is not executed on Jenkins, s
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/499
[exec] BUILD FAILED
[exec] [exec] OK (74)
[exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1355:
The following error occurred
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/499
@anmolnar I can't for the life of me find which unit test failed in the
Jenkins build. It can't be related though, as this just adds `libm` to the link
line on FreeBSD in addition to Linux, when
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/499
@dforsyth Can you rebase just to force another build?
---
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/499
LGTM.
@hanm the build failure was spurious as this was a change to the CMake
build.
---
