[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573114#comment-15573114 ] Shay Hazor commented on ZOOKEEPER-2209: --- [~ivan.kopcanski] I'm unsure how you've found your way here with the problem, but I'll try to help anyway. There's no C# client in the official ZooKeeper repo. I opened this issue in order to merge my C# client, it wasn't approved because they didn't want to support it. The nuget package you refer to is "ZooKeeperNet". It's built from https://github.com/ewhauser/zookeeper and what made me write my own version of the client. I'm the creator of the "ZooKeeperNetEx" package, it's way better than the other one - it has been integrated with Microsoft Orleans and has been used in production for more than a year. Now, regarding your problem, I don't have a dependency on log4net. I've implemented a simple logging mechanism that writes to trace and to a file. In case you want to use log4net, no problem... just set ZooKeeper.LogToFile=false and ZooKeeper.LogToTrace=false and ZooKeeper.CustomLogConsumer=YourLog4NetAdapter. I hope I've been helpful. > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of [~ewhauser] . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, no explicit threads used > * all relevant unit tests have been converted and passing consistently > * Code is 100% CoreCLR compliant > * [NuGet package|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. > * [Nuget package for > recipes|https://www.nuget.org/packages/ZooKeeperNetEx.Recipes] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572789#comment-15572789 ] Ivan Kopcanski commented on ZOOKEEPER-2209: --- Also, can someone explain me how to generate code in /Generated folder of .NET solution? After git cloning, I cannot build solution locally. I was reading that some standard java->c# conversion tool is used... > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of [~ewhauser] . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, no explicit threads used > * all relevant unit tests have been converted and passing consistently > * Code is 100% CoreCLR compliant > * [NuGet package|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. > * [Nuget package for > recipes|https://www.nuget.org/packages/ZooKeeperNetEx.Recipes] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572785#comment-15572785 ] Ivan Kopcanski commented on ZOOKEEPER-2209: --- There is an annoying issue with log4net.dll reference in projects. zookeepernet uses log4net version 1.2.10.0 has old public key token. If your project uses log4net recent versions, it has new public key token. Once you reference zookeepernet in your solution, it wont work, because there will be conflict with loading log4net dll. Environment sees these 2 versions as totally different dll-s, because of public key token. Solution: Can zookeepernet use nuget package for log4net that will manage version collisions? > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of [~ewhauser] . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, no explicit threads used > * all relevant unit tests have been converted and passing consistently > * Code is 100% CoreCLR compliant > * [NuGet package|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. > * [Nuget package for > recipes|https://www.nuget.org/packages/ZooKeeperNetEx.Recipes] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983672#comment-14983672 ] ASF GitHub Bot commented on ZOOKEEPER-2209: --- Github user shayhatsor closed the pull request at: https://github.com/apache/zookeeper/pull/31 > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of [~ewhauser] . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, no explicit threads used > * all relevant unit tests have been converted and passing consistently > * Code is 100% CoreCLR compliant > * [NuGet package|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. > * [Nuget package for > recipes|https://www.nuget.org/packages/ZooKeeperNetEx.Recipes] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715410#comment-14715410 ] ASF GitHub Bot commented on ZOOKEEPER-2209: --- GitHub user shayhatsor reopened a pull request: https://github.com/apache/zookeeper/pull/31 ZOOKEEPER-2209 - ZooKeeper client in C# for 3.4.6 Inspired by the work of @ewhauser . I propose a C# Client that supports the current stable version of ZK 3.4.6. It was built by using static code conversion tools followed by manual editing and C# implementations of java selector and other java constructs. A great measure was taken to follow the logic of the java version. In fact, the code is almost identical. Thus allowing easy evolution alongside the java version. Main features: •fully .NET async, no explicit threads used •all relevant unit tests have been converted and passing consistently •recipes are included, will be converted to async soon •Code is 100% CoreCLR compliant •NuGet package - [ZooKeeperNetEx](https://www.nuget.org/packages/ZooKeeperNetEx) is already integrated in [Microsoft Project Orleans](https://github.com/dotnet/orleans) as the only open-source membership provider. Current Limitations: * The recipes code hasn't been converted to task based async yet, so it still uses explicit threads. * Support for system properties (currently the defaults are used). * SASL support You can merge this pull request into a Git repository by running: $ git pull https://github.com/shayhatsor/zookeeper CSharp Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/31.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #31 commit 2ce061129d71dd2a533e1972bf5fcba4ab7f9d19 Author: Flavio Paiva Junqueira Date: 2014-02-19T23:12:33Z ZooKeeper 3.4.6-rc0 release. git-svn-id: https://svn.apache.org/repos/asf/zookeeper/tags/release-3.4.6-rc0@1569963 13f79535-47bb-0310-9956-ffa450edef68 commit 601207e1151b2691112c431fc3b4130a85ac93b5 Author: Flavio Paiva Junqueira Date: 2014-03-12T09:25:48Z ZooKeeper 3.4.6 release. git-svn-id: https://svn.apache.org/repos/asf/zookeeper/tags/release-3.4.6@1576670 13f79535-47bb-0310-9956-ffa450edef68 commit 40d5497c2345898365333dc2d910e9eb5c59b226 Author: shayhatsor Date: 2015-06-27T08:43:10Z A .NET C# version of ZooKeeper client (3.4.6.1001) commit 859e7d6e7efa7367060aa96228199ee2a79186ca Author: shayhatsor Date: 2015-07-25T19:36:41Z A .NET C# version of ZooKeeper client (3.4.6.1002) commit fbfc9e380cc9b50b289e4720dcef724dd369719d Author: shayhatsor Date: 2015-08-07T14:42:14Z ZOOKEEPER-2209 : A .NET C# version of ZooKeeper client commit 07ca830753ff961b1148573629a395442ecaf0ab Author: shayhatsor Date: 2015-08-16T22:40:18Z Added .NETPlatform5.0 support commit 0cc3bd941f13f846ea8890801bcff6cbf919aa3b Author: shayhatsor Date: 2015-08-17T16:22:08Z backward compatible with .net4 > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of [~ewhauser] . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, no explicit threads used > * all relevant unit tests have been converted and passing consistently > * Code is 100% CoreCLR compliant > * [NuGet package|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. > * [Nuget package for > recipes|https://www.nuget.org/packages/ZooKeeperNetEx.Recipes] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709728#comment-14709728 ] ASF GitHub Bot commented on ZOOKEEPER-2209: --- Github user shayhatsor closed the pull request at: https://github.com/apache/zookeeper/pull/31 > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch, > ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of [~ewhauser] . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, no explicit threads used > * all relevant unit tests have been converted and passing consistently > * Code is 100% CoreCLR compliant > * [NuGet package|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. > * [Nuget package for > recipes|https://www.nuget.org/packages/ZooKeeperNetEx.Recipes] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705030#comment-14705030 ] Shay Hazor commented on ZOOKEEPER-2209: --- [~fpj] I see your point. Most .NET developers aren't aware of this list, let alone JIRA. Before I started this project, I was one of them. I found this list only after adding myself to the mailing list. Anyway, It would be *great* if you guys can find a spot on the zookeeper site to link to my nuget package. (obviously stating that it's just a contribution and you're not responsible for it). thanks [~fpj] & [~rakeshr] for your time. > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch, > ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of [~ewhauser] . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, no explicit threads used > * all relevant unit tests have been converted and passing consistently > * Code is 100% CoreCLR compliant > * [NuGet package|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. > * [Nuget package for > recipes|https://www.nuget.org/packages/ZooKeeperNetEx.Recipes] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704715#comment-14704715 ] Flavio Junqueira commented on ZOOKEEPER-2209: - You've clearly put effort into it, and by no means I want to diminish the contribution, but the 1400 people downloading your client aren't speaking up on this list. If they do it, then it will be much easier to support your case. Let me also bring up the example of Apache Curator, which is super popular, but not part of the Apache ZooKeeper code base, it's an independent project. This is just to illustrate that there are other ways to make your software available and popular which aren't necessarily having it checked in here. > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch, > ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of [~ewhauser] . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, no explicit threads used > * all relevant unit tests have been converted and passing consistently > * Code is 100% CoreCLR compliant > * [NuGet package|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. > * [Nuget package for > recipes|https://www.nuget.org/packages/ZooKeeperNetEx.Recipes] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704442#comment-14704442 ] Shay Hazor commented on ZOOKEEPER-2209: --- [~fpj] Taking into account that the only way a .NET programmer can find my client is via [NuGet|https://www.nuget.org/packages/ZooKeeperNetEx/] and the fact that I'm an open source newbie, I believe that 1400 downloads in two months shows that there's interest. wouldn't you agree ? > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch, > ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of [~ewhauser] . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, no explicit threads used > * all relevant unit tests have been converted and passing consistently > * Code is 100% CoreCLR compliant > * [NuGet package|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. > * [Nuget package for > recipes|https://www.nuget.org/packages/ZooKeeperNetEx.Recipes] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703735#comment-14703735 ] Flavio Junqueira commented on ZOOKEEPER-2209: - [~shayhatsor] it'd be good to have one or more people championing this, right now I haven't seen any interest in such a client, which is a bit unfortunate. > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch, > ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of [~ewhauser] . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, no explicit threads used > * all relevant unit tests have been converted and passing consistently > * Code is 100% CoreCLR compliant > * [NuGet package|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. > * [Nuget package for > recipes|https://www.nuget.org/packages/ZooKeeperNetEx.Recipes] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703515#comment-14703515 ] Shay Hazor commented on ZOOKEEPER-2209: --- [~fpj] Is there anything I need to do in order for you to apply this patch (change status, assign to someone etc. ) thanks > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch, > ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of [~ewhauser] . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, no explicit threads used > * all relevant unit tests have been converted and passing consistently > * Code is 100% CoreCLR compliant > * [NuGet package|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. > * [Nuget package for > recipes|https://www.nuget.org/packages/ZooKeeperNetEx.Recipes] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693810#comment-14693810 ] Shay Hazor commented on ZOOKEEPER-2209: --- [~rakeshr], Is there anything I need to do in order for you to apply this patch (change status, assign to someone etc. ) thanks > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch, > ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of [~ewhauser] . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, no explicit threads used > * all relevant unit tests have been converted and passing consistently > * Code is 100% CoreCLR compliant > * [NuGet package|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. > * [Nuget package for > recipes|https://www.nuget.org/packages/ZooKeeperNetEx.Recipes] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660965#comment-14660965 ] Hadoop QA commented on ZOOKEEPER-2209: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12749134/ZOOKEEPER-2209.patch against trunk revision 1694317. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 86 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2822//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2822//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2822//console This message is automatically generated. > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch, > ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of ewhauser . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, not explicit threads used > * all relevant unit tests have been converted and passing consistently > * recipes are included > * Code is 100% CoreCLR compliant > * NuGet package - > [ZooKeeperNetEx|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660756#comment-14660756 ] Hadoop QA commented on ZOOKEEPER-2209: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12749110/ZOOKEEPER-2209.patch against trunk revision 1694317. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 86 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2821//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2821//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2821//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2821//console This message is automatically generated. > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch, > ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of ewhauser . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, not explicit threads used > * all relevant unit tests have been converted and passing consistently > * recipes are included > * Code is 100% CoreCLR compliant > * NuGet package - > [ZooKeeperNetEx|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659066#comment-14659066
]
Shay Hazor commented on ZOOKEEPER-2209:
---
ok, so now the only issue left is to add
[ZooKeeperNetEx.snk|https://github.com/shayhatsor/zookeeper/blob/trunk/src/csharp/ZooKeeperNetEx.snk?raw=true]
file. It should be in {{src\contrib\csharp}}. The solution wouldn't compile
without a valid snk file.
> A .NET C# version of ZooKeeper client
> -
>
> Key: ZOOKEEPER-2209
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209
> Project: ZooKeeper
> Issue Type: New Feature
>Affects Versions: 3.4.6
> Environment: .NET CoreCLR
>Reporter: Shay Hazor
>Assignee: Shay Hazor
> Labels: .NET, CoreCLR, async, c#
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Inspired by the work of ewhauser .
> I propose a C# Client that supports the current stable version of ZK 3.4.6.
> It was built by using static code conversion tools followed by manual editing
> and C# implementations of java selector and other java constructs.
> A great measure was taken to follow the logic of the java version. In fact,
> the code is almost identical. Thus allowing easy evolution alongside the java
> version.
> Main features:
> * fully .NET async, not explicit threads used
> * all relevant unit tests have been converted and passing consistently
> * recipes are included
> * Code is 100% CoreCLR compliant
> * NuGet package -
> [ZooKeeperNetEx|https://www.nuget.org/packages/ZooKeeperNetEx] is already
> integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans]
> as the only open-source membership provider.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659035#comment-14659035 ] Hadoop QA commented on ZOOKEEPER-2209: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12748934/ZOOKEEPER-2209.patch against trunk revision 1694317. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 68 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2820//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2820//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2820//console This message is automatically generated. > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2209.patch, ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of ewhauser . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, not explicit threads used > * all relevant unit tests have been converted and passing consistently > * recipes are included > * Code is 100% CoreCLR compliant > * NuGet package - > [ZooKeeperNetEx|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658894#comment-14658894 ] Hadoop QA commented on ZOOKEEPER-2209: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12748912/ZOOKEEPER-2209.patch against trunk revision 1694317. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 65 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 18 release audit warnings (more than the trunk's current 0 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2819//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2819//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2819//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2819//console This message is automatically generated. > A .NET C# version of ZooKeeper client > - > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of ewhauser . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, not explicit threads used > * all relevant unit tests have been converted and passing consistently > * recipes are included > * Code is 100% CoreCLR compliant > * NuGet package - > [ZooKeeperNetEx|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647267#comment-14647267
]
Rakesh R commented on ZOOKEEPER-2209:
-
IMHO, you can prepare a new patch based on the {{trunk}} branch and keep the
changes under {{contrib}} folder now. Probably someone good in C# can pitch in
and help in reviews!
> A .NET C# version of ZooKeeper client
> -
>
> Key: ZOOKEEPER-2209
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209
> Project: ZooKeeper
> Issue Type: New Feature
>Affects Versions: 3.4.6
> Environment: .NET CoreCLR
>Reporter: Shay Hazor
>Assignee: Shay Hazor
> Labels: .NET, CoreCLR, async, c#
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2209.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Inspired by the work of ewhauser .
> I propose a C# Client that supports the current stable version of ZK 3.4.6.
> It was built by using static code conversion tools followed by manual editing
> and C# implementations of java selector and other java constructs.
> A great measure was taken to follow the logic of the java version. In fact,
> the code is almost identical. Thus allowing easy evolution alongside the java
> version.
> Main features:
> * fully .NET async, not explicit threads used
> * all relevant unit tests have been converted and passing consistently
> * recipes are included, will be converted to async soon
> * Code is 100% CoreCLR compliant
> * NuGet package -
> [ZooKeeperNetEx|https://www.nuget.org/packages/ZooKeeperNetEx] is already
> integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans]
> as the only open-source membership provider.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client 3.4.6 release
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638976#comment-14638976 ] Shay Hazor commented on ZOOKEEPER-2209: --- [~fpj ] & [~rakeshr] I agree, this code needs the community feedback in order to convince you (and me) it's ready. It would be great if you could add it to the contrib folder. Should I make a new patch that puts the code in a contrib sub-folder? will I be able to post updates like it's "my" repo? will it be in the trunk branch ? I'd like to tell you a bit about why I did it this project. 3 months ago I started a new job in a place that uses mostly open source software, which was totally new to me. My first task was to learn about MS project Orleans and write a membership table implementation using ZK. I didn't know what Orleans or ZK were. so I took [~ewhauser]'s code and started playing with it. It worked most of the times, but there were some issues: sometimes I'd get "connection lost" for no apparent reason, the tests weren't passing consistently, no support for ZK multi and it wasn't async. When I told my boss we need to find another solution, he said "write a new one". (he wasn't aware of the size of the task, me neither) I made a clone of 3.4.6 release tag of the official ZK repo, to base on the latest stable code. I started with some static code conversion tools to get the easy parts out of the way. As I'm not a java programmer, the conversion wasn't easy (java selector almost killed me). Luckily, I am eloquent in c#. After about a month of not much sleep, I had a working c# client. all tests were passing consistently. but it wasn't async and the recipes weren't converted yet, that took two more weeks. I'm still improving performance, memory consumption and basically everything I can think of. Note that this code will soon be tested heavily in staging and production, since where I work we're rewriting our whole product with Orleans. My personal goal is to make ZK available to any .NET programmer. this JIRA is a step in that direction. > A .NET C# version of ZooKeeper client 3.4.6 release > --- > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of ewhauser . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, not explicit threads used > * all relevant unit tests have been converted and passing consistently > * recipes are included, will be converted to async soon > * Code is 100% CoreCLR compliant > * NuGet package - > [ZooKeeperNetEx|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client 3.4.6 release
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638638#comment-14638638
]
Rakesh R commented on ZOOKEEPER-2209:
-
[~shayhatsor], appreciate the initiative and the effort in making the
contribution!
I agree with [~fpj] +1 for keeping this outside core code base. {{contrib}}
would be fine if there are much interest from the community. Probably will wait
and see others opinion as well.
> A .NET C# version of ZooKeeper client 3.4.6 release
> ---
>
> Key: ZOOKEEPER-2209
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209
> Project: ZooKeeper
> Issue Type: New Feature
>Affects Versions: 3.4.6
> Environment: .NET CoreCLR
>Reporter: Shay Hazor
>Assignee: Shay Hazor
> Labels: .NET, CoreCLR, async, c#
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-2209.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Inspired by the work of ewhauser .
> I propose a C# Client that supports the current stable version of ZK 3.4.6.
> It was built by using static code conversion tools followed by manual editing
> and C# implementations of java selector and other java constructs.
> A great measure was taken to follow the logic of the java version. In fact,
> the code is almost identical. Thus allowing easy evolution alongside the java
> version.
> Main features:
> * fully .NET async, not explicit threads used
> * all relevant unit tests have been converted and passing consistently
> * recipes are included, will be converted to async soon
> * Code is 100% CoreCLR compliant
> * NuGet package -
> [ZooKeeperNetEx|https://www.nuget.org/packages/ZooKeeperNetEx] is already
> integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans]
> as the only open-source membership provider.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client 3.4.6 release
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638524#comment-14638524 ] Flavio Junqueira commented on ZOOKEEPER-2209: - [~shayhatsor], this patch is essentially proposing that we incorporate a c# client to the main branch of zookeeper. let me be up front about it and say that this is a big ask. we are in general pretty strict about we get into the core code base because we need to make sure that it all works when we prepare releases, and such a big merge without having clear indicators that the community will be able to maintain it makes me a bit uneasy (I suspect others too). my suggestion is that either we put it under contrib for now and see how the community reacts to it or just leave it on github and see how much interest it raises. we are always happy to help with promoting projects in the ecosystem. I was also wondering if you got some of the microsoft folks working with zookeeper (e.g., [~iandi], [~asamarna]) to review it. if they could help with the review process by commenting publicly and testing, then it'd make the process easier. > A .NET C# version of ZooKeeper client 3.4.6 release > --- > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of ewhauser . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, not explicit threads used > * all relevant unit tests have been converted and passing consistently > * recipes are included, will be converted to async soon > * Code is 100% CoreCLR compliant > * NuGet package - > [ZooKeeperNetEx|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client 3.4.6 release
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638513#comment-14638513 ] Hadoop QA commented on ZOOKEEPER-2209: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12746755/ZOOKEEPER-2209.patch against trunk revision 1690207. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 83 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2814//console This message is automatically generated. > A .NET C# version of ZooKeeper client 3.4.6 release > --- > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of ewhauser . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, not explicit threads used > * all relevant unit tests have been converted and passing consistently > * recipes are included, will be converted to async soon > * Code is 100% CoreCLR compliant > * NuGet package - > [ZooKeeperNetEx|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client 3.4.6 release
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638494#comment-14638494 ] Hadoop QA commented on ZOOKEEPER-2209: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12746746/ZooKeeperNetEx.snk against trunk revision 1690207. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2813//console This message is automatically generated. > A .NET C# version of ZooKeeper client 3.4.6 release > --- > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-2209.patch, ZooKeeperNetEx.snk > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of ewhauser . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, not explicit threads used > * all relevant unit tests have been converted and passing consistently > * recipes are included, will be converted to async soon > * Code is 100% CoreCLR compliant > * NuGet package - > [ZooKeeperNetEx|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client 3.4.6 release
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637729#comment-14637729 ] Hadoop QA commented on ZOOKEEPER-2209: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12746644/ZOOKEEPER-2209.patch against trunk revision 1690207. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 83 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2812//console This message is automatically generated. > A .NET C# version of ZooKeeper client 3.4.6 release > --- > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor >Assignee: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Attachments: ZOOKEEPER-2209.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Inspired by the work of ewhauser . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, not explicit threads used > * all relevant unit tests have been converted and passing consistently > * recipes are included, will be converted to async soon > * Code is 100% CoreCLR compliant > * NuGet package - > [ZooKeeperNetEx|https://www.nuget.org/packages/ZooKeeperNetEx] is already > integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans] > as the only open-source membership provider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2209) A .NET C# version of ZooKeeper client 3.4.6 release
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613305#comment-14613305 ] Shay Hazor commented on ZOOKEEPER-2209: --- the code is now .NET CoreCLR compatibile. also, it is fully Task based async, which allows it to not use explicit threads, and no threads when idle. The recipes code hasn't been converted to task based async yet, so it still uses threads. > A .NET C# version of ZooKeeper client 3.4.6 release > --- > > Key: ZOOKEEPER-2209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6 > Environment: .NET CoreCLR >Reporter: Shay Hazor > Labels: .NET, CoreCLR, async, c# > Original Estimate: 168h > Remaining Estimate: 168h > > Inspired by the work of ewhauser . > I propose a C# Client that supports the current stable version of ZK 3.4.6. > It was built by using static code conversion tools followed by manual editing > and C# implementations of java selector and other java constructs. > A great measure was taken to follow the logic of the java version. In fact, > the code is almost identical. Thus allowing easy evolution alongside the java > version. > Main features: > * fully .NET async, not explicit threads used > * all relevant unit tests have been converted and passing consistently > * recipes are included, will be converted to async soon > * Code is 100% CoreCLR compliant > * nuget package -- This message was sent by Atlassian JIRA (v6.3.4#6332)
