[jira] [Commented] (ZOOKEEPER-2826) Code refactoring for `CLI` module
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757484#comment-16757484 ] Hudson commented on ZOOKEEPER-2826: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #378 (See [https://builds.apache.org/job/ZooKeeper-trunk/378/]) ZOOKEEPER-2826: Code refactoring for `CLI` module (andor: rev 8f62ee9740c9cdd0e4e3ec5c6d906236fe35a003) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/ListQuotaCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/GetAclCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/SetAclCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/LsCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/DeleteCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/CliCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/RemoveWatchesCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/AddAuthCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/DelQuotaCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/GetConfigCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/SetCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/GetCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/SetQuotaCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/ReconfigCommand.java > Code refactoring for `CLI` module > - > > Key: ZOOKEEPER-2826 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2826 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.3 >Reporter: Benedict Jin >Assignee: Benedict Jin >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Original Estimate: 72h > Time Spent: 50m > Remaining Estimate: 71h 10m > > * Fix spell issues > * Remove unnecessary `import` > * Make initialization block that related with `options.addOption` into static > * Standardize `StringBuilder#append` usage > * Using `try` clause to release the resource of stream -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2826) Code refactoring for `CLI` module
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757433#comment-16757433 ] Hudson commented on ZOOKEEPER-2826: --- FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #214 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/214/]) ZOOKEEPER-2826: Code refactoring for `CLI` module (andor: rev 8f62ee9740c9cdd0e4e3ec5c6d906236fe35a003) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/GetConfigCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/ReconfigCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/GetAclCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/RemoveWatchesCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/AddAuthCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/DeleteCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/SetQuotaCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/DelQuotaCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/ListQuotaCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/SetCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/SetAclCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/CliCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/GetCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/LsCommand.java > Code refactoring for `CLI` module > - > > Key: ZOOKEEPER-2826 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2826 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.3 >Reporter: Benedict Jin >Assignee: Benedict Jin >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Original Estimate: 72h > Time Spent: 50m > Remaining Estimate: 71h 10m > > * Fix spell issues > * Remove unnecessary `import` > * Make initialization block that related with `options.addOption` into static > * Standardize `StringBuilder#append` usage > * Using `try` clause to release the resource of stream -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2826) Code refactoring for `CLI` module
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118024#comment-16118024 ] ASF GitHub Bot commented on ZOOKEEPER-2826: --- Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/298#discussion_r131848354 --- Diff: src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java --- @@ -52,12 +52,12 @@ private String members; /* version - version of config from which we want to reconfigure - if current config is different - * reconfiguration will fail. Should be ommitted from the CLI to disable this option. + * reconfiguration will fail. Should be committed from the CLI to disable this option. --- End diff -- @maoling Thank you for the comment. Yep, `ommitted` should be changed into `committed`. > Code refactoring for `CLI` module > - > > Key: ZOOKEEPER-2826 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2826 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.3 >Reporter: Benedict Jin >Assignee: Benedict Jin >Priority: Minor > Fix For: 3.5.4, 3.6.0 > > Original Estimate: 72h > Remaining Estimate: 72h > > * Fix spell issues > * Remove unnecessary `import` > * Make initialization block that related with `options.addOption` into static > * Standardize `StringBuilder#append` usage > * Using `try` clause to release the resource of stream -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2826) Code refactoring for `CLI` module
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118020#comment-16118020 ] ASF GitHub Bot commented on ZOOKEEPER-2826: --- Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/298#discussion_r131847801 --- Diff: src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java --- @@ -52,12 +52,12 @@ private String members; /* version - version of config from which we want to reconfigure - if current config is different - * reconfiguration will fail. Should be ommitted from the CLI to disable this option. + * reconfiguration will fail. Should be committed from the CLI to disable this option. --- End diff -- is it right? > Code refactoring for `CLI` module > - > > Key: ZOOKEEPER-2826 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2826 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.3 >Reporter: Benedict Jin >Assignee: Benedict Jin >Priority: Minor > Fix For: 3.5.4, 3.6.0 > > Original Estimate: 72h > Remaining Estimate: 72h > > * Fix spell issues > * Remove unnecessary `import` > * Make initialization block that related with `options.addOption` into static > * Standardize `StringBuilder#append` usage > * Using `try` clause to release the resource of stream -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2826) Code refactoring for `CLI` module
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067613#comment-16067613 ] Hadoop QA commented on ZOOKEEPER-2826: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/836//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/836//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/836//console This message is automatically generated. > Code refactoring for `CLI` module > - > > Key: ZOOKEEPER-2826 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2826 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.3 >Reporter: Benedict Jin >Assignee: Benedict Jin > Fix For: 3.5.4, 3.6.0 > > Original Estimate: 72h > Remaining Estimate: 72h > > * Fix spell issues > * Remove unnecessary `import` > * Make initialization block that related with `options.addOption` into static > * Standardize `StringBuilder#append` usage > * Using `try` clause to release the resource of stream -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2826) Code refactoring for `CLI` module
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067601#comment-16067601 ] ASF GitHub Bot commented on ZOOKEEPER-2826: --- GitHub user asdf2014 opened a pull request: https://github.com/apache/zookeeper/pull/298 ZOOKEEPER-2826: Code refactoring for `CLI` module * Fix spell issues * Remove unnecessary `import` * Make initialization block that related with `options.addOption` into static * Standardize `StringBuilder#append` usage * Using `try` clause to release the resource of stream You can merge this pull request into a Git repository by running: $ git pull https://github.com/asdf2014/zookeeper ZOOKEEPER-2826 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/298.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #298 commit 18cf0ab2c6fd33a77d46183c289f1b385acdf873 Author: asdf2014 <1571805...@qq.com> Date: 2017-06-29T01:59:59Z Code refactoring for `CLI` module > Code refactoring for `CLI` module > - > > Key: ZOOKEEPER-2826 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2826 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.3 >Reporter: Benedict Jin >Assignee: Benedict Jin > Fix For: 3.5.4, 3.6.0 > > Original Estimate: 72h > Remaining Estimate: 72h > > * Fix spell issues > * Remove unnecessary `import` > * Make initialization block that related with `options.addOption` into static > * Standardize `StringBuilder#append` usage > * Using `try` clause to release the resource of stream -- This message was sent by Atlassian JIRA (v6.4.14#64029)
