Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Gao, Liming
Sent: Thursday, April 11, 2019 12:57 PM
To: devel@edk2.groups.io
Cc: Feng, YunhuaX ; Feng, Bob C ;
Zhu, Yonghong
Subject: [Patch] BaseTools: Sometime write file not immediate to disk
From:
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhang, Shenglei
>Sent: Tuesday, April 09, 2019 11:22 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D ; Gao, Liming
>
>Subject: [PATCH] MdePkg/BaseLib: Remove LongJump.c and SetJump.c
>
>MdePkg BaseLib still uses the inline X86
From: Yunhua Feng
BZ: https://bugzilla.tianocore.org/process_bug.cgi
On Windows OS, sometime the generated file is not immediate saved to disk.
When run nmake, prompt AutoGen.h not found, and stop build.
Below blog shows Write-Replace to fix it. This patch uses this way to write
temp file, then
On 2019-04-10 20:07, Rebecca Cran via Groups.Io wrote:
Thanks. I'm working on fixing it now: it looks like it needs new
compiler flags in BaseTools/Source/C/Makefiles/header.makefile, as
well as recognizing arm64 as a platform name in addition to aarch64
It didn't need any compiler flag
I also added the incremental build performance data in BZ
https://bugzilla.tianocore.org/show_bug.cgi?id=1672
-Bob
-Original Message-
From: Fan, ZhijuX
Sent: Wednesday, April 10, 2019 4:51 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [edk2][PATCH V2]
Some systems such as FreeBSD identify the platform as 'arm64'
and not 'aarch64' as Linux does.
Signed-off-by: Rebecca Cran
---
BaseTools/Source/C/GNUmakefile | 5 +++--
BaseTools/Source/C/Makefiles/header.makefile | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff
On 2019-04-10 18:09, Liming Gao wrote:
Yes. No test on FreeBSD. If possible, can you contribute the patch to fix this
issue on FreeBSD?
Thanks. I'm working on fixing it now: it looks like it needs new
compiler flags in BaseTools/Source/C/Makefiles/header.makefile, as well
as recognizing
The patch looks good for me.
Reviewed-by: Bob Feng
-Bob
-Original Message-
From: Rodriguez, Christian
Sent: Wednesday, April 10, 2019 11:27 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Zhu, Yonghong
Subject: [PATCH] BaseTools: Hash false success with back to back
Mike:
Could you also update wiki
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format to
remove Contributed-under: TianoCore Contribution Agreement 1.1?
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, April 11, 2019 12:26 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Justen, Jordan L; Ard Biesheuvel; David Woodhouse; Ni, Ray
> Subject: Re: [PATCH v2 0/8] Duplicate 8259/8254 components in OvmfPkg
>
>
Push on commit ddb8cedce7e07b87c0ac6b84cd750a6d3dac47c8
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Monday, April 08, 2019 9:16 PM
>To: Philippe Mathieu-Daudé ; rebe...@bluestop.org
>Cc: devel@edk2.groups.io
>Subject: Re:
Yes. No test on FreeBSD. If possible, can you contribute the patch to fix this
issue on FreeBSD?
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Laszlo Ersek
>Sent: Thursday, April 11, 2019 1:31 AM
>To: devel@edk2.groups.io;
Reviewed-by: Ankit Sinha
-Original Message-
From: Bi, Dandan
Sent: Tuesday, April 9, 2019 10:33 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Sinha, Ankit
; Desimone, Nathaniel L
; Chiu, Chasel ; Lu,
Shifei A ; Zhou, Bowen ; Oram,
Isaac W
Subject:
Reviewed-by: Nate DeSimone
-Original Message-
From: Bi, Dandan
Sent: Tuesday, April 9, 2019 10:33 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Sinha, Ankit
; Desimone, Nathaniel L
; Chiu, Chasel ; Lu,
Shifei A ; Zhou, Bowen ; Oram,
Isaac W
Subject:
On 2019-04-10 07:16:34, Laszlo Ersek wrote:
> Hi Jordan,
>
> I've asked Phil (CC'd) to review this series in my stead. I'll be happy
> to provide an ACK when Phil gives his R-b (if I should forget, please
> ping me separately).
>
> In the future, please include a cover letter; a cumulative
On 2019-04-10 08:37:22, Philippe Mathieu-Daudé wrote:
> Hi Jordan,
>
> On 4/10/19 11:34 AM, Jordan Justen wrote:
> > If we are building for a non-native ARM, then we may need to select a
> > cross-compiler based on the -a paramter.
>
> I am sorry but I am non-native English and I have hard time
On 2019-04-10 09:41:43, Ard Biesheuvel wrote:
> On Wed, 10 Apr 2019 at 01:41, Jordan Justen wrote:
> >
> > https://github.com/jljusten/edk2.git temp-ram-support-v2
> >
> > https://github.com/jljusten/edk2/commits/temp-ram-support-v2
> >
> > v2:
> > * Add AARCH64 and ARM assembly
>
> Hi Jordan,
On Wed, 10 Apr 2019 at 11:28, Laszlo Ersek wrote:
>
> On 04/10/19 18:41, Ard Biesheuvel wrote:
> > On Wed, 10 Apr 2019 at 01:41, Jordan Justen
> > wrote:
> >>
> >> https://github.com/jljusten/edk2.git temp-ram-support-v2
> >>
> >> https://github.com/jljusten/edk2/commits/temp-ram-support-v2
>
On 04/10/19 18:41, Ard Biesheuvel wrote:
> On Wed, 10 Apr 2019 at 01:41, Jordan Justen wrote:
>>
>> https://github.com/jljusten/edk2.git temp-ram-support-v2
>>
>> https://github.com/jljusten/edk2/commits/temp-ram-support-v2
>>
>> v2:
>> * Add AARCH64 and ARM assembly
>
> Hi Jordan,
>
> I'm not
The current secure boot enabled DeveloperBox build contains all the
pieces to maintain the authenticated variable store, but doesn't
actually bother to check the signature on anything it boots. Fix that.
Signed-off-by: Ard Biesheuvel
---
Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 7
On 04/10/19 06:57, Rebecca Cran via Groups.Io wrote:
> Is there any expectation that EDK2 will build on non-x86 systems?
Yes. It should certainly build on aarch64 (Linux at least).
>
> I tried building BaseTools (from git master,
> ae2fb9ead47b5abaf2a4e815b5f57c8f4838b221) using GCC 8.2 on a
On 04/10/19 10:39, Jordan Justen wrote:
> https://github.com/jljusten/edk2.git temp-ram-support-v2
>
> https://github.com/jljusten/edk2/commits/temp-ram-support-v2
>
> v2:
> * Add AARCH64 and ARM assembly
> * Drop IA32 and X64 .S source files
> * Adjust PEI_CORE_TEMPORARY_RAM_TRANSITION
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, April 9, 2019 10:33 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Sinha, Ankit
> ; Desimone, Nathaniel L
> ; Chiu, Chasel ;
> Lu, Shifei A ; Zhou, Bowen
> ; Oram, Isaac W
> Subject:
On Wed, 10 Apr 2019 at 01:41, Jordan Justen wrote:
>
> https://github.com/jljusten/edk2.git temp-ram-support-v2
>
> https://github.com/jljusten/edk2/commits/temp-ram-support-v2
>
> v2:
> * Add AARCH64 and ARM assembly
Hi Jordan,
I'm not sure I'm following the reasoning behind this. Does this
On 04/10/19 03:06, Hao Wu wrote:
> This series is also available at:
> https://github.com/hwu25/edk2/tree/ovmf_8259_8254_v2
>
>
> V2 changes:
>
> Due to the file license change, rebase the whole series onto the tip of
> the master branch. The 'Contributed-under' tag is removed from the log
>
On 04/10/19 03:06, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1496
>
> This commit will remove the IntelFrameworkPkg DEC file dependency in the
> driver INF file.
>
> A new GUID has been updated for the INF file.
>
> Corresponding changes have been made in OVMF DSC
On 04/10/19 03:06, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1496
>
> Several updates have been made to the
> OvmfPkg/8259InterruptControllerDxe driver to make it build under OvmfPkg:
>
> A) Update the driver INF file to consume PCDs defined within OvmfPkg;
> B)
On 04/10/19 03:06, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1496
>
> According to the DEC file in PcAtChipsetPkg, this commit adds the two
> 8259-driver-related PCDs into the OvmfPkg DEC file.
>
> Please note that, instead of adding the two PCDs under section:
>
Hi Jordan,
On 4/10/19 11:34 AM, Jordan Justen wrote:
> If we are building for a non-native ARM, then we may need to select a
> cross-compiler based on the -a paramter.
I am sorry but I am non-native English and I have hard time to
understand your comment.
OVMF targets x86 hardware, which is
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1692
Add error handling to the --hash feature so that hash files
are invalidated when a build error occurs.
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/Source/Python/Common/GlobalData.py |
On 2019-04-10 08:41, Philippe Mathieu-Daudé wrote:
This doesn't look like an architecture problem. It seems your GCC
version isn't checked correctly by BaseTools. This warning is supposed
to be disabled, see:
StdLib/LibC/Stdio/Stdio.inf: GCC:*_*_*_CC_FLAGS= -fno-builtin
On 4/10/19 11:34 AM, Jordan Justen wrote:
> Signed-off-by: Jordan Justen
> ---
> OvmfPkg/build.sh | 19 +++
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 4fcbdd2bc9..c92e90acfa 100755
> --- a/OvmfPkg/build.sh
>
On 4/10/19 6:57 AM, Rebecca Cran via Groups.Io wrote:
> Is there any expectation that EDK2 will build on non-x86 systems?
I have no problem using Ubuntu Bionic on Aarch64 using the default GCC.
$ lsb_release -cd
Description:Ubuntu 18.04.2 LTS
Codename: bionic
$ uname -ms
Linux aarch64
There is PLATFORM_OUTPUT_DIR. And PLATFORM_DIR that points to same place
as WORKSPACE )-;
In setups where workspace is not in source tree there is no way to get
sources.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#38813):
Hi Jordan,
I've asked Phil (CC'd) to review this series in my stead. I'll be happy
to provide an ACK when Phil gives his R-b (if I should forget, please
ping me separately).
In the future, please include a cover letter; a cumulative diffstat
usually helps with the review. (I've had to check all
Reviewed-by: Xiaohu Zhou
-Original Message-
From: Bi, Dandan
Sent: Wednesday, April 10, 2019 1:33 PM
To: devel@edk2.groups.io
Cc: Lu, Shifei A ; Zhou, Bowen ;
Oram, Isaac W
Subject: [edk2-platforms/devel-MinPlatform] [patch 3/3]
PurleyOpenBoardPkg/BoardMtOlympus: Use shell source
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Dandan Bi
> Sent: Wednesday, April 10, 2019 1:33 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
>
> Subject: [edk2-devel]
This hasn't worked for me in quite some time. I always add a -cdrom
paramter, which causes build.sh to skip this.
Signed-off-by: Jordan Justen
---
OvmfPkg/build.sh | 3 ---
1 file changed, 3 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index c92e90acfa..217abae683 100755
---
Signed-off-by: Jordan Justen
---
OvmfPkg/build.sh | 72
1 file changed, 60 insertions(+), 12 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 812441b9b1..9d787452b5 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -35,6
Signed-off-by: Jordan Justen
---
OvmfPkg/build.sh | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 4fcbdd2bc9..c92e90acfa 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -43,7 +43,6 @@ PLATFORMFILE=
If we are building for a non-native ARM, then we may need to select a
cross-compiler based on the -a paramter.
Signed-off-by: Jordan Justen
---
OvmfPkg/build.sh | 99 +---
1 file changed, 51 insertions(+), 48 deletions(-)
diff --git
Signed-off-by: Jordan Justen
---
OvmfPkg/build.sh | 26 ++
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 9d787452b5..e1a708942b 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -103,9 +103,6 @@ do
shift
Signed-off-by: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
---
EmulatorPkg/build.sh | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh
index 89fd26baca..75561c116a 100755
--- a/EmulatorPkg/build.sh
+++ b/EmulatorPkg/build.sh
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1672
The /MP option of MSVC compiler can reduce the total time to compile the
source files on the command line.
This patch is going to enable this MSVC option in BaseTools.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution
Some compilers may optimize register usage in ways that are
incompatible with the TemporaryRamSupport PPI. Using assembly code to
call the TemporaryRamMigration function prevents this issue.
Signed-off-by: Jordan Justen
Cc: Jian J Wang
Cc: Hao Wu
Cc: Ray Ni
Cc: Star Zeng
---
Signed-off-by: Jordan Justen
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
.../AArch64/TemporaryRamMigration.S | 63 +++
.../AArch64/TemporaryRamMigration.asm | 63 +++
MdeModulePkg/Core/Pei/PeiMain.inf | 4 ++
3 files changed, 130
There is potential problem with PEI Core's usage of the
TemporaryRamSupport PPI. The issue is described in the previous patch:
"MdeModulePkg/Core/Pei: Add interface for assembly based TemporaryRamSupport"
Now that assembly paths are available for all supported architectures,
we can make use of
Signed-off-by: Jordan Justen
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
.../Dispatcher/Arm/TemporaryRamMigration.S| 68 +++
.../Dispatcher/Arm/TemporaryRamMigration.asm | 68 +++
MdeModulePkg/Core/Pei/PeiMain.inf | 5 ++
3 files changed, 141
Signed-off-by: Jordan Justen
Cc: Jian J Wang
Cc: Hao Wu
Cc: Ray Ni
Cc: Star Zeng
---
.../Ia32/TemporaryRamMigration.nasm | 77 +++
MdeModulePkg/Core/Pei/PeiMain.inf | 3 +
2 files changed, 80 insertions(+)
create mode 100644
There is potential problem with PEI Core's usage of the
TemporaryRamSupport PPI. When the TemporaryRamMigration function is
called, it returns to C based code after changing the stack to the new
permanent memory copy of the stack. But, the C compiler may have
stored pointers to addresses on the
https://github.com/jljusten/edk2.git temp-ram-support-v2
https://github.com/jljusten/edk2/commits/temp-ram-support-v2
v2:
* Add AARCH64 and ARM assembly
* Drop IA32 and X64 .S source files
* Adjust PEI_CORE_TEMPORARY_RAM_TRANSITION pointer in the assembly
code based on the stack pointer
GenerateCapsule: error: can not encode FMP Auth Header
The system cannot find the file specified.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/Capsule/GenerateCapsule.py | 2 +-
1 file changed, 1
From: Aaron Antone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1416
After ExitBootServices, some pointer would be invalid such as
the Protocol pointer and gBS. The function depend on those should
be prevent. So disable the related function while after
ExitBootServices.
Change the gST to
Some pointer will be invalid after ExitBootServices, such as protocol pointer,
gST, gBS and so on. Disable the functions which used that pointer.
Remove SMM support of UefiDebugLibDebugPortProtocol, UefidebugLibConOut
and UefiDebugLibStdErr.
Before removing, should change the SMM instance in the
From: Aaron Antone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1416
After ExitBootServices, some pointer would be invalid such as
the Protocol pointer and gBS. The function depend on those should
be prevent. So disable the related function while after
ExitBootServices.
Change the gST to
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1416
The UefiDebugLibConOut will not support DXE_SMM_DRIVER,
change UefiDebugLibConOut to PeiDxeDebugLibReportStatusCode.
Cc: Jian J Wang
Cc: Ray Ni
Cc: Star Zeng
Cc: Liming Gao
Cc: Sean Brogan
Cc: Michael Turner
Cc: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1416
The UefiDebugLibConOut will not support DXE_SMM_DRIVER,
change UefiDebugLibConOut to PeiDxeDebugLibReportStatusCode.
Cc: Jian J Wang
Cc: Ray Ni
Cc: Star Zeng
Cc: Liming Gao
Cc: Sean Brogan
Cc: Michael Turner
Cc: Bret Barkelew
From: Aaron Antone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1416
After ExitBootServices, some pointer would be invalid such as
the Protocol pointer and gBS. The function depend on those should
be prevent. So disable the related function while after
ExitBootServices.
Change the gBS to
58 matches
Mail list logo
