Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: remove unused code for IPF

2019-05-16 Thread Wang, Jian J
Thanks. Pushed at c2eab535c6790b8db5e9039e3d8886980b390389. Regards, Jian > -Original Message- > From: Gao, Liming > Sent: Friday, May 17, 2019 9:12 AM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Ye, Ting > > Subject: RE: [PATCH] CryptoPkg/BaseCryptLib: remove

Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-16 Thread Wang, Jian J
Hi Laszlo, There's already a float library used in OpensslLib.inf. [LibraryClasses.ARM] ArmSoftFloatLib The problem is that the below instance doesn't implement __aeabi_ui2d and __aeabi_d2uiz (I encountered this one as well) ArmPkg\Library\ArmSoftFloatLib\ArmSoftFloatLib.inf I think we

Re: [edk2-devel][Patch] Nt32Pkg: Remove it

2019-05-16 Thread Liming Gao
Done to add it into EDK II Release Planning. >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Laszlo Ersek >Sent: Friday, May 17, 2019 12:45 AM >To: devel@edk2.groups.io; Ni, Ray ; Wu, Hao A > >Subject: Re: [edk2-devel][Patch] Nt32Pkg: Remove it

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is removed

2019-05-16 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Ni, Ray >Sent: Friday, May 17, 2019 12:58 PM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Andrew Fish ; >Laszlo Ersek ; Leif Lindholm ; >Kinney, Michael D >Subject: [PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is

[edk2-devel] [PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is removed

2019-05-16 Thread Ni, Ray
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ray Ni Cc: Liming Gao Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney --- Maintainers.txt | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/Maintainers.txt

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Zeng, Star
Situation: All the generations (including the internal generations not listed in SDM) we saw have MSR 13Ch available when CpuInfo->CpuIdVersionInfoEcx.Bits.AESNI == 1. Requirement: Reuse more code. Could you help think the good method and even propose the patch for that? I am ok to any method

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation

2019-05-16 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Sami Mujawar > Sent: Thursday, May 9, 2019 9:37 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Matteo Carlini ; Stephanie Hughes-Fitt > ; nd ;

Re: [edk2-devel] [PATCH v3 2/3] UefiCpuPkg: Remove double \r

2019-05-16 Thread Dong, Eric
Hi Joe, Reviewed-by: Eric Dong And pushed. SHA-1: 4d5d7812786db947e476b4d850698b465d0e2d99 * UefiCpuPkg: Remove double \r Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Joe Richey Reviewed-by: Eric Dong Thanks, Eric > -Original Message- > From: Joe Richey

[edk2-devel] VariablePolicy presentation details

2019-05-16 Thread via Groups.Io
Slides for the call tonight have been uploaded to groups.io. If you’d like to review the public code, it can be found in the following commit and branch (both are relevant): https://github.com/microsoft/mu_basecore/commit/b8104538c89f758f8fa9464c67419595fe73b2d7

[edk2-devel] Upcoming Event: TianoCore Design Meeting - APAC/NAMO - Thu, 05/16/2019 6:30pm-7:30pm #cal-reminder

2019-05-16 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Design Meeting - APAC/NAMO *When:* Thursday, 16 May 2019, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/969264410 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=456832 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com (

Re: [edk2-devel] [PATCH] Maintainers.txt: Add 'Zhichao Gao' for ShellPkg review

2019-05-16 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Gao, Zhichao > Sent: Thursday, May 16, 2019 6:06 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Liming > Subject: [PATCH] Maintainers.txt: Add 'Zhichao Gao' for ShellPkg review > Importance: High > > Add

Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: remove unused code for IPF

2019-05-16 Thread Liming Gao
I see no module consumes this source file. The change is good. Reviewed-by: Liming Gao >-Original Message- >From: Wang, Jian J >Sent: Tuesday, May 14, 2019 10:30 PM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Kinney, Michael D >; Ye, Ting >Subject: [PATCH] CryptoPkg/BaseCryptLib:

[edk2-devel] [PATCH] Maintainers.txt: Add 'Zhichao Gao' for ShellPkg review

2019-05-16 Thread Gao, Zhichao
Add 'Zhichao Gao' as a reviewer for ShellPkg. Cc: Jaben Carsey Cc: Ray Ni Cc: Liming Gao Signed-off-by: Zhichao Gao --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index 7315241b6e..6a5f5d6200 100644 --- a/Maintainers.txt +++

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Ni, Ray
Star, I think the discussion is about providing the evidence to support removing the generation check. Not just the benefit of that. Thanks, Ray > -Original Message- > From: Zeng, Star > Sent: Thursday, May 16, 2019 10:52 PM > To: devel@edk2.groups.io; ler...@redhat.com > Cc: Dong, Eric

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Dong, Eric
Hi Star, I agree with Laszlo's comments. Just remove the generation check logic is not a correct approach. We also have another Bugz reported the similar issue https://bugzilla.tianocore.org/show_bug.cgi?id=591 I think maybe we can follow that bugz request to default enable the feature and

[edk2-devel] [PATCH] BaseTools:Add the FeatureFlagExpression usage to the InfBuildData

2019-05-16 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1446 FeatureFlagExpression Support in LibraryClasses/Guids/Ppi/Protocols section of INF file. The Pcd value in the expression is from INF or DEC When a FeatureFlagExpression is present,if the expression evaluates to TRUE,then the entry is valid.

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: Add GT Frame Number validation to GTDT parser

2019-05-16 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao > -Original Message- > From: Krzysztof Koch [mailto:krzysztof.k...@arm.com] > Sent: Thursday, May 16, 2019 4:44 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; sami.muja...@arm.com; > n...@arm.com > Subject: [PATCH v2 1/1] ShellPkg:

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 05/16/2019 5:00pm-5:30pm #cal-reminder

2019-05-16 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 16 May 2019, 5:00pm to 5:30pm, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/769108409 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=458022 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com (

Re: [edk2-devel] [PATCH edk2-platforms 00/16] Add Network's include segment files in DSC/FDF

2019-05-16 Thread Leif Lindholm
Hi Shenglei, I have now reviewed the patches that are mine to review. Many thanks for this bit of cleanup/standardisation. I would just like to raise one warning flag: These patches have been submitted without the Contributed-under tag. That means the series needs to either be held back until an

Re: [edk2-devel] [PATCH edk2-platforms 14/16] Platform/RDKQemu: Update DSC to use NetworkPkg's include fragment file.

2019-05-16 Thread Leif Lindholm
On Wed, May 15, 2019 at 04:56:59PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang > --- > Platform/Comcast/RDKQemu/RDKQemu.dsc | 36 +--- > 1 file

Re: [edk2-devel] [PATCH edk2-platforms 11/16] Platform/Overdrive1000Board: Update DSC/FDF to use NetworkPkg's fragment file.

2019-05-16 Thread Leif Lindholm
On Wed, May 15, 2019 at 04:56:56PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm > --- > .../Overdrive1000Board/Overdrive1000Board.dsc | 27

Re: [edk2-devel] [PATCH edk2-platforms 10/16] Platform/SynQuacerEvalBoard: Update DSC/FDF to use NetworkPkg's fragment file.

2019-05-16 Thread Leif Lindholm
On Wed, May 15, 2019 at 04:56:55PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang > --- > .../SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 35 +-- >

Re: [edk2-devel] [PATCH edk2-platforms 12/16] Silicon/Armada7k8k: Update DSC/FDF to use NetworkPkg's include fragment file.

2019-05-16 Thread Leif Lindholm
On Wed, May 15, 2019 at 04:56:57PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang > --- > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 26 +++ >

Re: [edk2-devel] [PATCH edk2-platforms 08/16] Platform/CelloBoard: Update DSC/FDF to use NetworkPkg's include fragment file.

2019-05-16 Thread Leif Lindholm
On Wed, May 15, 2019 at 04:56:53PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm > --- > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 28

Re: [edk2-devel] [PATCH edk2-platforms 07/16] Hisilicon/HiKey960: Update DSC/FDF to use NetworkPkg's include fragment file.

2019-05-16 Thread Leif Lindholm
On Wed, May 15, 2019 at 04:56:52PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/HiKey960/HiKey960.dsc | 25

Re: [edk2-devel] [PATCH edk2-platforms 04/16] Hisilicon/D05: Update DSC/FDF to use NetworkPkg's include fragment file.

2019-05-16 Thread Leif Lindholm
On Wed, May 15, 2019 at 04:56:49PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang > --- > Platform/Hisilicon/D05/D05.dsc | 56 +++--- >

[edk2-devel] [Patch V2] BaseTools: Library hashing fix and optimization for --hash feature

2019-05-16 Thread Christian Rodriguez
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1788 In V2: Build failure caused by passing incorrect boolean parameter to SaveFileOnChange(). Fixed for patch instances. Library hashing is now supported by the --hash feature. The --hash feature implementation assumed that the hashing could be

Re: [edk2-devel] [PATCH edk2-platforms 02/16] Platform/VExpressPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2019-05-16 Thread Leif Lindholm
On Wed, May 15, 2019 at 04:56:47PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang This looks to me like it translates the existing configuration accurately. Reviewed-by:

[edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

2019-05-16 Thread Krzysztof Koch
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1820 The ACPI 6.3 specification introduces a 'SPE overflow Interrupt' field as part of the GICC structure. Update the MADT parser to decode this field and validate the interrupt ID used. Signed-off-by: Krzysztof Koch --- Changes can be seen

Re: [edk2-devel] [PATCH v2 0/4] Add Network's include segment files in DSC/FDF

2019-05-16 Thread Laszlo Ersek
On 05/16/19 10:18, Zhang, Shenglei wrote: > We have plan to move all network related modules/libraries to > NetworkPkg. So in order to make these changes happen smoothly, > We update platforms' DSC/FDF to use Network's include segment files. > > Fu Siyuan (4): > OvmfPkg: Update DSC/FDF to use

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Zeng, Star
Laszlo, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Thursday, May 16, 2019 9:06 PM > To: Zeng, Star ; devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Chandana C > Subject: Re: [edk2-devel] [PATCH]

[edk2-devel] Upcoming Event: TianoCore Design Meeting - EMEA/NAMO - Thu, 05/16/2019 8:00am-9:00am #cal-reminder

2019-05-16 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Design Meeting - EMEA/NAMO *When:* Thursday, 16 May 2019, 8:00am to 9:00am, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/571317753 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=456830 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com (

Re: [edk2-devel] [edk2-platforms: PATCH 08/14] Marvell/Armada7k8k: Enable PCIE support

2019-05-16 Thread Leif Lindholm
On Thu, May 16, 2019 at 04:25:14PM +0200, Ard Biesheuvel wrote: > > > This driver requires gArmTokenSpaceGuid.PcdPciIoTranslation to be set > > > to a sane value. Are you sure this is the case for your platforms? > > > > > > > Do you mean the IO space for the controller? If yes, I'll set the PCD >

Re: [edk2-devel] [edk2-platforms: PATCH 06/14] Marvell/Armada7k8k: Add PciExpressLib implementation

2019-05-16 Thread Marcin Wojtas
czw., 16 maj 2019 o 16:02 Ard Biesheuvel napisał(a): > > On Thu, 9 May 2019 at 11:54, Marcin Wojtas wrote: > > > > From: Ard Biesheuvel > > > > Implement a special version of PciExpressLib that takes the quirky > > nature of the Synopsys Designware PCIe IP into account. In particular, > > we

Re: [edk2-devel] [edk2-platforms: PATCH 08/14] Marvell/Armada7k8k: Enable PCIE support

2019-05-16 Thread Ard Biesheuvel
On Thu, 16 May 2019 at 16:22, Marcin Wojtas wrote: > > Hi Ard, > > czw., 16 maj 2019 o 16:16 Ard Biesheuvel > napisał(a): > > > > On Thu, 9 May 2019 at 11:54, Marcin Wojtas wrote: > > > > > > Wire up the platform libraries to the generic drivers so that we can use > > > PCI devices and UEFI,

Re: [edk2-devel] [edk2-platforms: PATCH 08/14] Marvell/Armada7k8k: Enable PCIE support

2019-05-16 Thread Ard Biesheuvel
On Thu, 9 May 2019 at 11:54, Marcin Wojtas wrote: > > Wire up the platform libraries to the generic drivers so that we can use > PCI devices and UEFI, and leave the controller initialized so that the > OS can boot it using a generic driver of its own. > > Contributed-under: TianoCore Contribution

Re: [edk2-devel] [edk2-platforms: PATCH 07/14] Marvell/Armada7k8k: Implement PciHostBridgeLib

2019-05-16 Thread Ard Biesheuvel
On Thu, 9 May 2019 at 11:54, Marcin Wojtas wrote: > > Add an implementation of the PciHostBridgeLib glue library that > describes the PCIe RC on this SoC so that the generic PCI host bridge > driver can attach to it. > > This includes a constructor which performs the SoC specific init and >

Re: [edk2-devel] [edk2-platforms: PATCH 08/14] Marvell/Armada7k8k: Enable PCIE support

2019-05-16 Thread Marcin Wojtas
Hi Ard, czw., 16 maj 2019 o 16:16 Ard Biesheuvel napisał(a): > > On Thu, 9 May 2019 at 11:54, Marcin Wojtas wrote: > > > > Wire up the platform libraries to the generic drivers so that we can use > > PCI devices and UEFI, and leave the controller initialized so that the > > OS can boot it using

Re: [edk2-devel] [PATCH v2 1/4] OvmfPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2019-05-16 Thread Laszlo Ersek
On 05/16/19 10:18, Zhang, Shenglei wrote: > From: Fu Siyuan > > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > The feature enabling flags in [Defines] section have been updated to use > the NetworkPkg's terms, and the value has been

Re: [edk2-devel] [edk2-platforms: PATCH 06/14] Marvell/Armada7k8k: Add PciExpressLib implementation

2019-05-16 Thread Ard Biesheuvel
On Thu, 9 May 2019 at 11:54, Marcin Wojtas wrote: > > From: Ard Biesheuvel > > Implement a special version of PciExpressLib that takes the quirky > nature of the Synopsys Designware PCIe IP into account. In particular, > we need to ignores config space accesses to all devices on the first

Re: [edk2-devel] [edk2-platforms: PATCH 03/14] Marvell/Library: ArmadaBoardDescLib: Add PCIE information

2019-05-16 Thread Ard Biesheuvel
On Thu, 9 May 2019 at 11:53, Marcin Wojtas wrote: > > Introduce new callback that can provide information > about PCIE controller per-board description. > A new structure is defined containing base addresses, > windows/bus configuration and reset GPIO usage indication. > > Contributed-under:

Re: [edk2-devel] [edk2-platforms: PATCH 05/14] Marvell/Armada7k8k: MvBoardDesc: Extend protocol with PCIE support

2019-05-16 Thread Ard Biesheuvel
On Thu, 9 May 2019 at 11:54, Marcin Wojtas wrote: > > Introduce new callback that can provide information about PCIE > controllers, which are used on the platform. According ArmadaSoCDescLib > ArmadaBoardDescLib routines are used for obtaining required data. > > Contributed-under: TianoCore

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/EnrollDefaultKeys: import the non-default key into db

2019-05-16 Thread Laszlo Ersek
On 05/16/19 05:08, Gary Lin wrote: > For QA test and development, we may need to test Secure Boot with a > devel key instead of UEFI CA. > > This commit adds an argument, "--no-default", to EnrollDefaultKeys.efi. > With the argument, the key from SMBIOS Type 11 will also be enrolled > into db.

Re: [edk2-devel] [PATCH edk2-platform] Platform/PurleyOpenBoardPkg: Add the missing copyright and license

2019-05-16 Thread Zhou, Bowen
Reviewed-by: Xiaohu Zhou -Original Message- From: Gao, Liming Sent: Thursday, May 16, 2019 8:27 AM To: devel@edk2.groups.io Cc: Lu, Shifei A ; Zhou, Bowen Subject: [PATCH edk2-platform] Platform/PurleyOpenBoardPkg: Add the missing copyright and license Signed-off-by: Liming Gao cc:

Re: [edk2-devel] [PATCH edk2-platform] Silicon/Intel/PurleySktPkg: Add the missing copyright and license

2019-05-16 Thread Zhou, Bowen
Reviewed-by: Xiaohu Zhou -Original Message- From: Gao, Liming Sent: Thursday, May 16, 2019 8:27 AM To: devel@edk2.groups.io Cc: Lu, Shifei A ; Zhou, Bowen Subject: [PATCH edk2-platform] Silicon/Intel/PurleySktPkg: Add the missing copyright and license Signed-off-by: Liming Gao cc:

Re: [edk2-devel] [Patch 0/7] Add new CLANG8ELF tool chain for new LLVM/CLANG8

2019-05-16 Thread Liming Gao
This topic is discussed in edk2 design meeting. Here is the minutes https://edk2.groups.io/g/announce/topic/31575273 I also collect the image size for OvmfIa32x64 (Bytes). GCC and CLANG enables LTO, VS2015 enables GL. OvmfIa32X64 (Bytes)GCC5 VS2015x86 CLANG8ELF CLANG8PE PEIFV (IA32)

Re: [edk2-devel][Patch] Nt32Pkg: Remove it

2019-05-16 Thread Liming Gao
Ray: I have no comments on this change. Please also send the patch to update maintainer.txt. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, Ray > Sent: Wednesday, May 15, 2019 6:12 PM > To: Wu,

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Laszlo Ersek
Hi Star, On 05/16/19 12:33, Star Zeng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1679 > > The checking to CpuInfo->CpuIdVersionInfoEcx.Bits.AESNI is enough, > the checking to CPU generation could be removed, then the code > could be reused by more platforms. > > Cc: Laszlo

Re: [edk2-devel] [PATCH 3/4] OvmfPkg/PlatformPei: reorder the 32-bit PCI hole vs. the PCIEXBAR on q35

2019-05-16 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 5/16/19 2:18 PM, Laszlo Ersek wrote: > On 05/16/19 10:00, Ard Biesheuvel wrote: >> On Sat, 4 May 2019 at 02:07, Laszlo Ersek wrote: >>> >>> Commit 7b8fe63561b4 ("OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG >>> / ECAM) on Q35", 2016-03-10) claimed that, >>> >>> On Q35

Re: [edk2-devel] [PATCH 3/4] OvmfPkg/PlatformPei: reorder the 32-bit PCI hole vs. the PCIEXBAR on q35

2019-05-16 Thread Laszlo Ersek
On 05/16/19 10:00, Ard Biesheuvel wrote: > On Sat, 4 May 2019 at 02:07, Laszlo Ersek wrote: >> >> Commit 7b8fe63561b4 ("OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG >> / ECAM) on Q35", 2016-03-10) claimed that, >> >> On Q35 machine types that QEMU intends to support in the long term,

[edk2-devel] [Patch] BaseTools: Fix private includes for FILE_GUID override

2019-05-16 Thread Bob Feng
From: Michael D Kinney BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1648 When a module in a DSC file uses a FILE_GUID override in the module scoped section, a copy of the modified INF file is placed in the Conf/.cache directory. The check for private includes uses the INF path to

Re: [edk2-devel] [PATCH] BaseTools: Library hashing fix and optimization for --hash feature

2019-05-16 Thread Bob Feng
Hi Christian, +# Return a Boolean based on if can skip by hash, either from memory or from IO. +if self.Name not in GlobalData.gBuildHashSkipTracking[self.Arch]: +# If hashes are the same, SaveFileOnChange() will return False. +

[edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1679 The checking to CpuInfo->CpuIdVersionInfoEcx.Bits.AESNI is enough, the checking to CPU generation could be removed, then the code could be reused by more platforms. Cc: Laszlo Ersek Cc: Eric Dong Cc: Ruiyu Ni Cc: Chandana Kumar

[edk2-devel] [PATCH v1 2/3] DynamicTablesPkg: Test for duplicate UIDs in MADT generator

2019-05-16 Thread Krzysztof Koch
Check for duplicate ACPI Processor UIDs when populating the GIC CPU (GICC) Interface structures inside the MADT table generator. Signed-off-by: Krzysztof Koch --- Notes: v1: - Detect duplicate ACPI Processor UIDs in GICCs [Krzysztof]

[edk2-devel] [PATCH v1 0/3] Detect duplicate field values in ACPI tables

2019-05-16 Thread Krzysztof Koch
This patch set introduces generic code for finding duplicate elements in an array and uses it to validate two ACPI tables: MADT and GTDT. This change is motivated by the need for certain ACPI table field to have unique values across the entire table. Changes can be seen at:

[edk2-devel][Patch] IntelFspPkg: Remove them

2019-05-16 Thread Ni, Ray
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1819 Since there are V2 FSP packages (IntelFsp2Pkg, IntelFsp2WrapperPkg), this patch removes IntelFspPkg, IntelFspWrapperPkg to remove obsolete code in edk2 repo. Signed-off-by: Ray Ni Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng

[edk2-devel] [PATCH v2 2/4] Nt32Pkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2019-05-16 Thread Zhang, Shenglei
From: Fu Siyuan This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. The feature enabling flags in [Defines] section have be updated to use the NetworkPkg's terms, and the value have been overridden with the original default value on this

[edk2-devel] [PATCH v2 3/4] ArmVirtPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2019-05-16 Thread Zhang, Shenglei
From: Fu Siyuan This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. The feature enabling flags in [Defines] section have been updated to use the NetworkPkg's terms, and the value has been overridden with the original default value on this

[edk2-devel] [PATCH v2 0/4] Add Network's include segment files in DSC/FDF

2019-05-16 Thread Zhang, Shenglei
We have plan to move all network related modules/libraries to NetworkPkg. So in order to make these changes happen smoothly, We update platforms' DSC/FDF to use Network's include segment files. Fu Siyuan (4): OvmfPkg: Update DSC/FDF to use NetworkPkg's include fragment file. Nt32Pkg: Update

[edk2-devel] [PATCH v2 4/4] EmulatorPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2019-05-16 Thread Zhang, Shenglei
From: Fu Siyuan This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. The feature enabling flags in [Defines] section have been updated to use the NetworkPkg's terms, and the value has been overridden with the original default value on this

[edk2-devel] [PATCH v2 1/4] OvmfPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2019-05-16 Thread Zhang, Shenglei
From: Fu Siyuan This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. The feature enabling flags in [Defines] section have been updated to use the NetworkPkg's terms, and the value has been overridden with the original default value on this

Re: [edk2-devel] [PATCH 4/4] OvmfPkg/PlatformPei: fix MTRR for low-RAM sizes that have many bits clear

2019-05-16 Thread Ard Biesheuvel
On Sat, 4 May 2019 at 02:07, Laszlo Ersek wrote: > > Assume that we boot OVMF in a QEMU guest with 1025 MB of RAM. The > following assertion will fire: > > > ASSERT_EFI_ERROR (Status = Out of Resources) > > ASSERT OvmfPkg/PlatformPei/MemDetect.c(696): !EFI_ERROR (Status) > > That's because the

Re: [edk2-devel] [PATCH 3/4] OvmfPkg/PlatformPei: reorder the 32-bit PCI hole vs. the PCIEXBAR on q35

2019-05-16 Thread Ard Biesheuvel
On Sat, 4 May 2019 at 02:07, Laszlo Ersek wrote: > > Commit 7b8fe63561b4 ("OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG > / ECAM) on Q35", 2016-03-10) claimed that, > > On Q35 machine types that QEMU intends to support in the long term, QEMU > never lets the RAM below 4 GB exceed 2 GB.

[edk2-devel] [PATCH v4 7/7] CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible

2019-05-16 Thread Xiaoyu lu
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 OpenSSL internally redefines the size of HMAC_CTX at crypto/hmac/hmac_lcl.h(OpenSSL commit e0810e35). Ref: https://github.com/openssl/openssl/pull/4338 We should not use it directly and should remove relevant

[edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-16 Thread Xiaoyu lu
This series is also available at: https://github.com/xiaoyuxlu/edk2/tree/bz_1089_upgrade_to_openssl_1_1_1b_v4 Changes: (1) CryptoPkgOpensslLib: Modify process_files.pl for upgrading OpenSSL (2) CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl crypto/store/* are excluded.

[edk2-devel] [PATCH v4 2/7] CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl

2019-05-16 Thread Xiaoyu lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 When running process_files.py to configure OpenSSL, we can exclude some unnecessary files. This can reduce porting time, compiling time and library size. Upstream OpenSSL commit 71a5516dcc8a which was as part of OpenSSL_1_1_1b, Add the

[edk2-devel] [PATCH v4 4/7] CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL

2019-05-16 Thread Xiaoyu lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 Disable warning for building OpenSSL_1_1_1b add /wd4132 /wd4700 /wd4310 for Visual Studio in OpensslLib[Crypto].inf add -Wno-error=unused-but-set-variable for GCC in OpensslLib[Crypto].inf Although this option is set in some build

[edk2-devel] [PATCH v4 5/7] CryptoPkg/OpensslLib: Fix cross-build problem for AARCH64

2019-05-16 Thread Xiaoyu lu
From: Laszlo Ersek BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 Thanks Laszlo Ersek . Ref: https://edk2.groups.io/g/devel/message/40375 Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/Include/sys/syscall.h | 11 +++ 1 file changed, 11

[edk2-devel] [PATCH v4 6/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-16 Thread Xiaoyu lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 * Update OpenSSL submodule to OpenSSL_1_1_1b OpenSSL_1_1_1b(50eaac9f3337667259de725451f201e784599687) * Run process_files.pl script to regenerate OpensslLib[Crypto].inf and opensslconf.h * Remove -DNO_SYSLOG from OPENSSL_FLAGS in

[edk2-devel] [PATCH v4 1/7] CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL

2019-05-16 Thread Xiaoyu lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 OpenSSL configure mechanism use --with-rand-seed=xxx option to configure random number generation. OpenSSL_1_1_0j(74f2d9c1ec5f5510e1d3da5a9f03c28df0977762) we use default --with-rand-seed=os option to for building it. But

[edk2-devel] [PATCH v4 3/7] CryptoPkg/IntrinsicLib: Fix possible unresolved external symbol issue

2019-05-16 Thread Xiaoyu lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 This is for the upcoming upgrade to OpenSSL_1_1_1b Compiler optimization(Visual Studio) may automatically use _ftol2 instead of some type conversion. For example: OpensslLib.lib(drbg_lib.obj) : error LNK2001: unresolved external

Re: [edk2-devel] [PATCH 2/4] OvmfPkg/PlatformPei: hoist PciBase assignment above the i440fx/q35 branching

2019-05-16 Thread Ard Biesheuvel
On Sat, 4 May 2019 at 02:07, Laszlo Ersek wrote: > > In the MemMapInitialization() function, we currently assign PciBase > different values, on both branches of the board type check. Hoist the > PciBase assignment from the i440fx branch in front of the "if". This is a > no-op for the i440fx

Re: [edk2-devel] [PATCH 1/4] OvmfPkg/PlatformPei: assign PciSize on both i440fx/q35 branches explicitly

2019-05-16 Thread Ard Biesheuvel
On Sat, 4 May 2019 at 02:07, Laszlo Ersek wrote: > > In the MemMapInitialization() function, we currently have a common > PciSize assignment, shared between i440fx and q35. In order to simplify > the rest of this series, lift and duplicate the assignment identically to > both board-specific

Re: [edk2-devel] [[edk2-platforms][PATCH V2] 01/30] edk2-platforms: Add License-History.txt

2019-05-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Thursday, May 16, 2019 7:10 AM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Ard Biesheuvel > ; Gillispie, Thad ; Bu, > Daocheng ; Oram,

[edk2-devel] How to enable existing KVM template with UEFI ?

2019-05-16 Thread Pavan Kumar Aravapalli
Hi , As part of UEFI POC , we are trying to enable UEFI boot for the existing KVM template which is of flavour Cent OS 6.5 64-bit. Please suggest me how can we achieve that. It would be helpful if any documentation or steps provided for the same. Thanks in Advance. Regards, Pavan.