[edk2-devel] GCC compiler version

Hi, all Recently, I find some failure with the different GCC compiler version. I want to collect which GCC version are used by you. Now, I use GCC 5.5 for the verification. It may be a little old. Thanks Liming -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

Re: [edk2-devel] [edk2-platforms Patch 16/28] Vlv2TbltDevicePkg: Update Linux build scripts

Reviewed-By: Zailiang Sun > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Gary Lin > Subject: [edk2-devel]

Re: [edk2-devel] [edk2-platforms Patch 27/28] Vlv2TbltDevicePkg: Only build capsules for X64

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Gary Lin > Subject: [edk2-platforms Patch 27/28] Vlv2TbltDevicePkg: Only build capsules > for X64 > > Only

Re: [edk2-devel] [edk2-platforms Patch 28/28] Vlv2TbltDevicePkg: Update Readme.md for multiple repos

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Gary Lin > Subject: [edk2-platforms Patch 28/28] Vlv2TbltDevicePkg: Update > Readme.md for multiple repos > >

Re: [edk2-devel] [edk2-platforms Patch 26/28] Vlv2TbltDevicePkg: Clean up all build scripts

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Gary Lin > Subject: [edk2-platforms Patch 26/28] Vlv2TbltDevicePkg: Clean up all build > scripts > > * Remove

Re: [edk2-devel] [edk2-platforms Patch 25/28] Vlv2DeviceRefCodePlg/AcpiTablesPCAT: Fix ASL error

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Gary Lin > Subject: [edk2-platforms Patch 25/28] > Vlv2DeviceRefCodePlg/AcpiTablesPCAT: Fix ASL error > >

Re: [edk2-devel] [edk2-platforms Patch 22/28] Vlv2TbltDevicePkg: Add GCC IA32 build support

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Gary Lin > Subject: [edk2-platforms Patch 22/28] Vlv2TbltDevicePkg: Add GCC IA32 build > support > > * Remove

Re: [edk2-devel] [edk2-platforms Patch 21/28] Vlv2TbltDevicePkg: Re-enable BIOS ID feature

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Gary Lin > Subject: [edk2-platforms Patch 21/28] Vlv2TbltDevicePkg: Re-enable BIOS ID > feature > > Add back

Re: [edk2-devel] [edk2-platforms Patch 19/28] Vlv2DeviceRefCodePkg: Remove redundant gEfiSpiProtocolGuid

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Gary Lin > Subject: [edk2-platforms Patch 19/28] Vlv2DeviceRefCodePkg: Remove > redundant gEfiSpiProtocolGuid >

Re: [edk2-devel] [edk2-platforms Patch 17/28] Vlvt2TbltDevicePkg: Fix NULL pointer access in SmbiosMiscDxe

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Gary Lin > Subject: [edk2-platforms Patch 17/28] Vlvt2TbltDevicePkg: Fix NULL pointer > access in SmbiosMiscDxe

Re: [edk2-devel] [edk2-platforms Patch 20/28] Vlv2TbltDevicePkg: Remove redundant gEfiSpiProtocolGuid

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Gary Lin > Subject: [edk2-platforms Patch 20/28] Vlv2TbltDevicePkg: Remove > redundant gEfiSpiProtocolGuid > >

Re: [edk2-devel] [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM

Gary, I suggest remove the first line "From: Gary Lin " from the description section since you have appended the "signed-off-by" declaration. > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Gary Lin ; Sun, Zailiang

Re: [edk2-devel] [edk2-platforms Patch 06/28] Vlv2TbltDevicePkg/bld_vlv.sh: Update the script to fit edk2-platforms

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Gary Lin ; Sun, Zailiang ; Qian, > Yi > Subject: [edk2-platforms Patch 06/28] Vlv2TbltDevicePkg/bld_vlv.sh: Update > the script to fit

Re: [edk2-devel] [edk2-platforms Patch 08/28] Vlv2TbltDevicePkg/bld_vlv.sh: Remove BiosId.env completely

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Gary Lin ; Sun, Zailiang ; Qian, > Yi > Subject: [edk2-platforms Patch 08/28] Vlv2TbltDevicePkg/bld_vlv.sh: > Remove BiosId.env completely >

Re: [edk2-devel] [edk2-platforms Patch 07/28] Vlv2TbltDevicePkg: Add the missing headers to inf files

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Gary Lin ; Sun, Zailiang ; Qian, > Yi > Subject: [edk2-platforms Patch 07/28] Vlv2TbltDevicePkg: Add the missing > headers to inf files > >

Re: [edk2-devel] [edk2-platforms Patch 09/28] Vlv2TbltDevicePkg/bld_vlv.sh: Correct the path to PlatformCapsuleGcc.dsc

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Gary Lin ; Sun, Zailiang ; Qian, > Yi > Subject: [edk2-platforms Patch 09/28] Vlv2TbltDevicePkg/bld_vlv.sh: Correct > the path to

Re: [edk2-devel] [edk2-platforms Patch 04/28] Vlv2TbltDevicePkg/bld_vlv.sh: Update the gcc version detection

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Gary Lin ; Sun, Zailiang ; Qian, > Yi > Subject: [edk2-platforms Patch 04/28] Vlv2TbltDevicePkg/bld_vlv.sh: Update > the gcc version

Re: [edk2-devel] [edk2-platforms Patch 05/28] Vlv2TbltDevicePkg/bld_vlv.sh: Remove ECP completely

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Gary Lin ; Sun, Zailiang ; Qian, > Yi > Subject: [edk2-platforms Patch 05/28] Vlv2TbltDevicePkg/bld_vlv.sh: > Remove ECP completely > >

Re: [edk2-devel] [edk2-platforms Patch 02/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Change the root directory path

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Gary Lin ; Sun, Zailiang ; Qian, > Yi > Subject: [edk2-platforms Patch 02/28] Vlv2TbltDevicePkg/Build_IFWI.sh: > Change the root directory

Re: [edk2-devel] [edk2-platforms Patch 03/28] Vlv2TbltDevicePkg/bld_vlv.sh: Fix the log name

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Gary Lin ; Sun, Zailiang ; Qian, > Yi > Subject: [edk2-platforms Patch 03/28] Vlv2TbltDevicePkg/bld_vlv.sh: Fix the > log name > > From:

Re: [edk2-devel] [edk2-platforms Patch 01/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Add "set -e" to exit on error

Reviewed-By: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Gary Lin ; Sun, Zailiang ; Qian, > Yi > Subject: [edk2-platforms Patch 01/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Add > "set -e" to exit on

Re: [edk2-devel] [edk2-DscSpecification PATCH v1] DSC document: Support HOST_APPLICATION ModuleType

Reviewed-by: Liming Gao >-Original Message- >From: Lu, XiaoyuX >Sent: Thursday, July 11, 2019 12:13 PM >To: devel@edk2.groups.io >Cc: Lu, XiaoyuX ; Gao, Liming ; >Yao, Jiewen >Subject: [edk2-DscSpecification PATCH v1] DSC document: Support >HOST_APPLICATION ModuleType > >REF:

[edk2-devel] [edk2-DscSpecification PATCH v1] DSC document: Support HOST_APPLICATION ModuleType

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1952 INF spec add a new MODULE_TYPE HOST_APPLICATION, so this SPEC also need be updated to support this type. Cc: Liming Gao Cc: Jiewen Yao Signed-off-by: Xiaoyu Lu --- 1_introduction/12_terms.md | 6 +++---

Re: [edk2-devel] [PATCH v2 2/3] MdePkg/BaseLib.h: Update IA32_CR4 structure for 5-level paging

Laszlo, Mike, An update to my revert proposal, I will only revert the below 2 patches: 7c5010c7f88b790f4524c4a5311819e3af5e2752 * MdePkg/BaseLib.h: Update IA32_CR4 structure for 5-level paging 7365eb2c8cf1d7112330d09918c0c67e8d0b827a * UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU

Re: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands

Mike, > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 1:28 AM > To: Leif Lindholm ; Kinney, Michael D > > Cc: Wang, Jian J ; devel@edk2.groups.io; Gao, > Liming > Subject: RE: [ PATCH v2 1/2] Readme.md: add submodule policy and clone > commands > > > >

Re: [edk2-devel] [PATCH v2 2/3] MdePkg/BaseLib.h: Update IA32_CR4 structure for 5-level paging

Laszlo, Mike, Sorry I did violate the process. I had two assumptions which led me violate the process: 1. Reviewed-by from UefiCpuPkg maintainers on this IA32_CR4 change is more important than that from MdePkg maintainers. In another word, I thought if UefiCpuPkg maintainers agree with

Re: [edk2-devel] [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode

HI Laszlo: There is a discussion over this issue in UEFI Manits https://mantis.uefi.org/mantis/view.php?id=1983 The justification lies here: Spec perspective: Section 8.2.2 : In SetupMode Secure Boot Policy variables shall consider step 3 and 4 check to be successful. Section

Re: [edk2-devel] [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol

> -Original Message- > From: Dong, Eric > Sent: Thursday, July 11, 2019 10:22 AM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Sean Brogan ; Ni, Ray ; > Laszlo Ersek ; Gao, Liming ; > Michael Turner ; Bret Barkelew > > Subject: RE: [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2

Re: [edk2-devel] [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol

Hi Zhizhao, The new add files don't have copyright info, is it ok? Thanks, Eric > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, July 9, 2019 4:40 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Dong, Eric > ; Ni, Ray ; Laszlo Ersek > ; Gao, Liming ; Michael Turner > ; Bret

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Fix GCC7/GCC8 build failure

Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Thursday, July 11, 2019 9:17 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Dong, Eric > ; Laszlo Ersek > Subject: [PATCH] UefiCpuPkg/PiSmmCpu: Fix GCC7/GCC8 build failure > > Signed-off-by: Ray Ni > Cc:

Re: [edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Fix an ASSERTION issue

Reviewed-by: Eric Dong > -Original Message- > From: Zeng, Star > Sent: Wednesday, July 10, 2019 7:43 PM > To: devel@edk2.groups.io > Cc: Zeng, Star ; Laszlo Ersek ; > Dong, Eric ; Ni, Ray ; Kumar, > Chandana C ; Li, Kevin Y > > Subject: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Fix an

Re: [edk2-devel] [Patch 0/7] Revert new added BfmLib/FCE/FMMT

Reviewed-by: Feng Bob C -Original Message- From: Gao, Liming Sent: Thursday, July 11, 2019 9:45 AM To: devel@edk2.groups.io Cc: Leif Lindholm ; Feng, Bob C Subject: [Patch 0/7] Revert new added BfmLib/FCE/FMMT Rewrite those tools for review again. Now, move them into

Re: [edk2-devel] [Patch v3] BaseTools: Fix GCC compiler failure in new added tools.

Mike: Yes. I send the patch and revert them today. Thanks Liming >-Original Message- >From: Kinney, Michael D >Sent: Thursday, July 11, 2019 4:10 AM >To: Gao, Liming ; devel@edk2.groups.io; >leif.lindh...@linaro.org; Kinney, Michael D >Cc: Gao, Zhichao ; Feng, Bob C >; Andrew Fish ;

[edk2-devel] [Patch 2/7] Revert "BaseTools/BfmLib: Change BfmLib script type in PosixLike"

This reverts commit 556bf5b3570a2290ad82c1a027740e72230baa26. There are the concerns on code design and code quality, and request to rewrite FCE, BfmLib and FMMT for the review. Cc: Leif Lindholm Cc: Feng Bob C Signed-off-by: Liming Gao --- BaseTools/BinWrappers/PosixLike/BfmLib | 58

[edk2-devel] [Patch 3/7] Revert "BaseTools/FMMT: Change FMMT script type in PosixLike"

This reverts commit 2112fc71b1112554bcfb75a454002d2bbeed552f. There are the concerns on code design and code quality, and request to rewrite FCE, BfmLib and FMMT for the review. Cc: Leif Lindholm Cc: Feng Bob C Signed-off-by: Liming Gao --- BaseTools/BinWrappers/PosixLike/FMMT | 58

[edk2-devel] [Patch 1/7] Revert "BaseTools/FCE: Change FCE script type in PosixLike"

This reverts commit 8a842b31b93323ee3dc7631059292d30f6179cd3. There are the concerns on code design and code quality, and request to rewrite FCE, BfmLib and FMMT for the review. Cc: Leif Lindholm Cc: Feng Bob C Signed-off-by: Liming Gao --- BaseTools/BinWrappers/PosixLike/FCE | 58

[edk2-devel] [Patch 4/7] Revert "BaseTools: fix FCE build when edksetup not executed"

This reverts commit d031fc07eb83c9d13bff3ebac25da458d5a47917. There are the concerns on code design and code quality, and request to rewrite FCE, BfmLib and FMMT for the review. Cc: Leif Lindholm Cc: Feng Bob C Signed-off-by: Liming Gao --- BaseTools/Source/C/FCE/GNUmakefile | 2 +- 1 file

[edk2-devel] [Patch 0/7] Revert new added BfmLib/FCE/FMMT

Rewrite those tools for review again. Now, move them into edk2-staging/FceFmmt branch. Cc: Leif Lindholm Cc: Feng Bob C Liming Gao (7): Revert "BaseTools/FCE: Change FCE script type in PosixLike" Revert "BaseTools/BfmLib: Change BfmLib script type in PosixLike" Revert "BaseTools/FMMT:

Re: [edk2-devel] [PATCH V2 4/4] MdeModulePkg/DxeMain: Implement common event protocol

Zhichao, Understood now. Thanks for the information. Regards, Jian > -Original Message- > From: Gao, Zhichao > Sent: Thursday, July 11, 2019 8:21 AM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Sean Brogan ; Wu, Hao A > ; Ni, Ray ; Zeng, Star > ; Gao, Liming ; Michael > Turner ;

Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports

Mike, Thanks for raising this build failure. I just tried in my Ubuntu 18 in Win10. Even GCC7 complains about this. My bad! I just posted a fix. Thanks, Ray > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 4:06 AM > To: devel@edk2.groups.io; Ni, Ray ;

[edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Fix GCC7/GCC8 build failure

Signed-off-by: Ray Ni Cc: Michael D Kinney Cc: Eric Dong Cc: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c index

[edk2-devel] [Patch 1/1] BaseTools: Fixed the issue when ToolDefinitionFile is not generated

ToolDefinitionFile is generated by PlatformAutoGen.ToolDefinition() Code assume ToolDefinition is always called before using ToolDefinitionFile, but in some cases, it's not true. This patch is to fix this issue. Cc: Liming Gao Signed-off-by: Bob Feng ---

Re: [edk2-devel] [PATCH V2 4/4] MdeModulePkg/DxeMain: Implement common event protocol

> -Original Message- > From: Wang, Jian J > Sent: Wednesday, July 10, 2019 4:47 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Sean Brogan ; Wu, Hao A > ; Ni, Ray ; Zeng, Star > ; Gao, Liming ; Michael Turner > ; Bret Barkelew > > Subject: RE: [PATCH V2 4/4] MdeModulePkg/DxeMain:

Re: [edk2-devel] [Patch] ShellPkg/AcpiView: Fix IA32 link error

Reviewed-by: Jaben Carsey > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, July 10, 2019 3:35 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao > Subject: [Patch] ShellPkg/AcpiView: Fix IA32 link error > Importance: High > >

[edk2-devel] [Patch] ShellPkg/AcpiView: Fix IA32 link error

https://bugzilla.tianocore.org/show_bug.cgi?id=1970 Update local variable in ParseAcpiSlot() to be UINT32 instead of UINT64 to avoid 64-bit multiply operation in the SLIT_ELEMENT() macro. Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Michael D Kinney ---

[edk2-devel] [PATCH] Simplify edksetup.sh

o Use '$SCRIPTNAME' consistently instead of 'edksetup.sh' o Use the bash environment variable $PWD instead of executing the pwd command. o Add quotes around variables to ensure they're evaluated correctly. o Simplify SetupPython3() and SetupPython() functions. On Linux, "whereis" matches

Re: [edk2-devel] [Patch v3] BaseTools: Fix GCC compiler failure in new added tools.

On Wed, Jul 10, 2019 at 01:42:44PM +, Liming Gao wrote: > > > - strncat (LocalStr, "[attributes] \n", sizeof("[attributes] \n")); > > > + strncat (LocalStr, "[attributes] \n", STR_LEN_MAX_4K - strlen > > > (LocalStr) - 1); > > > > This is a very inefficient, and difficult to read, way of

Re: [edk2-devel] [Patch v3] BaseTools: Fix GCC compiler failure in new added tools.

Liming, I agree that edk2-staging is a good place to work on cleaning these tools up. Please revert the commit of these tools today so GCC builds are not broken. Thanks, Mike > -Original Message- > From: Gao, Liming > Sent: Wednesday, July 10, 2019 6:43 AM > To: devel@edk2.groups.io;

Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports

Hi Ray, I noticed a Linux/GCC build issue with this patch when using GCC version: gcc version 8.2.1 20181215 (Red Hat 8.2.1-6) (GCC) edk2/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c: In function 'ReclaimPages': edk2/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c:574:89: error: ?: using integer

Re: [edk2-devel] [PATCH v2 2/3] MdePkg/BaseLib.h: Update IA32_CR4 structure for 5-level paging

Laszlo, I agree with your feedback. Process must be followed. I also agree that it may make sense to add some more maintainers to the MdePkg, especially for some of the content in MdePkg that is closely related to the UefiCpuPkg content. I have reviewed this patch to the BaseLib.h. The new

Re: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies

Gary, Thanks for the feedback. I fixes these in the patch email review I sent out today. Mike > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Wednesday, July 10, 2019 12:10 AM > To: devel@edk2.groups.io; Kinney, Michael D > > Cc: Qian, Yi ; Sun, Zailiang > >

[edk2-devel] [edk2-platforms Patch 22/28] Vlv2TbltDevicePkg: Add GCC IA32 build support

* Remove CpuIa32Lib that contains inline assembly that is not compatible with GCC builds. Use BaseLib functions for CPUID and MSR access and the CPUID and MSR defintions from the UefiCpuPkg. * Add PlatformPkgGccIa32.dsc * Add /IA32 flag to Build_IFWI.sh * Add /IA32 flag to bld_vlv.sh *

[edk2-devel] [edk2-platforms Patch 25/28] Vlv2DeviceRefCodePlg/AcpiTablesPCAT: Fix ASL error

Remove use of a method to read a register from a BAR and instead access the register directly. Resolves the following error from the latest iasl compiler. Or(ShiftLeft(Derefof(Index(CDCT, \_SB.PCI0.GFX0.MCHK.DCFE)), 21),PARM, PARM) Error 6163 - Object is created temporarily in another method

[edk2-devel] [edk2-platforms Patch 24/28] Vlv2TbltDevicePkg: Reorganize the libraries

From: Gary Lin * Simplify the logic of importing TpmMeasurementLib * Import BaseCryptLib, OpensslLib, and IntrinsicLib unconditionally since FmpDxe needs them * Import FileExplorerLib unconditionally since UiApp needs it * Update the import of TPM/TCG libraries Cc: Zailiang Sun Cc: Yi Qian

[edk2-devel] [edk2-platforms Patch 28/28] Vlv2TbltDevicePkg: Update Readme.md for multiple repos

Update Readme.md with instructions to clone content from the edk2, edk2-platforms, and edk2-non-osi repositories and build Vlv2TbltDevicePkg for Windows and Linux. Cc: Zailiang Sun Cc: Yi Qian Cc: Gary Lin Signed-off-by: Michael D Kinney --- Platform/Intel/Vlv2TbltDevicePkg/Readme.md | 145

[edk2-devel] [edk2-platforms Patch 26/28] Vlv2TbltDevicePkg: Clean up all build scripts

* Remove cln.sh * Remove unused PlatformDefintions.h file * Remove unused defines from DSC files * Make Windows and Linux script more consistent * Remove unused options from Windows/Linux scripts * Remove unused defines from Windows/Linux scripts * Do not modify Target.txt in Conf directory.

[edk2-devel] [edk2-platforms Patch 27/28] Vlv2TbltDevicePkg: Only build capsules for X64

Only build capsules for X64 builds. More changes are required to build IA32 capsules. Cc: Zailiang Sun Cc: Yi Qian Cc: Gary Lin Signed-off-by: Michael D Kinney --- Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat | 6 +- Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 6 +- 2 files

[edk2-devel] [edk2-platforms Patch 19/28] Vlv2DeviceRefCodePkg: Remove redundant gEfiSpiProtocolGuid

Remove redundant declaration of gEfiSpiProtocolGuid Cc: Zailiang Sun Cc: Yi Qian Cc: Gary Lin Signed-off-by: Michael D Kinney --- Silicon/Intel/Vlv2DeviceRefCodePkg/Vlv2DeviceRefCodePkg.dec | 1 - 1 file changed, 1 deletion(-) diff --git

[edk2-devel] [edk2-platforms Patch 20/28] Vlv2TbltDevicePkg: Remove redundant gEfiSpiProtocolGuid

Remove redundant declaration of gEfiSpiProtocolGuid. This protocol is defined in Vlv2DeviceRefCodePkg. Cc: Zailiang Sun Cc: Yi Qian Cc: Gary Lin Signed-off-by: Michael D Kinney --- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.dec | 1 - 1 file changed, 1 deletion(-) diff --git

[edk2-devel] [edk2-platforms Patch 21/28] Vlv2TbltDevicePkg: Re-enable BIOS ID feature

Add back BIOSID feature using GenBiosId.py script and BiosIdLib from the BoardModulePkg. Remove the VLV2 specific BiosIdLib implementation. Cc: Zailiang Sun Cc: Yi Qian Cc: Gary Lin Signed-off-by: Michael D Kinney --- .../Include/Library/BiosIdLib.h | 86

[edk2-devel] [edk2-platforms Patch 17/28] Vlvt2TbltDevicePkg: Fix NULL pointer access in SmbiosMiscDxe

Handle case where no Simple Network Protocols are found. Cc: Zailiang Sun Cc: Yi Qian Cc: Gary Lin Signed-off-by: Michael D Kinney --- .../MiscBaseBoardManufacturerFunction.c| 14 +- .../SmBiosMiscDxe/MiscSystemManufacturerFunction.c | 14 +- 2 files

[edk2-devel] [edk2-platforms Patch 14/28] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix the indentation

From: Gary Lin Fix the indentation of MiscSystemManufacturerFunction.c to improve the readability. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- .../MiscSystemManufacturerFunction.c | 51 +-- 1 file changed, 24 insertions(+), 27

[edk2-devel] [edk2-platforms Patch 11/28] Vlv2TbltDevicePkg/GenerateCapsule: Fix the bash scripts

From: Gary Lin Adjust the paths to fit the current directory structure Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- .../Capsule/GenerateCapsule/GenCapsuleAll.sh | 37 +++ .../GenerateCapsule/GenCapsuleMinnowMax.sh| 24 +---

[edk2-devel] [edk2-platforms Patch 04/28] Vlv2TbltDevicePkg/bld_vlv.sh: Update the gcc version detection

From: Gary Lin Borrow the logic from OvmfPkg/build.sh Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git

[edk2-devel] [edk2-platforms Patch 15/28] Vlv2TbltDevicePkg: Import SD/MMC drivers

From: Gary Lin Import the SD card/MMC drivers from MdeModulePkg Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 7 +++ Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf| 7 +++

[edk2-devel] [edk2-platforms Patch 02/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Change the root directory path

From: Gary Lin Also make Build_IFWI.sh executable Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) mode change 100644 => 100755

[edk2-devel] [edk2-platforms Patch 07/28] Vlv2TbltDevicePkg: Add the missing headers to inf files

From: Gary Lin Some headers files are not listed in the inf files. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- .../Library/FlashDeviceLib/FlashDeviceLib.inf | 2 +- .../Vlv2TbltDevicePkg/Library/PchSmmLib/PchSmmLib.inf | 8 +---

[edk2-devel] [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM

From: Gary Lin The scripts for PlatformCapsuleGcc.dsc need Vlv.ROM. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh

[edk2-devel] [edk2-platforms Patch 01/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Add "set -e" to exit on error

From: Gary Lin Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh b/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh

[edk2-devel] [edk2-platforms Patch 08/28] Vlv2TbltDevicePkg/bld_vlv.sh: Remove BiosId.env completely

From: Gary Lin Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh

[edk2-devel] [edk2-platforms Patch 12/28] Vlv2TbltDevicePkg/AcpiPlatform: Remove a unused variable

From: Gary Lin TableVersion in AcpiPlatformEntryPoint() is not used anymore. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[edk2-devel] [edk2-platforms Patch 13/28] Vlv2TbltDevicePkg/AcpiPlatform: Fix the error from InstallAcpiTable

From: Gary Lin The firmware crashed when installing ACPI tables: ASSERT_EFI_ERROR (Status = Invalid Parameter) ASSERT [AcpiPlatform] edk2-platforms/Platform/Intel/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c(1162): !EFI_ERROR (AcpiStatus) The 'Size' from ReadSection() is not the size of the

[edk2-devel] [edk2-platforms Patch 06/28] Vlv2TbltDevicePkg/bld_vlv.sh: Update the script to fit edk2-platforms

From: Gary Lin * Add "set -e" to exit immediately on error * Update the paths to fit the directory changes WORKSPACE +--edk2 (CORE) | +--edk2-platforms | | | +---Platform | || | |+---Intel

[edk2-devel] [edk2-platforms Patch 23/28] Vlv2TbltDevicePkg: Import TlsLib for HTTPS Boot

From: Gary Lin When setting NETWORK_TLS_ENABLE to TRUE, we need TlsLib. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc | 3 +++ Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 3 +++

[edk2-devel] [edk2-platforms Patch 16/28] Vlv2TbltDevicePkg: Update Linux build scripts

* Do not change WORKSPACE env var. Assume it is set before running script. * Access Conf dir relative to WORKSPACE * Run Build_IFWI.sh from the Vlv2Tbl2DevicePkg dir * run bld_vlv.sh from same dir as Build_IFWI.sh Cc: Zailiang Sun Cc: Yi Qian Cc: Gary Lin Signed-off-by: Michael D Kinney ---

[edk2-devel] [edk2-platforms Patch 05/28] Vlv2TbltDevicePkg/bld_vlv.sh: Remove ECP completely

From: Gary Lin Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 3 --- 1 file changed, 3 deletions(-) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh b/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh index

[edk2-devel] [edk2-platforms Patch 09/28] Vlv2TbltDevicePkg/bld_vlv.sh: Correct the path to PlatformCapsuleGcc.dsc

From: Gary Lin For the gcc build, we should use PlatformCapsuleGcc.dsc instead of PlatformCapsule.dsc. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [edk2-platforms Patch 18/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Check the WORKSPACE env variable

From: Gary Lin Check WORKSPACE before running the script and notify the user to export the variable if the variable doesn't exist Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 14 +- 1 file

Re: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands

On Wed, Jul 10, 2019 at 05:28:27PM +, Kinney, Michael D wrote: > > > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Wednesday, July 10, 2019 10:18 AM > > To: Kinney, Michael D > > Cc: Wang, Jian J ; > > devel@edk2.groups.io; Gao, Liming > >

Re: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, July 10, 2019 10:18 AM > To: Kinney, Michael D > Cc: Wang, Jian J ; > devel@edk2.groups.io; Gao, Liming > Subject: Re: [ PATCH v2 1/2] Readme.md: add submodule > policy and clone commands >

Re: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands

On Wed, Jul 10, 2019 at 05:08:32PM +, Kinney, Michael D wrote: > Leif, > > I think the following command has to be run from the git > dir that the edk2 repo was cloned into. > > $ git submodule update --init > > So I think the correct instructions would be: > > $ git clone

Re: [edk2-devel] [PATCH v2 2/3] MdePkg/BaseLib.h: Update IA32_CR4 structure for 5-level paging

Ray, Eric, (+Liming, +Mike, +Leif) On 07/09/19 03:04, Dong, Eric wrote: > Reviewed-by: Eric Dong > >> -Original Message- >> From: Ni, Ray >> Sent: Wednesday, July 3, 2019 2:54 PM >> To: devel@edk2.groups.io >> Cc: Dong, Eric ; Laszlo Ersek >> Subject: [PATCH v2 2/3] MdePkg/BaseLib.h:

Re: [edk2-devel] [PATCH] PL031: Actually disable interrupts

On Wed, Jul 10, 2019 at 04:53:11PM +0200, Alexander Graf via Groups.Io wrote: > The PL031 interrupt mask register (IMSC) is not very clearly documented > in the PL031 specification. However, bit 0 (RTCIMSC) indicates whether > interrupts are enabled, not disabled. 3.3.5. Interrupt Mask Set or

Re: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands

Leif, I think the following command has to be run from the git dir that the edk2 repo was cloned into. $ git submodule update --init So I think the correct instructions would be: $ git clone https://github.com/tianocore/edk2.git $ cd edk2 $ git submodule update --init $ cd .. Mike >

Re: [edk2-devel] [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode

Hi, On 07/10/19 10:50, Wang, Jian J wrote: > Hi Derek, > > Please file a Bugzilla for this issue. With it addressed, > > Reviewed-by: Jian J Wang > jian.j.w...@intel.com I saw this patch as soon as it was posted, and I've been hoping for a deeper discussion

Re: [edk2-devel] [Patch v5 0/2] Enable new MM MP protocol

On 07/10/19 09:56, Dong, Eric wrote: > V5: > 1. Some small enhancement. > > V4 changes: > 1. Use link list to save the used tokens. > > V3 changes: > 1. Fix Token clean up too early caused CheckProcedure return error. > > V1 changes: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=1937 >

Re: [edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Fix an ASSERTION issue

On 07/10/19 13:42, Star Zeng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1968 > > We met assertion like below, it happens when there is only > one processor. > > ASSERT_EFI_ERROR (Status = Not started) > ASSERT [CpuFeaturesDxe] X:\XXX\XXX\RegisterCpuFeaturesLib\ >

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove maintainer info for IntelFsp[Wrapper]Pkg

On 07/10/19 10:05, Ray Ni wrote: > Signed-off-by: Ray Ni > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao > --- > Maintainers.txt | 12 > 1 file changed, 12 deletions(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index

[edk2-devel] [PATCH] PL031: Actually disable interrupts

The PL031 interrupt mask register (IMSC) is not very clearly documented in the PL031 specification. However, bit 0 (RTCIMSC) indicates whether interrupts are enabled, not disabled. So before this commit, we were actually *enabling* interrupts for the RTC. This patch changes the logic to instead

Re: [edk2-devel] [PATCH v3 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

On 07/04/19 16:41, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/ovmf.git > br.platform-xen-pvh-v3 > > Hi, > > I've started to create a Xen specific platform, in OvmfPkg/XenOvmf.dsc > with the goal to make it work on both

Re: [edk2-devel] [PATCH v3 33/35] OvmfPkg: Introduce XenIoPvhDxe to initialize Grant Tables

On 07/04/19 16:42, Anthony PERARD wrote: > XenIoPvhDxe use XenIoMmioLib to reserve some space to be use by the > Grant Tables. > > The call is only done if it is necessary, we simply detect if the > guest is PVH, as in this case there is currently no PCI bus, and no > PCI Xen platform device

Re: [edk2-devel] [Patch v3] BaseTools: Fix GCC compiler failure in new added tools.

Lefi: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif > Lindholm > Sent: Wednesday, July 10, 2019 2:26 AM > To: devel@edk2.groups.io; Gao, Liming > Cc: Gao, Zhichao ; Feng, Bob C ; > Andrew Fish ; Laszlo Ersek > ; Kinney, Michael D >

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove maintainer info for IntelFsp[Wrapper]Pkg

Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, > Ray > Sent: Wednesday, July 10, 2019 4:05 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Laszlo Ersek ; Leif > Lindholm ; Kinney, Michael D > ; Gao, Liming >

[edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Fix an ASSERTION issue

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1968 We met assertion like below, it happens when there is only one processor. ASSERT_EFI_ERROR (Status = Not started) ASSERT [CpuFeaturesDxe] X:\XXX\XXX\RegisterCpuFeaturesLib\ DxeRegisterCpuFeaturesLib.c(149): !EFI_ERROR (Status) The code

Re: [edk2-devel] [PATCH v3 32/35] OvmfPkg/PlatformBootManagerLib: Use a Xen console for ConOut/ConIn

On 07/04/19 16:42, Anthony PERARD wrote: > On a Xen PVH guest, none of the existing serial or console interface > works, so we add a new one, based on XenConsoleSerialPortLib, and > implemented via SerialDxe. > > That is a simple console implementation that can works on both PVH > guest and HVM

Re: [edk2-devel] [Patch 1/1] BaseTools: Detect the change of env variable used in tooldef.txt

On 6/28/19 5:32 AM, Bob Feng wrote: > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1921 > > Add TOOLS_DEF.ARCH file to all workspace meta files list. > TOOLS_DEF.ARCH include the evaluated Tool definition information > which is filtered by current tool_chain. > > With this change, when the

Re: [edk2-devel] [PATCH v3 31/35] OvmfPkg/OvmfXen: Introduce XenTimerDxe

On 07/04/19 16:42, Anthony PERARD wrote: > "PcAtChipsetPkg/8254TimerDxe" is replaced with a Xen-specific > EFI_TIMER_ARCH_PROTOCOL implementation. Also remove > 8259InterruptControllerDxe as it is not used anymore. > > This Timer uses the local APIC timer as time source as it can work on > both a

Re: [edk2-devel] [PATCH v3 29/35] OvmfPkg/PlatformBootManagerLib: Handle the absence of PCI bus on Xen PVH

On 07/04/19 16:42, Anthony PERARD wrote: > When running in a Xen PVH guest, there's nothing to do in > PciAcpiInitialization() because there isn't any PCI bus. When the Host > Bridge DID isn't recognised, simply continue. (The value of > PcdOvmfHostBridgePciDevId would be 0 because it isn't set.)

Re: [edk2-devel] [PATCH v3 28/35] OvmfPkg/PlatformBootManagerLib: Use XenDetected from XenPlatformLib

On 07/04/19 16:42, Anthony PERARD wrote: > Replace the XenDetected() implementation by the one from > XenPlatformLib. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > --- > > Notes: > v3: > - new patch > > .../PlatformBootManagerLib.inf

Re: [edk2-devel] [PATCH v3 14/35] OvmfPkg/AcpiPlatformDxe: Use XenPlatformLib

On 07/08/19 16:38, Laszlo Ersek wrote: > On 07/04/19 16:42, Anthony PERARD wrote: >> This patch replace the XenDetected() function by the one in >> XenPlatformLib. >> >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 >> Signed-off-by: Anthony PERARD >> --- >> >> Notes: >> v3: >>

  1   2   >