> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Leif Lindholm
> Sent: Wednesday, July 17, 2019 10:37 PM
> To: Laszlo Ersek
> Cc: Wu, Hao A; devel@edk2.groups.io; Andrew Fish; Kinney, Michael D; Bi,
> Dandan; Dong, Eric; Gao, Liming; Ni, Ray;
Reviewed-by: Dandan Bi
Thanks,
Dandan
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, July 18, 2019 9:19 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Andrew Fish ;
> Laszlo Ersek ; Leif Lindholm ;
> Kinney, Michael D ; Bi, Dandan
> ; Dong, Eric ; Gao, Liming
> ; Zeng, Star ;
Reviewed-by: Star Zeng for my part.
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, July 18, 2019 9:19 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Andrew Fish ;
> Laszlo Ersek ; Leif Lindholm ;
> Kinney, Michael D ; Bi, Dandan
> ; Dong, Eric ; Gao, Liming
> ; Zeng, Star ;
On 7/15/19 7:04 PM, Laszlo Ersek wrote:
> Repo: https://github.com/lersek/edk2.git
> Branch: ovmfpkg_maintainers
>
> The patches in this series should be inserted between Leif's patches
>
> * [edk2-devel] [PATCH 2/3] Maintainers.txt: add wildcard path association for
> Arm/AArch64
>
> -Original Message-
> From: Kinney, Michael D
> Sent: Wednesday, July 17, 2019 11:41 PM
> To: devel@edk2.groups.io; Gao, Zhichao ; Kinney,
> Michael D
> Cc: Wang, Jian J ; Wu, Hao A ;
> Ni, Ray ; Zeng, Star ; Gao, Liming
> ; Sean Brogan ;
> Michael Turner ; Bret Barkelew
>
> Subject:
Reviewed-by: Eric Dong
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, July 18, 2019 9:19 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Andrew Fish ;
> Laszlo Ersek ; Leif Lindholm ;
> Kinney, Michael D ; Bi, Dandan
> ; Dong, Eric ; Gao, Liming
> ; Zeng, Star ; Gao, Zhichao
>
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, July 17, 2019 9:15 PM
> To: devel@edk2.groups.io; Gao, Zhichao
> Cc: Kinney, Michael D ; Gao, Liming
> ; Wang, Jian J ; Wu, Hao A
> ; Ni, Ray ; Zeng, Star
> ;
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu, Hao
> A
> Sent: Thursday, July 18, 2019 9:19 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Andrew Fish ; Laszlo
> Ersek ; Leif Lindholm
> ; Kinney, Michael D ;
>
This commit add the reviewers information for modules within MdeModulePkg.
For now the modules list includes:
ACPI
ACPI S3
BDS
Console and Graphics
Core services (PEI, DXE and Runtime)
Device and Peripheral
Firmware Update
HII and UI
Management Mode (MM, SMM)
Reset
SMBIOS
UEFI Variable
Please
This patch is also available at:
https://github.com/hwu25/edk2/tree/mdemodulepkg_reviewers_v2
Also, please note that on the above branch, the proposed patch
(MdeModulePkg reviewers) is inserted between:
* [edk2-devel] [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM
modules"
(from
I see. I have no concerns on the 3 &4 in different patches.
> -Original Message-
> From: Gao, Zhichao
> Sent: Wednesday, July 17, 2019 4:44 PM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Zeng, Star ; Gao, Liming
> ; Sean Brogan ; Michael
> Turner ; Bret
>
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, July 17, 2019 8:41 PM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Andrew Fish; Leif Lindholm; Kinney, Michael D; Bi, Dandan; Dong, Eric;
> Gao, Liming; Ni, Ray;
On Wed, Jul 17, 2019 at 03:23:26AM +, Gao, Liming wrote:
> Leif:
> I agree to discuss the behavior first, then review the code logic in
> detail. I add my comments below.
>
> > -Original Message-
> > From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> > So, first of all - I am
On 07/17/19 16:32, Gao, Liming wrote:
> Laszlo:
>
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Wednesday, July 17, 2019 6:22 PM
>> To: Gao, Liming ; Leif Lindholm
>>
>> Cc: devel@edk2.groups.io; Rebecca Cran ; Feng, Bob C
>> ; Kinney, Michael D
>> ;
On Mon, Jul 15, 2019 at 07:04:29PM +0200, Laszlo Ersek wrote:
> We ask contributors to copy Anthony and Julien on patches that affect "Xen
> modules" under OvmfPkg. With the "GetMaintainer.py" script being
> introduced later, express this expectation in "Maintainers.txt" in
> machine-readable
Zhichao,
Why is CapsuleRuntimeDxe the component that is responsible for
setting the UEFI Variable for supported RT services?
I would think this should be in:
MdeModulePkg\Core\RuntimeDxe
I agree that each RT driver that populates the RT Services
Table with a RT services can consume
Regarding the role assigned to me, Reviewed-by: Ray Ni
> -Original Message-
> From: Leif Lindholm
> Sent: Wednesday, July 17, 2019 10:37 PM
> To: Laszlo Ersek
> Cc: Wu, Hao A ; devel@edk2.groups.io; Andrew Fish
> ; Kinney, Michael D ; Bi,
> Dandan ; Dong, Eric ; Gao,
> Liming ; Ni, Ray
Laszlo:
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, July 17, 2019 6:22 PM
> To: Gao, Liming ; Leif Lindholm
>
> Cc: devel@edk2.groups.io; Rebecca Cran ; Feng, Bob C
> ; Kinney, Michael D
> ; af...@apple.com
> Subject: Re: [PATCH 1/1]
On 07/17/19 00:59, Laszlo Ersek wrote:
> The EDK II C Coding Standards Specification (v2.20) strongly discourages
> variable declarations in nested block scope:
>
> 5 Source Files
> 5.4 Code File Structure
> 5.4.1 Scoping Rules
> 5.4.1.1 Scope
>
>> Block (local) Scope
>>
>> [...]
>>
Top-posting because lazy.
Basically, I agree with all of Laszlo's comments.
I would be happy for this to remain a single patch, however. Partly
because I'm lazy. But also because this is effectively "converting"
a single package (MdeModulePkg) into multiple sections. (This is not a
strong
On Tue, Jul 16, 2019 at 02:10:43PM -0600, Rebecca Cran wrote:
> On 2019-07-16 13:07, Leif Lindholm wrote:
> > +EXECUTABLE=`basename $file`
> > +VERSION=`echo $EXECUTABLE | sed 's/[^0-9.]//g'`
> > +
> > +MAJOR=`echo $VERSION | sed 's/\([0-9]*\)\.*.*/\1/'`
> > +
Hi Jaben,
I will split the changes into separate patch sets with each patch set having
the same logical change made to every applicable acpiview table parser. The
per-parser modifications will be separate commits as well.
Kind regards,
Krzysztof
-Original Message-
From:
Hello Zhichao,
On 07/17/19 09:37, Gao, Zhichao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1907
>
> UEFI spec 2.8 introduce a new variable L"RuntimeServicesSupported".
> If some runtime sevices is not supported at runtime phase, the variable
> should present at boot services. It
On 07/17/19 10:07, Ni, Ray wrote:
> Zhichao,
>
> Firstly, patch 4/4 is a fix to patch 3/4, why not merge them into one patch?
> Do we have a policy to strictly cherry-pick the patches from MU?
>
> Secondly, the change that skips to add the to BootOrder may cause the
> Boot pointing to
On 07/17/19 03:44, Hao A Wu wrote:
> This commit add the reviewers information for modules within MdeModulePkg.
>
> For now the modules list includes:
> ACPI
> BDS
> Console and Graphic
> Core services (PEI, DXE and Runtime)
> Device and Peripheral
> Firmware Update
> HII and UI
> Reset
> S3
>
From: Michael Brown
The design of the EFI_USB2_HC_PROTOCOL does not allow for long-lived
bulk IN transactions as used by network devices, but instead requires
the network driver to rely on repeatedly issuing bulk IN transactions
with a very short timeout and in the expectation that most bulk IN
Networking applications (e.g. iPXE) might experience failures when submitting
a bulk IN for the NIC's RX endpoint, because the bulk IN (correctly) times out
when no received packet is waiting, but DwUsbHostDxe.c treats this as a fatal
error.
With these patches, iPXE is able to successfully
From: Michael Brown
There are multiple points in the existing code that take the UINT32
value returned by Wait4Bit and return it directly as an EFI_STATUS
value. If Wait4Bit fails, this will result in a spurious EFI_STATUS
value of 0x1 (EFI_WARN_UNKNOWN_GLYPH) being returned to the caller. A
From: Michael Brown
When a timeout occurs, attempt to gracefully disable the channel.
Report a final status of EFI_TIMEOUT if the channel was disabled
successfully, or EFI_DEVICE_ERROR if we were unable to disable the
channel.
Signed-off-by: Michael Brown
Signed-off-by: Pete Batard
---
Hi Tzy Way,
On Wed, Jul 17, 2019 at 09:25:49AM +, Ooi, Tzy Way wrote:
> Ya. I am on Linux. I managed to replicated the warning that you have
> provided in the previous email thread by using the gcc 8.3.
Excellent.
> Currently, I'm looking at the compiler warning/error. While I am
> fixing
On 07/17/19 05:23, Gao, Liming wrote:
> Leif:
> I agree to discuss the behavior first, then review the code logic in
> detail. I add my comments below.
>
>> -Original Message-
>> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
>> Sent: Wednesday, July 17, 2019 6:05 AM
>> To:
On 07/17/19 00:04, Leif Lindholm wrote:
> On Tue, Jul 16, 2019 at 10:49:03PM +0200, Laszlo Ersek wrote:
>> Hi Leif,
>>
>> On 07/16/19 21:07, Leif Lindholm wrote:
>>> If PYTHON_COMMAND is set, use that.
>>> If PYTHON_COMMAND is not set, use first working of "python", "python3",
>>> "python2".
>>>
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43867): https://edk2.groups.io/g/devel/message/43867
Mute This Topic: https://groups.io/mt/32439510/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43870): https://edk2.groups.io/g/devel/message/43870
Mute This Topic: https://groups.io/mt/32439506/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43868): https://edk2.groups.io/g/devel/message/43868
Mute This Topic: https://groups.io/mt/32439509/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43872): https://edk2.groups.io/g/devel/message/43872
Mute This Topic: https://groups.io/mt/32439502/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43871): https://edk2.groups.io/g/devel/message/43871
Mute This Topic: https://groups.io/mt/32439504/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43866): https://edk2.groups.io/g/devel/message/43866
Mute This Topic: https://groups.io/mt/32439512/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43873): https://edk2.groups.io/g/devel/message/43873
Mute This Topic: https://groups.io/mt/32439501/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43869): https://edk2.groups.io/g/devel/message/43869
Mute This Topic: https://groups.io/mt/32439507/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43863): https://edk2.groups.io/g/devel/message/43863
Mute This Topic: https://groups.io/mt/32439516/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43865): https://edk2.groups.io/g/devel/message/43865
Mute This Topic: https://groups.io/mt/32439513/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43864): https://edk2.groups.io/g/devel/message/43864
Mute This Topic: https://groups.io/mt/32439515/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Stephano,
On 07/17/19 00:05, David Woodhouse wrote:
> On Tue, 2019-07-16 at 22:55 +0200, Laszlo Ersek wrote:
>> something must have gone wrong -- I don't see your message in my list
>> folder, and I haven't received a moderation request either. Do you have
>> an idea why your message may not have
Hi Leif,
Ya. I am on Linux. I managed to replicated the warning that you have provided
in the previous email thread by using the gcc 8.3.
Currently, I'm looking at the compiler warning/error. While I am fixing the
issue when compiling the source code, I encountered another issue where the
Sorry to miss the first question. I used to send a patch to the community to
merge my change and the changes from Mu.
And Leif suggests to separate them. That would distinguish the contributor when
encounter copyright issue. And also make a history of it.
Here is the message link:
I don't know the requirement. That's just my guess so I used "if".
You need to clarify with Bret Barkelew and get real requirement.
> -Original Message-
> From: Gao, Zhichao
> Sent: Wednesday, July 17, 2019 4:29 PM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
>
Ray,
You are right. I didn't view the implementation of BmGetFreeOptionNumber. Only
use it base on its comments.
If new options are added after BootManagerMenuApp with the pcd's value FALSE
then it would be overwriten.
3/4 would remove the BootManagerMenuApp option from Boot and BootOrder.
Zhichao,
Firstly, patch 4/4 is a fix to patch 3/4, why not merge them into one patch? Do
we have a policy to strictly cherry-pick the patches from MU?
Secondly, the change that skips to add the to BootOrder may cause the
Boot pointing to the BootManagerMenu be overwritten later.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1979
Add a pcd to control whether the BootManager is in BootOrder variable.
>From a UI perspective, it never want to see a Front Page UI in the boot
order list. So add a pcd PcdBootManagerInBootOrder to control it. If it
is FALSE, the
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1979
Use pcd PcdBootManagerInBootOrder to control whether BootManager
is in BootOrder. Also add EFI_UNSUPPORTED to indicate the
BootManager is not in the BootOrder.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Cc: Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1979
Add prompt and help string for PcdBootManagerInBootOrder.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Cc: Star Zeng
Cc: Liming gao
Cc: Sean Brogan
Cc: Michael Turner
Cc: Bret Barkelew
Signed-off-by: Zhichao Gao
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1979
The PcdBootManagerInBootOrder should only control whether
BootManager is in BootOrder. It shouldn't affect the Hotkey
service with BootManager.
Acctually, setting this pcd hides the boot option from BootOrder.
But it didn't disable the boot
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1979
Add defination of PcdBootManagerInBootOrder to MdeModulePkg.dec.
This pcd indicates if the Boot Manager should be in the Boot
Order list.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Cc: Star Zeng
Cc: Liming gao
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1907
Add pcd PcdRuntimeServicesSupport to control whether runtime
services is supported at runtime phase. It is a UINT16 type
bitmask value. Refer to Uefi Spec 2.8, Section 8.1.1.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Sean Brogan
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1907
Add PcdRuntimeServicesSupport to control whether the capsule services
is supported during runtime phase. If the L"RuntimeServicesSupported"
variable is not set yet, it would set the variable base on the pcd.
If the pcd value is 0x3FFF that
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1907
UEFI spec 2.8, Section 8.1.1 define some MACROs for
RuntimeServicesSupported variable. Add them to UefiSpec.h.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Sean Brogan
Cc: Michael Turner
Cc: Bret Barkelew
Signed-off-by: Zhichao Gao
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1907
UEFI spec 2.8 introduce a new variable L"RuntimeServicesSupported".
If some runtime sevices is not supported at runtime phase, the variable
should present at boot services. It is a bitmask value, the bit value of
zero indicate the related
On 7/17/19 12:59 AM, Laszlo Ersek wrote:
> The EDK II C Coding Standards Specification (v2.20) strongly discourages
> variable declarations in nested block scope:
>
> 5 Source Files
> 5.4 Code File Structure
> 5.4.1 Scoping Rules
> 5.4.1.1 Scope
>
>> Block (local) Scope
>>
>> [...]
Mike,
Per last discussion in TianoCore Community Design Meeting
https://edk2.groups.io/g/announce/topic/tianocore_community_design/32438738,
"FirstX" is the only proposed option and you would like to see whether a better
name
can be used.
Here I listed some candidates:
1.
60 matches
Mail list logo
