Andrew,
Thanks for the reminder for CpuDxe.
I think we saw CpuDxe calculation some time ago, and it was most likely a
reason we went with a very similar approach to determine the TSC frequency as a
fallback mechanism. It, however, is in fact prone to issues, putting aside the
non-guaranteed
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Sai Chaganty
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:15 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Gao, Liming ; Desimone,
> Nathaniel L ; Kinney, Michael D
> ; Sinha, Ankit
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Gao, Liming ; Desimone,
> Nathaniel L ; Kinney, Michael D
> ; Sinha, Ankit
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Gao, Liming ; Desimone,
> Nathaniel L ; Kinney, Michael D
> ; Sinha, Ankit
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D
> Subject: [edk2-platforms][PATCH V1
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:16 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 17, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Kinney, Michael D ; Sinha, Ankit
>
> Subject:
Liming,
I would like to include the following bug fixes to EmulatorPkg in the stable
tag:
https://edk2.groups.io/g/devel/message/45953 [edk2-devel] [Patch V5 00/11]
EmulatorPkg: Fix VS20xx IA32 boot and simplify build config
The first set of patches were sent for review on 8/1. Most of the
From: Andrew Fish
Add -gdwarf to XCODE5 X64 builds to generate symbols for
source level debug using lldb.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
Reviewed-by: Michael D Kinney
Tested-by: Andrew Fish
---
BaseTools/Conf/tools_def.template | 4 ++--
1
From: Andrew Fish
* Disable XCODE5 compiler optimizations fort Unix/Host.
* Disable inline of SecGdbScriptBreak() to improve
compatibility with XCODE5
* For X64 XCODE5 builds place output Host application
in $(BIN_DIR) to match all other EmulatorPkg Host
application builds.
Cc: Jordan
From: Andrew Fish
Disable TftpDynamicCommand for XCODE5 because this command
places HII content in an PE/COFF resource section that is not
supported by the XCODE5 tool chain, and the missing HII
content causes the load of this command to ASSERT().
Disable the LogoDxe module that places the logo
From: Andrew Fish
Initialize Private->ReadBuffer to NULL.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
Reviewed-by: Michael D Kinney
Tested-by: Andrew Fish
---
EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 1 +
1 file changed, 1 insertion(+)
diff --git
https://bugzilla.tianocore.org/show_bug.cgi?id=162
Update EmulatorPkg specific modules and libraries to use
safe string functions in BaseLib and safe PcdSetxx()
functions in PcdLib. With these updates, the define
DISABLE_NEW_DEPRECATED_INTERFACES is enabled in the DSC
file.
Cc: Jordan Justen
https://bugzilla.tianocore.org/show_bug.cgi?id=2056
The IA32 build of the EmulatorPkg for VS20xx does not boot
because the default value of PCD PcdPeiServicesTablePage
rarely succeeds to be mapped on IA32 Windows Host Environments.
Change the DEC default value for this PCD to a value that
is
https://bugzilla.tianocore.org/show_bug.cgi?id=2055
Remove the use of the defines UNIX_SEC_BUILD and
WIN_SEC_BUILD. This simplifies the build command
for the EmulatorPkg. Instead, use !if statements
in the DSC file using $(ARCH) and $(FAMILY) to
determine if the build is for a Windows or POSIX
From: Andrew Fish
Fix scripts to support lldb symbolic debugging when
using XCODE5 tool chain.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
Reviewed-by: Michael D Kinney
Tested-by: Andrew Fish
---
EmulatorPkg/Unix/lldbefi.py | 8 +---
From: Andrew Fish
Remove old debug code that generates an exception.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
Reviewed-by: Michael D Kinney
Tested-by: Andrew Fish
---
EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 4
1 file changed, 4 deletions(-)
From: Andrew Fish
The local variable PpiArray[10] is declared in the middle
of the SEC module _ModuleEntryPoint() with its own scope.
However, PpiArray has a dangling reference to its location
on the stack after the scope is closed. This causes issues
with some compilers (e.g. XCODE5).
The fix
New in V5
=
* Update author to be Andrew Fish for XCODE5 fixes
* Split patch #7 into two patches
* Break up long line in build.sh into multiple lines
New in V4 (Resolve XCODE5 issues)
==
* Disable inline if SecGdbScriptBreak() for XCODE5 issues
* Disable
Add NOOPT to BUILD_TARGETS in DSC file.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney
Reviewed-by: Hao A Wu
Reviewed-by: Jordan Justen
Tested-by: Andrew Fish
---
EmulatorPkg/EmulatorPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Gao, Liming ; Desimone,
Nathaniel L ; Kinney, Michael D
; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Gao, Liming ; Desimone,
Nathaniel L ; Kinney, Michael D
; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Gao, Liming ; Desimone,
Nathaniel L ; Kinney, Michael D
; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D
Subject: [edk2-platforms][PATCH V1 30/37]
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:15 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:15 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:15 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ; Kinney,
Michael D ; Sinha, Ankit
Subject: [edk2-platforms][PATCH V1
> -Original Message-
> From: Alex Williamson [mailto:alex.william...@redhat.com]
> Sent: Saturday, August 17, 2019 6:20 AM
> To: Laszlo Ersek
> Cc: Yao, Jiewen ; Paolo Bonzini
> ; devel@edk2.groups.io; edk2-rfc-groups-io
> ; qemu devel list ; Igor
> Mammedov ; Chen, Yingwen
> ;
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2083
* Adds the WhiskeylakeURvp board as a build option in build.cfg so it
it is listed as a valid build target.
* Updates relevant Readme.md files to include instructions for
WhiskeylakeOpenBoardPkg.
* Adds the maintainers for
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Michael Kubacki
---
Maintainers.txt | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Maintainers.txt
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds PCH DXE library class instances.
* DxePchPolicyLib
* DxeResetSystemLib
* DxeRuntimeResetSystemLib
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds PCH SMM private library class instances.
* SmmPchPrivateLib
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2083
Header files for the WhiskeylakeURvp board instance.
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Liming Gao
Cc: Nate DeSimone
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds the following header files:
* Pch/Include/Private/Protocol
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2083
Adds the DSC and build files necessary to build the
WhiskeylakeURvp board instance.
Key files
=
* build_config.cfg - Board-specific build configuration file.
* OpenBoardPkg.dsc - The WhiskeylakeURvp board description file.
*
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds header files common to silicon Sample Code.
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha >
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds ME library class instances.
* PeiMePolicyLib - PEI ME policy configuration services.
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds header files common to ME modules.
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 215
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds PCH DXE private library class instances.
* DxeGpioNameBufferLib
* DxePchHdaLib
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds header files common to CPU modules.
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds the following header files:
* Pch/Include/Private
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds PCH SMM library class instances.
* SmmSpiFlashCommonLib
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds PCH Base library class instances.
* BaseResetSystemLib
* BaseSmbusLib
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds the following header files:
* Pch/Include/Ppi
* Pch/Include/Protocol
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds Pch/Include headers.
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/DxeHdaNhlt.h
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds the following header files:
* Pch/Include/library
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Create the CoffeelakeSiliconPkg to provide an initial package for
silicon initialization code for Coffee Lake (CFL) and Whiskey Lake
(WHL) generation products.
* Major areas of functionality are categorized into CPU, Management
Engine
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds Pch/Library/Private Base library class instances.
* BaseGpioHelpersLibNull
* BasePchSpiCommonlib
* BaseSiScheduleResetLib
* BaseSiScheduleResetLibFsp
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds package-level library class instances.
* BaseConfigBlockLib - Library functions for config block management.
* BaseSiConfigBlockLib - Library functions for managing component
config blocks.
* DxeAslUpdateLib - Services to update ACPI
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds header files to Pch/Include/ConfigBlock.
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds CPU library class instances.
* BaseCpuMailboxLibNull - Generic CPU mailbox interaction services.
* PeiCpuPolicyLib - CPU policy configuration services.
* PeiCpuPolicyLibPreMem - CPU policy pre-memory configuration services.
*
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082
Adds the following header files:
* Pch/Include/Private/Library
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
---
On 2019-08-16 18:03, Andrew Fish wrote:
> It is also interesting in the context of our CI as we could pick oldest and
> newest version from every compiler family for the CI build test.
Yes, that's going to be important. Given
> On Aug 16, 2019, at 5:01 PM, Rebecca Cran wrote:
>
> On 2019-08-16 16:58, Andrew Fish via Groups.Io wrote:
>>
>> I'm all for modernization of the C code as long we are thoughtful
>> about compatibility. For example I still see that VS2008 is a
>> supported
On 2019-08-16 16:58, Andrew Fish via Groups.Io wrote:
>
> I'm all for modernization of the C code as long we are thoughtful
> about compatibility. For example I still see that VS2008 is a
> supported BaseTools/Conf/tools_def.template.
It would be interesting to see who's using the older
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2048
New STATIC_ASSERT macro supersedes VERIFY_SIZE_OF as being more functional.
Signed-off-by: Vitaly Cheptsov
---
MdePkg/Include/Base.h | 13 -
1 file changed, 13 deletions(-)
diff --git a/MdePkg/Include/Base.h
Things to note:
- This patchset should go after STATIC_ASSERT implementation:
https://edk2.groups.io/g/devel/topic/32917749
- It is suggested that unlike the previous patch, which in my
opinion should appear in edk2-stable201908, this patchset should
land in edk2-stable2019011. This will
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2048
Use new STATIC_ASSERT macro instead of VERIFY_SIZE_OF.
Signed-off-by: Vitaly Cheptsov
---
MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2048
Use new STATIC_ASSERT macro instead of VERIFY_SIZE_OF.
Signed-off-by: Vitaly Cheptsov
---
MdePkg/Include/Base.h | 79 ++--
1 file changed, 40 insertions(+), 39 deletions(-)
diff --git a/MdePkg/Include/Base.h
Andrew, Mike,
Actually thanks for making me recheck it. I have just installed doxygen, and
can confirm that it can generate parameters for non-functional macros. This was
my main reason for going with /// comment style, which is used for all other
plain macros. I have just submitted V3 version
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2048
Provide a macro for compile time assertions.
Equivalent to C11 static_assert macro from assert.h.
Signed-off-by: Vitaly Cheptsov
---
MdePkg/Include/Base.h | 14 ++
1 file changed, 14 insertions(+)
diff --git
1 - 100 of 179 matches
Mail list logo
