Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Race condition between APHandler's release of Busy spinlock and user-triggered SmmStartupThisAP's

2019-09-03 Thread Dong, Eric
Agree with Ray, no need to call AcquireSpinLockOrFail anymore. I think final code like change like below: - if (Token == NULL) { -AcquireSpinLock (mSmmMpSyncData->CpuData[CpuIndex].Busy); - } else { -if (!AcquireSpinLockOrFail (mSmmMpSyncData->CpuData[CpuIndex].Busy)) { -

[edk2-devel] [PATCH 1/1] Platform: Intel: Update licenses to SPDX and update clock settings

2019-09-03 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Update all license to SPDX. Also update UART clock to be calculated instead of hardcoded, removed some unused packages, and updated maintainers. Signed-off-by: "Tien Hock, Loh" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Ard Biesheuvel Cc: Leif Lindholm

Re: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Fix GCC5 build issue

2019-09-03 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io On Behalf Of Agyeman, > Prince > Sent: Tuesday, September 3, 2019 11:18 AM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Sinha, Ankit > ; Desimone, Nathaniel L > ; Kubacki, Michael A > ; Chiu, Chasel ;

[edk2-devel] [PATCH] BaseTools/GenFw AARCH64: fix up GOT based relative relocations

2019-09-03 Thread Ard Biesheuvel
We take great care to avoid GOT based relocations in EDK2 executables, primarily because they are pointless - we don't care about things like the CoW footprint or relocations that target read-only sections, and so GOT entries only bloat the binary. However, in some cases (e.g., when building the

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/Pci.c: Update supported link speed to PCI5.0

2019-09-03 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Gao, Zhichao > Sent: Sunday, September 1, 2019 8:15 AM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Ni, Ray ; Oleksiy > ; Gao, Liming > > Subject: [PATCH v3 1/1] ShellPkg/Pci.c: Update supported link speed to PCI5.0 > > From: "Gao,

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Allow other NSIDs for Admin commands

2019-09-03 Thread Wu, Hao A
> -Original Message- > From: Wu, Hao A > Sent: Wednesday, September 04, 2019 11:39 AM > To: devel@edk2.groups.io; Tyler Erickson > Cc: Wu, Hao A; Ni, Ray > Subject: [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Allow other NSIDs > for Admin commands > > Repost the mail to the list. > > Best

[edk2-devel] [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Allow other NSIDs for Admin commands

2019-09-03 Thread Wu, Hao A
Repost the mail to the list. Best Regards, Hao Wu -Original Message- From: Tyler Erickson [mailto:tyler.j.erick...@seagate.com] Sent: Tuesday, September 03, 2019 9:55 PM To: edk2-de...@lists.01.org Cc: Wu, Hao A; Ni, Ray Subject: [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Allow other

Re: [edk2-devel] Cancelled Event: TianoCore Design / Bug Triage - EMEA - Wednesday, 4 September 2019 #cal-cancelled

2019-09-03 Thread Stephano Cetola
Canceling, as there were no submissions. Also, OSFC is this week. --S On Tue, Sep 3, 2019 at 8:36 PM devel@edk2.groups.io Calendar wrote: > > Cancelled: TianoCore Design / Bug Triage - EMEA > > This event has been cancelled. > > When: > Wednesday, 4 September 2019 > 8:00am to 9:00am >

[edk2-devel] [PATCH v1 0/1] Allow any NSID value for NVMe admin commands

2019-09-03 Thread Wu, Hao A
Repost the mail to the list. Best Regards, Hao Wu -Original Message- From: Tyler Erickson [mailto:tyler.j.erick...@seagate.com] Sent: Tuesday, September 03, 2019 9:55 PM To: edk2-de...@lists.01.org Cc: Wu, Hao A; Ni, Ray Subject: [PATCH v1 0/1] Allow any NSID value for NVMe admin

[edk2-devel] Cancelled Event: TianoCore Design / Bug Triage - EMEA - Wednesday, 4 September 2019 #cal-cancelled

2019-09-03 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL CALSCALE:GREGORIAN BEGIN:VEVENT STATUS:CANCELLED UID:calendar.15...@groups.io DTSTAMP:20190904T033646Z ORGANIZER;CN=Stephano Cetola:mailto:stephano.cet...@linux.intel.com

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'Remained test cases'

2019-09-03 Thread Eric Jin
Hi Heinrich Schuchardt, According to https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format The statement "Contributed-under:..." need be removed. With that: Reviewed-by: Eric Jin If no object, I will help to push with this change by end of this week. -Original

Re: [edk2-devel] [edk2] [Patch 32/33] BaseTools: ECC tool Python3 adaption

2019-09-03 Thread Bob Feng
Hi Leif, I have no Debian environment. On Debian, can python3 work with antlr3? I checked the antlr3 python github repository, the source code is still in beta version and has not been updated for 7 years. But If yes, I think the import statement in ECC can be changed as: try: import

Re: [edk2-devel] [PATCH] ArmVirtPkg/PlatformBootManagerLib: unload image on EFI_SECURITY_VIOLATION

2019-09-03 Thread Dandan Bi
Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, September 4, 2019 12:38 AM > To: edk2-devel-groups-io > Cc: Ard Biesheuvel ; Bi, Dandan > ; Leif Lindholm > Subject: [PATCH] ArmVirtPkg/PlatformBootManagerLib:

Re: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Fix GCC5 build issue

2019-09-03 Thread Dandan Bi
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Agyeman, Prince > Sent: Wednesday, September 4, 2019 2:18 AM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Sinha, Ankit > ; Desimone, Nathaniel L > ; Kubacki, Michael A > ; Chiu, Chasel ;

Re: [edk2-devel] [Patch] BaseTools: Update GenFw tool to support -e -z option together

2019-09-03 Thread Bob Feng
Thanks, with the change, Reviewed-by: Bob Feng -Original Message- From: Gao, Liming Sent: Wednesday, September 4, 2019 9:21 AM To: Feng, Bob C ; devel@edk2.groups.io Subject: RE: [edk2-devel] [Patch] BaseTools: Update GenFw tool to support -e -z option together Yes. Thanks for your

Re: [edk2-devel] [Patch] BaseTools: Update GenFw tool to support -e -z option together

2019-09-03 Thread Liming Gao
Yes. Thanks for your comments. I will update it and push the change. Thanks Liming >-Original Message- >From: Feng, Bob C >Sent: Wednesday, September 04, 2019 9:03 AM >To: devel@edk2.groups.io; Gao, Liming >Subject: RE: [edk2-devel] [Patch] BaseTools: Update GenFw tool to support -e >-z

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Remove unneeded MdeModulePkg dependency

2019-09-03 Thread Zeng, Star
Reviewed-by: Star Zeng > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, > Ray > Sent: Wednesday, September 4, 2019 2:18 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-devel] [PATCH]

Re: [edk2-devel] [Patch] BaseTools: Update GenFw tool to support -e -z option together

2019-09-03 Thread Bob Feng
Liming, The patch looks good to me. A minor comment that the code looks fix the bug of the combinations of -e -z and -t -z, so would you please update the commit message to add "-t -z" Thanks, Bob -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of

Re: [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLeConfig.h: Add type EfiBluetoothSmpPeerAddressList

2019-09-03 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, >Ray >Sent: Tuesday, August 27, 2019 2:16 AM >To: devel@edk2.groups.io >Cc: Kinney, Michael D ; Gao, Liming > >Subject: [edk2-devel] [PATCH] [edk2-stable201908]

[edk2-devel] [PATCH] IntelFsp2WrapperPkg: Remove unneeded MdeModulePkg dependency

2019-09-03 Thread Ni, Ray
Signed-off-by: Ray Ni Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng --- IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 4 +--- IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git

[edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Fix GCC5 build issue

2019-09-03 Thread Agyeman, Prince
From: Agyeman Fixed GPIO table missing curly brackets Cc: Ankit Sinha Cc: Nate DeSimone Cc: Michael Kubacki Cc: Chasel Chiu CC: Dandan Bi Signed-off-by: Prince Agyeman --- .../N1xxWU/Library/BoardInitLib/N1xxWUGpioTable.c | 2 +- 1 file changed, 1 insertion(+), 1

[edk2-devel] [PATCH] UefiCpuPkg/CpuExceptionHandlerLib: Fix #AC split lock

2019-09-03 Thread John E Lofgren
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2150 Fix #AC split lock's caused by seperating base and limit from sgdt and sidt by changing xchg operands to 32-bit to stop from crossing cacheline. Signed-off-by: John E Lofgren ---

Re: [edk2-rfc] [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-03 Thread Laszlo Ersek
On 09/03/19 19:09, Sean Brogan wrote: > Laszlo/Mike, > > The idea that the maintainer must create the PR is fighting the > optimized github PR flow. Github and PRs process is optimized for > letting everyone contribute from "their" fork while still protecting > and putting process in place for

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Race condition between APHandler's release of Busy spinlock and user-triggered SmmStartupThisAP's

2019-09-03 Thread Laszlo Ersek
On 09/03/19 16:57, Damian Nikodem wrote: > Race condition between APHandler's release of Busy spinlock and > user-triggered SmmStartupThisAP's acquisition attempt of the Busy spinlock > (non-blocking mode). > > UserProc is the user's procedure to execute on an AP. > UserProcCompletion is the

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-09-03 Thread Laszlo Ersek
On 09/03/19 16:53, Igor Mammedov wrote: > On Mon, 2 Sep 2019 21:09:58 +0200 > Laszlo Ersek wrote: > >> On 09/02/19 10:45, Igor Mammedov wrote: >>> On Fri, 30 Aug 2019 20:46:14 +0200 >>> Laszlo Ersek wrote: >>> On 08/30/19 16:48, Igor Mammedov wrote: > (01) On boot firmware

Re: [edk2-devel] [edk2-platforms][PATCH V2 6/6] QuarkSocPkg: Clean up duplicated SmramMemoryReserve.h files

2019-09-03 Thread Steele, Kelly
Reviewed-by: Kelly Steele Thanks, Kelly > -Original Message- > From: Chen, Marc W > Sent: September 02, 2019 08:36 > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Steele, Kelly > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH V2 6/6] QuarkSocPkg: Clean up

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-09-03 Thread Igor Mammedov
On Mon, 2 Sep 2019 21:09:58 +0200 Laszlo Ersek wrote: > On 09/02/19 10:45, Igor Mammedov wrote: > > On Fri, 30 Aug 2019 20:46:14 +0200 > > Laszlo Ersek wrote: > > > >> On 08/30/19 16:48, Igor Mammedov wrote: > >> > >>> (01) On boot firmware maps and initializes SMI handler at default

Re: [edk2-devel] [edk2-platforms][PATCH V2 2/6] QuarkPlatformPkg: Clean up duplicated SmramMemoryReserve.h files

2019-09-03 Thread Steele, Kelly
Reviewed-by: Kelly Steele Thanks, Kelly > -Original Message- > From: Chen, Marc W > Sent: September 02, 2019 08:36 > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Steele, Kelly > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH V2 2/6] QuarkPlatformPkg: Clean up >

[edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Race condition between APHandler's release of Busy spinlock and user-triggered SmmStartupThisAP's

2019-09-03 Thread Damian Nikodem
Race condition between APHandler's release of Busy spinlock and user-triggered SmmStartupThisAP's acquisition attempt of the Busy spinlock (non-blocking mode). UserProc is the user's procedure to execute on an AP. UserProcCompletion is the user procedure's completion spinlock. All other

Re: [edk2-rfc] [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-03 Thread Sean via Groups.Io
Laszlo/Mike, The idea that the maintainer must create the PR is fighting the optimized github PR flow. Github and PRs process is optimized for letting everyone contribute from "their" fork while still protecting and putting process in place for the "upstream". Why not use github to assign

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Race condition between APHandler's release of Busy spinlock and user-triggered SmmStartupThisAP's

2019-09-03 Thread Ni, Ray
1. can we directly call AcquireSpinLock()? *OrFail() can be removed IMO. 2. It's a patch to change the behavior of SmmStartupThisAP(). So that to reduce the potential bugs in caller's code. Patch title is a bit mis-leading. > -Original Message- > From: Nikodem, Damian > Sent: Tuesday,

Re: [edk2-rfc] [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-03 Thread Laszlo Ersek
On 09/03/19 18:41, Ni, Ray wrote: >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek >> Sent: Tuesday, September 3, 2019 6:20 AM >> To: Ni, Ray ; r...@edk2.groups.io; devel@edk2.groups.io; >> Gao, Liming ; Kinney, >> Michael D >> Subject: Re: [edk2-rfc]

Re: [edk2-devel] [PATCH] ArmVirtPkg/PlatformBootManagerLib: unload image on EFI_SECURITY_VIOLATION

2019-09-03 Thread Ard Biesheuvel
On Tue, 3 Sep 2019 at 09:38, Laszlo Ersek wrote: > > The LoadImage() boot service is a bit unusual in that it allocates > resources in a particular failure case; namely, it produces a valid > "ImageHandle" when it returns EFI_SECURITY_VIOLATION. This is supposed to > happen e.g. when Secure Boot

Re: [edk2-rfc] [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-03 Thread Ni, Ray
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Tuesday, September 3, 2019 6:20 AM > To: Ni, Ray ; r...@edk2.groups.io; devel@edk2.groups.io; > Gao, Liming ; Kinney, > Michael D > Subject: Re: [edk2-rfc] [edk2-devel] [RFC] EDK II Continuous

[edk2-devel] [PATCH] ArmVirtPkg/PlatformBootManagerLib: unload image on EFI_SECURITY_VIOLATION

2019-09-03 Thread Laszlo Ersek
The LoadImage() boot service is a bit unusual in that it allocates resources in a particular failure case; namely, it produces a valid "ImageHandle" when it returns EFI_SECURITY_VIOLATION. This is supposed to happen e.g. when Secure Boot verification fails for the image, but the platform policy

[edk2-devel] Upcoming Event: TianoCore Design / Bug Triage - EMEA - Wed, 09/04/2019 8:00am-9:00am #cal-reminder

2019-09-03 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Design / Bug Triage - EMEA *When:* Wednesday, 4 September 2019, 8:00am to 9:00am, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/695893389 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=503240 ) *Organizer:* Stephano Cetola

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: buffer overflow in NotifyFunctionTplEx()

2019-09-03 Thread Heinrich Schuchardt
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1976 CreateEventEx() may lead to a change in the memory map causing an EFI_EVENT_GROUP_MEMORY_MAP_CHANGE. So in BBTestCreateEventEx_Func_Sub3() we should only check for events triggered after the events have been set up. Among other changes

Re: [edk2-rfc] [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-03 Thread Laszlo Ersek
On 09/03/19 05:39, Ni, Ray wrote: > Can someone draw a flow chart of who does what to help clarify? I don't see this as a huge change, relative to the current process. Before, it's always been up to the subsys maintainer to apply & rebase the patches locally, pick up the feedback tags, and run

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'Remained test cases'

2019-09-03 Thread Heinrich Schuchardt
%s/Remained/Remaining/g Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heinrich Schuchardt --- .../SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [edk2-devel] [edk2-platforms][PATCH V2 4/6] KabylakeSiliconPkg: Clean up duplicated SmramMemoryReserve.h files

2019-09-03 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Chen, Marc W > Sent: Monday, September 2, 2019 11:36 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH V2 4/6]

Re: [edk2-devel] [edk2-platforms][PATCH V2 3/6] CoffeelakeSiliconPkg: Clean up duplicated SmramMemoryReserve.h files

2019-09-03 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Chen, Marc W > Sent: Monday, September 2, 2019 11:36 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH V2 3/6]

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/6] MinPlatformPkg: Clean up duplicated SmramMemoryReserve.h files

2019-09-03 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Chen, Marc W > Sent: Monday, September 2, 2019 11:36 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-platforms][PATCH V2 1/6] MinPlatformPkg: Clean up

Re: [edk2-devel] [edk2-test] [PATCH] uefi-sct/SctPkg: StrUpr() test for cyrillic letters

2019-09-03 Thread Eric Jin
Reviewed-by: Eric Jin -Original Message- From: Heinrich Schuchardt Sent: Monday, September 2, 2019 5:57 PM To: devel@edk2.groups.io Cc: Jin, Eric ; Supreeth Venkatesh ; Stephano Cetola ; Heinrich Schuchardt Subject: [edk2-test] [PATCH] uefi-sct/SctPkg: StrUpr() test for cyrillic

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak

2019-09-03 Thread Liming Gao
This patch has passed the package maintainer review. So, I push this change @8b8e91584555b6193f2099a36502763b47501533. Thanks Liming >-Original Message- >From: Desimone, Nathaniel L >Sent: Tuesday, September 03, 2019 1:00 PM >To: devel@edk2.groups.io; xypron.g...@gmx.de; Carsey, Jaben >;